Skip to contentSkip to conversation

xen: xenbus_probe_frontend: mark expected switch fall-throughs

PATCH Applied Gustavo A. R. Silva 3 participants 4 messages Nov 2, 2017 – Nov 8, 2017 Xen hypervisor interface

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 xen: xenbus_probe_frontend: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146562
Addresses-Coverity-ID: 146563

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/xen/xenbus/xenbus_probe_frontend.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/xen/xenbus/xenbus_probe_frontend.c +2 -0
index 19e45ce..07896f4 100644
@@ -379,10 +379,12 @@ static void xenbus_reset_frontend(char *fe, char *be, int be_state)
 	case XenbusStateConnected:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosing);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosing);
+		/* fall through */
 
 	case XenbusStateClosing:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosed);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosed);
+		/* fall through */
 
 	case XenbusStateClosed:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateInitialising);
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146562
Addresses-Coverity-ID: 146563

Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Juergen Gross <[email protected]>

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel

Applied
#3 lore raw
Quoted 8 lines · Juergen Gross
Quoted 6 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 146562
Addresses-Coverity-ID: 146563

Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Juergen Gross <[email protected]>

Applied to for-linus-4.15.

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel