Skip to contentSkip to conversation

soc: amlogic: gx pm domain: add PM and OF dependencies

PATCH In review Arnd Bergmann 2 participants 2 messages Nov 2, 2017 – Nov 3, 2017 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: amlogic: gx pm domain: add PM and OF dependencies

The new driver introduces harmless warnings:

warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)

This adds CONFIG_OF and CONFIG_PM dependencies to ensure it will only be enabled in valid configurations.

Fixes 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
---
 drivers/soc/amlogic/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/amlogic/Kconfig +1 -0
index 1621bb25a1ea..b04f6e4aedbc 100644
@@ -12,6 +12,7 @@ config MESON_GX_SOCINFO
 config MESON_GX_PM_DOMAINS
 	bool "Amlogic Meson GX Power Domains driver"
 	depends on ARCH_MESON || COMPILE_TEST
+	depends on PM && OF
 	default ARCH_MESON
 	select PM_GENERIC_DOMAINS
 	select PM_GENERIC_DOMAINS_OF
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Arnd Bergmann

The new driver introduces harmless warnings:

warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)

This adds CONFIG_OF and CONFIG_PM dependencies to ensure it will only be enabled in valid configurations.

Fixes 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
---
 drivers/soc/amlogic/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/amlogic/Kconfig +0 -0
index 1621bb25a1ea..b04f6e4aedbc 100644

drivers/soc/amlogic/Kconfig config MESON_GX_SOCINFO · line 18

Quoted 7 lines
drivers/soc/amlogic/Kconfig +1 -0
@@ -12,6 +12,7 @@ config MESON_GX_SOCINFO
 config MESON_GX_PM_DOMAINS
 	bool "Amlogic Meson GX Power Domains driver"
 	depends on ARCH_MESON || COMPILE_TEST
+	depends on PM && OF
 	default ARCH_MESON
 	select PM_GENERIC_DOMAINS
 	select PM_GENERIC_DOMAINS_OF

Thanks for the fix