Skip to contentSkip to conversation

tracing: make PREEMPTIRQ_EVENTS depend on TRACING

PATCH In review Arnd Bergmann 2 participants 2 messages Nov 3, 2017 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: make PREEMPTIRQ_EVENTS depend on TRACING

When CONFIG_TRACING is disabled, the new preemptirq events tracer produces a build failure:

In file included from kernel/trace/trace_irqsoff.c:17:0:
kernel/trace/trace.h: In function 'trace_test_and_set_recursion':
kernel/trace/trace.h:542:28: error: 'struct task_struct' has no member named 'trace_recursion'

Adding an explicit dependency avoids the broken configuration.

Fixes d59158162e03 ("tracing: Add support for preempt and irq enable/disable events")

---
No idea if this is the best solution, it just happened to fix the build failure for me.

---
 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/Kconfig +1 -0
index 1ff10ca078d6..c8c18c793c86 100644
@@ -164,6 +164,7 @@ config PREEMPTIRQ_EVENTS
 	bool "Enable trace events for preempt and irq disable/enable"
 	select TRACE_IRQFLAGS
 	depends on DEBUG_PREEMPT || !PROVE_LOCKING
+	depends on TRACING
 	default n
 	help
 	  Enable tracing of disable and enable events for preemption and irqs.
Signature · 1 line
2.9.0
maintainer
#1 lore raw
Quoted 7 lines · On Fri, 3 Nov 2017 11:39:57 +0100 Arnd Bergmann <[email protected]> wrote:

When CONFIG_TRACING is disabled, the new preemptirq events tracer produces a build failure:

In file included from kernel/trace/trace_irqsoff.c:17:0:
kernel/trace/trace.h: In function 'trace_test_and_set_recursion':
kernel/trace/trace.h:542:28: error: 'struct task_struct' has no member named 'trace_recursion'

Quoted 7 lines

Adding an explicit dependency avoids the broken configuration.

Fixes d59158162e03 ("tracing: Add support for preempt and irq enable/disable events")

---
No idea if this is the best solution, it just happened to fix the build failure for me.

OK, as same as other tracers, it should select GENERIC_TRACER and TRACER_MAX_TRACE, and depends on TRACE_IRQFLAGS_SUPPORT, and maybe depends on !ARCH_USES_GETTIMEOFFSET.

Thank you,

Quoted 19 lines
---
 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/Kconfig +1 -0
index 1ff10ca078d6..c8c18c793c86 100644
@@ -164,6 +164,7 @@ config PREEMPTIRQ_EVENTS
 	bool "Enable trace events for preempt and irq disable/enable"
 	select TRACE_IRQFLAGS
 	depends on DEBUG_PREEMPT || !PROVE_LOCKING
+	depends on TRACING
 	default n
 	help
 	  Enable tracing of disable and enable events for preemption and irqs.
Signature · 1 line
2.9.0
Signature · 1 line
Masami Hiramatsu <[email protected]>