Skip to contentSkip to conversation

tracing: use swap macro in update_max_tr

PATCH New Gustavo A. R. Silva 1 participant 1 message Nov 3, 2017 Tracing

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 tracing: use swap macro in update_max_tr

Make use of the swap macro and remove unnecessary variable buf. This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 kernel/trace/trace.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
kernel/trace/trace.c +1 -7
index dbce1be..1bca7fb 100644
@@ -1351,8 +1351,6 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 void
 update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 {
-	struct ring_buffer *buf;
-
 	if (tr->stop_count)
 		return;
 

@@ -1365,11 +1363,7 @@ update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 	}
 
 	arch_spin_lock(&tr->max_lock);
-
-	buf = tr->trace_buffer.buffer;
-	tr->trace_buffer.buffer = tr->max_buffer.buffer;
-	tr->max_buffer.buffer = buf;
-
+	swap(tr->trace_buffer.buffer, tr->max_buffer.buffer);
 	__update_max_tr(tr, tsk, cpu);
 	arch_spin_unlock(&tr->max_lock);
 }
Signature · 1 line
2.7.4