Skip to contentSkip to conversation

x86/unwind_orc: use swap macro in orc_sort_swap

PATCH New Gustavo A. R. Silva 1 participant 1 message Nov 3, 2017

Subsystems (2)
x86 x86 stack unwinding
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 x86/unwind_orc: use swap macro in orc_sort_swap

Make use of the swap macro and remove unnecessary variable orc_tmp. This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 arch/x86/kernel/unwind_orc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
arch/x86/kernel/unwind_orc.c +1 -4
index b95007e..82b8fd2 100644
@@ -117,7 +117,6 @@ static struct orc_entry *orc_find(unsigned long ip)
 static void orc_sort_swap(void *_a, void *_b, int size)
 {
 	struct orc_entry *orc_a, *orc_b;
-	struct orc_entry orc_tmp;
 	int *a = _a, *b = _b, tmp;
 	int delta = _b - _a;
 

@@ -129,9 +128,7 @@ static void orc_sort_swap(void *_a, void *_b, int size)
 	/* Swap the corresponding .orc_unwind entries: */
 	orc_a = cur_orc_table + (a - cur_orc_ip_table);
 	orc_b = cur_orc_table + (b - cur_orc_ip_table);
-	orc_tmp = *orc_a;
-	*orc_a = *orc_b;
-	*orc_b = orc_tmp;
+	swap(*orc_a, *orc_b);
 }
 
 static int orc_sort_cmp(const void *_a, const void *_b)
Signature · 1 line
2.7.4