Perform package tests in Travis CI

Changelog: v0->v1:
* The "cbuild: Properly create tarball for SuSE" patch was abandoned as no one is interested by scripts behavior when being ran by root.
* Patch "travis: Add RedHat and SuSE rpmbuild support" "buildlib/package-build-test" script to skip build tests when being ran outside travis (the actual check is whether we are already running inside a container or not).
* In the patch "travis: Test Debian packaging under artful container" removed as no longer needed installations: debhelper, dh-systemd, fakeroot

-----------------------------------------------------------------------------

This patchset comes from Alaa and he adds to Travis CI ability to reuse our cbuild script to build various packages.

The PR is https://github.com/linux-rdma/rdma-core/pull/241

The change to SuSE Tumbleweed wasn't straightforward and can be done as a followup patch.

Thanks

Alaa Hleihel (3):
travis: Add RedHat and SuSE rpmbuild support buildlib/cbuild: Add Ubuntu artful
travis: Test Debian packaging under artful container

 .travis.yml                 |  7 ++++---
 buildlib/cbuild             |  7 +++++++
 buildlib/package-build-test | 21 +++++++++++++++++++++
 buildlib/travis-build       | 14 --------------
 4 files changed, 32 insertions(+), 17 deletions(-)
 create mode 100755 buildlib/package-build-test

--
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/[email protected]>

Provide a new script for testing rpmbuild under RedHat and SuSE environments which validates both of the suse/rdma-core.spec and redhat/rdma-core.spec spec files.

The script performs the RPM package build test by utilizing the existing cbuild tool.

---
 .travis.yml                 |  4 ++++
 buildlib/package-build-test | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100755 buildlib/package-build-test

index c190a241..4d7b0cc0 100644
@@ -42,6 +42,9 @@ addons:
       - gcc-multilib
       - lib32gcc-7-dev
 
+service:
+    - docker
+
 before_script:
   - export LATEST_GCC_LINARO_URL=`wget -qO - https://releases.linaro.org/components/toolchain/binaries/latest/aarch64-linux-gnu/ | grep -o '<a href=['"'"'"].*gcc-linaro-.*x86_64_aarch64-linux-gnu.tar.xz['"'"'"]'  |  sed -e 's/^<a href=["'"'"']//' -e 's/["'"'"']$//'`
   - export LATEST_GCC_LINARO_TAR=`basename $LATEST_GCC_LINARO_URL`

@@ -51,6 +54,7 @@ before_script:
 script:
   - buildlib/travis-build
   - buildlib/travis-checkpatch
+  - buildlib/package-build-test
   - buildlib/github-release
 deploy:
   # Deploy assets to Github releases

new file mode 100755
index 00000000..d5fcdd9c
@@ -0,0 +1,21 @@
+#!/bin/bash
+
+# fail on errors
+set -e
+# be verbose
+set -x
+
+# Do not run these tests if we are already inside a container
+if [ -e "/.dockerenv" ] || (grep -q docker /proc/self/cgroup &>/dev/null); then
+       echo "We are running in a container, skipping ..."
+       exit 0
+fi
+
+for OS in centos7 opensuse-42.3
+do
+	echo
+	echo "Checking package build for ${OS} ...."
+	echo
+	buildlib/cbuild build-images ${OS}
+	buildlib/cbuild pkg ${OS}
+done

2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/[email protected]>

This patch adds Ubuntu17.10 artful, that comes with GCC 7

---
 buildlib/cbuild | 7 +++++++
 1 file changed, 7 insertions(+)

index fac1c3c6..e6a64e8a 100755
@@ -181,6 +181,12 @@ class xenial(APTEnvironment):
     name = "ubuntu-16.04";
     aliases = {"xenial"};
 
+class artful(APTEnvironment):
+    docker_parent = "ubuntu:17.10"
+    pkgs = xenial.pkgs
+    name = "ubuntu-17.10";
+    aliases = {"artful"};
+
 class jessie(APTEnvironment):
     docker_parent = "debian:8"
     pkgs = xenial.pkgs;

@@ -325,6 +331,7 @@ environments = [centos6(),
                 travis(),
                 trusty(),
                 xenial(),
+                artful(),
                 jessie(),
                 stretch(),
                 fc26(),

2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Alaa Hleihel <alaa-VPRAkNaXOzVWk0Htik3J/[email protected]>

This will be compiled with GCC 7 coming with Ubuntu artful.

Also, remove installations of debian helpers from addons->apt list in .travis.yml file as they are no longer required.

---
 .travis.yml                 |  3 ---
 buildlib/package-build-test |  2 +-
 buildlib/travis-build       | 14 --------------
 3 files changed, 1 insertion(+), 18 deletions(-)

index 4d7b0cc0..bdcb20a8 100644
@@ -21,9 +21,6 @@ addons:
       - build-essential
       - clang-4.0
       - cmake
-      - debhelper
-      - dh-systemd
-      - fakeroot
       - gcc
       - gcc-7
       - git

index d5fcdd9c..e6d7b100 100755
@@ -11,7 +11,7 @@ if [ -e "/.dockerenv" ] || (grep -q docker /proc/self/cgroup &>/dev/null); then
        exit 0
 fi
 
-for OS in centos7 opensuse-42.3
+for OS in centos7 opensuse-42.3 artful
 do
 	echo
 	echo "Checking package build for ${OS} ...."

index bf86baa7..1a88dff2 100755
@@ -45,17 +45,3 @@ rm CMakeCache.txt
 CC=clang-4.0 CFLAGS=-Werror cmake -GNinja ..
 ninja
 cp ../util/udma_barrier.h.old ../util/udma_barrier.h
-
-# Finally run through gcc-7 64 bit through the debian packaging This gives a
-# good clue if patches are changing packaging related things, the RPM stuff
-# will have to be audited by hand.
-
-# When running cmake through debian/rules it is hard to set -Werror,
-# instead force it on by changing the CMakeLists.txt
-cd ..
-echo 'set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror")' >> buildlib/RDMA_EnableCStd.cmake
-sed -i -e 's/-DCMAKE_BUILD_TYPE=Release//g' debian/rules
-sed -i -e 's/ninja \(.*\)-v/ninja \1/g' debian/rules
-
-CC=gcc-7 debian/rules build
-fakeroot debian/rules binary

2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

We still have compilation tests with -Werror in buildlib/travis-build (clang, 32 bit, arm, etc..). If that is not enough, I think we can pass the -Werror to rpmbuild via CFLAGS environment variable:
CFLAGS="-Werror" rpmbuild ............

What do you think ?

Regards,
Alaa

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

It is not enough. All compilation tests must be run with -Werror and if you move the gcc-7 test then you have to keep the -Werror

If that works properly it would be fine.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

I will take the two patches above, because they are not controversial and resend the third one.

Thanks