video: fbdev: cirrusfb: mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Nov 6, 2017 – Nov 9, 2017 Framebuffer layer

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-11-06 22:45 UTC #0 lore raw

PATCH 1/1 video: fbdev: cirrusfb: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case I placed the "fall through" comment on its own line, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/video/fbdev/cirrusfb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/video/fbdev/cirrusfb.c +4 -2

index d992aa5..b3be06d 100644
@@ -1477,10 +1477,12 @@ static void init_vgachip(struct fb_info *info)
 		mdelay(100);
 		/* mode */
 		vga_wgfx(cinfo->regbase, CL_GR31, 0x00);
-	case BT_GD5480:  /* fall through */
+		/* fall through */
+	case BT_GD5480:
 		/* from Klaus' NetBSD driver: */
 		vga_wgfx(cinfo->regbase, CL_GR2F, 0x00);
-	case BT_ALPINE:  /* fall through */
+		/* fall through */
+	case BT_ALPINE:
 		/* put blitter into 542x compat */
 		vga_wgfx(cinfo->regbase, CL_GR33, 0x00);
 		break;

Signature · 1 line

2.7.4

Bartlomiej Zolnierkiewicz

2017-11-09 16:00 UTC #1 lore raw

Quoted 7 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case I placed the "fall through" comment on its own line, which is what GCC is expecting to find.
Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics