pwm: stmpe: Fix wrong register offset for hwpwm=2 case
PATCH 1/1 pwm: stmpe: Fix wrong register offset for hwpwm=2 case
Fix trivial copy/paste bug.
---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.
Thanks,
Axel
drivers/pwm/pwm-stmpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-stmpe.c +1 -1
@@ -145,7 +145,7 @@ static int stmpe_24xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,break ;case 2 : - offset =STMPE24XX_PWMIC1 ; + offset =STMPE24XX_PWMIC2 ;break ;default :
Signature · 1 line
2.11.0
Quoted 7 lines · Axel Lin
Fix trivial copy/paste bug.
Signed-off-by Axel Lin <[email protected]>---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.
This is an obvious copy/paste bug indeed.
Yours,
Linus Walleij
2017-11-09 16:45 GMT+08:00 Linus Walleij <[email protected]>:
Quoted 11 lines · Axel Lin
Quoted 8 lines
Fix trivial copy/paste bug.
Signed-off-by Axel Lin <[email protected]>---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.Reviewed-by Linus Walleij <[email protected]>
Hi Thierry,
Seems this one is still not apply. Should I resend?
Thanks,
Axel
Quoted 11 lines · Axel Lin
2017-11-09 16:45 GMT+08:00 Linus Walleij <[email protected]>:
Quoted 10 lines · Axel Lin
Quoted 8 lines
Fix trivial copy/paste bug.
Signed-off-by Axel Lin <[email protected]>---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.
Quoted 4 lines
Quoted 1 line
Reviewed-by Linus Walleij <[email protected]>Hi Thierry,
Seems this one is still not apply. Should I resend?
No need to resend, I can see it in patchwork. I'm not exactly sure what happened, but it looks like this may have just missed the cut-off point for v4.15-rc1. Is this a serious bug? Do you want it to go into v4.15? By the looks of it this has been wrong since forever (no changes since the original patch adding the driver), so I'm wondering if anybody has ever used this third PWM at all.
I'm fine either way. If this is something that's creating problems, let me know and I'll queue it for v4.15-rc2. If so, you may want it to be backported to stable kernel, in which case:
Thierry
Quoted 8 lines · Axel Lin
Fix trivial copy/paste bug.
Signed-off-by Axel Lin <[email protected]>---
Hi Linus,
I don't have this h/w to test.
Appreciate if you can review and test this patch.
Quoted 4 lines
Thanks,
Axeldrivers/pwm/pwm-stmpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied this and added:
Thanks,
Thierry