Skip to contentSkip to conversation

sunxi: fix CONFIG_SUNXI_EMAC references

PATCH New Artturi Alm 2 participants 6 messages Nov 8, 2017 – Nov 9, 2017

Subsystems (2)
Network drivers Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Artturi Alm

author
#0 lore raw

PATCH 1/2 sunxi: fix CONFIG_SUNXI_EMAC references

fixes CONFIG_SUNXI_EMAC references from drivers/net/Makefile and include/configs/sunxi-common.h likely forgotten in:
commit abc3e4df59f5 ("sunxi: Convert SUNXI_EMAC to Kconfig")

Signed-off-by Artturi Alm <[email protected]>

---

 drivers/net/Makefile           | 2 +-
 include/configs/sunxi-common.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/Makefile +1 -1
index 94a4fd8..ac5443c 100644
@@ -21,7 +21,7 @@ obj-$(CONFIG_DNET) += dnet.o
 obj-$(CONFIG_E1000) += e1000.o
 obj-$(CONFIG_E1000_SPI) += e1000_spi.o
 obj-$(CONFIG_EEPRO100) += eepro100.o
-obj-$(CONFIG_SUNXI_EMAC) += sunxi_emac.o
+obj-$(CONFIG_SUN4I_EMAC) += sunxi_emac.o
 obj-$(CONFIG_SUN8I_EMAC) += sun8i_emac.o
 obj-$(CONFIG_ENC28J60) += enc28j60.o
 obj-$(CONFIG_EP93XX) += ep93xx_eth.o
include/configs/sunxi-common.h +1 -1
index 4207398..4391a8c 100644
@@ -286,7 +286,7 @@ extern int soft_i2c_gpio_scl;
 #endif /* CONFIG_VIDEO_SUNXI */
 
 /* Ethernet support */
-#ifdef CONFIG_SUNXI_EMAC
+#ifdef CONFIG_SUN4I_EMAC
 #define CONFIG_PHY_ADDR		1
 #define CONFIG_MII			/* MII PHY management		*/
 #endif
Signature · 1 line
2.9.5
author
#1 lore raw

PATCH 2/2 sunxi: restore PHYLIB for CONFIG_SUN4I_EMAC users

due misnaming of CONFIG_SUN4I_EMAC in include/configs/sunxi-common.h, likely missed in:

	commit 3146f0c017df ("Move PHYLIB to Kconfig")
Signed-off-by Artturi Alm <[email protected]>

---

 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
index c1ce54e..52555da 100644
@@ -247,6 +247,7 @@ config SUN7I_GMAC
 config SUN4I_EMAC
 	bool "Allwinner Sun4i Ethernet MAC support"
 	depends on DM_ETH
+	select PHYLIB
 	help
 	  This driver supports the Allwinner based SUN4I Ethernet MAC.
Signature · 1 line
2.9.5
#2 lore raw

PATCH 2/2 sunxi: restore PHYLIB for CONFIG_SUN4I_EMAC users

Quoted 5 lines · Artturi Alm

due misnaming of CONFIG_SUN4I_EMAC in include/configs/sunxi-common.h, likely missed in:

        commit 3146f0c017df ("Move PHYLIB to Kconfig")
Signed-off-by Artturi Alm <[email protected]>
Reviewed-by Jagan Teki <[email protected]>

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#3 lore raw

PATCH 2/2 sunxi: restore PHYLIB for CONFIG_SUN4I_EMAC users

Quoted 8 lines · Jagan Teki
Quoted 5 lines · Artturi Alm

due misnaming of CONFIG_SUN4I_EMAC in include/configs/sunxi-common.h, likely missed in:

        commit 3146f0c017df ("Move PHYLIB to Kconfig")
Signed-off-by Artturi Alm <[email protected]>
Reviewed-by Jagan Teki <[email protected]>

Applied to u-boot-sunxi/master

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#4 lore raw

PATCH 1/2 sunxi: fix CONFIG_SUNXI_EMAC references

In reply to Artturi Alm
Quoted 5 lines · Artturi Alm

fixes CONFIG_SUNXI_EMAC references from drivers/net/Makefile and include/configs/sunxi-common.h likely forgotten in:
commit abc3e4df59f5 ("sunxi: Convert SUNXI_EMAC to Kconfig")

Signed-off-by Artturi Alm <[email protected]>
Reviewed-by Jagan Teki <[email protected]>

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#5 lore raw

PATCH 1/2 sunxi: fix CONFIG_SUNXI_EMAC references

Quoted 8 lines · Jagan Teki
Quoted 5 lines · Artturi Alm

fixes CONFIG_SUNXI_EMAC references from drivers/net/Makefile and include/configs/sunxi-common.h likely forgotten in:
commit abc3e4df59f5 ("sunxi: Convert SUNXI_EMAC to Kconfig")

Signed-off-by Artturi Alm <[email protected]>
Reviewed-by Jagan Teki <[email protected]>

Applied to u-boot-sunxi/master

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.