Skip to contentSkip to conversation

Move Cache-As-RAM memory from area mapped to ROM in QEMU

PATCH In review Anton Gerasimov 3 participants 5 messages Nov 10, 2017 – Nov 14, 2017 x86

lore
Share & tools
lore

Anton Gerasimov

author
#0 lore raw

PATCH 1/1 Move Cache-As-RAM memory from area mapped to ROM in QEMU

ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues

Signed-off-by Anton Gerasimov <[email protected]>
---
 arch/x86/cpu/qemu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/cpu/qemu/Kconfig +1 -1
index 6808c9a6b9..f4b9922a34 100644
@@ -11,7 +11,7 @@ if QEMU
 
 config SYS_CAR_ADDR
 	hex
-	default 0xd0000
+	default 0x10000
 
 config SYS_CAR_SIZE
 	hex
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 Move Cache-As-RAM memory from area mapped to ROM in QEMU

Quoted 17 lines · Anton Gerasimov

ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues

Signed-off-by Anton Gerasimov <[email protected]>
---
 arch/x86/cpu/qemu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/cpu/qemu/Kconfig +0 -0
index 6808c9a6b9..f4b9922a34 100644

arch/x86/cpu/qemu/Kconfig if QEMU · line 17

Quoted 8 lines
arch/x86/cpu/qemu/Kconfig +1 -1
@@ -11,7 +11,7 @@ if QEMU
 
 config SYS_CAR_ADDR
 	hex
-	default 0xd0000
+	default 0x10000
 
 config SYS_CAR_SIZE
 	hex

Bin, are you happy with this? Do you want this in before release? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171110/678c2706/attachment.sig>
Tested-by on v1 1/1
#2 lore raw
In reply to Anton Gerasimov
Quoted 6 lines · Anton Gerasimov

ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues

I could not reproduce that reverting aaaa55751ab1 is necessary. Your patch and CONFIG_SMP=n was suffcient to start U-Boot with qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)

Tested-by Heinrich Schuchardt <[email protected]>
Quoted 20 lines
Signed-off-by Anton Gerasimov <[email protected]>
---
  arch/x86/cpu/qemu/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/cpu/qemu/Kconfig +1 -1
index 6808c9a6b9..f4b9922a34 100644
@@ -11,7 +11,7 @@ if QEMU
 
  config SYS_CAR_ADDR
  	hex
-	default 0xd0000
+	default 0x10000
 
  config SYS_CAR_SIZE
  	hex
author
#3 lore raw

Thank you Heinrich, I can confirm that current u-boot master works without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2 apparently.

Best regards,
Anton Gerasimov

Quoted 33 lines · Heinrich Schuchardt
Quoted 6 lines · Anton Gerasimov

ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues

I could not reproduce that reverting aaaa55751ab1 is necessary. Your patch and CONFIG_SMP=n was suffcient to start U-Boot with qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)

Tested-by Heinrich Schuchardt <[email protected]>
Quoted 18 lines
Signed-off-by Anton Gerasimov <[email protected]>

---
  arch/x86/cpu/qemu/Kconfig | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/cpu/qemu/Kconfig +0 -0
index 6808c9a6b9..f4b9922a34 100644
@@ -11,7 +11,7 @@ if QEMU

    config SYS_CAR_ADDR
      hex
-    default 0xd0000
+    default 0x10000
    config SYS_CAR_SIZE
      hex

Signature · 4 lines
Anton Gerasimov, ATS Advanced Telematic Systems GmbH
Kantstrasse 162, 10623 Berlin
Managing Directors: Dirk Pöschl, Armin G. Schmidt
Register Court: HRB 151501 B, Amtsgericht Charlottenburg
#4 lore raw
Quoted 3 lines · Anton Gerasimov

Thank you Heinrich, I can confirm that current u-boot master works without reverting aaaa55751ab1. I had problems with u-boot v2017.11-rc2 apparently.

Could you, please, resubmit the patch with an updated commit message.

Regards

Heinrich

Quoted 39 lines

Best regards,
Anton Gerasimov

Quoted 33 lines · Heinrich Schuchardt
Quoted 6 lines · Anton Gerasimov

ROM has been made read-only in qemu recently (namely commit 208fa0e43645edd0b0d8f838857dfc79daff40a8), so this patch restores compatibility between u-boot and qemu. It is still broken for me unless I set CONFIG_SMP=n and disable lapic (i.e. revert patch aaaa55751ab1e5a5cfa0962d604593a7e6f33ff6 in u-boot), but these are separate issues

I could not reproduce that reverting aaaa55751ab1 is necessary. Your patch and CONFIG_SMP=n was suffcient to start U-Boot with qemu-system-x86_64 version 2.10.1(Debian 1:2.10.0+dfsg-2)

Tested-by Heinrich Schuchardt <[email protected]>
Quoted 18 lines
Signed-off-by Anton Gerasimov <[email protected]>
---
   arch/x86/cpu/qemu/Kconfig | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/cpu/qemu/Kconfig +1 -1
index 6808c9a6b9..f4b9922a34 100644
@@ -11,7 +11,7 @@ if QEMU
     config SYS_CAR_ADDR
       hex
-    default 0xd0000
+    default 0x10000
     config SYS_CAR_SIZE
       hex