Skip to contentSkip to conversation

xen/pci: Use acpi_noirq_set() helper

PATCH In review Andy Shevchenko 2 participants 2 messages Nov 10, 2017 – Nov 21, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xen/pci: Use acpi_noirq_set() helper

No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.

---
- resend as v2 with slightly longer Cc list, i.e. +Rafael and ACPI ML
- in v1 Bjorn told he is okay with patch, but assumed it goes not via PCI tree

 arch/x86/pci/xen.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/pci/xen.c +1 -3
index c4b3646bd04c..9542a746dc50 100644
@@ -409,10 +409,8 @@ int __init pci_xen_init(void)
 	pcibios_enable_irq = xen_pcifront_enable_irq;
 	pcibios_disable_irq = NULL;
 
-#ifdef CONFIG_ACPI
 	/* Keep ACPI out of the picture */
-	acpi_noirq = 1;
-#endif
+	acpi_noirq_set();
 
 #ifdef CONFIG_PCI_MSI
 	x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
Signature · 1 line
2.14.2
#1 lore raw
Quoted 7 lines · Andy Shevchenko

No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.

---
- resend as v2 with slightly longer Cc list, i.e. +Rafael and ACPI ML
- in v1 Bjorn told he is okay with patch, but assumed it goes not via PCI tree

Sorry, I didn't understand your pings on the previous patch correctly, and I still assumed a Xen or x86 person would take this. Since they haven't, I put it on pci/virtualization for v4.16.

If anybody else wants it and does pick it up, let me know and I'll drop it.

Bjorn

Quoted 26 lines
 arch/x86/pci/xen.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/pci/xen.c +1 -3
index c4b3646bd04c..9542a746dc50 100644
@@ -409,10 +409,8 @@ int __init pci_xen_init(void)
 	pcibios_enable_irq = xen_pcifront_enable_irq;
 	pcibios_disable_irq = NULL;
 
-#ifdef CONFIG_ACPI
 	/* Keep ACPI out of the picture */
-	acpi_noirq = 1;
-#endif
+	acpi_noirq_set();
 
 #ifdef CONFIG_PCI_MSI
 	x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
Signature · 6 lines
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html