Skip to contentSkip to conversation

HDMI 2.0 on CNL... not working...

PATCH In review Rodrigo Vivi 7 participants 16 messages Nov 10, 2017 – Nov 17, 2017

Subsystems (2)
lore
Share & tools
lore

Rodrigo Vivi

author maintainer
#0 lore raw

cover HDMI 2.0 on CNL... not working...

I'm just sending this patch for reference here since this is the patch that I believe it is the correct one to get HDMI 2.0 working on CNL.

However I'm just getting a blank screen when trying to use HDMI at 4k@60Hz here... Maybe it is just my bad old cable here... maybe I'm missing something... but I couldn't stop yet to collect logs...

Any feedback, idea, help is very welcome.

Thanks,
Rodrigo.

Rodrigo Vivi (1):
drm/i915/cnl: Extend HDMI 2.0 support to CNL.

 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#1 lore raw

PATCH 1/1 drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +4 -3
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
 		&dev_priv->vbt.ddi_port_info[encoder->port];
 	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		max_tmds_clock = 594000;
 	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
 		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
 	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
 		if (scdc->scrambling.low_rates)
 			pipe_config->hdmi_scrambling = true;
 
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
 	connector->doublescan_allowed = 0;
 	connector->stereo_allowed = 1;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		connector->ycbcr_420_allowed = true;
 
 	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#2 lore raw

PATCH 1/1 drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

v2: The version that compiles :/

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +4 -3
index 2d95db64cdf2..96c314a6170a 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
 		&dev_priv->vbt.ddi_port_info[encoder->port];
 	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		max_tmds_clock = 594000;
 	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
 		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
 	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10)) {
 		if (scdc->scrambling.low_rates)
 			pipe_config->hdmi_scrambling = true;
 
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
 	connector->doublescan_allowed = 0;
 	connector->stereo_allowed = 1;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		connector->ycbcr_420_allowed = true;
 
 	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

In reply to Rodrigo Vivi

Looks good.
But are these the only places that need change to support 2.0? Dont we need any changes in voltage swing programming or DDI clocks?

Manasi`

Quoted 46 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +4 -3
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
 		&dev_priv->vbt.ddi_port_info[encoder->port];
 	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		max_tmds_clock = 594000;
 	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
 		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
 	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
 		if (scdc->scrambling.low_rates)
 			pipe_config->hdmi_scrambling = true;
 
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
 	connector->doublescan_allowed = 0;
 	connector->stereo_allowed = 1;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		connector->ycbcr_420_allowed = true;
 
 	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 1 line
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#4 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Quoted 3 lines · Manasi Navare

Looks good.
But are these the only places that need change to support 2.0? Dont we need any changes in voltage swing programming or DDI clocks?

not that I'm aware of... but that would explain the blank screens...

Quoted 42 lines

Manasi`

Quoted 38 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +3 -2
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
 		&dev_priv->vbt.ddi_port_info[encoder->port];
 	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		max_tmds_clock = 594000;
 	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
 		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
 	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
 		if (scdc->scrambling.low_rates)
 			pipe_config->hdmi_scrambling = true;
 
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
 	connector->doublescan_allowed = 0;
 	connector->stereo_allowed = 1;
 
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
 		connector->ycbcr_420_allowed = true;
 
 	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 1 line
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

I am still waiting for the dmesg logs, Rodrigo :P

I am pretty sure that you would have picked up if there is a general problem, wit the modeset or HDMI.

I just want to check what is following from the mode and monitor combination during blankout:

- is the mode YCBCR420 ?

- is scrambling enabled ?

- does the monitor supports 4k@60 RGB (594Mhz) or its 4k@60 YCBCR420 (300Mhz)

- are we in 12 BPC deep color mode ?
- is this a CEA 4k@60 mode, or other one ?

Regards
Shashank

Quoted 47 lines · Rodrigo Vivi
Quoted 3 lines · Manasi Navare

Looks good.
But are these the only places that need change to support 2.0? Dont we need any changes in voltage swing programming or DDI clocks?

not that I'm aware of... but that would explain the blank screens...

Quoted 41 lines

Manasi`

Quoted 38 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +3 -2
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
  	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;
 
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
  	connector->stereo_allowed = 1;
 
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;
 
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 1 line
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#6 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Quoted 4 lines · Shashank

I am still waiting for the dmesg logs, Rodrigo :P

I am pretty sure that you would have picked up if there is a general problem, wit the modeset or HDMI.

yep... my bad... sorry...
We will provide that soon.

Quoted 58 lines

I just want to check what is following from the mode and monitor combination during blankout:

- is the mode YCBCR420 ?

- is scrambling enabled ?

- does the monitor supports 4k@60 RGB (594Mhz) or its 4k@60 YCBCR420 (300Mhz)

- are we in 12 BPC deep color mode ?
- is this a CEA 4k@60 mode, or other one ?

Regards
Shashank

Quoted 41 lines · Rodrigo Vivi
Quoted 3 lines · Manasi Navare

Looks good.
But are these the only places that need change to support 2.0? Dont we need any changes in voltage swing programming or DDI clocks?

not that I'm aware of... but that would explain the blank screens...

Quoted 35 lines

Manasi`

Quoted 32 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +3 -2
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
  	pipe_config->lane_count = 4;
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
  	connector->stereo_allowed = 1;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);
Signature · 1 line
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

In reply to Rodrigo Vivi

Regards

Shashank

Quoted 16 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +0 -0
index 2d95db64cdf2..1b22b587e98c 100644

drivers/gpu/drm/i915/intel_hdmi.c static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) · line 1238

Quoted 5 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)

Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or a function is_hdmi2_supported() where we keep all the GEN check ?

Quoted 14 lines
drivers/gpu/drm/i915/intel_hdmi.c +2 -1
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 
  	pipe_config->lane_count = 4;
 
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;
 

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2038

Quoted 6 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
  	connector->stereo_allowed = 1;
 
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;

Looks good otherwise.
- Shashank

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2040

Quoted 2 lines
drivers/gpu/drm/i915/intel_hdmi.c +0 -0
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#8 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Quoted 17 lines · Shashank

Regards

Shashank

Quoted 11 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_hdmi.c static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) · line 1237

Quoted 9 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)

Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or a function is_hdmi2_supported() where we keep all the GEN check ?

I asked myself the same question.
I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea...

Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_hdmi.c +2 -1
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
  	pipe_config->lane_count = 4;
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;
Quoted 10 lines

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2037

Quoted 6 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
  	connector->stereo_allowed = 1;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;

Looks good otherwise.
- Shashank

Quoted 1 line
drivers/gpu/drm/i915/intel_hdmi.c +0 -0
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Quoted 30 lines · Rodrigo Vivi
Quoted 17 lines · Shashank

Regards

Shashank

Quoted 11 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_hdmi.c static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) · line 1237

Quoted 9 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)

Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or a function is_hdmi2_supported() where we keep all the GEN check ?

Quoted 2 lines

I asked myself the same question.
I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea...

Typically we use HAS_* to check whether a feature is available,
and IS_* to identify a platform, or whether the parameter passed is of a certain type.

So I believe HAS_HDMI2_SUPPORT would be correct if it's to check whether the platform supports HDMI2.

Quoted 18 lines
Quoted 18 lines
Quoted 11 lines
drivers/gpu/drm/i915/intel_hdmi.c +2 -1
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
  	pipe_config->lane_count = 4;
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2037

Quoted 5 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
  	connector->stereo_allowed = 1;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;

Looks good otherwise.
- Shashank

Quoted 6 lines
Quoted 2 lines

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2040

Quoted 1 line
drivers/gpu/drm/i915/intel_hdmi.c +0 -0
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#10 lore raw

Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Quoted 34 lines · David Weinehall
Quoted 30 lines · Rodrigo Vivi
Quoted 17 lines · Shashank

Regards

Shashank

Quoted 11 lines · Rodrigo Vivi

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL.

Cc Paulo Zanoni <[email protected]>
Cc Shashank Sharma <[email protected]>
Cc Manasi Navare <[email protected]>
---
  drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_hdmi.c static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) · line 1237

Quoted 9 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
index 2d95db64cdf2..1b22b587e98c 100644
@@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder)
  		&dev_priv->vbt.ddi_port_info[encoder->port];
  	int max_tmds_clock;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)

Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or a function is_hdmi2_supported() where we keep all the GEN check ?

Quoted 2 lines

I asked myself the same question.
I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea...

Quoted 6 lines

Typically we use HAS_* to check whether a feature is available,
and IS_* to identify a platform, or whether the parameter passed is of a certain type.

So I believe HAS_HDMI2_SUPPORT would be correct if it's to check whether the platform supports HDMI2.

I'd rather this was more like the DP code. There's none of this "has DP x.y support" kind of thing for the source. Instead, we look at *features* within those specs. "supports hbr2" and so on. And those checks tend to be more limited in scope than an overarching "hdmi 2.0 support".

BR,
Jani.

Quoted 29 lines
Quoted 19 lines
Quoted 19 lines
Quoted 12 lines
drivers/gpu/drm/i915/intel_hdmi.c +2 -1
  		max_tmds_clock = 594000;
  	else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv))
  		max_tmds_clock = 300000;
@@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
  	pipe_config->lane_count = 4;
-	if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) {
+	if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) ||
+					   INTEL_GEN(dev_priv) >= 10) {
  		if (scdc->scrambling.low_rates)
  			pipe_config->hdmi_scrambling = true;

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2037

Quoted 5 lines
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
  	connector->doublescan_allowed = 0;
  	connector->stereo_allowed = 1;
-	if (IS_GEMINILAKE(dev_priv))
+	if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10)
  		connector->ycbcr_420_allowed = true;

Looks good otherwise.
- Shashank

Quoted 6 lines
Quoted 2 lines

drivers/gpu/drm/i915/intel_hdmi.c void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, · line 2040

Quoted 1 line
drivers/gpu/drm/i915/intel_hdmi.c +0 -0
  	intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw

✗ Fi.CI.BAT: failure for HDMI 2.0 on CNL... not working...

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: HDMI 2.0 on CNL... not working...
URL : https://patchwork.freedesktop.org/series/33640/
State : failure

== Summary ==

  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     scripts/mod/devicetable-offsets.h
  CHK     include/generated/compile.h
  CHK     kernel/config_data.h
  CC [M]  drivers/gpu/drm/i915/intel_hdmi.o
drivers/gpu/drm/i915/intel_hdmi.c: In function ‘intel_hdmi_compute_config’:
drivers/gpu/drm/i915/intel_hdmi.c:1515:36: error: expected ‘)’ before ‘{’ token
         INTEL_GEN(dev_priv) >= 10) {
                                    ^

drivers/gpu/drm/i915/intel_hdmi.c:1526:1: error: expected expression before ‘}’ token
}
^
drivers/gpu/drm/i915/intel_hdmi.c:1526:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1: all warnings being treated as errors
scripts/Makefile.build:314: recipe for target 'drivers/gpu/drm/i915/intel_hdmi.o' failed make[4]: *** [drivers/gpu/drm/i915/intel_hdmi.o] Error 1
scripts/Makefile.build:573: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:573: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:573: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1024: recipe for target 'drivers' failed
make: *** [drivers] Error 2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.BAT: success for HDMI 2.0 on CNL... not working... (rev2)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: HDMI 2.0 on CNL... not working... (rev2)
URL : https://patchwork.freedesktop.org/series/33640/
State : success

== Summary ==

Series 33640v2 HDMI 2.0 on CNL... not working...
https://patchwork.freedesktop.org/api/1.0/series/33640/revisions/2/mbox/

Test gem_exec_reloc:

        Subgroup basic-gtt-read-active:
                fail       -> PASS       (fi-gdg-551) fdo#102582

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:446s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:452s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:383s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:532s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:274s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:500s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:504s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:495s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:492s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:261s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:548s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:427s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:436s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:426s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:467s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:459s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:489s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:521s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:534s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:454s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:546s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:521s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:460s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:558s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:419s
Blacklisted hosts:
fi-cfl-s         total:289  pass:254  dwarn:3   dfail:0   fail:0   skip:32  time:534s
fi-cnl-y         total:289  pass:261  dwarn:0   dfail:0   fail:1   skip:27  time:552s
fi-glk-dsi       total:289  pass:257  dwarn:0   dfail:0   fail:2   skip:30  time:513s

1342299348dec3bd4890284390a2209a00beafce drm-tip: 2017y-11m-10d-18h-11m-22s UTC integration manifest f23baddaee6b drm/i915/cnl: Extend HDMI 2.0 support to CNL.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7074/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

✗ Fi.CI.IGT: warning for HDMI 2.0 on CNL... not working... (rev2)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: HDMI 2.0 on CNL... not working... (rev2)
URL : https://patchwork.freedesktop.org/series/33640/
State : warning

== Summary ==

Test kms_setmode:

        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test kms_frontbuffer_tracking:
        Subgroup fbc-rgb101010-draw-mmap-gtt:
                pass       -> SKIP       (shard-hsw)

fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

shard-hsw total:2584 pass:1470 dwarn:4 dfail:2 fail:8 skip:1100 time:9425s
Blacklisted hosts:

shard-apl        total:2584 pass:1622 dwarn:2   dfail:1   fail:23  skip:936 time:13280s
shard-kbl        total:2565 pass:1692 dwarn:17  dfail:4   fail:23  skip:828 time:10826s
shard-snb        total:2584 pass:1198 dwarn:3   dfail:2   fail:11  skip:1370 time:7795s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7074/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw
In reply to Rodrigo Vivi

Hi

You will need a HDMI 2 cable

Regards

Mike

Quoted 20 lines · Rodrigo Vivi,

I'm just sending this patch for reference here since this is the patch that I believe it is the correct one to get HDMI 2.0 working on CNL.

However I'm just getting a blank screen when trying to use HDMI at 4k@60Hz here... Maybe it is just my bad old cable here... maybe I'm missing something... but I couldn't stop yet to collect logs...

Any feedback, idea, help is very welcome.

Thanks,
Rodrigo.

Rodrigo Vivi (1):
drm/i915/cnl: Extend HDMI 2.0 support to CNL.

 drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Quoted 8 lines

--
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#15 lore raw
Quoted 3 lines · Mike Lothian

Hi

You will need a HDMI 2 cable

Yes, I wonder already if that was the case... So we have a new HDMI cable type? a high-higher-speed? Or the regular high speed should be enough?

Anyways we are trying to get a "certified" hdmi 2.0 cable here :/

Thanks,
Rodrigo.

Quoted 28 lines

Regards

Mike

On Fri, 10 Nov 2017, 10:27 pm Rodrigo Vivi, <[email protected]> wrote:

I'm just sending this patch for reference here since this is the patch that I believe it is the correct one to get HDMI 2.0 working on CNL.

However I'm just getting a blank screen when trying to use HDMI at 4k@60Hz here... Maybe it is just my bad old cable here... maybe I'm missing something... but I couldn't stop yet to collect logs...

Any feedback, idea, help is very welcome.

Thanks,
Rodrigo.

Rodrigo Vivi (1):
drm/i915/cnl: Extend HDMI 2.0 support to CNL.

drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)

Quoted 8 lines

--
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx