kms_ccs improvements
v5 cover kms_ccs improvements
Hi,
This is a new version of the series with the updates requested by reviewers. It fixes the KBL issue pointed out by Arkadiusz, adds a test for pitches[1] mentioned by Ville and does some other improvements.
It does not set the modifier to 0 for plane1 on patch 4, nor change only the handle to zero on the same patch as mentioned by Ben and Ville, respectively, because Daniel Stone made the opposite request on a prior version and, after checking the dmesg, I verified it is correctly testing the missing BO (unless I'm understanding it wrong, in which case, oops :)
Ben, Ville, Arkadiusz, Daniel, Petri, thanks for the review.
Gabriel Krisman Bertazi (6):
tests/kms_ccs: Test pipes other than pipe A lib/igt_kms: Fix off-by-one bug on skip of missing pipe tests/kms_ccs: Prevent segfault if pipe is not supported tests/kms_ccs: Test case where the CCS buffer was not provided tests/kms_ccs: Test case where CCS is on a different BO tests/kms_ccs: Test case for wrong aux buffer stride size
lib/igt_kms.c | 2 +- tests/kms_ccs.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++++-------- 2 files changed, 70 insertions(+), 11 deletions(-)
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 1/6 tests/kms_ccs: Test pipes other than pipe A
Commit d41c4ccbd2f9 ("tests/kms_ccs: Fix subtest enumeration") accidently removed the update of data.pipe, causing kms_ccs to silently only test PIPE_A.
This fixes the behavior reported by Daniel Vetter where tests would succeed even on nonexistent pipes.
--- tests/kms_ccs.c | 2 ++ 1 file changed, 2 insertions(+)
tests/kms_ccs.c +2 -0
@@ -483,6 +483,8 @@ igt_mainconst char *pipe_name =kmstest_pipe_name (pipe);int sprite_idx =0 ; + data.pipe = pipe; + data.flags =TEST_BAD_PIXEL_FORMAT ; igt_subtest_f("pipe-%s-bad-pixel-format", pipe_name)test_output (&data);
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 2/6 lib/igt_kms: Fix off-by-one bug on skip of missing pipe
In reply to Gabriel Krisman Bertazidisplay->n_pipes is zero-indexed, so N returned in igt_display_get_n_pipes is already not a valid pipe. This patch prevents kms_ccs from going nuts when testing the first unexisting pipe.
--- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_kms.c +1 -1
@@ -1817,7 +1817,7 @@ void igt_display_require_output_on_pipe(igt_display_t *display, enum pipe pipe) {igt_output_t *output; -igt_skip_on_f (igt_display_get_n_pipes (display) < pipe, +igt_skip_on_f (pipe >=igt_display_get_n_pipes (display),"Pipe %s does not exist.\n" ,kmstest_pipe_name (pipe));for_each_valid_output_on_pipe (display, pipe, output)
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 3/6 tests/kms_ccs: Prevent segfault if pipe is not supported
In reply to Gabriel Krisman Bertazifor_each_plane_on_pipe() indexes bad memory when iterating over an invalid pipe. Make sure the pipe exists before trying to use it. This prevents the crash below:
root@ideacentre:~# igt-gpu-tools/tests/kms_ccs --r pipe-D-crc-sprite-planes-basic IGT-Version: 1.19-g59f0e3d182a8 (x86_64) (Linux: 4.13.0-rc6.intel-boxes+x86_64) Received signal SIGSEGV. Stack trace: #0 [fatal_sig_handler+0x185] #1 [killpg+0x40] #2 [__real_main485+0x2de] #3 [main+0x3f] #4 [__libc_start_main+0xf1] #5 [_start+0x2a] #6 [<unknown>+0x2a] Subtest pipe-D-crc-sprite-planes-basic: CRASH (0.004s)
--- tests/kms_ccs.c | 3 +++ 1 file changed, 3 insertions(+)
tests/kms_ccs.c +3 -0
@@ -503,6 +503,9 @@ igt_main data.flags =TEST_CRC ; igt_subtest_f("pipe-%s-crc-sprite-planes-basic", pipe_name) { + +igt_display_require_output_on_pipe (&data.display, data.pipe); +for_each_plane_on_pipe (&data.display, data.pipe, data.plane) {if (data.plane->type ==DRM_PLANE_TYPE_PRIMARY )continue ;
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 4/6 tests/kms_ccs: Test case where the CCS buffer was not provided
In reply to Gabriel Krisman Bertazi--- tests/kms_ccs.c | 40 +++++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 11 deletions(-)
tests/kms_ccs.c +29 -11
@@ -33,8 +33,12 @@ enum test_flags {TEST_ROTATE_180 =1 <<2 ,TEST_BAD_PIXEL_FORMAT =1 <<3 ,TEST_BAD_ROTATION_90 =1 <<4 , + TEST_NO_AUX_BUFFER = 1 << 5, }; +#define TEST_FAIL_ON_ADDFB2 \ + (TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER) +enum test_fb_flags {FB_COMPRESSED =1 <<0 , FB_HAS_PLANE = 1 << 1,
@@ -315,22 +319,30 @@ static void generate_fb(data_t *data, struct igt_fb *fb,*/ int ccs_width =ALIGN (width *4 ,32 ) /32 ;int ccs_height =ALIGN (height,16 ) /16 ; - f.pitches[1 ] =ALIGN (ccs_width *1 ,128 ); - f.modifier[1 ] = modifier; - f.offsets[1 ] = size[0 ]; - size[1 ] = f.pitches[1 ] *ALIGN (ccs_height,32 ); +int ccs_pitches =ALIGN (ccs_width *1 ,128 ); +int ccs_offsets = size[0 ]; + + size[1 ] = ccs_pitches *ALIGN (ccs_height,32 ); f.handles[0 ] =gem_create (data->drm_fd, size[0 ] + size[1 ]); - f.handles[1 ] = f.handles[0 ]; -render_ccs (data, f.handles[1 ], f.offsets[1 ], size[1 ], - height, f.pitches[1 ]); - }else + +if (!(data->flags &TEST_NO_AUX_BUFFER )) { + f.modifier[1 ] = modifier; + f.handles[1 ] = f.handles[0 ]; + f.pitches[1 ] = ccs_pitches; + f.offsets[1 ] = ccs_offsets; + +render_ccs (data, f.handles[1 ], f.offsets[1 ], size[1 ], + height, f.pitches[1 ]); + } + }else { f.handles[0 ] =gem_create (data->drm_fd, size[0 ]); + }render_fb (data, f.handles[0 ], size[0 ], fb_flags, height, f.pitches[0 ]); ret =drmIoctl (data->drm_fd,LOCAL_DRM_IOCTL_MODE_ADDFB2 , &f); -if (data->flags &TEST_BAD_PIXEL_FORMAT ) { +if (data->flags &TEST_FAIL_ON_ADDFB2 ) {igt_assert_eq (ret,-1 );igt_assert_eq (errno,EINVAL );return ;
@@ -379,7 +391,7 @@ static void try_config(data_t *data, enum test_fb_flags fb_flags) drm_mode->vdisplay, fb_flags); } -if (data->flags &TEST_BAD_PIXEL_FORMAT ) +if (data->flags &TEST_FAIL_ON_ADDFB2 )return ;igt_plane_set_position (primary,0 ,0 );
@@ -446,7 +458,8 @@ static void test_output(data_t *data) }if (data->flags &TEST_BAD_PIXEL_FORMAT || - data->flags &TEST_BAD_ROTATION_90 ) { + data->flags &TEST_BAD_ROTATION_90 || + data->flags &TEST_NO_AUX_BUFFER ) {try_config (data, fb_flags |FB_COMPRESSED ); }
@@ -515,6 +528,11 @@ igt_main } data.plane =NULL ; + + data.flags =TEST_NO_AUX_BUFFER ; + igt_subtest_f("pipe-%s-missing-ccs-buffer", pipe_name) +test_output (&data); + } igt_fixture
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 5/6 tests/kms_ccs: Test case where CCS is on a different BO
In reply to Gabriel Krisman Bertazi--- tests/kms_ccs.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
tests/kms_ccs.c +14 -3
@@ -34,10 +34,11 @@ enum test_flags {TEST_BAD_PIXEL_FORMAT =1 <<3 ,TEST_BAD_ROTATION_90 =1 <<4 ,TEST_NO_AUX_BUFFER =1 <<5 , + TEST_BAD_CCS_HANDLE = 1 << 6, };#define TEST_FAIL_ON_ADDFB2 \ - (TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER) + (TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER | TEST_BAD_CCS_HANDLE)enum test_fb_flags { FB_COMPRESSED = 1 << 0,
@@ -275,6 +276,7 @@ static void generate_fb(data_t *data, struct igt_fb *fb,unsigned int size[2 ];uint64_t modifier;int ret; +uint32_t ccs_handle;/* Use either compressed or Y-tiled to test. However, given the lack of * available bandwidth, we use linear for the primary plane when
@@ -325,10 +327,15 @@ static void generate_fb(data_t *data, struct igt_fb *fb, size[1 ] = ccs_pitches *ALIGN (ccs_height,32 ); f.handles[0 ] =gem_create (data->drm_fd, size[0 ] + size[1 ]); +if (data->flags &TEST_BAD_CCS_HANDLE ) { +/* Put the CCS buffer on a different BO. */ + ccs_handle =gem_create (data->drm_fd, size[0 ] + size[1 ]); + }else + ccs_handle = f.handles[0 ];if (!(data->flags &TEST_NO_AUX_BUFFER )) { f.modifier[1 ] = modifier; - f.handles[1 ] = f.handles[0 ]; + f.handles[1 ] = ccs_handle; f.pitches[1 ] = ccs_pitches; f.offsets[1 ] = ccs_offsets;
@@ -459,7 +466,8 @@ static void test_output(data_t *data)if (data->flags &TEST_BAD_PIXEL_FORMAT || data->flags &TEST_BAD_ROTATION_90 || - data->flags &TEST_NO_AUX_BUFFER ) { + data->flags &TEST_NO_AUX_BUFFER || + data->flags &TEST_BAD_CCS_HANDLE ) {try_config (data, fb_flags |FB_COMPRESSED ); }
@@ -533,6 +541,9 @@ igt_main igt_subtest_f("pipe-%s-missing-ccs-buffer", pipe_name)test_output (&data); + data.flags =TEST_BAD_CCS_HANDLE ; + igt_subtest_f("pipe-%s-ccs-on-another-bo", pipe_name) +test_output (&data); } igt_fixture
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 6/6 tests/kms_ccs: Test case for wrong aux buffer stride size
In reply to Gabriel Krisman BertaziTwo scenarios tested:
- unaligned stride
- Stride too small
Since v4:
- Fix SIGFPE if width <= 1024 (Arkadiusz Hiler/Ville Syrjälä)
- Add test for pitches[1]=0 (Ville Syrjälä)
--- tests/kms_ccs.c | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-)
tests/kms_ccs.c +29 -3
@@ -35,14 +35,19 @@ enum test_flags {TEST_BAD_ROTATION_90 =1 <<4 ,TEST_NO_AUX_BUFFER =1 <<5 ,TEST_BAD_CCS_HANDLE =1 <<6 , + TEST_BAD_AUX_STRIDE = 1 << 7, };#define TEST_FAIL_ON_ADDFB2 \ - (TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER | TEST_BAD_CCS_HANDLE) + (TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER | TEST_BAD_CCS_HANDLE | \ + TEST_BAD_AUX_STRIDE)enum test_fb_flags {FB_COMPRESSED =1 <<0 ,FB_HAS_PLANE =1 <<1 , +FB_MISALIGN_AUX_STRIDE =1 <<2 , +FB_SMALL_AUX_STRIDE =1 <<3 , +FB_ZERO_AUX_STRIDE =1 <<4 , }; typedef struct {
@@ -324,6 +329,17 @@ static void generate_fb(data_t *data, struct igt_fb *fb,int ccs_pitches =ALIGN (ccs_width *1 ,128 );int ccs_offsets = size[0 ]; +if (fb_flags &FB_MISALIGN_AUX_STRIDE ) { +igt_skip_on_f (width <=1024 , +"FB already has the smallest possible stride\n" ); + ccs_pitches -=64 ; + } +else if (fb_flags &FB_SMALL_AUX_STRIDE ) { +igt_skip_on_f (width <=1024 , +"FB already has the smallest possible stride\n" ); + ccs_pitches =ALIGN (ccs_width/2 ,128 ); + } + size[1 ] = ccs_pitches *ALIGN (ccs_height,32 ); f.handles[0 ] =gem_create (data->drm_fd, size[0 ] + size[1 ]);
@@ -336,11 +352,11 @@ static void generate_fb(data_t *data, struct igt_fb *fb,if (!(data->flags &TEST_NO_AUX_BUFFER )) { f.modifier[1 ] = modifier; f.handles[1 ] = ccs_handle; - f.pitches[1 ] = ccs_pitches; f.offsets[1 ] = ccs_offsets; + f.pitches[1 ] = (fb_flags &FB_ZERO_AUX_STRIDE )?0 :ccs_pitches;render_ccs (data, f.handles[1 ], f.offsets[1 ], size[1 ], - height, f.pitches[1 ]); + height, ccs_pitches); } }else { f.handles[0 ] =gem_create (data->drm_fd, size[0 ]);
@@ -471,6 +487,12 @@ static void test_output(data_t *data)try_config (data, fb_flags |FB_COMPRESSED ); } +if (data->flags &TEST_BAD_AUX_STRIDE ) { +try_config (data, fb_flags |FB_COMPRESSED |FB_MISALIGN_AUX_STRIDE ); +try_config (data, fb_flags |FB_COMPRESSED |FB_SMALL_AUX_STRIDE ); +try_config (data, fb_flags |FB_COMPRESSED |FB_ZERO_AUX_STRIDE ); + } + primary =igt_output_get_plane_type (data->output,DRM_PLANE_TYPE_PRIMARY );igt_plane_set_fb (primary,NULL );igt_plane_set_rotation (primary,IGT_ROTATION_0 );
@@ -544,6 +566,10 @@ igt_main data.flags =TEST_BAD_CCS_HANDLE ; igt_subtest_f("pipe-%s-ccs-on-another-bo", pipe_name)test_output (&data); + + data.flags =TEST_BAD_AUX_STRIDE ; + igt_subtest_f("pipe-%s-bad-aux-stride", pipe_name) +test_output (&data); } igt_fixture
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t v5 6/6] tests/kms_ccs: Test case for wrong aux buffer stride size
Quoted 9 lines · Gabriel Krisman Bertazi
Two scenarios tested:
- unaligned stride
- Stride too smallSince v4:
- Fix SIGFPE if width <= 1024 (Arkadiusz Hiler/Ville Syrjälä)
- Add test for pitches[1]=0 (Ville Syrjälä)Signed-off-by Gabriel Krisman Bertazi <[email protected]>
[snip]
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for kms_ccs improvements (rev2)
In reply to Gabriel Krisman Bertazi== Series Details ==
== Series Details ==
Series: kms_ccs improvements (rev2)
URL : https://patchwork.freedesktop.org/series/29408/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 88d6550795fad3974d77e4db2f563c5e2e8872e1 Revert "tests/kms_flip: Make flip-vs-panning-vs-hang change DSPSURF"
with latest DRM-Tip kernel build CI_DRM_3351bd5e410d0f03 drm-tip: 2017y-11m-15d-17h-22m-19s UTC integration manifest
Testlist changes:
+igt@kms_ccs@pipe-a-bad-aux-stride
+igt@kms_ccs@pipe-a-ccs-on-another-bo
+igt@kms_ccs@pipe-a-missing-ccs-buffer
+igt@kms_ccs@pipe-b-bad-aux-stride
+igt@kms_ccs@pipe-b-ccs-on-another-bo
+igt@kms_ccs@pipe-b-missing-ccs-buffer
+igt@kms_ccs@pipe-c-bad-aux-stride
+igt@kms_ccs@pipe-c-ccs-on-another-bo
+igt@kms_ccs@pipe-c-missing-ccs-buffer
+igt@kms_ccs@pipe-d-bad-aux-stride
+igt@kms_ccs@pipe-d-ccs-on-another-bo
+igt@kms_ccs@pipe-d-missing-ccs-buffer
+igt@kms_ccs@pipe-e-bad-aux-stride
+igt@kms_ccs@pipe-e-ccs-on-another-bo
+igt@kms_ccs@pipe-e-missing-ccs-buffer
+igt@kms_ccs@pipe-f-bad-aux-stride
+igt@kms_ccs@pipe-f-ccs-on-another-bo
+igt@kms_ccs@pipe-f-missing-ccs-buffer
Test gem_exec_reloc:
Subgroup basic-gtt-active:
fail -> PASS (fi-gdg-551) fdo#102582 +1
Test gem_ringfill:
Subgroup basic-default-hang:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:450s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:462s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:384s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:544s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:278s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:511s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:517s fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:500s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:434s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:268s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:433s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:440s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:430s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:481s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:466s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:488s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:533s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:478s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:535s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:586s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:455s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:543s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:561s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:498s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:465s fi-snb-2520m total:246 pass:212 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s Blacklisted hosts: fi-cfl-s total:289 pass:254 dwarn:3 dfail:0 fail:0 skip:32 time:532s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:555s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_507/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for kms_ccs improvements (rev2)
In reply to Gabriel Krisman Bertazi== Series Details ==
== Series Details ==
Series: kms_ccs improvements (rev2)
URL : https://patchwork.freedesktop.org/series/29408/
State : success
== Summary ==
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-a:
dmesg-warn -> PASS (shard-hsw) fdo#102249
Subgroup extended-modeset-hang-newfb-with-reset-render-b:
dmesg-warn -> PASS (shard-hsw) fdo#103038
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test drv_module_reload:
Subgroup basic-reload-inject:
dmesg-warn -> PASS (shard-hsw) fdo#102707
Test drv_selftest:
Subgroup mock_sanitycheck:
dmesg-warn -> PASS (shard-hsw) fdo#103719fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#103038 https://bugs.freedesktop.org/show_bug.cgi?id=103038
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#103719 https://bugs.freedesktop.org/show_bug.cgi?id=103719
shard-hsw total:2602 pass:1473 dwarn:1 dfail:1 fail:10 skip:1117 time:9558s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_507/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Gabriel Krisman Bertazi
Hi,
This is a new version of the series with the updates requested by reviewers. It fixes the KBL issue pointed out by Arkadiusz, adds a test for pitches[1] mentioned by Ville and does some other improvements.
Quoted 8 lines
It does not set the modifier to 0 for plane1 on patch 4, nor change only the handle to zero on the same patch as mentioned by Ben and Ville, respectively, because Daniel Stone made the opposite request on a prior version and, after checking the dmesg, I verified it is correctly testing the missing BO (unless I'm understanding it wrong, in which case, oops :)
Ben, Ville, Arkadiusz, Daniel, Petri, thanks for the review.
Hey,
Can we get some eye balls on this series? It's been spinning for a while and the first 4 patches are well-reviewed bug fixes already :)
Signature · 5 lines
Gabriel Krisman Bertazi _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx