Documentation: dt: rtc-imxdi: imx53-rtc is not compatible
Subsystems (3)
PATCH 1/1 Documentation: dt: rtc-imxdi: imx53-rtc is not compatible
From: Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>
rtc-imxdi driver is not compatible with imx53-rtc like the example suggested.
Only the raw timestamp register offsets match by accident, which has the effect, that during startup/shutdown system clock syncronization with rtc seems to work for imx53, too.
However hwclock and rtctest, will not work as expected on imx53. To avoid future reverts like [1], we should adjust the documentation.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/542312.html
---
To: Alessandro Zummo <[email protected]>
To: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Mark Rutland <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: [email protected] (open list:REAL TIME CLOCK (RTC) SUBSYSTEM)
Cc: [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: [email protected] (open list)
Cc: Fabio Estevam <[email protected]>
Cc: Juergen Borleis <[email protected]>
Cc: Noel Vellemans <[email protected]>
Cc: Shawn Guo <[email protected]>
--- Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/rtc/imxdi-rtc.txt +2 -2
@@ -1,6 +1,6 @@ * i.MX25 Real Time Clock controller -This binding supports the following chips: i.MX25, i.MX53 +This binding supports the following chips: i.MX25 Required properties: - compatible: should be: "fsl,imx25-rtc"
@@ -14,7 +14,7 @@ Optional properties: Example: rtc@80056000 { - compatible = "fsl,imx53-rtc", "fsl,imx25-rtc"; + compatible = "fsl,imx25-rtc"; reg = <0x80056000 2000>; interrupts = <29 56>; };
Signature · 7 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
The following patch was already sent by Fabio:
http://patchwork.ozlabs.org/patch/838173/
Quoted 56 lines · On 16/11/2017 at 10:34:25 +0100, linux-kernel-dev-QonKdJ6Bx35Wk0Htik3J/w@public…
From: Patrick Bruenn <p.bruenn-QonKdJ6Bx35Wk0Htik3J/[email protected]>
rtc-imxdi driver is not compatible with imx53-rtc like the example suggested.
Only the raw timestamp register offsets match by accident, which has the effect, that during startup/shutdown system clock syncronization with rtc seems to work for imx53, too.
However hwclock and rtctest, will not work as expected on imx53. To avoid future reverts like [1], we should adjust the documentation.[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/542312.html
---
To: Alessandro Zummo <[email protected]>
To: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Mark Rutland <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: [email protected] (open list:REAL TIME CLOCK (RTC) SUBSYSTEM)
Cc: [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: [email protected] (open list)
Cc: Fabio Estevam <[email protected]>
Cc: Juergen Borleis <[email protected]>
Cc: Noel Vellemans <[email protected]>
Cc: Shawn Guo <[email protected]>--- Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/rtc/imxdi-rtc.txt +2
-2@@ -1,6 +1,6 @@ * i.MX25 Real Time Clock controller -This binding supports the following chips: i.MX25, i.MX53 +This binding supports the following chips: i.MX25 Required properties: - compatible: should be: "fsl,imx25-rtc"@@ -14,7 +14,7 @@ Optional properties: Example: rtc@80056000 { - compatible = "fsl,imx53-rtc", "fsl,imx25-rtc"; + compatible = "fsl,imx25-rtc"; reg = <0x80056000 2000>; interrupts = <29 56>; };Signature · 1 line
2.11.0
Signature · 7 lines
Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html