trace-cmd: Fix err msg for record w/o the -e option
PATCH 1/1 trace-cmd: Fix err msg for record w/o the -e option
Currently, running just trace-cmd record without telling which events have to be traced (-e) nor which tracer to use (-p), trace-cmd dies with the message:
No instances reference??
Which might not be helpful to new users of the tool. This small patch removes an early check in trace_record() allowing, in the same case, the execution to continue a few more statements and fail more gracefully in the function check_doing_something() with the following message:
no event or plugin was specified... aborting
Signed-off-by Vladislav Valtchev (VMware) <[email protected]>
--- trace-record.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
trace-record.c +2 -4
@@ -4722,11 +4722,9 @@ void trace_record (int argc, char **argv)* If top_instance doesn't have any plugins or events, then * remove it from being processed. */ -if (!extract && !__check_doing_something (&top_instance)) { -if (!buffer_instances) -die ("No instances reference??" ); +if (!extract && !__check_doing_something (&top_instance)) first_instance = buffer_instances; - }else +else topt =1 ;update_first_instance (instance, topt);
Signature · 1 line
2.14.1