Skip to contentSkip to conversation

staging: comedi: add missing MODULE_DESCRIPTION/LICENSE

PATCH Superseded Jesse Chan 4 participants 6 messages Nov 20, 2017 – Nov 22, 2017 Staging

lore
Share & tools
lore

Jesse Chan

author
#0 lore raw

PATCH 1/1 staging: comedi: add missing MODULE_DESCRIPTION/LICENSE

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/ni_atmio.c +3 -0
index 2d62a8c57332..b61d56367773 100644
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
 	.detach		= ni_atmio_detach,
 };
 module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");
Signature · 1 line
2.14.1
author
#2 lore raw

PATCH v2 1/1 staging: comedi: add missing MODULE_DESCRIPTION/LICENSE

In reply to Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see include/linux/module.h for more information

This adds the license as "GPL", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>
---
 drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/ni_atmio.c +3 -0
index 2d62a8c57332..b61d56367773 100644
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
 	.detach		= ni_atmio_detach,
 };
 module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");
Signature · 1 line
2.14.1
Reviewed-by on v2 1/1
#3 lore raw
Quoted 20 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see include/linux/module.h for more information

This adds the license as "GPL", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>
---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/ni_atmio.c +0 -0
index 2d62a8c57332..b61d56367773 100644

drivers/staging/comedi/drivers/ni_atmio.c static struct comedi_driver ni_atmio_driver = { · line 366

Quoted 6 lines
drivers/staging/comedi/drivers/ni_atmio.c +3 -0
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
  	.detach		= ni_atmio_detach,
  };
  module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");

Thanks! I wonder how I managed to miss out this driver in commit 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI modules")?

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#4 lore raw
Quoted 30 lines · Ian Abbott
Quoted 20 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see include/linux/module.h for more information

This adds the license as "GPL", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>

---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++

  1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/ni_atmio.c +0 -0
index 2d62a8c57332..b61d56367773 100644

drivers/staging/comedi/drivers/ni_atmio.c static struct comedi_driver ni_atmio_driver = { · line 366

Quoted 6 lines
drivers/staging/comedi/drivers/ni_atmio.c +3 -0
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
       .detach        = ni_atmio_detach,
   };
   module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");

Thanks!  I wonder how I managed to miss out this driver in commit 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI modules")?

Quoted 1 line
Reviewed-by Ian Abbott <[email protected]>

Despite my above comment, we should probably give precedence to Matthew Giassa's patch for the same issue, since it was sent earlier.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#5 lore raw
Quoted 38 lines · Ian Abbott
Quoted 30 lines · Ian Abbott
Quoted 20 lines · Jesse Chan

This change resolves a new compile-time warning
when built as a loadable module:

WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see include/linux/module.h for more information

This adds the license as "GPL", which matches the header of the file.

MODULE_DESCRIPTION is also added.

Signed-off-by Jesse Chan <[email protected]>

---
  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++

  1 file changed, 3 insertions(+)
drivers/staging/comedi/drivers/ni_atmio.c +0 -0
index 2d62a8c57332..b61d56367773 100644

drivers/staging/comedi/drivers/ni_atmio.c static struct comedi_driver ni_atmio_driver = { · line 366

Quoted 6 lines
drivers/staging/comedi/drivers/ni_atmio.c +3 -0
@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
       .detach        = ni_atmio_detach,
   };
   module_comedi_driver(ni_atmio_driver);
+
+MODULE_DESCRIPTION("Comedi low-level driver");
+MODULE_LICENSE("GPL");

Thanks!  I wonder how I managed to miss out this driver in commit 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI modules")?

Quoted 1 line
Reviewed-by Ian Abbott <[email protected]>

Despite my above comment, we should probably give precedence to Matthew Giassa's patch for the same issue, since it was sent earlier.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
Signature · 4 lines
Thanks. Also, this one should probably include the MODULE_AUTHOR macro
as well.

Cheers!