proc: simpler /proc/vmcore cleanup

PATCH Applied Alexey Dobriyan 1 participant 1 message Nov 21, 2017

Subsystems (2)

Proc filesystem Kdump

lore

Share & tools

lore

Alexey Dobriyan

author

2017-11-21 19:11 UTC #0 lore raw

PATCH 1/1 proc: simpler /proc/vmcore cleanup

Iterators aren't necessary as you can just grab the first entry and delete it until no entries left.

Signed-off-by Alexey Dobriyan <[email protected]>

---

 fs/proc/vmcore.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

fs/proc/vmcore.c +2 -4

@@ -1178,18 +1178,16 @@ fs_initcall(vmcore_init);
 /* Cleanup function for vmcore module. */
 void vmcore_cleanup(void)
 {
-	struct list_head *pos, *next;
-
 	if (proc_vmcore) {
 		proc_remove(proc_vmcore);
 		proc_vmcore = NULL;
 	}
 
 	/* clear the vmcore list. */
-	list_for_each_safe(pos, next, &vmcore_list) {
+	while (!list_empty(&vmcore_list)) {
 		struct vmcore *m;
 
-		m = list_entry(pos, struct vmcore, list);
+		m = list_first_entry(&vmcore_list, struct vmcore, list);
 		list_del(&m->list);
 		kfree(m);
 	}