MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry
PATCH 1/2 MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry
Make sure Thunderbolt maintainers get to see patches that touch documentation of the Thunderbolt driver as well.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -13471,6 +13471,7 @@ M: Mika Westerberg <[email protected]> M: Yehezkel Bernat <[email protected]> T: git git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git S: Maintained +F: Documentation/admin-guide/thunderbolt.rst F: drivers/thunderbolt/ F: include/linux/thunderbolt.h
Signature · 1 line
2.15.0
PATCH 2/2 thunderbolt: Mask ring interrupt properly when polling starts
When ring enters polling mode we are expected to mask the ring interrupt before the callback is called. However, the current code actually unmasks it probably because of a copy-paste mistake.
Mask the interrupt properly from now on.
--- drivers/thunderbolt/nhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/nhi.c +1 -1
@@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring *ring)return ;if (ring->start_poll) { -__ring_interrupt_mask (ring, false); +__ring_interrupt_mask (ring, true); ring->start_poll (ring->poll_data); }else {schedule_work (&ring->work);
Signature · 1 line
2.15.0
Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts
Quoted 24 lines · Mika Westerberg
When ring enters polling mode we are expected to mask the ring interrupt
before the callback is called. However, the current code actually unmasks it probably because of a copy-paste mistake.Mask the interrupt properly from now on.
Fixes 4ffe722eefcb ("thunderbolt: Add polling mode for rings")Signed-off-by Mika Westerberg <[email protected]>---
drivers/thunderbolt/nhi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/thunderbolt/nhi.c +0
-0@@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring *ring) return;
if (ring->start_poll) {drivers/thunderbolt/nhi.c +1
-1-__ring_interrupt_mask (ring, false); +__ring_interrupt_mask (ring, true);
Quoted 3 lines
ring->start_poll(ring->poll_data); } else {schedule_work(&ring->work);
Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts
Quoted 14 lines · Yehezkel
Quoted 13 lines · Mika Westerberg
When ring enters polling mode we are expected to mask the ring interrupt
before the callback is called. However, the current code actually unmasks it probably because of a copy-paste mistake.Mask the interrupt properly from now on.
Fixes 4ffe722eefcb ("thunderbolt: Add polling mode for rings")Signed-off-by Mika Westerberg <[email protected]>---
drivers/thunderbolt/nhi.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 11 lines
drivers/thunderbolt/nhi.c +0
-0@@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring *ring) return;
if (ring->start_poll) {drivers/thunderbolt/nhi.c +1
-1-__ring_interrupt_mask (ring, false); +__ring_interrupt_mask (ring, true);Quoted 3 lines
ring->start_poll(ring->poll_data); } else {schedule_work(&ring->work);Acked-by Yehezkel Bernat <[email protected]>
Applied with Yehezkel's ACK.
Mika Westerberg
AppliedQuoted 4 lines · Mika Westerberg
Make sure Thunderbolt maintainers get to see patches that touch documentation of the Thunderbolt driver as well.
Signed-off-by Mika Westerberg <[email protected]>
Applied.