staging: xgifb: remove unused macro XGIPART3

PATCH In review Joshua Abraham 2 participants 3 messages Nov 30, 2017 Staging

lore

Share & tools

lore

Joshua Abraham

author

2017-11-30 02:53 UTC #0 lore raw

PATCH 1/1 staging: xgifb: remove unused macro XGIPART3

Signed-off-by Joshua Abraham <[email protected]>

This patch removes the unused macro XGIPART3.

---
 drivers/staging/xgifb/XGI_main.h | 1 -
 1 file changed, 1 deletion(-)

drivers/staging/xgifb/XGI_main.h +0 -1

index a3af1cbbf8ee..5f55d0a39bc1 100644
@@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
 #define XGIDACD			  (xgifb_info->dev_info.P3c9)
 #define XGIPART1		  (xgifb_info->dev_info.Part1Port)
 #define XGIPART2		  (xgifb_info->dev_info.Part2Port)
-#define XGIPART3		  (xgifb_info->dev_info.Part3Port)
 #define XGIPART4		  (xgifb_info->dev_info.Part4Port)
 #define XGIPART5		  (xgifb_info->dev_info.Part5Port)
 #define XGIDAC2A                  XGIPART5

Signature · 1 line

2.15.0

Dan Carpenter

2017-11-30 05:56 UTC #1 lore raw

Quoted 4 lines · Joshua Abraham

Signed-off-by Joshua Abraham <[email protected]>
This patch removes the unused macro XGIPART3.

The Signed-off-by line goes after the changelog.

drivers/staging/xgifb/XGI_main.h MODULE_DEVICE_TABLE(pci, xgifb_pci_table); · line 28

Quoted 13 lines

---
 drivers/staging/xgifb/XGI_main.h | 1 -
 1 file changed, 1 deletion(-)

drivers/staging/xgifb/XGI_main.h +0 -1

index a3af1cbbf8ee..5f55d0a39bc1 100644
@@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
 #define XGIDACD			  (xgifb_info->dev_info.P3c9)
 #define XGIPART1		  (xgifb_info->dev_info.Part1Port)
 #define XGIPART2		  (xgifb_info->dev_info.Part2Port)
-#define XGIPART3		  (xgifb_info->dev_info.Part3Port)

That define isn't hurting anyone.

drivers/staging/xgifb/XGI_main.h MODULE_DEVICE_TABLE(pci, xgifb_pci_table); · line 29

Quoted 2 lines

drivers/staging/xgifb/XGI_main.h +0 -0

 #define XGIPART4		  (xgifb_info->dev_info.Part4Port)
 #define XGIPART5		  (xgifb_info->dev_info.Part5Port)

Actually these should all be deleted because they mean you have to have a xgifb_info variable and they hurt readability by hiding stuff behind a define. It would be better to remove them all than to just remove one from the middle. That's a more complicated patch, but it's a useful patch.

regards,
dan carpenter

Josh Abraham

author

2017-11-30 12:52 UTC #2 lore raw

Quoted 27 lines · Dan Carpenter

Quoted 4 lines · Joshua Abraham
Signed-off-by Joshua Abraham <[email protected]>
This patch removes the unused macro XGIPART3.
The Signed-off-by line goes after the changelog.
drivers/staging/xgifb/XGI_main.h MODULE_DEVICE_TABLE(pci, xgifb_pci_table); · line 28
Quoted 13 lines
---
 drivers/staging/xgifb/XGI_main.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/xgifb/XGI_main.h +0 -1
index a3af1cbbf8ee..5f55d0a39bc1 100644
@@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
 #define XGIDACD			  (xgifb_info->dev_info.P3c9)
 #define XGIPART1		  (xgifb_info->dev_info.Part1Port)
 #define XGIPART2		  (xgifb_info->dev_info.Part2Port)
-#define XGIPART3		  (xgifb_info->dev_info.Part3Port)
That define isn't hurting anyone.
drivers/staging/xgifb/XGI_main.h MODULE_DEVICE_TABLE(pci, xgifb_pci_table); · line 29
Quoted 2 lines
drivers/staging/xgifb/XGI_main.h +0 -0
 #define XGIPART4		  (xgifb_info->dev_info.Part4Port)
 #define XGIPART5		  (xgifb_info->dev_info.Part5Port)

Quoted 9 lines

Actually these should all be deleted because they mean you have to have a xgifb_info variable and they hurt readability by hiding stuff behind a define. It would be better to remove them all than to just remove one from the middle. That's a more complicated patch, but it's a useful patch.
regards,
dan carpenter

Great point. I will work on that and get the patch out!

-Josh