pci: dwc: pci-dra7xx: Make shutdown handler static
PATCH 1/1 pci: dwc: pci-dra7xx: Make shutdown handler static
Declare dra7xx_pcie_shutdown() as a static function as its not used elsewhere.
--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/dwc/pci-dra7xx.c +1 -1
@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);
Signature · 1 line
2.15.0
Quoted 2 lines · Vignesh R
Declare
dra7xx_pcie_shutdown()as a static function as its not used elsewhere.
Seems like the below version that had static version was not taken:
https://patchwork.kernel.org/patch/10052579/
So for this patch:
Quoted 20 lines
Signed-off-by Vignesh R <[email protected]>--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/dwc/pci-dra7xx.c +1
-1@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);
Quoted 9 lines · Keerthy
Quoted 2 lines · Vignesh R
Declare
dra7xx_pcie_shutdown()as a static function as its not used elsewhere.Seems like the below version that had static version was not taken:
It looks like I can drop the patch above then - let me know if that's ok.
Thanks,
Lorenzo
Quoted 24 lines
So for this patch:
Reviewed-by Keerthy <[email protected]>Quoted 20 lines
Signed-off-by Vignesh R <[email protected]>--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/dwc/pci-dra7xx.c +1
-1@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);
Quoted 7 lines · Lorenzo Pieralisi
Quoted 6 lines · Keerthy
Quoted 2 lines · Vignesh R
Declare
dra7xx_pcie_shutdown()as a static function as its not used elsewhere.
Quoted 6 lines
Quoted 3 lines
Seems like the below version that had static version was not taken:
It looks like I can drop the patch above then - let me know if that's ok.
I would appreciate some feedback; I assume that dropping the patch above and applying the patch in $SUBJECT is what you expect, if there is a problem with that please manifest yourselves.
Lorenzo
Quoted 27 lines
Thanks,
LorenzoQuoted 24 lines
So for this patch:
Reviewed-by Keerthy <[email protected]>Quoted 20 lines
Signed-off-by Vignesh R <[email protected]>--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/dwc/pci-dra7xx.c +1
-1@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);
Quoted 10 lines · Lorenzo Pieralisi
Quoted 9 lines · Lorenzo Pieralisi
Quoted 8 lines · Keerthy
Quoted 2 lines · Vignesh R
Declare
dra7xx_pcie_shutdown()as a static function as its not used elsewhere.Seems like the below version that had static version was not taken:
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
It looks like I can drop the patch above then - let me know if that's ok.
I would appreciate some feedback; I assume that dropping the patch above and applying the patch in $SUBJECT is what you expect, if there is a problem with that please manifest yourselves.
Applying this patch is fine. Thanks.
Quoted 30 lines
Lorenzo
Quoted 27 lines
Thanks,
LorenzoQuoted 24 lines
So for this patch:
Reviewed-by Keerthy <[email protected]>Quoted 20 lines
Signed-off-by Vignesh R <[email protected]>--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/dwc/pci-dra7xx.c +1
-1@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);
Lorenzo Pieralisi
AppliedQuoted 7 lines · Vignesh R
Declare
dra7xx_pcie_shutdown()as a static function as its not used elsewhere.Signed-off-by Vignesh R <[email protected]>--- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/dwc for v4.16.
Thanks,
Lorenzo
Quoted 16 lines
drivers/pci/dwc/pci-dra7xx.c +1
-1@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev) }#endif -void dra7xx_pcie_shutdown (struct platform_device *pdev) +static void dra7xx_pcie_shutdown (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct dra7xx_pcie *dra7xx =dev_get_drvdata (dev);Signature · 1 line
2.15.0