Skip to contentSkip to conversation

workqueue/hotplug: remove the workaround in rebind_workers()

PATCH Applied Lai Jiangshan 2 participants 2 messages Dec 1, 2017 – Dec 4, 2017 Workqueue

lore
Share & tools
lore

Lai Jiangshan

author reviewer
#0 lore raw

PATCH 1/1 workqueue/hotplug: remove the workaround in rebind_workers()

Sine the cpu/hotplug refactor is done, the hotplug callbacks are called properly. So the workaround is useless.

---
 kernel/workqueue.c | 10 ----------
 1 file changed, 10 deletions(-)
kernel/workqueue.c +0 -10
index 5c99beb8577d..528321bc45eb 100644
@@ -4588,16 +4588,6 @@ static void rebind_workers(struct worker_pool *pool)
 
 	spin_lock_irq(&pool->lock);
 
-	/*
-	 * XXX: CPU hotplug notifiers are weird and can call DOWN_FAILED
-	 * w/o preceding DOWN_PREPARE.  Work around it.  CPU hotplug is
-	 * being reworked and this can go away in time.
-	 */
-	if (!(pool->flags & POOL_DISASSOCIATED)) {
-		spin_unlock_irq(&pool->lock);
-		return;
-	}
-
 	pool->flags &= ~POOL_DISASSOCIATED;
 
 	for_each_pool_worker(worker, pool) {
Signature · 1 line
2.13.6 (Apple Git-96)
maintainer Applied
#1 lore raw
Quoted 5 lines · Lai Jiangshan

Sine the cpu/hotplug refactor is done, the hotplug callbacks are called properly. So the workaround is useless.

Applied to wq/for-4.16 w/ desc updates.

Thanks.

Signature · 1 line
tejun