USB: serial: Avoid goto in bulk callbacks
Subsystems (2)
Refactor bulk callback functions to make use of goto pointless.
Signed-off-by Ladislav Michl <[email protected]>
--- drivers/usb/serial/generic.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/usb/serial/generic.c +5 -7
@@ -389,6 +389,9 @@ void usb_serial_generic_read_bulk_callback(struct urb *urb) urb->actual_length);switch (status) {case 0 : +usb_serial_debug_data (&port->dev, __func__, + urb->actual_length, data); + port->serial->type->process_read_urb (urb);break ;case -ENOENT :case -ECONNRESET :
@@ -403,13 +406,9 @@ void usb_serial_generic_read_bulk_callback(struct urb *urb)default :dev_dbg (&port->dev,"%s - nonzero urb status: %d\n" , __func__, status); - goto resubmit; +break ; } -usb_serial_debug_data (&port->dev, __func__, urb->actual_length, data); - port->serial->type->process_read_urb (urb); - -resubmit:/* Throttle the device if requested by tty */ spin_lock_irqsave (&port->lock, flags); port->throttled = port->throttle_req;
@@ -454,10 +453,9 @@ void usb_serial_generic_write_bulk_callback(struct urb *urb)default :dev_err_console (port,"%s - nonzero urb status: %d\n" , __func__, status); - goto resubmit; +break ; } -resubmit:usb_serial_generic_write_start (port,GFP_ATOMIC );usb_serial_port_softint (port); }