Skip to contentSkip to conversation

arm: imx: add tzic interrupt controller for imx53

PATCH New linux-kernel-dev at beckhoff.com 3 participants 3 messages Dec 11, 2017 – Dec 17, 2017

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

linux-kernel-dev at beckhoff.com

author
#0 lore raw

PATCH 1/1 arm: imx: add tzic interrupt controller for imx53

From: Patrick Bruenn <[email protected]>

Since commit 999a78d5cf00 ("scripts/dtc: Update to upstream version v1.4.5-3-gb1a60033c110")
dtc warns about:
arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/serial at 53fc0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/ccm at 53fd4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/gpio at 53fe4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/sdma at 63fb0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/ethernet at 63fec000

Fix this by adding a node for the tzic interrupt controller. Copied from "<Linux>/arch/arm/boot/dts/imx53.dts"

Signed-off-by Patrick Bruenn <[email protected]>

---

 arch/arm/dts/imx53.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/imx53.dtsi +8 -0
index 1bdf0668a5..f68e88585e 100644
@@ -23,10 +23,18 @@
 		serial1 = &uart2;
 	};
 
+	tzic: tz-interrupt-controller at fffc000 {
+		compatible = "fsl,imx53-tzic", "fsl,tzic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0x0fffc000 0x4000>;
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "simple-bus";
+		interrupt-parent = <&tzic>;
 		ranges;
 
 		aips at 50000000 { /* AIPS1 */
Signature · 1 line
2.11.0
reviewer
#1 lore raw

PATCH 1/1 arm: imx: add tzic interrupt controller for imx53

Quoted 10 lines · On Mon, Dec 11, 2017 at 10:09 AM, <[email protected]> wrote:

From: Patrick Bruenn <[email protected]>

Since commit 999a78d5cf00 ("scripts/dtc: Update to upstream version v1.4.5-3-gb1a60033c110")
dtc warns about:
arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/serial at 53fc0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/ccm at 53fd4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/gpio at 53fe4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/sdma at 63fb0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/ethernet at 63fec000

Quoted 4 lines

Fix this by adding a node for the tzic interrupt controller. Copied from "<Linux>/arch/arm/boot/dts/imx53.dts"

Signed-off-by Patrick Bruenn <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
#2 lore raw

PATCH 1/1 arm: imx: add tzic interrupt controller for imx53

In reply to linux-kernel-dev at beckhoff.com
Quoted 33 lines · linux-kernel-dev at beckhoff.com

From: Patrick Bruenn <[email protected]>

Since commit 999a78d5cf00 ("scripts/dtc: Update to upstream version v1.4.5-3-gb1a60033c110")
dtc warns about:
arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/serial at 53fc0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/ccm at 53fd4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 50000000/gpio at 53fe4000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/sdma at 63fb0000 arch/arm/dts/imx53-cx9020.dtb: Warning (interrupts_property): Missing interrupt-parent for /soc/aips at 60000000/ethernet at 63fec000

Fix this by adding a node for the tzic interrupt controller. Copied from "<Linux>/arch/arm/boot/dts/imx53.dts"

Signed-off-by Patrick Bruenn <[email protected]>

---

 arch/arm/dts/imx53.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/imx53.dtsi +5 -0
index 1bdf0668a5..f68e88585e 100644
@@ -23,10 +23,18 @@
 		serial1 = &uart2;
 	};
 
+	tzic: tz-interrupt-controller at fffc000 {
+		compatible = "fsl,imx53-tzic", "fsl,tzic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0x0fffc000 0x4000>;

arch/arm/dts/imx53.dtsi line 40

Quoted 10 lines
arch/arm/dts/imx53.dtsi +3 -0
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "simple-bus";
+		interrupt-parent = <&tzic>;
 		ranges;
 
 		aips at 50000000 { /* AIPS1 */

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================