Skip to contentSkip to conversation

tests/psr: Dump PSR debugfs contents if PSR entry times out.

PATCH In review Dhinakaran Pandiyan 4 participants 7 messages Dec 12, 2017 – Dec 20, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/psr: Dump PSR debugfs contents if PSR entry times out.

(kms_psr_sink_crc:1717) CRITICAL: Failed assertion:
wait_psr_entry(&data)
(kms_psr_sink_crc:1717) CRITICAL: Last errno: 25, Inappropriate ioctl for device

isn't very useful, the Source_OK field would have indicated that the requirements to enable PSR weren't met in this case.

---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr_sink_crc.c +1 -0
index 831368b2..c586d6e1 100644
@@ -223,6 +223,7 @@ static bool wait_psr_entry(data_t *data)
 			return true;
 		sleep(1);
 	}
+	igt_debugfs_dump(data->drm_fd, "i915_edp_psr_status");
 	return false;
 }
 
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for tests/psr: Dump PSR debugfs contents if PSR entry times out.

== Series Details ==

== Series Details ==

Series: tests/psr: Dump PSR debugfs contents if PSR entry times out.
URL : https://patchwork.freedesktop.org/series/35254/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build 74407418720ff7a9de7caabec05d4c3afe9a5c51 igt/kms_flip: Allow very large bo to fail pageflips with E2BIG

with latest DRM-Tip kernel build CI_DRM_3503
8874c0f95698 drm-tip: 2017y-12m-12d-21h-34m-33s UTC integration manifest

No testlist changes.

Test gem_exec_reloc:

        Subgroup basic-cpu-noreloc:
                pass       -> INCOMPLETE (fi-byt-j1900)
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:440s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:447s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:381s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:513s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:281s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:507s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:507s
fi-byt-j1900     total:80   pass:70   dwarn:0   dfail:0   fail:0   skip:9  
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:477s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:268s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:542s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:372s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:263s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:394s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:483s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:447s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:481s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:472s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:527s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:589s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:450s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:541s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:562s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:519s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:492s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:452s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:547s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:418s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:603s
fi-cnl-y         total:252  pass:226  dwarn:0   dfail:0   fail:0   skip:25 
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:497s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_660/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Acked-by on v1 1/1
#2 lore raw
In reply to Dhinakaran Pandiyan
Quoted 7 lines · Dhinakaran Pandiyan

(kms_psr_sink_crc:1717) CRITICAL: Failed assertion:
wait_psr_entry(&data)
(kms_psr_sink_crc:1717) CRITICAL: Last errno: 25, Inappropriate ioctl for device

isn't very useful, the Source_OK field would have indicated that the requirements to enable PSR weren't met in this case.

Is this still the case with the source_ok getting killed?

Quoted 12 lines
---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr_sink_crc.c +0 -0
index 831368b2..c586d6e1 100644

tests/kms_psr_sink_crc.c static bool wait_psr_entry(data_t *data) · line 226

Quoted 4 lines
tests/kms_psr_sink_crc.c +1 -0
@@ -223,6 +223,7 @@ static bool wait_psr_entry(data_t *data)
 			return true;
 		sleep(1);
 	}
+	igt_debugfs_dump(data->drm_fd, "i915_edp_psr_status");

anyways seems a good thing to have...
so, with the commit message modified feel free to use:

Quoted 6 lines
tests/kms_psr_sink_crc.c +0 -0
 	return false;
 }
 
Signature · 1 line
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 10 lines · PST Rodrigo Vivi
Quoted 7 lines · Dhinakaran Pandiyan

(kms_psr_sink_crc:1717) CRITICAL: Failed assertion:
wait_psr_entry(&data)
(kms_psr_sink_crc:1717) CRITICAL: Last errno: 25, Inappropriate ioctl for device

isn't very useful, the Source_OK field would have indicated that the requirements to enable PSR weren't met in this case.

Is this still the case with the source_ok getting killed?

"Enabled:" will do the same job, conveying whether an attempt to enable PSR was made.

Quoted 18 lines
Quoted 18 lines

---

 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr_sink_crc.c +0 -0
index 831368b2..c586d6e1 100644
@@ -223,6 +223,7 @@ static bool wait_psr_entry(data_t *data)
 
 			return true;
 
 		sleep(1);
 
Quoted 9 lines

tests/kms_psr_sink_crc.c static bool wait_psr_entry(data_t *data) · line 226

Quoted 3 lines
tests/kms_psr_sink_crc.c +1 -0
 	}
 
+	igt_debugfs_dump(data->drm_fd, "i915_edp_psr_status");

anyways seems a good thing to have...
so, with the commit message modified feel free to use:

Thanks!

Quoted 8 lines
Quoted 3 lines

return false;

}

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

PATCH v2 1/1 tests/psr: Dump PSR debugfs contents if PSR entry times out.

In reply to Dhinakaran Pandiyan

(kms_psr_sink_crc:1717) CRITICAL: Failed assertion:
wait_psr_entry(&data)
(kms_psr_sink_crc:1717) CRITICAL: Last errno: 25, Inappropriate ioctl for device

isn't very useful, the "Enabled" field would have indicated that the requirements to enable PSR weren't met in this case.

v2: s/Source_OK/Enabled in commit message.(Rodrigo)

---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_psr_sink_crc.c +1 -0
index 831368b2..c586d6e1 100644
@@ -223,6 +223,7 @@ static bool wait_psr_entry(data_t *data)
 			return true;
 		sleep(1);
 	}
+	igt_debugfs_dump(data->drm_fd, "i915_edp_psr_status");
 	return false;
 }
 
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

✓ Fi.CI.BAT: success for tests/psr: Dump PSR debugfs contents if PSR entry times out. (rev2)

In reply to Dhinakaran Pandiyan
== Series Details ==

== Series Details ==

Series: tests/psr: Dump PSR debugfs contents if PSR entry times out. (rev2)
URL : https://patchwork.freedesktop.org/series/35254/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_tracking: Access via GGTT is not guaranteed to be tracked

with latest DRM-Tip kernel build CI_DRM_3551
e27ee23e076d drm-tip: 2017y-12m-19d-23h-07m-26s UTC integration manifest

No testlist changes.

Test kms_psr_sink_crc:

        Subgroup psr_basic:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#101144

fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:436s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:383s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:503s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:496s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:506s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:479s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:468s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:268s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:541s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:411s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:412s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:476s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:435s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:479s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:527s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:468s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:525s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:586s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:446s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:529s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:557s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:498s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:493s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:448s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:555s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:421s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:593s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:625s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_709/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Fi.CI.IGT: success for tests/psr: Dump PSR debugfs contents if PSR entry times out. (rev2)

In reply to Dhinakaran Pandiyan
== Series Details ==

== Series Details ==

Series: tests/psr: Dump PSR debugfs contents if PSR entry times out. (rev2)
URL : https://patchwork.freedesktop.org/series/35254/
State : success

== Summary ==

Test gem_tiled_swapping:

        Subgroup non-threaded:
                pass       -> INCOMPLETE (shard-hsw) fdo#104218
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-pri-indfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623 +2

fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623

shard-hsw        total:2689 pass:1523 dwarn:1   dfail:0   fail:10  skip:1154 time:8933s
shard-snb        total:2712 pass:1309 dwarn:1   dfail:0   fail:11  skip:1391 time:8027s
Blacklisted hosts:
shard-apl        total:2690 pass:1664 dwarn:1   dfail:0   fail:23  skip:1001 time:13314s
shard-kbl        total:2712 pass:1807 dwarn:1   dfail:0   fail:24  skip:880 time:11110s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_709/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx