Skip to contentSkip to conversation

ANDROID: binder: make binder_alloc_new_buf_locked static and indent its arguments

PATCH New Xongwei.Song 1 participant 1 message Dec 14, 2017 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ANDROID: binder: make binder_alloc_new_buf_locked static and indent its arguments

From: Xiongwei Song <[email protected]>

The function binder_alloc_new_buf_locked() is only used in this file, so make it static. Also clean up sparse warning:

drivers/android/binder_alloc.c:330:23: warning: no previous prototype for ‘binder_alloc_new_buf_locked’ [-Wmissing-prototypes]

In addition, the line of the function name exceeds 80 characters when add static for this function, hence indent its arguments anew.

---
 drivers/android/binder_alloc.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/android/binder_alloc.c +6 -5
index 0dba2308125c..a2e1904cde06 100644
@@ -327,11 +327,12 @@ static int binder_update_page_range(struct binder_alloc *alloc, int allocate,
 	return vma ? -ENOMEM : -ESRCH;
 }
 
-struct binder_buffer *binder_alloc_new_buf_locked(struct binder_alloc *alloc,
-						  size_t data_size,
-						  size_t offsets_size,
-						  size_t extra_buffers_size,
-						  int is_async)
+static struct binder_buffer *binder_alloc_new_buf_locked(
+				struct binder_alloc *alloc,
+				size_t data_size,
+				size_t offsets_size,
+				size_t extra_buffers_size,
+				int is_async)
 {
 	struct rb_node *n = alloc->free_buffers.rb_node;
 	struct binder_buffer *buffer;
Signature · 1 line
2.15.1