4.4.106-stable review
Subsystems (3)
Greg Kroah-Hartman
maintainerPATCH 2/105 can: kvaser_usb: free buf in error paths
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jimmy Assarsson <[email protected]>
commit 435019b48033138581a6171093b181fc6b4d3d30 upstream.
The allocated buffer was not freed if usb_submit_urb() failed.
--- drivers/net/can/usb/kvaser_usb.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/usb/kvaser_usb.c +2 -0
@@ -809,6 +809,7 @@ static int kvaser_usb_simple_msg_async(sif (err) {netdev_err (netdev,"Error transmitting URB\n" );usb_unanchor_urb (urb); +kfree (buf);usb_free_urb (urb);return err; }
@@ -1767,6 +1768,7 @@ static netdev_tx_t kvaser_usb_start_xmitspin_unlock_irqrestore (&priv->tx_contexts_lock, flags);usb_unanchor_urb (urb); +kfree (buf); stats->tx_dropped++;
Greg Kroah-Hartman
maintainerPATCH 4/105 can: kvaser_usb: ratelimit errors if incomplete messages are received
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jimmy Assarsson <[email protected]>
commit 8bd13bd522ff7dfa0eb371921aeb417155f7a3be upstream.
Avoid flooding the kernel log with "Formate error", if incomplete message are received.
--- drivers/net/can/usb/kvaser_usb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/can/usb/kvaser_usb.c +4 -3
@@ -603,8 +603,8 @@ static int kvaser_usb_wait_msg(const str }if (pos + tmp->len > actual_len) { -dev_err (dev->udev->dev.parent, -"Format error\n" ); +dev_err_ratelimited (dev->udev->dev.parent, +"Format error\n" );break ; }
@@ -1349,7 +1349,8 @@ static void kvaser_usb_read_bulk_callbac }if (pos + msg->len > urb->actual_length) { -dev_err (dev->udev->dev.parent,"Format error\n" ); +dev_err_ratelimited (dev->udev->dev.parent, +"Format error\n" );break ; }
Greg Kroah-Hartman
maintainerPATCH 7/105 can: esd_usb2: cancel urb on -EPIPE and -EPROTO
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Martin Kelly <[email protected]>
commit 7a31ced3de06e9878e4f9c3abe8f87d9344d8144 upstream.
In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO).
This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way.
--- drivers/net/can/usb/esd_usb2.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/usb/esd_usb2.c +2 -0
@@ -393,6 +393,8 @@ static void esd_usb2_read_bulk_callback(break ;case -ENOENT : +case -EPIPE : +case -EPROTO :case -ESHUTDOWN :return ;
Greg Kroah-Hartman
maintainerPATCH 8/105 can: usb_8dev: cancel urb on -EPIPE and -EPROTO
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Martin Kelly <[email protected]>
commit 12147edc434c9e4c7c2f5fee2e5519b2e5ac34ce upstream.
In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO).
This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way.
--- drivers/net/can/usb/usb_8dev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/usb/usb_8dev.c +2 -0
@@ -524,6 +524,8 @@ static void usb_8dev_read_bulk_callback(break ;case -ENOENT : +case -EPIPE : +case -EPROTO :case -ESHUTDOWN :return ;
Greg Kroah-Hartman
maintainerPATCH 9/105 virtio: release virtio index when fail to device_register
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: weiping zhang <[email protected]>
commit e60ea67bb60459b95a50a156296041a13e0e380e upstream.
index can be reused by other virtio device.
--- drivers/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/virtio/virtio.c +2 -0
@@ -323,6 +323,8 @@ int register_virtio_device(struct virtio/* device_register() causes the bus infrastructure to look for a * matching driver. */ err =device_register (&dev->dev); +if (err) +ida_simple_remove (&virtio_index_ida, dev->index); out:if (err)add_status (dev,VIRTIO_CONFIG_S_FAILED );
Greg Kroah-Hartman
maintainerPATCH 11/105 isa: Prevent NULL dereference in isa_bus driver callbacks
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: William Breathitt Gray <[email protected]>
commit 5a244727f428a06634f22bb890e78024ab0c89f3 upstream.
The isa_driver structure for an isa_bus device is stored in the device platform_data member of the respective device structure. This platform_data member may be reset to NULL if isa_driver match callback for the device fails, indicating a device unsupported by the ISA driver.
This patch fixes a possible NULL pointer dereference if one of the isa_driver callbacks to attempted for an unsupported device. This error should not occur in practice since ISA devices are typically manually configured and loaded by the users, but we may as well prevent this error from popping up for the 0day testers.
--- drivers/base/isa.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/base/isa.c +5 -5
@@ -39,7 +39,7 @@ static int isa_bus_probe(struct device * {struct isa_driver *isa_driver = dev->platform_data; -if (isa_driver->probe) +if (isa_driver && isa_driver->probe)return isa_driver->probe (dev,to_isa_dev (dev)->id);return 0 ;
@@ -49,7 +49,7 @@ static int isa_bus_remove(struct device {struct isa_driver *isa_driver = dev->platform_data; -if (isa_driver->remove) +if (isa_driver && isa_driver->remove)return isa_driver->remove (dev,to_isa_dev (dev)->id);return 0 ;
@@ -59,7 +59,7 @@ static void isa_bus_shutdown(struct devi {struct isa_driver *isa_driver = dev->platform_data; -if (isa_driver->shutdown) +if (isa_driver && isa_driver->shutdown) isa_driver->shutdown (dev,to_isa_dev (dev)->id); }
@@ -67,7 +67,7 @@ static int isa_bus_suspend(struct device {struct isa_driver *isa_driver = dev->platform_data; -if (isa_driver->suspend) +if (isa_driver && isa_driver->suspend)return isa_driver->suspend (dev,to_isa_dev (dev)->id, state);return 0 ;
@@ -77,7 +77,7 @@ static int isa_bus_resume(struct device {struct isa_driver *isa_driver = dev->platform_data; -if (isa_driver->resume) +if (isa_driver && isa_driver->resume)return isa_driver->resume (dev,to_isa_dev (dev)->id);return 0 ;
Greg Kroah-Hartman
maintainerPATCH 13/105 efi: Move some sysfs files to be read-only by root
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kroah-Hartman <[email protected]>
commit af97a77bc01ce49a466f9d4c0125479e2e2230b6 upstream.
Thanks to the scripts/leaking_addresses.pl script, it was found that some EFI values should not be readable by non-root users.
So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to make this easier, and use it in other places at the same time.
--- drivers/firmware/efi/efi.c | 3 +-- drivers/firmware/efi/esrt.c | 15 ++++++--------- drivers/firmware/efi/runtime-map.c | 10 +++++----- include/linux/sysfs.h | 6 ++++++ 4 files changed, 18 insertions(+), 16 deletions(-)
drivers/firmware/efi/efi.c +1 -2
@@ -113,8 +113,7 @@ static ssize_t systab_show(struct kobjecreturn str - buf; } -static struct kobj_attribute efi_attr_systab = -__ATTR (systab,0400 , systab_show,NULL ); +static struct kobj_attribute efi_attr_systab =__ATTR_RO_MODE (systab,0400 );#define EFI_FIELD (var) efi.var
drivers/firmware/efi/esrt.c +6 -9
@@ -105,7 +105,7 @@ static const struct sysfs_ops esre_attr_ };/* Generic ESRT Entry ("ESRE") support. */ -static ssize_t esre_fw_class_show (struct esre_entry *entry,char *buf) +static ssize_t fw_class_show (struct esre_entry *entry,char *buf) {char *str = buf;
@@ -116,18 +116,16 @@ static ssize_t esre_fw_class_show(structreturn str - buf; } -static struct esre_attribute esre_fw_class =__ATTR (fw_class,0400 , - esre_fw_class_show,NULL ); +static struct esre_attribute esre_fw_class =__ATTR_RO_MODE (fw_class,0400 );#define esre_attr_decl (name, size, fmt) \ -static ssize_t esre_##name##_show(struct esre_entry *entry, char *buf) \ +static ssize_t name##_show(struct esre_entry *entry, char *buf) \ { \ return sprintf(buf, fmt "\n", \ le##size##_to_cpu(entry->esre.esre1->name)); \ } \ \ -static struct esre_attribute esre_##name = __ATTR(name, 0400, \ - esre_##name##_show, NULL) +static struct esre_attribute esre_##name = __ATTR_RO_MODE(name, 0400)esre_attr_decl (fw_type,32 ,"%u" );esre_attr_decl (fw_version,32 ,"%u" );
@@ -195,14 +193,13 @@ static int esre_create_sysfs_entry(void/* support for displaying ESRT fields at the top level */ #define esrt_attr_decl (name, size, fmt) \ -static ssize_t esrt_##name##_show(struct kobject *kobj, \ +static ssize_t name##_show(struct kobject *kobj, \ struct kobj_attribute *attr, char *buf)\ { \ return sprintf(buf, fmt "\n", le##size##_to_cpu(esrt->name)); \ } \ \ -static struct kobj_attribute esrt_##name = __ATTR(name, 0400, \ - esrt_##name##_show, NULL) +static struct kobj_attribute esrt_##name = __ATTR_RO_MODE(name, 0400)esrt_attr_decl (fw_resource_count,32 ,"%u" );esrt_attr_decl (fw_resource_count_max,32 ,"%u" );
drivers/firmware/efi/runtime-map.c +5 -5
@@ -67,11 +67,11 @@ static ssize_t map_attr_show(struct kobjreturn map_attr->show (entry, buf); } -static struct map_attribute map_type_attr =__ATTR_RO (type); -static struct map_attribute map_phys_addr_attr =__ATTR_RO (phys_addr); -static struct map_attribute map_virt_addr_attr =__ATTR_RO (virt_addr); -static struct map_attribute map_num_pages_attr =__ATTR_RO (num_pages); -static struct map_attribute map_attribute_attr =__ATTR_RO (attribute); +static struct map_attribute map_type_attr =__ATTR_RO_MODE (type,0400 ); +static struct map_attribute map_phys_addr_attr =__ATTR_RO_MODE (phys_addr,0400 ); +static struct map_attribute map_virt_addr_attr =__ATTR_RO_MODE (virt_addr,0400 ); +static struct map_attribute map_num_pages_attr =__ATTR_RO_MODE (num_pages,0400 ); +static struct map_attribute map_attribute_attr =__ATTR_RO_MODE (attribute,0400 );/* * These are default attributes that are added for every memmap entry.
include/linux/sysfs.h +6 -0
@@ -116,6 +116,12 @@ struct attribute_group { .show = _name##_show, \ } +#define __ATTR_RO_MODE (_name, _mode) { \ + .attr = { .name = __stringify(_name), \ + .mode = VERIFY_OCTAL_PERMISSIONS(_mode) }, \ + .show = _name##_show, \ +} +#define __ATTR_WO (_name) { \ .attr = { .name = __stringify(_name), .mode = S_IWUSR }, \ .store = _name##_store, \
Greg Kroah-Hartman
maintainerPATCH 14/105 ASN.1: fix out-of-bounds read when parsing indefinite length item
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit e0058f3a874ebb48b25be7ff79bc3b4e59929f90 upstream.
In asn1_ber_decoder(), indefinitely-sized ASN.1 items were being passed to the action functions before their lengths had been computed, using the bogus length of 0x80 (ASN1_INDEFINITE_LENGTH). This resulted in reading data past the end of the input buffer, when given a specially crafted message.
Fix it by rearranging the code so that the indefinite length is resolved before the action is called.
This bug was originally found by fuzzing the X.509 parser in userspace using libFuzzer from the LLVM project.
KASAN report (cleaned up slightly):
BUG: KASAN: slab-out-of-bounds in memcpy ./include/linux/string.h:341 [inline]
BUG: KASAN: slab-out-of-bounds in x509_fabricate_name.constprop.1+0x1a4/0x940 crypto/asymmetric_keys/x509_cert_parser.c:366
Read of size 128 at addr ffff880035dd9eaf by task keyctl/195
CPU: 1 PID: 195 Comm: keyctl Not tainted 4.14.0-09238-g1d3b78bbc6e9 #26
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-20171110_100015-anatol 04/01/2014
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0xd1/0x175 lib/dump_stack.c:53
print_address_description+0x78/0x260 mm/kasan/report.c:252
kasan_report_error mm/kasan/report.c:351 [inline]
kasan_report+0x23f/0x350 mm/kasan/report.c:409
memcpy+0x1f/0x50 mm/kasan/kasan.c:302
memcpy ./include/linux/string.h:341 [inline]
x509_fabricate_name.constprop.1+0x1a4/0x940 crypto/asymmetric_keys/x509_cert_parser.c:366
asn1_ber_decoder+0xb4a/0x1fd0 lib/asn1_decoder.c:447
x509_cert_parse+0x1c7/0x620 crypto/asymmetric_keys/x509_cert_parser.c:89
x509_key_preparse+0x61/0x750 crypto/asymmetric_keys/x509_public_key.c:174
asymmetric_key_preparse+0xa4/0x150 crypto/asymmetric_keys/asymmetric_type.c:388
key_create_or_update+0x4d4/0x10a0 security/keys/key.c:850
SYSC_add_key security/keys/keyctl.c:122 [inline]
SyS_add_key+0xe8/0x290 security/keys/keyctl.c:62
entry_SYSCALL_64_fastpath+0x1f/0x96
Allocated by task 195:
__do_kmalloc_node mm/slab.c:3675 [inline]
__kmalloc_node+0x47/0x60 mm/slab.c:3682
kvmalloc ./include/linux/mm.h:540 [inline]
SYSC_add_key security/keys/keyctl.c:104 [inline]
SyS_add_key+0x19e/0x290 security/keys/keyctl.c:62
entry_SYSCALL_64_fastpath+0x1f/0x96--- lib/asn1_decoder.c | 47 ++++++++++++++++++++++++++--------------------- 1 file changed, 26 insertions(+), 21 deletions(-)
lib/asn1_decoder.c +26 -21
@@ -312,42 +312,47 @@ next_op:/* Decide how to handle the operation */ switch (op) { -case ASN1_OP_MATCH_ANY_ACT : -case ASN1_OP_MATCH_ANY_ACT_OR_SKIP : -case ASN1_OP_COND_MATCH_ANY_ACT : -case ASN1_OP_COND_MATCH_ANY_ACT_OR_SKIP : - ret = actions[machine[pc +1 ]](context, hdr, tag, data + dp, len); -if (ret <0 ) -return ret; - goto skip_data; - -case ASN1_OP_MATCH_ACT : -case ASN1_OP_MATCH_ACT_OR_SKIP : -case ASN1_OP_COND_MATCH_ACT_OR_SKIP : - ret = actions[machine[pc +2 ]](context, hdr, tag, data + dp, len); -if (ret <0 ) -return ret; - goto skip_data; -case ASN1_OP_MATCH :case ASN1_OP_MATCH_OR_SKIP : +case ASN1_OP_MATCH_ACT : +case ASN1_OP_MATCH_ACT_OR_SKIP :case ASN1_OP_MATCH_ANY :case ASN1_OP_MATCH_ANY_OR_SKIP : +case ASN1_OP_MATCH_ANY_ACT : +case ASN1_OP_MATCH_ANY_ACT_OR_SKIP :case ASN1_OP_COND_MATCH_OR_SKIP : +case ASN1_OP_COND_MATCH_ACT_OR_SKIP :case ASN1_OP_COND_MATCH_ANY :case ASN1_OP_COND_MATCH_ANY_OR_SKIP : - skip_data: +case ASN1_OP_COND_MATCH_ANY_ACT : +case ASN1_OP_COND_MATCH_ANY_ACT_OR_SKIP : +if (!(flags &FLAG_CONS )) {if (flags &FLAG_INDEFINITE_LENGTH ) { +size_t tmp = dp; + ret =asn1_find_indefinite_length ( - data, datalen, &dp, &len, &errmsg); + data, datalen, &tmp, &len, &errmsg);if (ret <0 ) goto error; - }else { - dp += len; }pr_debug ("- LEAF: %zu\n" , len); } + +if (op &ASN1_OP_MATCH__ACT ) { +unsigned char act; + +if (op &ASN1_OP_MATCH__ANY ) + act = machine[pc +1 ]; +else + act = machine[pc +2 ]; + ret = actions[act](context, hdr, tag, data + dp, len); +if (ret <0 ) +return ret; + } + +if (!(flags &FLAG_CONS )) + dp += len; pc += asn1_op_lengths[op]; goto next_op;
Greg Kroah-Hartman
maintainerPATCH 15/105 ASN.1: check for error from ASN1_OP_END__ACT actions
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 81a7be2cd69b412ab6aeacfe5ebf1bb6e5bce955 upstream.
asn1_ber_decoder() was ignoring errors from actions associated with the opcodes ASN1_OP_END_SEQ_ACT, ASN1_OP_END_SET_ACT, ASN1_OP_END_SEQ_OF_ACT, and ASN1_OP_END_SET_OF_ACT. In practice, this meant the pkcs7_note_signed_info() action (since that was the only user of those opcodes). Fix it by checking for the error, just like the decoder does for actions associated with the other opcodes.
This bug allowed users to leak slab memory by repeatedly trying to add a specially crafted "pkcs7_test" key (requires CONFIG_PKCS7_TEST_KEY).
In theory, this bug could also be used to bypass module signature verification, by providing a PKCS#7 message that is misparsed such that a signature's ->authattrs do not contain its ->msgdigest. But it doesn't seem practical in normal cases, due to restrictions on the format of the ->authattrs.
--- lib/asn1_decoder.c | 2 ++ 1 file changed, 2 insertions(+)
lib/asn1_decoder.c +2 -0
@@ -438,6 +438,8 @@ next_op:else act = machine[pc +1 ]; ret = actions[act](context, hdr,0 , data + tdp, len); +if (ret <0 ) +return ret; } pc += asn1_op_lengths[op]; goto next_op;
Greg Kroah-Hartman
maintainerPATCH 16/105 X.509: reject invalid BIT STRING for subjectPublicKey
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Biggers <[email protected]>
commit 0f30cbea005bd3077bd98cd29277d7fc2699c1da upstream.
Adding a specially crafted X.509 certificate whose subjectPublicKey ASN.1 value is zero-length caused x509_extract_key_data() to set the public key size to SIZE_MAX, as it subtracted the nonexistent BIT STRING metadata byte. Then, x509_cert_parse() called kmemdup() with that bogus size, triggering the WARN_ON_ONCE() in kmalloc_slab().
This appears to be harmless, but it still must be fixed since WARNs are never supposed to be user-triggerable.
Fix it by updating x509_cert_parse() to validate that the value has a BIT STRING metadata byte, and that the byte is 0 which indicates that the number of bits in the bitstring is a multiple of 8.
It would be nice to handle the metadata byte in asn1_ber_decoder() instead. But that would be tricky because in the general case a BIT STRING could be implicitly tagged, and/or could legitimately have a length that is not a whole number of bytes.
Here was the WARN (cleaned up slightly):
WARNING: CPU: 1 PID: 202 at mm/slab_common.c:971 kmalloc_slab+0x5d/0x70 mm/slab_common.c:971
Modules linked in:
CPU: 1 PID: 202 Comm: keyctl Tainted: G B 4.14.0-09238-g1d3b78bbc6e9 #26
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-20171110_100015-anatol 04/01/2014
task: ffff880033014180 task.stack: ffff8800305c8000
Call Trace:
__do_kmalloc mm/slab.c:3706 [inline]
__kmalloc_track_caller+0x22/0x2e0 mm/slab.c:3726
kmemdup+0x17/0x40 mm/util.c:118
kmemdup include/linux/string.h:414 [inline]
x509_cert_parse+0x2cb/0x620 crypto/asymmetric_keys/x509_cert_parser.c:106
x509_key_preparse+0x61/0x750 crypto/asymmetric_keys/x509_public_key.c:174
asymmetric_key_preparse+0xa4/0x150 crypto/asymmetric_keys/asymmetric_type.c:388
key_create_or_update+0x4d4/0x10a0 security/keys/key.c:850
SYSC_add_key security/keys/keyctl.c:122 [inline]
SyS_add_key+0xe8/0x290 security/keys/keyctl.c:62
entry_SYSCALL_64_fastpath+0x1f/0x96--- crypto/asymmetric_keys/x509_cert_parser.c | 2 ++ 1 file changed, 2 insertions(+)
crypto/asymmetric_keys/x509_cert_parser.c +2 -0
@@ -399,6 +399,8 @@ int x509_extract_key_data(void *context, ctx->cert->pub->pkey_algo =PKEY_ALGO_RSA ;/* Discard the BIT STRING metadata */ +if (vlen <1 || *(const u8 *)value !=0 ) +return -EBADMSG ; ctx->key = value +1 ; ctx->key_size = vlen -1 ;return 0 ;
Greg Kroah-Hartman
maintainerPATCH 18/105 ALSA: pcm: prevent UAF in snd_pcm_info
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Robb Glasser <[email protected]>
commit 362bca57f5d78220f8b5907b875961af9436e229 upstream.
When the device descriptor is closed, the substream->runtime pointer is freed. But another thread may be in the ioctl handler, case SNDRV_CTL_IOCTL_PCM_INFO. This case calls snd_pcm_info_user() which calls snd_pcm_info() which accesses the now freed substream->runtime.
Note: this fixes CVE-2017-0861
--- sound/core/pcm.c | 2 ++ 1 file changed, 2 insertions(+)
sound/core/pcm.c +2 -0
@@ -149,7 +149,9 @@ static int snd_pcm_control_ioctl(struct err = -ENXIO ; goto _error; } +mutex_lock (&pcm->open_mutex); err =snd_pcm_info_user (substream, info); +mutex_unlock (&pcm->open_mutex); _error:mutex_unlock (®ister_mutex);return err;
Greg Kroah-Hartman
maintainerPATCH 21/105 ALSA: usb-audio: Add check return value for usb_string()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jaejoong Kim <[email protected]>
commit 89b89d121ffcf8d9546633b98ded9d18b8f75891 upstream.
snd_usb_copy_string_desc() returns zero if usb_string() fails. In case of failure, we need to check the snd_usb_copy_string_desc()'s return value and add an exception case
--- sound/usb/mixer.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
sound/usb/mixer.c +5 -4
@@ -2106,13 +2106,14 @@ static int parse_audio_selector_unit(strif (len) ;else if (nameid) -snd_usb_copy_string_desc (state, nameid, kctl->id.name, + len =snd_usb_copy_string_desc (state, nameid, kctl->id.name,sizeof (kctl->id.name)); -else { +else len =get_term_name (state, &state->oterm, kctl->id.name,sizeof (kctl->id.name),0 ); -if (!len) -strlcpy (kctl->id.name,"USB" ,sizeof (kctl->id.name)); + +if (!len) { +strlcpy (kctl->id.name,"USB" ,sizeof (kctl->id.name));if (desc->bDescriptorSubtype ==UAC2_CLOCK_SELECTOR )append_ctl_name (kctl," Clock Source" );
Greg Kroah-Hartman
maintainerPATCH 22/105 iommu/vt-d: Fix scatterlist offset handling
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Robin Murphy <[email protected]>
commit 29a90b70893817e2f2bb3cea40a29f5308e21b21 upstream.
The intel-iommu DMA ops fail to correctly handle scatterlists where sg->offset is greater than PAGE_SIZE - the IOVA allocation is computed appropriately based on the page-aligned portion of the offset, but the mapping is set up relative to sg->page, which means it fails to actually cover the whole buffer (and in the worst case doesn't cover it at all):
(sg->dma_address + sg->dma_len) ----+
sg->dma_address ---------+ |
iov_pfn------+ | |
| | |
v v v
iova: a b c d e f
|--------|--------|--------|--------|--------|
<...calculated....>
[_____mapped______]
pfn: 0 1 2 3 4 5
|--------|--------|--------|--------|--------|
^ ^ ^
| | |
sg->page ----+ | |
sg->offset --------------+ |
(sg->offset + sg->length) ----------+As a result, the caller ends up overrunning the mapping into whatever lies beyond, which usually goes badly:
[ 429.645492] DMAR: DRHD: handling fault status reg 2 [ 429.650847] DMAR: [DMA Write] Request device [02:00.4] fault addr f2682000 ...
Whilst this is a fairly rare occurrence, it can happen from the result of intermediate scatterlist processing such as scatterwalk_ffwd() in the crypto layer. Whilst that particular site could be fixed up, it still seems worthwhile to bring intel-iommu in line with other DMA API implementations in handling this robustly.
To that end, fix the intel_map_sg() path to line up the mapping correctly (in units of MM pages rather than VT-d pages to match the aligned_nrpages() calculation) regardless of the offset, and use sg_phys() consistently for clarity.
Reviewed by: Ashok Raj <[email protected]>
Tested by: Jacob Pan <[email protected]>
--- drivers/iommu/intel-iommu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/iommu/intel-iommu.c +5 -3
@@ -2201,10 +2201,12 @@ static int __domain_mapping(struct dmar_uint64_t tmp;if (!sg_res) { +unsigned int pgoff = sg->offset & ~PAGE_MASK ; + sg_res =aligned_nrpages (sg->offset, sg->length); - sg->dma_address = ((dma_addr_t )iov_pfn <<VTD_PAGE_SHIFT ) + sg->offset; + sg->dma_address = ((dma_addr_t )iov_pfn <<VTD_PAGE_SHIFT ) + pgoff; sg->dma_length = sg->length; - pteval =page_to_phys (sg_page (sg)) | prot; + pteval = (sg_phys (sg) - pgoff) | prot; phys_pfn = pteval >>VTD_PAGE_SHIFT ; }
@@ -3757,7 +3759,7 @@ static int intel_nontranslate_map_sg(strfor_each_sg (sglist, sg, nelems, i) {BUG_ON (!sg_page (sg)); - sg->dma_address =page_to_phys (sg_page (sg)) + sg->offset; + sg->dma_address =sg_phys (sg); sg->dma_length = sg->length; }return nelems;
Greg Kroah-Hartman
maintainerPATCH 23/105 s390: fix compat system call table
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Heiko Carstens <[email protected]>
commit e779498df587dd2189b30fe5b9245aefab870eb8 upstream.
When wiring up the socket system calls the compat entries were incorrectly set. Not all of them point to the corresponding compat wrapper functions, which clear the upper 33 bits of user space pointers, like it is required.
--- arch/s390/kernel/syscalls.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/s390/kernel/syscalls.S +3 -3
@@ -369,10 +369,10 @@ SYSCALL(sys_recvmmsg,compat_sys_recvmmsg SYSCALL(sys_sendmmsg,compat_sys_sendmmsg) SYSCALL(sys_socket,sys_socket) SYSCALL(sys_socketpair,compat_sys_socketpair) /* 360 */ -SYSCALL(sys_bind,sys_bind) -SYSCALL(sys_connect,sys_connect) +SYSCALL(sys_bind,compat_sys_bind) +SYSCALL(sys_connect,compat_sys_connect) SYSCALL(sys_listen,sys_listen) -SYSCALL(sys_accept4,sys_accept4) +SYSCALL(sys_accept4,compat_sys_accept4) SYSCALL(sys_getsockopt,compat_sys_getsockopt) /* 365 */ SYSCALL(sys_setsockopt,compat_sys_setsockopt) SYSCALL(sys_getsockname,compat_sys_getsockname)
Greg Kroah-Hartman
maintainerPATCH 28/105 arm64: KVM: fix VTTBR_BADDR_MASK BUG_ON off-by-one
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kristina Martsenko <[email protected]>
commit 26aa7b3b1c0fb3f1a6176a0c1847204ef4355693 upstream.
VTTBR_BADDR_MASK is used to sanity check the size and alignment of the VTTBR address. It seems to currently be off by one, thereby only allowing up to 47-bit addresses (instead of 48-bit) and also insufficiently checking the alignment. This patch fixes it.
As an example, with 4k pages, before this patch we have:
PHYS_MASK_SHIFT = 48
VTTBR_X = 37 - 24 = 13
VTTBR_BADDR_SHIFT = 13 - 1 = 12
VTTBR_BADDR_MASK = ((1 << 35) - 1) << 12 = 0x00007ffffffff000
Which is wrong, because the mask doesn't allow bit 47 of the VTTBR address to be set, and only requires the address to be 12-bit (4k) aligned, while it actually needs to be 13-bit (8k) aligned because we concatenate two 4k tables.
With this patch, the mask becomes 0x0000ffffffffe000, which is what we want.
--- arch/arm64/include/asm/kvm_arm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/include/asm/kvm_arm.h +1 -2
@@ -164,8 +164,7 @@#define VTTBR_X (37 - VTCR_EL2_T0SZ_40B)#endif -#define VTTBR_BADDR_SHIFT (VTTBR_X - 1) -#define VTTBR_BADDR_MASK (((UL(1) << (PHYS_MASK_SHIFT - VTTBR_X)) - 1) << VTTBR_BADDR_SHIFT) +#define VTTBR_BADDR_MASK (((UL(1) << (PHYS_MASK_SHIFT - VTTBR_X)) - 1) << VTTBR_X)#define VTTBR_VMID_SHIFT (UL(48))#define VTTBR_VMID_MASK (UL(0xFF) << VTTBR_VMID_SHIFT)
Greg Kroah-Hartman
maintainerPATCH 33/105 scsi: storvsc: Workaround for virtual DVD SCSI version
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stephen Hemminger <[email protected]>
commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f upstream.
Hyper-V host emulation of SCSI for virtual DVD device reports SCSI version 0 (UNKNOWN) but is still capable of supporting REPORTLUN.
Without this patch, a GEN2 Linux guest on Hyper-V will not boot 4.11 successfully with virtual DVD ROM device. What happens is that the SCSI scan process falls back to doing sequential probing by INQUIRY. But the storvsc driver has a previous workaround that masks/blocks all errors reports from INQUIRY (or MODE_SENSE) commands. This workaround causes the scan to then populate a full set of bogus LUN's on the target and then sends kernel spinning off into a death spiral doing block reads on the non-existent LUNs.
By setting the correct blacklist flags, the target with the DVD device is scanned with REPORTLUN and that works correctly.
Patch needs to go in current 4.11, it is safe but not necessary in older kernels.
--- drivers/scsi/storvsc_drv.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-)
drivers/scsi/storvsc_drv.c +17 -10
@@ -379,8 +379,6 @@ MODULE_PARM_DESC(vcpus_per_sub_channel,*/ static int storvsc_timeout =180 ; -static int msft_blist_flags =BLIST_TRY_VPD_PAGES ; -static void storvsc_on_channel_callback (void *context);
@@ -1241,6 +1239,22 @@ static int storvsc_do_io(struct hv_devicreturn ret; } +static int storvsc_device_alloc (struct scsi_device *sdevice) +{ +/* +* Set blist flag to permit the reading of the VPD pages even when +* the target may claim SPC-2 compliance. MSFT targets currently +* claim SPC-2 compliance while they implement post SPC-2 features. +* With this flag we can correctly handle WRITE_SAME_16 issues. +* +* Hypervisor reports SCSI_UNKNOWN type for DVD ROM device but +* still supports REPORT LUN. +*/ + sdevice->sdev_bflags =BLIST_REPORTLUN2 |BLIST_TRY_VPD_PAGES ; + +return 0 ; +} +static int storvsc_device_configure (struct scsi_device *sdevice) {
@@ -1256,14 +1270,6 @@ static int storvsc_device_configure(stru sdevice->no_write_same =1 ;/* -* Add blist flags to permit the reading of the VPD pages even when -* the target may claim SPC-2 compliance. MSFT targets currently -* claim SPC-2 compliance while they implement post SPC-2 features. -* With this patch we can correctly handle WRITE_SAME_16 issues. -*/ - sdevice->sdev_bflags |= msft_blist_flags; - -/* * If the host is WIN8 or WIN8 R2, claim conformance to SPC-3 * if the device is a MSFT virtual device. If the host is * WIN10 or newer, allow write_same.
@@ -1529,6 +1535,7 @@ static struct scsi_host_template scsi_dr .eh_host_reset_handler = storvsc_host_reset_handler, .proc_name = "storvsc_host", .eh_timed_out = storvsc_eh_timed_out, + .slave_alloc = storvsc_device_alloc, .slave_configure = storvsc_device_configure, .cmd_per_lun = 255, .this_id = -1,
Greg Kroah-Hartman
maintainerPATCH 34/105 thp: reduce indentation level in change_huge_pmd()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill A. Shutemov <[email protected]>
commit 0a85e51d37645e9ce57e5e1a30859e07810ed07c upstream.
Patch series "thp: fix few MADV_DONTNEED races"
For MADV_DONTNEED to work properly with huge pages, it's critical to not clear pmd intermittently unless you hold down_write(mmap_sem).
Otherwise MADV_DONTNEED can miss the THP which can lead to userspace breakage.
See example of such race in commit message of patch 2/4.
All these races are found by code inspection. I haven't seen them triggered. I don't think it's worth to apply them to stable@.
This patch (of 4):
Restructure code in preparation for a fix.
--- mm/huge_memory.c | 54 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 28 insertions(+), 26 deletions(-)
mm/huge_memory.c +28 -26
@@ -1566,35 +1566,37 @@ int change_huge_pmd(struct vm_area_struc {struct mm_struct *mm = vma->vm_mm;spinlock_t *ptl; +pmd_t entry; +bool preserve_write; +int ret =0 ; -if (__pmd_trans_huge_lock (pmd, vma, &ptl) ==1 ) { -pmd_t entry; -bool preserve_write = prot_numa &&pmd_write (*pmd); - ret =1 ; - -/* -* Avoid trapping faults against the zero page. The read-only -* data is likely to be read-cached on the local CPU and -* local/remote hits to the zero page are not interesting. -*/ -if (prot_numa &&is_huge_zero_pmd (*pmd)) { -spin_unlock (ptl); -return ret; - } - -if (!prot_numa || !pmd_protnone (*pmd)) { - entry =pmdp_huge_get_and_clear_notify (mm, addr, pmd); - entry =pmd_modify (entry, newprot); -if (preserve_write) - entry =pmd_mkwrite (entry); - ret =HPAGE_PMD_NR ; -set_pmd_at (mm, addr, pmd, entry); -BUG_ON (!preserve_write &&pmd_write (entry)); - } -spin_unlock (ptl); - } +if (__pmd_trans_huge_lock (pmd, vma, &ptl) !=1 ) +return 0 ; + + preserve_write = prot_numa &&pmd_write (*pmd); + ret =1 ; + +/* +* Avoid trapping faults against the zero page. The read-only +* data is likely to be read-cached on the local CPU and +* local/remote hits to the zero page are not interesting. +*/ +if (prot_numa &&is_huge_zero_pmd (*pmd)) + goto unlock; + +if (prot_numa &&pmd_protnone (*pmd)) + goto unlock; + entry =pmdp_huge_get_and_clear_notify (mm, addr, pmd); + entry =pmd_modify (entry, newprot); +if (preserve_write) + entry =pmd_mkwrite (entry); + ret =HPAGE_PMD_NR ; +set_pmd_at (mm, addr, pmd, entry); +BUG_ON (!preserve_write &&pmd_write (entry)); +unlock: +spin_unlock (ptl);return ret; }
Greg Kroah-Hartman
maintainerPATCH 35/105 thp: fix MADV_DONTNEED vs. numa balancing race
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill A. Shutemov <[email protected]>
commit ced108037c2aa542b3ed8b7afd1576064ad1362a upstream.
In case prot_numa, we are under down_read(mmap_sem). It's critical to not clear pmd intermittently to avoid race with MADV_DONTNEED which is also under down_read(mmap_sem):
CPU0: CPU1: change_huge_pmd(prot_numa=1) pmdp_huge_get_and_clear_notify()
madvise_dontneed()
zap_pmd_range()
pmd_trans_huge(*pmd) == 0 (without ptl)
// skip the pmd
set_pmd_at(); // pmd is re-established
The race makes MADV_DONTNEED miss the huge pmd and don't clear it which may break userspace.
Found by code analysis, never saw triggered.
--- mm/huge_memory.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-)
mm/huge_memory.c +33 -1
@@ -1588,7 +1588,39 @@ int change_huge_pmd(struct vm_area_strucif (prot_numa &&pmd_protnone (*pmd)) goto unlock; - entry =pmdp_huge_get_and_clear_notify (mm, addr, pmd); +/* +* In case prot_numa, we are under down_read(mmap_sem). It's critical +* to not clear pmd intermittently to avoid race with MADV_DONTNEED +* which is also under down_read(mmap_sem): +* +* CPU0: CPU1: +* change_huge_pmd(prot_numa=1) +* pmdp_huge_get_and_clear_notify() +* madvise_dontneed() +* zap_pmd_range() +* pmd_trans_huge(*pmd) == 0 (without ptl) +* // skip the pmd +* set_pmd_at(); +* // pmd is re-established +* +* The race makes MADV_DONTNEED miss the huge pmd and don't clear it +* which may break userspace. +* +* pmdp_invalidate() is required to make sure we don't miss +* dirty/young flags set by hardware. +*/ + entry = *pmd; +pmdp_invalidate (vma, addr, pmd); + +/* +* Recover dirty/young flags. It relies on pmdp_invalidate to not +* corrupt them. +*/ +if (pmd_dirty (*pmd)) + entry =pmd_mkdirty (entry); +if (pmd_young (*pmd)) + entry =pmd_mkyoung (entry); + entry =pmd_modify (entry, newprot);if (preserve_write) entry =pmd_mkwrite (entry);
Greg Kroah-Hartman
maintainerPATCH 36/105 mm: drop unused pmdp_huge_get_and_clear_notify()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kirill A. Shutemov <[email protected]>
commit c0c379e2931b05facef538e53bf3b21f283d9a0b upstream.
Dave noticed that after fixing MADV_DONTNEED vs numa balancing race the last pmdp_huge_get_and_clear_notify() user is gone.
Let's drop the helper.
--- include/linux/mmu_notifier.h | 13 ------------- 1 file changed, 13 deletions(-)
include/linux/mmu_notifier.h +0 -13
@@ -381,18 +381,6 @@ static inline void mmu_notifier_mm_destr ___pmd; \ }) -#define pmdp_huge_get_and_clear_notify (__mm, __haddr, __pmd) \ -({ \ - unsigned long ___haddr = __haddr & HPAGE_PMD_MASK; \ - pmd_t ___pmd; \ - \ - ___pmd = pmdp_huge_get_and_clear(__mm, __haddr, __pmd); \ - mmu_notifier_invalidate_range(__mm, ___haddr, \ - ___haddr + HPAGE_PMD_SIZE); \ - \ - ___pmd; \ -}) -/* * set_pte_at_notify() sets the pte _after_ running the notifier. * This is safe to start by updating the secondary MMUs, because the primary MMU
@@ -475,7 +463,6 @@ static inline void mmu_notifier_mm_destr#define pmdp_clear_young_notify pmdp_test_and_clear_young#define ptep_clear_flush_notify ptep_clear_flush#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush -#define pmdp_huge_get_and_clear_notify pmdp_huge_get_and_clear#define set_pte_at_notify set_pte_at#endif /* CONFIG_MMU_NOTIFIER */
Greg Kroah-Hartman
maintainerPATCH 38/105 Revert "spi: SPI_FSL_DSPI should depend on HAS_DMA"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sasha Levin <[email protected]>
This reverts commit dadab2d4e3cf708ceba22ecddd94aedfecb39199.
Not required on < 4.10.
--- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/spi/Kconfig +0 -1
@@ -315,7 +315,6 @@ config SPI_FSL_SPI config SPI_FSL_DSPI tristate "Freescale DSPI controller" select REGMAP_MMIO - depends on HAS_DMA depends on SOC_VF610 || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST help This enables support for the Freescale DSPI controller in master
Greg Kroah-Hartman
maintainerPATCH 42/105 x86/hpet: Prevent might sleep splat on resume
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Gleixner <[email protected]>
[ Upstream commit bb1a2c26165640ba2cbcfe06c81e9f9d6db4e643 ]
Sergey reported a might sleep warning triggered from the hpet resume path. It's caused by the call to disable_irq() from interrupt disabled context.
The problem with the low level resume code is that it is not accounted as a special system_state like we do during the boot process. Calling the same code during system boot would not trigger the warning. That's inconsistent at best.
In this particular case it's trivial to replace the disable_irq() with disable_hardirq() because this particular code path is solely used from system resume and the involved hpet interrupts can never be force threaded.
--- arch/x86/kernel/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/hpet.c +1 -1
@@ -353,7 +353,7 @@ static int hpet_resume(struct clock_evenirq_domain_deactivate_irq (irq_get_irq_data (hdev->irq));irq_domain_activate_irq (irq_get_irq_data (hdev->irq)); -disable_irq (hdev->irq); +disable_hardirq (hdev->irq);irq_set_affinity (hdev->irq,cpumask_of (hdev->cpu));enable_irq (hdev->irq); }
Greg Kroah-Hartman
maintainerPATCH 46/105 ARM: OMAP2+: Release device node after it is no longer needed.
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
[ Upstream commit b92675d998a9fa37fe9e0e35053a95b4a23c158b ]
The device node returned by of_find_node_by_name() needs to be released after it is no longer needed to avoid a device node leak.
--- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +7 -2
@@ -3967,15 +3967,20 @@ int __init omap3xxx_hwmod_init(void)if (h_sham &&omap3xxx_hwmod_is_hs_ip_block_usable (bus,"sham" )) { r =omap_hwmod_register_links (h_sham); -if (r <0 ) +if (r <0 ) { +of_node_put (bus);return r; + } }if (h_aes &&omap3xxx_hwmod_is_hs_ip_block_usable (bus,"aes" )) { r =omap_hwmod_register_links (h_aes); -if (r <0 ) +if (r <0 ) { +of_node_put (bus);return r; + } } +of_node_put (bus);/* * Register hwmod links specific to certain ES levels of a
Greg Kroah-Hartman
maintainerPATCH 48/105 HID: chicony: Add support for another ASUS Zen AiO keyboard
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Drake <[email protected]>
[ Upstream commit f2f10b7e722a75c6d75a7f7cd06b0eee3ae20f7c ]
Add support for media keys on the keyboard that comes with the Asus V221ID and ZN241IC All In One computers.
The keys to support here are WLAN, BRIGHTNESSDOWN and BRIGHTNESSUP.
This device is not visibly branded as Chicony, and the USB Vendor ID suggests that it is a JESS device. However this seems like the right place to put it: the usage codes are identical to the currently supported devices, and this driver already supports the ASUS AIO keyboard AK1D.
--- drivers/hid/Kconfig | 4 ++-- drivers/hid/hid-chicony.c | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 4 files changed, 5 insertions(+), 2 deletions(-)
drivers/hid/Kconfig +2 -2
@@ -165,11 +165,11 @@ config HID_CHERRY Support for Cherry Cymotion keyboard. config HID_CHICONY - tristate "Chicony Tactical pad" + tristate "Chicony devices" depends on HID default !EXPERT ---help--- - Support for Chicony Tactical pad. + Support for Chicony Tactical pad and special keys on Chicony keyboards. config HID_CORSAIR tristate "Corsair devices"
drivers/hid/hid-chicony.c +1 -0
@@ -86,6 +86,7 @@ static const struct hid_device_id ch_dev { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_WIRELESS2) }, { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_AK1D) }, { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_ACER_SWITCH12) }, + { HID_USB_DEVICE(USB_VENDOR_ID_JESS, USB_DEVICE_ID_JESS_ZEN_AIO_KBD) }, { } };MODULE_DEVICE_TABLE (hid, ch_devices);
drivers/hid/hid-core.c +1 -0
@@ -1867,6 +1867,7 @@ static const struct hid_device_id hid_ha { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081) }, { HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A0C2) }, { HID_USB_DEVICE(USB_VENDOR_ID_HUION, USB_DEVICE_ID_HUION_TABLET) }, + { HID_USB_DEVICE(USB_VENDOR_ID_JESS, USB_DEVICE_ID_JESS_ZEN_AIO_KBD) }, { HID_USB_DEVICE(USB_VENDOR_ID_JESS2, USB_DEVICE_ID_JESS2_COLOR_RUMBLE_PAD) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ION, USB_DEVICE_ID_ICADE) }, { HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON, USB_DEVICE_ID_KS_SLIMBLADE) },
drivers/hid/hid-ids.h +1 -0
@@ -523,6 +523,7 @@#define USB_VENDOR_ID_JESS 0x0c45#define USB_DEVICE_ID_JESS_YUREX 0x1010 +#define USB_DEVICE_ID_JESS_ZEN_AIO_KBD 0x5112#define USB_VENDOR_ID_JESS2 0x0f30#define USB_DEVICE_ID_JESS2_COLOR_RUMBLE_PAD 0x0111
Greg Kroah-Hartman
maintainerPATCH 50/105 USB: gadgetfs: Fix a potential memory leak in dev_config()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe JAILLET <[email protected]>
[ Upstream commit b6e7aeeaf235901c42ec35de4633c7c69501d303 ]
'kbuf' is allocated just a few lines above using 'memdup_user()'. If the 'if (dev->buf)' test fails, this memory is never released.
--- drivers/usb/gadget/legacy/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/gadget/legacy/inode.c +3 -1
@@ -1837,8 +1837,10 @@ dev_config (struct file *fd, const charspin_lock_irq (&dev->lock); value = -EINVAL ; -if (dev->buf) +if (dev->buf) { +kfree (kbuf); goto fail; + } dev->buf = kbuf;/* full or low speed config */
Greg Kroah-Hartman
maintainerPATCH 53/105 workqueue: trigger WARN if queue_delayed_work() is called with NULL @wq
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tejun Heo <[email protected]>
[ Upstream commit 637fdbae60d6cb9f6e963c1079d7e0445c86ff7d ]
If queue_delayed_work() gets called with NULL @wq, the kernel will oops asynchronuosly on timer expiration which isn't too helpful in tracking down the offender. This actually happened with smc.
__queue_delayed_work() already does several input sanity checks synchronously. Add NULL @wq check.
--- kernel/workqueue.c | 1 + 1 file changed, 1 insertion(+)
kernel/workqueue.c +1 -0
@@ -1479,6 +1479,7 @@ static void __queue_delayed_work(int cpustruct timer_list *timer = &dwork->timer;struct work_struct *work = &dwork->work; +WARN_ON_ONCE (!wq);WARN_ON_ONCE (timer->function != delayed_work_timer_fn || timer->data != (unsigned long )dwork);WARN_ON_ONCE (timer_pending (timer));
Greg Kroah-Hartman
maintainerPATCH 54/105 scsi: lpfc: Fix crash during Hardware error recovery on SLI3 adapters
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: James Smart <[email protected]>
[ Upstream commit 5d181531bc6169e19a02a27d202cf0e982db9d0e ]
if REG_VPI fails, the driver was incorrectly issuing INIT_VFI (a SLI4 command) on a SLI3 adapter.
--- drivers/scsi/lpfc/lpfc_els.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +10 -4
@@ -7887,11 +7887,17 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hbaspin_lock_irq (shost->host_lock); vport->fc_flag |=FC_VPORT_NEEDS_REG_VPI ;spin_unlock_irq (shost->host_lock); -if (vport->port_type ==LPFC_PHYSICAL_PORT - && !(vport->fc_flag &FC_LOGO_RCVD_DID_CHNG )) -lpfc_issue_init_vfi (vport); -else +if (mb->mbxStatus ==MBX_NOT_FINISHED ) +break ; +if ((vport->port_type ==LPFC_PHYSICAL_PORT ) && + !(vport->fc_flag &FC_LOGO_RCVD_DID_CHNG )) { +if (phba->sli_rev ==LPFC_SLI_REV4 ) +lpfc_issue_init_vfi (vport); +else +lpfc_initial_flogi (vport); + }else {lpfc_initial_fdisc (vport); + }break ; } }else {
Greg Kroah-Hartman
maintainerPATCH 57/105 arm: KVM: Survive unknown traps from guests
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Rutland <[email protected]>
[ Upstream commit f050fe7a9164945dd1c28be05bf00e8cfb082ccf ]
Currently we BUG() if we see a HSR.EC value we don't recognise. As configurable disables/enables are added to the architecture (controlled by RES1/RES0 bits respectively), with associated synchronous exceptions, it may be possible for a guest to trigger exceptions with classes that we don't recognise.
While we can't service these exceptions in a manner useful to the guest, we can avoid bringing down the host. Per ARM DDI 0406C.c, all currently unallocated HSR EC encodings are reserved, and per ARM DDI 0487A.k_iss10775, page G6-4395, EC values within the range 0x00 - 0x2c are reserved for future use with synchronous exceptions, and EC values within the range 0x2d - 0x3f may be used for either synchronous or asynchronous exceptions.
The patch makes KVM handle any unknown EC by injecting an UNDEFINED exception into the guest, with a corresponding (ratelimited) warning in the host dmesg. We could later improve on this with with a new (opt-in) exit to the host userspace.
--- arch/arm/include/asm/kvm_arm.h | 1 + arch/arm/kvm/handle_exit.c | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 7 deletions(-)
arch/arm/include/asm/kvm_arm.h +1 -0
@@ -209,6 +209,7 @@#define HSR_EC_IABT_HYP (0x21)#define HSR_EC_DABT (0x24)#define HSR_EC_DABT_HYP (0x25) +#define HSR_EC_MAX (0x3f)#define HSR_WFI_IS_WFE (1U << 0)
arch/arm/kvm/handle_exit.c +12 -7
@@ -100,7 +100,19 @@ static int kvm_handle_wfx(struct kvm_vcpreturn 1 ; } +static int kvm_handle_unknown_ec (struct kvm_vcpu *vcpu,struct kvm_run *run) +{ +u32 hsr =kvm_vcpu_get_hsr (vcpu); + +kvm_pr_unimpl ("Unknown exception class: hsr: %#08x\n" , + hsr); + +kvm_inject_undefined (vcpu); +return 1 ; +} +static exit_handle_fn arm_exit_handlers[] = { + [0 ...HSR_EC_MAX ] = kvm_handle_unknown_ec, [HSR_EC_WFI ] = kvm_handle_wfx, [HSR_EC_CP15_32 ] = kvm_handle_cp15_32, [HSR_EC_CP15_64 ] = kvm_handle_cp15_64,
@@ -122,13 +134,6 @@ static exit_handle_fn kvm_get_exit_handl {u8 hsr_ec =kvm_vcpu_trap_get_class (vcpu); -if (hsr_ec >=ARRAY_SIZE (arm_exit_handlers) || - !arm_exit_handlers[hsr_ec]) { -kvm_err ("Unknown exception class: hsr: %#08x\n" , - (unsigned int )kvm_vcpu_get_hsr (vcpu)); -BUG (); - } -return arm_exit_handlers[hsr_ec]; }
Greg Kroah-Hartman
maintainerPATCH 61/105 bnx2x: fix possible overrun of VFPF multicast addresses array
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michal Schmidt <[email protected]>
[ Upstream commit 22118d861cec5da6ed525aaf12a3de9bfeffc58f ]
It is too late to check for the limit of the number of VF multicast addresses after they have already been copied to the req->multicast[] array, possibly overflowing it.
Do the check before copying.
Also fix the error path to not skip unlocking vf2pf_mutex.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c +11 -12
@@ -868,7 +868,7 @@ int bnx2x_vfpf_set_mcast(struct net_devistruct bnx2x *bp =netdev_priv (dev);struct vfpf_set_q_filters_tlv *req = &bp->vf2pf_mbox->req.set_q_filters;struct pfvf_general_resp_tlv *resp = &bp->vf2pf_mbox->resp.general_resp; -int rc, i =0 ; +int rc =0 , i =0 ;struct netdev_hw_addr *ha;if (bp->state !=BNX2X_STATE_OPEN ) {
@@ -883,6 +883,15 @@ int bnx2x_vfpf_set_mcast(struct net_devi/* Get Rx mode requested */ DP (NETIF_MSG_IFUP ,"dev->flags = %x\n" , dev->flags); +/* We support PFVF_MAX_MULTICAST_PER_VF mcast addresses tops */ +if (netdev_mc_count (dev) >PFVF_MAX_MULTICAST_PER_VF ) { +DP (NETIF_MSG_IFUP , +"VF supports not more than %d multicast MAC addresses\n" , +PFVF_MAX_MULTICAST_PER_VF ); + rc = -EINVAL ; + goto out; + } +netdev_for_each_mc_addr (ha, dev) {DP (NETIF_MSG_IFUP ,"Adding mcast MAC: %pM\n" ,bnx2x_mc_addr (ha));
@@ -890,16 +899,6 @@ int bnx2x_vfpf_set_mcast(struct net_devi i++; } -/* We support four PFVF_MAX_MULTICAST_PER_VF mcast -* addresses tops -*/ -if (i >=PFVF_MAX_MULTICAST_PER_VF ) { -DP (NETIF_MSG_IFUP , -"VF supports not more than %d multicast MAC addresses\n" , -PFVF_MAX_MULTICAST_PER_VF ); -return -EINVAL ; - } - req->n_multicast = i; req->flags |=VFPF_SET_Q_FILTERS_MULTICAST_CHANGED ; req->vf_qid =0 ;
@@ -924,7 +923,7 @@ int bnx2x_vfpf_set_mcast(struct net_devi out:bnx2x_vfpf_finalize (bp, &req->first_tlv); -return 0 ; +return rc; }/* request pf to add a vlan for the vf */
Greg Kroah-Hartman
maintainerPATCH 63/105 ipv6: reorder icmpv6_init() and ip6_mr_init()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: WANG Cong <[email protected]>
[ Upstream commit 15e668070a64bb97f102ad9cf3bccbca0545cda8 ]
Andrey reported the following kernel crash:
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 0 PID: 14446 Comm: syz-executor6 Not tainted 4.10.0+ #82 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task: ffff88001f311700 task.stack: ffff88001f6e8000 RIP: 0010:ip6mr_sk_done+0x15a/0x3d0 net/ipv6/ip6mr.c:1618 RSP: 0018:ffff88001f6ef418 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: 1ffff10003edde8c RCX: ffffc900043ee000 RDX: 0000000000000004 RSI: ffffffff83e3b3f8 RDI: 0000000000000020 RBP: ffff88001f6ef508 R08: fffffbfff0dcc5d8 R09: 0000000000000000 R10: ffffffff86e62ec0 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: ffff88001f6ef4e0 R15: ffff8800380a0040 FS: 00007f7a52cec700(0000) GS:ffff88003ec00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000000000061c500 CR3: 000000001f1ae000 CR4: 00000000000006f0 DR0: 0000000020000000 DR1: 0000000020000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600 Call Trace: rawv6_close+0x4c/0x80 net/ipv6/raw.c:1217 inet_release+0xed/0x1c0 net/ipv4/af_inet.c:425 inet6_release+0x50/0x70 net/ipv6/af_inet6.c:432 sock_release+0x8d/0x1e0 net/socket.c:597 __sock_create+0x39d/0x880 net/socket.c:1226 sock_create_kern+0x3f/0x50 net/socket.c:1243 inet_ctl_sock_create+0xbb/0x280 net/ipv4/af_inet.c:1526 icmpv6_sk_init+0x163/0x500 net/ipv6/icmp.c:954 ops_init+0x10a/0x550 net/core/net_namespace.c:115 setup_net+0x261/0x660 net/core/net_namespace.c:291 copy_net_ns+0x27e/0x540 net/core/net_namespace.c:396 9pnet_virtio: no channels available for device ./file1 create_new_namespaces+0x437/0x9b0 kernel/nsproxy.c:106 unshare_nsproxy_namespaces+0xae/0x1e0 kernel/nsproxy.c:205 SYSC_unshare kernel/fork.c:2281 [inline] SyS_unshare+0x64e/0x1000 kernel/fork.c:2231 entry_SYSCALL_64_fastpath+0x1f/0xc2
This is because net->ipv6.mr6_tables is not initialized at that point, ip6mr_rules_init() is not called yet, therefore on the error path when we iterator the list, we trigger this oops. Fix this by reordering ip6mr_rules_init() before icmpv6_sk_init().
--- net/ipv6/af_inet6.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/ipv6/af_inet6.c +5 -5
@@ -893,12 +893,12 @@ static int __init inet6_init(void) err =register_pernet_subsys (&inet6_net_ops);if (err) goto register_pernet_fail; - err =icmpv6_init (); -if (err) - goto icmp_fail; err =ip6_mr_init ();if (err) goto ipmr_fail; + err =icmpv6_init (); +if (err) + goto icmp_fail; err =ndisc_init ();if (err) goto ndisc_fail;
@@ -1016,10 +1016,10 @@ igmp_fail:ndisc_cleanup (); ndisc_fail:ip6_mr_cleanup (); -ipmr_fail: -icmpv6_cleanup (); icmp_fail:unregister_pernet_subsys (&inet6_net_ops); +ipmr_fail: +icmpv6_cleanup (); register_pernet_fail:sock_unregister (PF_INET6 );rtnl_unregister_all (PF_INET6 );
Greg Kroah-Hartman
maintainerPATCH 64/105 crypto: s5p-sss - Fix completing crypto request in IRQ handler
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 07de4bc88ce6a4d898cad9aa4c99c1df7e87702d ]
In a regular interrupt handler driver was finishing the crypt/decrypt request by calling complete on crypto request. This is disallowed since converting to skcipher in commit b286d8b1a690 ("crypto: skcipher - Add skcipher walk interface") and causes a warning:
WARNING: CPU: 0 PID: 0 at crypto/skcipher.c:430 skcipher_walk_first+0x13c/0x14c
The interrupt is marked shared but in fact there are no other users sharing it. Thus the simplest solution seems to be to just use a threaded interrupt handler, after converting it to oneshot.
--- drivers/crypto/s5p-sss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/crypto/s5p-sss.c +3 -2
@@ -664,8 +664,9 @@ static int s5p_aes_probe(struct platformdev_warn (dev,"feed control interrupt is not available.\n" ); goto err_irq; } - err =devm_request_irq (dev, pdata->irq_fc, s5p_aes_interrupt, -IRQF_SHARED , pdev->name, pdev); + err =devm_request_threaded_irq (dev, pdata->irq_fc,NULL , + s5p_aes_interrupt,IRQF_ONESHOT , + pdev->name, pdev);if (err <0 ) {dev_warn (dev,"feed control interrupt is not available.\n" ); goto err_irq;
Greg Kroah-Hartman
maintainerPATCH 65/105 i2c: riic: fix restart condition
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Brandt <[email protected]>
[ Upstream commit 2501c1bb054290679baad0ff7f4f07c714251f4c ]
While modifying the driver to use the STOP interrupt, the completion of the intermediate transfers need to wake the driver back up in order to initiate the next transfer (restart condition). Otherwise you get never ending interrupts and only the first transfer sent.
--- drivers/i2c/busses/i2c-riic.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-riic.c +5 -1
@@ -218,8 +218,12 @@ static irqreturn_t riic_tend_isr(int irq }if (riic->is_last || riic->err) { -riic_clear_set_bit (riic,0 ,ICIER_SPIE ,RIIC_ICIER ); +riic_clear_set_bit (riic,ICIER_TEIE ,ICIER_SPIE ,RIIC_ICIER );writeb (ICCR2_SP , riic->base +RIIC_ICCR2 ); + }else { +/* Transfer is complete, but do not send STOP */ +riic_clear_set_bit (riic,ICIER_TEIE ,0 ,RIIC_ICIER ); +complete (&riic->msg_done); }return IRQ_HANDLED ;
Greg Kroah-Hartman
maintainerPATCH 67/105 netfilter: dont track fragmented packets
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
[ Upstream commit 7b4fdf77a450ec0fdcb2f677b080ddbf2c186544 ]
Andrey reports syzkaller splat caused by
NF_CT_ASSERT(!ip_is_fragment(ip_hdr(skb)));
in ipv4 nat. But this assertion (and the comment) are wrong, this function does see fragments when IP_NODEFRAG setsockopt is used.
As conntrack doesn't track packets without complete l4 header, only the first fragment is tracked.
Because applying nat to first packet but not the rest makes no sense this also turns off tracking of all fragments.
--- net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c | 4 ++++ net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-)
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c +4 -0
@@ -158,6 +158,10 @@ static unsigned int ipv4_conntrack_localif (skb->len <sizeof (struct iphdr ) ||ip_hdrlen (skb) <sizeof (struct iphdr ))return NF_ACCEPT ; + +if (ip_is_fragment (ip_hdr (skb)))/* IP_NODEFRAG setsockopt set */ +return NF_ACCEPT ; +return nf_conntrack_in (state->net,PF_INET , state->hook, skb); }
net/ipv4/netfilter/nf_nat_l3proto_ipv4.c +0 -5
@@ -268,11 +268,6 @@ nf_nat_ipv4_fn(void *priv, struct sk_buf/* maniptype == SRC for postrouting. */ enum nf_nat_manip_type maniptype =HOOK2MANIP (state->hook); -/* We never see fragments: conntrack defrags on pre-routing -* and local-out, and nf_nat_out protects post-routing. -*/ -NF_CT_ASSERT (!ip_is_fragment (ip_hdr (skb))); - ct =nf_ct_get (skb, &ctinfo);/* Can't track? It's not due to stress, or conntrack would * have dropped it. Hence it's the user's responsibilty to
Greg Kroah-Hartman
maintainerPATCH 68/105 axonram: Fix gendisk handling
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jan Kara <[email protected]>
[ Upstream commit 672a2c87c83649fb0167202342ce85af9a3b4f1c ]
It is invalid to call del_gendisk() when disk->queue is NULL. Fix error handling in axon_ram_probe() to avoid doing that.
Also del_gendisk() does not drop a reference to gendisk allocated by alloc_disk(). That has to be done by put_disk(). Add that call where needed.
--- arch/powerpc/sysdev/axonram.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/powerpc/sysdev/axonram.c +4 -1
@@ -276,7 +276,9 @@ failed:if (bank->disk->major >0 )unregister_blkdev (bank->disk->major, bank->disk->disk_name); -del_gendisk (bank->disk); +if (bank->disk->flags &GENHD_FL_UP ) +del_gendisk (bank->disk); +put_disk (bank->disk); } device->dev.platform_data =NULL ;if (bank->io_addr !=0 )
@@ -301,6 +303,7 @@ axon_ram_remove(struct platform_device *device_remove_file (&device->dev, &dev_attr_ecc);free_irq (bank->irq_id, device);del_gendisk (bank->disk); +put_disk (bank->disk);iounmap ((void __iomem *) bank->io_addr);kfree (bank);
Greg Kroah-Hartman
maintainerPATCH 73/105 kbuild: pkg: use --transform option to prefix paths in tar
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Masahiro Yamada <[email protected]>
[ Upstream commit 2dbc644ac62bbcb9ee78e84719953f611be0413d ]
For rpm-pkg and deb-pkg, a source tar file is created. All paths in the archive must be prefixed with the base name of the tar so that everything is contained in the directory when you extract it.
Currently, scripts/package/Makefile uses a symlink for that, and removes it after the tar is created.
If you terminate the build during the tar creation, the symlink is left over. Then, at the next package build, you will see a warning like follows:
ln: '.' and 'kernel-4.14.0+/.' are the same file
It is possible to fix it by adding -n (--no-dereference) option to the "ln" command, but a cleaner way is to use --transform option of "tar" command. This option is GNU extension, but it should not hurt to use it in the Linux build system.
The 'S' flag is needed to exclude symlinks from the path fixup. Without it, symlinks in the kernel are broken.
--- scripts/package/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
scripts/package/Makefile +2 -3
@@ -39,10 +39,9 @@ if test "$(objtree)" != "$(srctree)"; th false; \ fi ; \ $(srctree)/scripts/setlocalversion --save-scmversion; \ -ln -sf $(srctree) $(2); \ tar -cz $(RCS_TAR_IGNORE) -f $(2).tar.gz \ - $(addprefix $(2)/,$(TAR_CONTENT) $(3)); \ -rm -f $(2) $(objtree)/.scmversion + --transform 's:^:$(2)/:S' $(TAR_CONTENT) $(3); \ +rm -f $(objtree)/.scmversion # rpm-pkg # ---------------------------------------------------------------------------
Greg Kroah-Hartman
maintainerPATCH 80/105 sunrpc: Fix rpc_task_begin trace point
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chuck Lever <[email protected]>
[ Upstream commit b2bfe5915d5fe7577221031a39ac722a0a2a1199 ]
The rpc_task_begin trace point always display a task ID of zero. Move the trace point call site so that it picks up the new task ID.
--- net/sunrpc/sched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/sunrpc/sched.c +1 -2
@@ -273,10 +273,9 @@ static inline void rpc_task_set_debuginfstatic void rpc_set_active (struct rpc_task *task) { -trace_rpc_task_begin (task->tk_client, task,NULL ); -rpc_task_set_debuginfo (task);set_bit (RPC_TASK_ACTIVE , &task->tk_runstate); +trace_rpc_task_begin (task->tk_client, task,NULL ); }/*
Greg Kroah-Hartman
maintainerPATCH 83/105 sctp: do not free asoc when it is already dead in sctp_sendmsg
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xin Long <[email protected]>
[ Upstream commit ca3af4dd28cff4e7216e213ba3b671fbf9f84758 ]
Now in sctp_sendmsg sctp_wait_for_sndbuf could schedule out without holding sock sk. It means the current asoc can be freed elsewhere, like when receiving an abort packet.
If the asoc is just created in sctp_sendmsg and sctp_wait_for_sndbuf returns err, the asoc will be freed again due to new_asoc is not nil. An use-after-free issue would be triggered by this.
This patch is to fix it by setting new_asoc with nil if the asoc is already dead when cpu schedules back, so that it will not be freed again in sctp_sendmsg.
v1->v2:
set new_asoc as nil in sctp_sendmsg instead of sctp_wait_for_sndbuf.
--- net/sctp/socket.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
net/sctp/socket.c +14 -3
@@ -1954,8 +1954,14 @@ static int sctp_sendmsg(struct sock *sk, timeo =sock_sndtimeo (sk, msg->msg_flags &MSG_DONTWAIT );if (!sctp_wspace (asoc)) { err =sctp_wait_for_sndbuf (asoc, &timeo, msg_len); -if (err) +if (err) { +if (err == -ESRCH ) { +/* asoc is already dead. */ + new_asoc =NULL ; + err = -EPIPE ; + } goto out_free; + } }/* If an address is passed with the sendto/sendmsg call, it is used
@@ -6992,10 +6998,11 @@ static int sctp_wait_for_sndbuf(struct sfor (;;) {prepare_to_wait_exclusive (&asoc->wait, &wait,TASK_INTERRUPTIBLE ); +if (asoc->base.dead) + goto do_dead;if (!*timeo_p) goto do_nonblock; -if (sk->sk_err || asoc->state >=SCTP_STATE_SHUTDOWN_PENDING || - asoc->base.dead) +if (sk->sk_err || asoc->state >=SCTP_STATE_SHUTDOWN_PENDING ) goto do_error;if (signal_pending (current)) goto do_interrupted;
@@ -7020,6 +7027,10 @@ out:return err; +do_dead: + err = -ESRCH ; + goto out; + do_error: err = -EPIPE ; goto out;
Greg Kroah-Hartman
maintainerPATCH 84/105 sctp: use the right sk after waking up from wait_buf sleep
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xin Long <[email protected]>
[ Upstream commit cea0cc80a6777beb6eb643d4ad53690e1ad1d4ff ]
Commit dfcb9f4f99f1 ("sctp: deny peeloff operation on asocs with threads sleeping on it") fixed the race between peeloff and wait sndbuf by checking waitqueue_active(&asoc->wait) in sctp_do_peeloff().
But it actually doesn't work, as even if waitqueue_active returns false the waiting sndbuf thread may still not yet hold sk lock. After asoc is peeled off, sk is not asoc->base.sk any more, then to hold the old sk lock couldn't make assoc safe to access.
This patch is to fix this by changing to hold the new sk lock if sk is not asoc->base.sk, meanwhile, also set the sk in sctp_sendmsg with the new sk.
With this fix, there is no more race between peeloff and waitbuf, the check 'waitqueue_active' in sctp_do_peeloff can be removed.
Thanks Marcelo and Neil for making this clear.
v1->v2:
fix it by changing to lock the new sock instead of adding a flag in asoc.
--- net/sctp/socket.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
net/sctp/socket.c +11 -10
@@ -82,8 +82,8 @@/* Forward declarations for internal helper functions. */ static int sctp_writeable (struct sock *sk);static void sctp_wfree (struct sk_buff *skb); -static int sctp_wait_for_sndbuf (struct sctp_association *,long *timeo_p, -size_t msg_len); +static int sctp_wait_for_sndbuf (struct sctp_association *asoc,long *timeo_p, +size_t msg_len,struct sock **orig_sk);static int sctp_wait_for_packet (struct sock *sk,int *err,long *timeo_p);static int sctp_wait_for_connect (struct sctp_association *,long *timeo_p);static int sctp_wait_for_accept (struct sock *sk,long timeo);
@@ -1953,7 +1953,8 @@ static int sctp_sendmsg(struct sock *sk, timeo =sock_sndtimeo (sk, msg->msg_flags &MSG_DONTWAIT );if (!sctp_wspace (asoc)) { - err =sctp_wait_for_sndbuf (asoc, &timeo, msg_len); +/* sk can be changed by peel off when waiting for buf. */ + err =sctp_wait_for_sndbuf (asoc, &timeo, msg_len, &sk);if (err) {if (err == -ESRCH ) {/* asoc is already dead. */
@@ -4466,12 +4467,6 @@ int sctp_do_peeloff(struct sock *sk, sctif (!asoc)return -EINVAL ; -/* If there is a thread waiting on more sndbuf space for -* sending on this asoc, it cannot be peeled. -*/ -if (waitqueue_active (&asoc->wait)) -return -EBUSY ; -/* An association cannot be branched off from an already peeled-off * socket, nor is this supported for tcp style sockets. */
@@ -6981,7 +6976,7 @@ void sctp_sock_rfree(struct sk_buff *skb/* Helper function to wait for space in the sndbuf. */ static int sctp_wait_for_sndbuf (struct sctp_association *asoc,long *timeo_p, -size_t msg_len) +size_t msg_len,struct sock **orig_sk) {struct sock *sk = asoc->base.sk;int err =0 ;
@@ -7015,11 +7010,17 @@ static int sctp_wait_for_sndbuf(struct srelease_sock (sk); current_timeo =schedule_timeout (current_timeo);lock_sock (sk); +if (sk != asoc->base.sk) { +release_sock (sk); + sk = asoc->base.sk; +lock_sock (sk); + } *timeo_p = current_timeo; } out: + *orig_sk = sk;finish_wait (&asoc->wait, &wait);/* Release the association's refcnt. */
Greg Kroah-Hartman
maintainerPATCH 85/105 atm: horizon: Fix irq release error
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Arvind Yadav <[email protected]>
[ Upstream commit bde533f2ea607cbbbe76ef8738b36243939a7bc2 ]
atm_dev_register() can fail here and passed parameters to free irq which is not initialised. Initialization of 'dev->irq' happened after the 'goto out_free_irq'. So using 'irq' insted of 'dev->irq' in free_irq().
--- drivers/atm/horizon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/atm/horizon.c +1 -1
@@ -2804,7 +2804,7 @@ out:return err; out_free_irq: -free_irq (dev->irq, dev); +free_irq (irq, dev); out_free:kfree (dev); out_release:
Greg Kroah-Hartman
maintainerPATCH 87/105 xfrm: Copy policy family in clone_policy
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Herbert Xu <[email protected]>
[ Upstream commit 0e74aa1d79a5bbc663e03a2804399cae418a0321 ]
The syzbot found an ancient bug in the IPsec code. When we cloned a socket policy (for example, for a child TCP socket derived from a listening socket), we did not copy the family field. This results in a live policy with a zero family field. This triggers a BUG_ON check in the af_key code when the cloned policy is retrieved.
This patch fixes it by copying the family field over.
--- net/xfrm/xfrm_policy.c | 1 + 1 file changed, 1 insertion(+)
net/xfrm/xfrm_policy.c +1 -0
@@ -1361,6 +1361,7 @@ static struct xfrm_policy *clone_policy( newp->xfrm_nr = old->xfrm_nr; newp->index = old->index; newp->type = old->type; + newp->family = old->family;memcpy (newp->xfrm_vec, old->xfrm_vec, newp->xfrm_nr*sizeof (struct xfrm_tmpl ));write_lock_bh (&net->xfrm.xfrm_policy_lock);
Greg Kroah-Hartman
maintainerPATCH 88/105 IB/mlx4: Increase maximal message size under UD QP
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Bloch <[email protected]>
[ Upstream commit 5f22a1d87c5315a98981ecf93cd8de226cffe6ca ]
Maximal message should be used as a limit to the max message payload allowed, without the headers. The ConnectX-3 check is done against this value includes the headers. When the payload is 4K this will cause the NIC to drop packets.
Increase maximal message to 8K as workaround, this shouldn't change current behaviour because we continue to set the MTU to 4k.
To reproduce;
set MTU to 4296 on the corresponding interface, for example:
ifconfig eth0 mtu 4296 (both server and client)
On server:ib_send_bw -c UD -d mlx4_0 -s 4096 -n 1000000 -i1 -m 4096
On client:ib_send_bw -d mlx4_0 -c UD <server_ip> -s 4096 -n 1000000 -i 1 -m 4096
--- drivers/infiniband/hw/mlx4/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx4/qp.c +1 -1
@@ -1564,7 +1564,7 @@ static int __mlx4_ib_modify_qp(struct ib context->mtu_msgmax = (IB_MTU_4096 <<5 ) |ilog2 (dev->dev->caps.max_gso_sz); else - context->mtu_msgmax = (IB_MTU_4096 << 5) | 12; + context->mtu_msgmax = (IB_MTU_4096 << 5) | 13; }else if (attr_mask &IB_QP_PATH_MTU ) {if (attr->path_mtu <IB_MTU_256 || attr->path_mtu >IB_MTU_4096 ) { pr_err("path MTU (%u) is invalid\n",
Greg Kroah-Hartman
maintainerPATCH 91/105 ipvlan: fix ipv6 outbound device
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Keefe Liu <[email protected]>
[ Upstream commit ca29fd7cce5a6444d57fb86517589a1a31c759e1 ]
When process the outbound packet of ipv6, we should assign the master device to output device other than input device.
--- drivers/net/ipvlan/ipvlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipvlan/ipvlan_core.c +1 -1
@@ -388,7 +388,7 @@ static int ipvlan_process_v6_outbound(ststruct dst_entry *dst;int err, ret =NET_XMIT_DROP ;struct flowi6 fl6 = { - .flowi6_iif = dev->ifindex, + .flowi6_oif = dev->ifindex, .daddr = ip6h->daddr, .saddr = ip6h->saddr, .flowi6_flags =FLOWI_FLAG_ANYSRC ,
Greg Kroah-Hartman
maintainerPATCH 92/105 audit: ensure that audit=1 actually enables audit for PID 1
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Paul Moore <[email protected]>
[ Upstream commit 173743dd99a49c956b124a74c8aacb0384739a4c ]
Prior to this patch we enabled audit in audit_init(), which is too late for PID 1 as the standard initcalls are run after the PID 1 task is forked. This means that we never allocate an audit_context (see audit_alloc()) for PID 1 and therefore miss a lot of audit events generated by PID 1.
This patch enables audit as early as possible to help ensure that when PID 1 is forked it can allocate an audit_context if required.
--- kernel/audit.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
kernel/audit.c +5 -5
@@ -80,13 +80,13 @@ static int audit_initialized;#define AUDIT_OFF 0#define AUDIT_ON 1#define AUDIT_LOCKED 2 -u32 audit_enabled; -u32 audit_ever_enabled; +u32 audit_enabled =AUDIT_OFF ; +u32 audit_ever_enabled = !!AUDIT_OFF ;EXPORT_SYMBOL_GPL (audit_enabled);/* Default state when kernel boots without any parameters. */ -static u32 audit_default; +static u32 audit_default =AUDIT_OFF ;/* If auditing cannot proceed, audit_failure selects what happens. */ static u32 audit_failure =AUDIT_FAIL_PRINTK ;
@@ -1179,8 +1179,6 @@ static int __init audit_init(void)skb_queue_head_init (&audit_skb_queue);skb_queue_head_init (&audit_skb_hold_queue); audit_initialized =AUDIT_INITIALIZED ; - audit_enabled = audit_default; - audit_ever_enabled |= !!audit_default;audit_log (NULL ,GFP_KERNEL ,AUDIT_KERNEL ,"initialized" );
@@ -1197,6 +1195,8 @@ static int __init audit_enable(char *str audit_default = !!simple_strtol (str,NULL ,0 );if (!audit_default) audit_initialized =AUDIT_DISABLED ; + audit_enabled = audit_default; + audit_ever_enabled = !!audit_enabled;pr_info ("%s\n" , audit_default ?"enabled (after initialization)" :"disabled (until reboot)" );
Greg Kroah-Hartman
maintainerPATCH 93/105 ipmi: Stop timers before cleaning up the module
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Masamitsu Yamazaki <[email protected]>
commit 4f7f5551a760eb0124267be65763008169db7087 upstream.
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again. But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timerAs a result, before the timer set in start_new_msg() expires, the polling loop may see si_state becoming SI_NORMAL and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following. smi_timeout was called after smi_event_handler, kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start, as member of struct smi_info.
The flag is enabled immediately after initializing the timer and disabled immediately before waiting for timer deletion.
[Some fairly major changes went into the IPMI driver in 4.15, so this
required a backport as the code had changed and moved to a different file. The 4.14 version of this patch moved some code under an if statement and there was an API change causing it to not apply to 4.4-4.6.]
---
This is for kernel version 4.4-4.6 only. Code and API changes required backporting. There is another version for 4.7-4.13 and another for 4.14 coming, too. Bug was introduced in 4.4.
drivers/char/ipmi/ipmi_si_intf.c | 44 ++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 21 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +23 -21
@@ -239,6 +239,9 @@ struct smi_info {/* The timer for this si. */ struct timer_list si_timer; +/* This flag is set, if the timer can be set */ +bool timer_can_start; +/* This flag is set, if the timer is running (timer_pending() isn't enough) */ bool timer_running;
@@ -414,6 +417,8 @@ static enum si_sm_result start_next_msg(static void smi_mod_timer (struct smi_info *smi_info,unsigned long new_val) { +if (!smi_info->timer_can_start) +return ; smi_info->last_timeout_jiffies = jiffies;mod_timer (&smi_info->si_timer, new_val); smi_info->timer_running = true;
@@ -433,21 +438,18 @@ static void start_new_msg(struct smi_inf smi_info->handlers->start_transaction (smi_info->si_sm, msg, size); } -static void start_check_enables (struct smi_info *smi_info,bool start_timer) +static void start_check_enables (struct smi_info *smi_info) {unsigned char msg[2 ]; msg[0 ] = (IPMI_NETFN_APP_REQUEST <<2 ); msg[1 ] =IPMI_GET_BMC_GLOBAL_ENABLES_CMD ; -if (start_timer) -start_new_msg (smi_info, msg,2 ); -else - smi_info->handlers->start_transaction (smi_info->si_sm, msg,2 ); +start_new_msg (smi_info, msg,2 ); smi_info->si_state =SI_CHECKING_ENABLES ; } -static void start_clear_flags (struct smi_info *smi_info,bool start_timer) +static void start_clear_flags (struct smi_info *smi_info) {unsigned char msg[3 ];
@@ -456,10 +458,7 @@ static void start_clear_flags(struct smi msg[1 ] =IPMI_CLEAR_MSG_FLAGS_CMD ; msg[2 ] =WDT_PRE_TIMEOUT_INT ; -if (start_timer) -start_new_msg (smi_info, msg,3 ); -else - smi_info->handlers->start_transaction (smi_info->si_sm, msg,3 ); +start_new_msg (smi_info, msg,3 ); smi_info->si_state =SI_CLEARING_FLAGS ; }
@@ -494,11 +493,11 @@ static void start_getting_events(struct* Note that we cannot just use disable_irq(), since the interrupt may * be shared. */ -static inline bool disable_si_irq (struct smi_info *smi_info,bool start_timer) +static inline bool disable_si_irq (struct smi_info *smi_info) {if ((smi_info->irq) && (!smi_info->interrupt_disabled)) { smi_info->interrupt_disabled = true; -start_check_enables (smi_info, start_timer); +start_check_enables (smi_info);return true; }return false;
@@ -508,7 +507,7 @@ static inline bool enable_si_irq(struct {if ((smi_info->irq) && (smi_info->interrupt_disabled)) { smi_info->interrupt_disabled = false; -start_check_enables (smi_info, true); +start_check_enables (smi_info);return true; }return false;
@@ -526,7 +525,7 @@ static struct ipmi_smi_msg *alloc_msg_ha msg =ipmi_alloc_smi_msg ();if (!msg) { -if (!disable_si_irq (smi_info, true)) +if (!disable_si_irq (smi_info)) smi_info->si_state =SI_NORMAL ; }else if (enable_si_irq (smi_info)) {ipmi_free_smi_msg (msg);
@@ -542,7 +541,7 @@ static void handle_flags(struct smi_info/* Watchdog pre-timeout */ smi_inc_stat (smi_info, watchdog_pretimeouts); -start_clear_flags (smi_info, true); +start_clear_flags (smi_info); smi_info->msg_flags &= ~WDT_PRE_TIMEOUT_INT ;if (smi_info->intf)ipmi_smi_watchdog_pretimeout (smi_info->intf);
@@ -925,7 +924,7 @@ static enum si_sm_result smi_event_handl* disable and messages disabled. */ if (smi_info->supports_event_msg_buff || smi_info->irq) { -start_check_enables (smi_info, true); +start_check_enables (smi_info); }else { smi_info->curr_msg =alloc_msg_handle_irq (smi_info);if (!smi_info->curr_msg)
@@ -1232,6 +1231,7 @@ static int smi_start_processing(void/* Set up the timer that drives the interface. */ setup_timer (&new_smi->si_timer, smi_timeout, (long )new_smi); + new_smi->timer_can_start = true;smi_mod_timer (new_smi, jiffies +SI_TIMEOUT_JIFFIES );/* Try to claim any interrupts. */
@@ -3434,10 +3434,12 @@ static void check_for_broken_irqs(structcheck_set_rcv_irq (smi_info); } -static inline void wait_for_timer_and_thread (struct smi_info *smi_info) +static inline void stop_timer_and_thread (struct smi_info *smi_info) {if (smi_info->thread !=NULL )kthread_stop (smi_info->thread); + + smi_info->timer_can_start = false;if (smi_info->timer_running)del_timer_sync (&smi_info->si_timer); }
@@ -3635,7 +3637,7 @@ static int try_smi_init(struct smi_info* Start clearing the flags before we enable interrupts or the * timer to avoid racing with the timer. */ -start_clear_flags (new_smi, false); +start_clear_flags (new_smi);/* * IRQ is defined to be set when non-zero. req_events will
@@ -3713,7 +3715,7 @@ static int try_smi_init(struct smi_inforeturn 0 ; out_err_stop_timer: -wait_for_timer_and_thread (new_smi); +stop_timer_and_thread (new_smi); out_err: new_smi->interrupt_disabled = true;
@@ -3919,7 +3921,7 @@ static void cleanup_one_si(struct smi_in*/ if (to_clean->irq_cleanup) to_clean->irq_cleanup (to_clean); -wait_for_timer_and_thread (to_clean); +stop_timer_and_thread (to_clean);/* * Timeouts are stopped, now make sure the interrupts are off
@@ -3930,7 +3932,7 @@ static void cleanup_one_si(struct smi_inpoll (to_clean);schedule_timeout_uninterruptible (1 ); } -disable_si_irq (to_clean, false); +disable_si_irq (to_clean);while (to_clean->curr_msg || (to_clean->si_state !=SI_NORMAL )) {poll (to_clean);schedule_timeout_uninterruptible (1 );
Greg Kroah-Hartman
maintainerPATCH 95/105 more bio_map_user_iov() leak fixes
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Al Viro <[email protected]>
commit 2b04e8f6bbb196cab4b232af0f8d48ff2c7a8058 upstream.
we need to take care of failure exit as well - pages already in bio should be dropped by analogue of bio_unmap_pages(), since their refcounts had been bumped only once per reference in bio.
---
Fixed conflicts.
Intended for v4.4.y. Does not apply to v3.18.y or older kernels.
block/bio.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
block/bio.c +9 -5
@@ -1268,6 +1268,7 @@ struct bio *bio_map_user_iov(struct requint ret, offset;struct iov_iter i;struct iovec iov; +struct bio_vec *bvec;iov_for_each (iov, i, *iter) {unsigned long uaddr = (unsigned long ) iov.iov_base;
@@ -1312,7 +1313,12 @@ struct bio *bio_map_user_iov(struct requ ret =get_user_pages_fast (uaddr, local_nr_pages, (iter->type &WRITE ) !=WRITE , &pages[cur_page]); -if (ret < local_nr_pages) { +if (unlikely (ret < local_nr_pages)) { +for (j = cur_page; j < page_limit; j++) { +if (!pages[j]) +break ; +put_page (pages[j]); + } ret = -EFAULT ; goto out_unmap; }
@@ -1374,10 +1380,8 @@ struct bio *bio_map_user_iov(struct requreturn bio; out_unmap: -for (j =0 ; j < nr_pages; j++) { -if (!pages[j]) -break ; -page_cache_release (pages[j]); +bio_for_each_segment_all (bvec, bio, j) { +put_page (bvec->bv_page); } out:kfree (pages);
Greg Kroah-Hartman
maintainerPATCH 96/105 tipc: fix memory leak in tipc_accept_from_sock()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jon Maloy <[email protected]>
[ Upstream commit a7d5f107b4978e08eeab599ee7449af34d034053 ]
When the function tipc_accept_from_sock() fails to create an instance of struct tipc_subscriber it omits to free the already created instance of struct tipc_conn instance before it returns.
We fix that with this commit.
--- net/tipc/server.c | 1 + 1 file changed, 1 insertion(+)
net/tipc/server.c +1 -0
@@ -311,6 +311,7 @@ static int tipc_accept_from_sock(struct newcon->usr_data = s->tipc_conn_new (newcon->conid);if (!newcon->usr_data) {sock_release (newsock); +conn_put (newcon);return -ENOMEM ; }
Greg Kroah-Hartman
maintainerPATCH 98/105 sit: update frag_off info
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hangbin Liu <[email protected]>
[ Upstream commit f859b4af1c52493ec21173ccc73d0b60029b5b88 ]
After parsing the sit netlink change info, we forget to update frag_off in ipip6_tunnel_update(). Fix it by assigning frag_off with new value.
--- net/ipv6/sit.c | 1 + 1 file changed, 1 insertion(+)
net/ipv6/sit.c +1 -0
@@ -1093,6 +1093,7 @@ static void ipip6_tunnel_update(struct iipip6_tunnel_link (sitn, t); t->parms.iph.ttl = p->iph.ttl; t->parms.iph.tos = p->iph.tos; + t->parms.iph.frag_off = p->iph.frag_off;if (t->parms.link != p->link) { t->parms.link = p->link;ipip6_tunnel_bind_dev (t->dev);
Greg Kroah-Hartman
maintainerPATCH 99/105 packet: fix crash in fanout_demux_rollover()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mike Maloney <[email protected]>
syzkaller found a race condition fanout_demux_rollover() while removing a packet socket from a fanout group.
po->rollover is read and operated on during packet_rcv_fanout(), via fanout_demux_rollover(), but the pointer is currently cleared before the
synchronization in packet_release(). It is safer to delay the cleanup
until after synchronize_net() has been called, ensuring all calls to packet_rcv_fanout() for this socket have finished.
To further simplify synchronization around the rollover structure, set po->rollover in fanout_add() only if there are no errors. This removes the need for rcu in the struct and in the call to packet_getsockopt(..., PACKET_ROLLOVER_STATS, ...).
Crashing stack trace:
fanout_demux_rollover+0xb6/0x4d0 net/packet/af_packet.c:1392 packet_rcv_fanout+0x649/0x7c8 net/packet/af_packet.c:1487 dev_queue_xmit_nit+0x835/0xc10 net/core/dev.c:1953 xmit_one net/core/dev.c:2975 [inline] dev_hard_start_xmit+0x16b/0xac0 net/core/dev.c:2995 __dev_queue_xmit+0x17a4/0x2050 net/core/dev.c:3476 dev_queue_xmit+0x17/0x20 net/core/dev.c:3509 neigh_connected_output+0x489/0x720 net/core/neighbour.c:1379 neigh_output include/net/neighbour.h:482 [inline] ip6_finish_output2+0xad1/0x22a0 net/ipv6/ip6_output.c:120 ip6_finish_output+0x2f9/0x920 net/ipv6/ip6_output.c:146 NF_HOOK_COND include/linux/netfilter.h:239 [inline] ip6_output+0x1f4/0x850 net/ipv6/ip6_output.c:163 dst_output include/net/dst.h:459 [inline] NF_HOOK.constprop.35+0xff/0x630 include/linux/netfilter.h:250 mld_sendpack+0x6a8/0xcc0 net/ipv6/mcast.c:1660 mld_send_initial_cr.part.24+0x103/0x150 net/ipv6/mcast.c:2072 mld_send_initial_cr net/ipv6/mcast.c:2056 [inline] ipv6_mc_dad_complete+0x99/0x130 net/ipv6/mcast.c:2079 addrconf_dad_completed+0x595/0x970 net/ipv6/addrconf.c:4039 addrconf_dad_work+0xac9/0x1160 net/ipv6/addrconf.c:3971 process_one_work+0xbf0/0x1bc0 kernel/workqueue.c:2113 worker_thread+0x223/0x1990 kernel/workqueue.c:2247 kthread+0x35e/0x430 kernel/kthread.c:231 ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:432
--- net/packet/af_packet.c | 32 ++++++++++---------------------- net/packet/internal.h | 1 - 2 files changed, 10 insertions(+), 23 deletions(-)
net/packet/af_packet.c +10 -22
@@ -1665,7 +1665,6 @@ static int fanout_add(struct sock *sk, uatomic_long_set (&rollover->num,0 );atomic_long_set (&rollover->num_huge,0 );atomic_long_set (&rollover->num_failed,0 ); - po->rollover = rollover; } match =NULL ;
@@ -1710,6 +1709,8 @@ static int fanout_add(struct sock *sk, uif (atomic_read (&match->sk_ref) <PACKET_FANOUT_MAX ) {__dev_remove_pack (&po->prot_hook); po->fanout = match; + po->rollover = rollover; + rollover =NULL ;atomic_inc (&match->sk_ref);__fanout_link (sk, po); err =0 ;
@@ -1723,10 +1724,7 @@ static int fanout_add(struct sock *sk, u } out: -if (err && rollover) { -kfree_rcu (rollover, rcu); - po->rollover =NULL ; - } +kfree (rollover);mutex_unlock (&fanout_mutex);return err; }
@@ -1750,11 +1748,6 @@ static struct packet_fanout *fanout_relelist_del (&f->list); else f =NULL ; - -if (po->rollover) { -kfree_rcu (po->rollover, rcu); - po->rollover =NULL ; - } }mutex_unlock (&fanout_mutex);
@@ -2914,6 +2907,7 @@ static int packet_release(struct socketsynchronize_net ();if (f) { +kfree (po->rollover);fanout_release_data (f);kfree (f); }
@@ -3771,7 +3765,6 @@ static int packet_getsockopt(struct sockvoid *data = &val;union tpacket_stats_u st;struct tpacket_rollover_stats rstats; -struct packet_rollover *rollover;if (level !=SOL_PACKET )return -ENOPROTOOPT ;
@@ -3850,18 +3843,13 @@ static int packet_getsockopt(struct sock 0);break ;case PACKET_ROLLOVER_STATS : -rcu_read_lock (); - rollover =rcu_dereference (po->rollover); -if (rollover) { - rstats.tp_all =atomic_long_read (&rollover->num); - rstats.tp_huge =atomic_long_read (&rollover->num_huge); - rstats.tp_failed =atomic_long_read (&rollover->num_failed); - data = &rstats; - lv =sizeof (rstats); - } -rcu_read_unlock (); -if (!rollover) +if (!po->rollover)return -EINVAL ; + rstats.tp_all =atomic_long_read (&po->rollover->num); + rstats.tp_huge =atomic_long_read (&po->rollover->num_huge); + rstats.tp_failed =atomic_long_read (&po->rollover->num_failed); + data = &rstats; + lv =sizeof (rstats);break ;case PACKET_TX_HAS_OFF : val = po->tp_tx_has_off;
net/packet/internal.h +0 -1
@@ -92,7 +92,6 @@ struct packet_fanout {struct packet_rollover {int sock; -struct rcu_head rcu;atomic_long_t num;atomic_long_t num_huge;atomic_long_t num_failed;
Greg Kroah-Hartman
maintainerPATCH 101/105 Revert "x86/efi: Build our own page table structures"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kroah-Hartman <[email protected]>
This reverts commit 36e0f05afd4e1d09fd47936761a502aedbc50649 which is commit 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36 upstream.
Turns there was too many other issues with this patch to make it viable for the stable tree.
--- arch/x86/include/asm/efi.h | 1 arch/x86/platform/efi/efi.c | 39 ++++++++++------ arch/x86/platform/efi/efi_32.c | 5 -- arch/x86/platform/efi/efi_64.c | 97 ++++++----------------------------------- 4 files changed, 40 insertions(+), 102 deletions(-)
arch/x86/include/asm/efi.h +0 -1
@@ -136,7 +136,6 @@ extern void __init efi_memory_uc(u64 addextern void __init efi_map_region (efi_memory_desc_t *md);extern void __init efi_map_region_fixed (efi_memory_desc_t *md);extern void efi_sync_low_kernel_mappings (void ); -extern int __init efi_alloc_page_tables (void );extern int __init efi_setup_page_tables (unsigned long pa_memmap,unsigned num_pages);extern void __init efi_cleanup_page_tables (unsigned long pa_memmap,unsigned num_pages);extern void __init old_map_region (efi_memory_desc_t *md);
arch/x86/platform/efi/efi.c +25 -14
@@ -869,7 +869,7 @@ static void __init kexec_enter_virtual_m* This function will switch the EFI runtime services to virtual mode. * Essentially, we look through the EFI memmap and map every region that * has the runtime attribute bit set in its memory descriptor into the -* efi_pgd page table. +* ->trampoline_pgd page table using a top-down VA allocation scheme. * * The old method which used to update that memory descriptor with the * virtual address obtained from ioremap() is still supported when the
@@ -879,8 +879,8 @@ static void __init kexec_enter_virtual_m* * The new method does a pagetable switch in a preemption-safe manner * so that we're in a different address space when calling a runtime -* function. For function arguments passing we do copy the PUDs of the -* kernel page table into efi_pgd prior to each call. +* function. For function arguments passing we do copy the PGDs of the +* kernel page table into ->trampoline_pgd prior to each call. * * Specially for kexec boot, efi runtime maps in previous kernel should * be passed in via setup_data. In that case runtime ranges will be mapped
@@ -895,12 +895,6 @@ static void __init __efi_enter_virtual_m efi.systab =NULL ; -if (efi_alloc_page_tables ()) { -pr_err ("Failed to allocate EFI page tables\n" ); -clear_bit (EFI_RUNTIME_SERVICES , &efi.flags); -return ; - } -efi_merge_regions (); new_memmap =efi_map_regions (&count, &pg_shift);if (!new_memmap) {
@@ -960,11 +954,28 @@ static void __init __efi_enter_virtual_mefi_runtime_mkexec ();/* -* We mapped the descriptor array into the EFI pagetable above -* but we're not unmapping it here because if we're running in -* EFI mixed mode we need all of memory to be accessible when -* we pass parameters to the EFI runtime services in the -* thunking code. +* We mapped the descriptor array into the EFI pagetable above but we're +* not unmapping it here. Here's why: +* +* We're copying select PGDs from the kernel page table to the EFI page +* table and when we do so and make changes to those PGDs like unmapping +* stuff from them, those changes appear in the kernel page table and we +* go boom. +* +* From setup_real_mode(): +* +* ... +* trampoline_pgd[0] = init_level4_pgt[pgd_index(__PAGE_OFFSET)].pgd; +* +* In this particular case, our allocation is in PGD 0 of the EFI page +* table but we've copied that PGD from PGD[272] of the EFI page table: +* +* pgd_index(__PAGE_OFFSET = 0xffff880000000000) = 272 +* +* where the direct memory mapping in kernel space is. +* +* new_memmap's VA comes from that direct mapping and thus clearing it, +* it would get cleared in the kernel page table too. * * efi_cleanup_page_tables(__pa(new_memmap), 1 << pg_shift); */
arch/x86/platform/efi/efi_32.c +0 -5
@@ -38,11 +38,6 @@* say 0 - 3G. */ -int __init efi_alloc_page_tables (void ) -{ -return 0 ; -} -void efi_sync_low_kernel_mappings (void ) {}void __init efi_dump_pagetable (void ) {}int __init efi_setup_page_tables (unsigned long pa_memmap,unsigned num_pages)
arch/x86/platform/efi/efi_64.c +15 -82
143 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 102/105 Revert "x86/efi: Hoist page table switching code into efi_call_virt()"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kroah-Hartman <[email protected]>
This reverts commit b73adb60852034d84092d123b323196ca42529cd which is commit c9f2a9a65e4855b74d92cdad688f6ee4a1a323ff upstream.
Turns there was too many other issues with this patch to make it viable for the stable tree.
--- arch/x86/include/asm/efi.h | 25 -------------------- arch/x86/platform/efi/efi_64.c | 24 ++++++++++---------- arch/x86/platform/efi/efi_stub_64.S | 43 ++++++++++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+), 36 deletions(-)
arch/x86/include/asm/efi.h +0 -25
@@ -3,7 +3,6 @@#include <asm/fpu/api.h> #include <asm/pgtable.h> -#include <asm/tlb.h> /* * We map the EFI regions needed for runtime services non-contiguously,
@@ -65,17 +64,6 @@ extern u64 asmlinkage efi_call(void *fp, #define efi_call_phys(f, args...) efi_call((f), args) -/* -* Scratch space used for switching the pagetable in the EFI stub -*/ -struct efi_scratch { -u64 r15; -u64 prev_cr3; -pgd_t *efi_pgt; -bool use_pgd; -u64 phys_stack; -} __packed; -#define efi_call_virt (f, ...) \ ({ \ efi_status_t __s; \
@@ -83,20 +71,7 @@ struct efi_scratch {efi_sync_low_kernel_mappings (); \preempt_disable (); \__kernel_fpu_begin (); \ - \ -if (efi_scratch.use_pgd) { \ - efi_scratch.prev_cr3 =read_cr3 (); \ -write_cr3 ((unsigned long )efi_scratch.efi_pgt); \ -__flush_tlb_all (); \ - } \ - \ __s =efi_call ((void *)efi.systab->runtime->f, __VA_ARGS__); \ - \ -if (efi_scratch.use_pgd) { \ -write_cr3 (efi_scratch.prev_cr3); \ -__flush_tlb_all (); \ - } \ - \__kernel_fpu_end (); \preempt_enable (); \ __s; \
arch/x86/platform/efi/efi_64.c +13 -11
@@ -47,7 +47,16 @@*/ static u64 efi_va =EFI_VA_START ; -struct efi_scratch efi_scratch; +/* +* Scratch space used for switching the pagetable in the EFI stub +*/ +struct efi_scratch { +u64 r15; +u64 prev_cr3; +pgd_t *efi_pgt; +bool use_pgd; +u64 phys_stack; +} __packed;static void __init early_code_mapping_set_exec (int executable) {
@@ -74,11 +83,8 @@ pgd_t * __init efi_call_phys_prolog(voidint pgd;int n_pgds; -if (!efi_enabled (EFI_OLD_MEMMAP )) { - save_pgd = (pgd_t *)read_cr3 (); -write_cr3 ((unsigned long )efi_scratch.efi_pgt); - goto out; - } +if (!efi_enabled (EFI_OLD_MEMMAP )) +return NULL ;early_code_mapping_set_exec (1 );
@@ -90,7 +96,6 @@ pgd_t * __init efi_call_phys_prolog(void vaddress = (unsigned long )__va (pgd *PGDIR_SIZE );set_pgd (pgd_offset_k (pgd *PGDIR_SIZE ), *pgd_offset_k (vaddress)); } -out:__flush_tlb_all ();return save_pgd;
@@ -104,11 +109,8 @@ void __init efi_call_phys_epilog(pgd_t *int pgd_idx;int nr_pgds; -if (!efi_enabled (EFI_OLD_MEMMAP )) { -write_cr3 ((unsigned long )save_pgd); -__flush_tlb_all (); +if (!save_pgd)return ; - } nr_pgds =DIV_ROUND_UP ((max_pfn <<PAGE_SHIFT ) ,PGDIR_SIZE );
arch/x86/platform/efi/efi_stub_64.S +43 -0
57 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 103/105 Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kroah-Hartman <[email protected]>
This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream.
Turns there was too many other issues with this patch to make it viable for the stable tree.
--- arch/x86/mm/pageattr.c | 17 +++++++++++------ arch/x86/platform/efi/efi_64.c | 16 ++++++---------- 2 files changed, 17 insertions(+), 16 deletions(-)
arch/x86/mm/pageattr.c +11 -6
@@ -911,10 +911,15 @@ static void populate_pte(struct cpa_data pte =pte_offset_kernel (pmd, start);while (num_pages-- && start < end) { -set_pte (pte,pfn_pte (cpa->pfn, pgprot)); + +/* deal with the NX bit */ +if (!(pgprot_val (pgprot) & _PAGE_NX)) + cpa->pfn &= ~_PAGE_NX; + +set_pte (pte,pfn_pte (cpa->pfn >>PAGE_SHIFT , pgprot)); start +=PAGE_SIZE ; - cpa->pfn++; + cpa->pfn +=PAGE_SIZE ; pte++; } }
@@ -970,11 +975,11 @@ static int populate_pmd(struct cpa_data pmd =pmd_offset (pud, start); -set_pmd (pmd,__pmd (cpa->pfn <<PAGE_SHIFT | _PAGE_PSE | +set_pmd (pmd,__pmd (cpa->pfn | _PAGE_PSE |massage_pgprot (pmd_pgprot))); start +=PMD_SIZE ; - cpa->pfn +=PMD_SIZE >>PAGE_SHIFT ; + cpa->pfn +=PMD_SIZE ; cur_pages +=PMD_SIZE >>PAGE_SHIFT ; }
@@ -1043,11 +1048,11 @@ static int populate_pud(struct cpa_data* Map everything starting from the Gb boundary, possibly with 1G pages */ while (end - start >=PUD_SIZE ) { -set_pud (pud,__pud (cpa->pfn <<PAGE_SHIFT | _PAGE_PSE | +set_pud (pud,__pud (cpa->pfn | _PAGE_PSE |massage_pgprot (pud_pgprot))); start +=PUD_SIZE ; - cpa->pfn +=PUD_SIZE >>PAGE_SHIFT ; + cpa->pfn +=PUD_SIZE ; cur_pages +=PUD_SIZE >>PAGE_SHIFT ; pud++; }
arch/x86/platform/efi/efi_64.c +6 -10
@@ -143,7 +143,7 @@ void efi_sync_low_kernel_mappings(void)int __init efi_setup_page_tables (unsigned long pa_memmap,unsigned num_pages) { -unsigned long pfn, text; +unsigned long text;struct page *page;unsigned npages;pgd_t *pgd;
@@ -160,8 +160,7 @@ int __init efi_setup_page_tables(unsigne* and ident-map those pages containing the map before calling * phys_efi_set_virtual_address_map(). */ - pfn = pa_memmap >>PAGE_SHIFT ; -if (kernel_map_pages_in_pgd (pgd, pfn, pa_memmap, num_pages, _PAGE_NX)) { +if (kernel_map_pages_in_pgd (pgd, pa_memmap, pa_memmap, num_pages, _PAGE_NX)) {pr_err ("Error ident-mapping new memmap (0x%lx)!\n" , pa_memmap);return 1 ; }
@@ -186,9 +185,8 @@ int __init efi_setup_page_tables(unsigne npages = (_end - _text) >>PAGE_SHIFT ; text =__pa (_text); - pfn = text >>PAGE_SHIFT ; -if (kernel_map_pages_in_pgd (pgd, pfn, text, npages,0 )) { +if (kernel_map_pages_in_pgd (pgd, text >>PAGE_SHIFT , text, npages,0 )) {pr_err ("Failed to map kernel text 1:1\n" );return 1 ; }
@@ -206,14 +204,12 @@ void __init efi_cleanup_page_tables(unsistatic void __init __map_region (efi_memory_desc_t *md,u64 va) {pgd_t *pgd = (pgd_t *)__va (real_mode_header->trampoline_pgd); -unsigned long flags =0 ; -unsigned long pfn; +unsigned long pf =0 ;if (!(md->attribute &EFI_MEMORY_WB )) - flags |= _PAGE_PCD; + pf |= _PAGE_PCD; - pfn = md->phys_addr >>PAGE_SHIFT ; -if (kernel_map_pages_in_pgd (pgd, pfn, va, md->num_pages, flags)) +if (kernel_map_pages_in_pgd (pgd, md->phys_addr, va, md->num_pages, pf))pr_warn ("Error mapping PA 0x%llx -> VA 0x%llx!\n" , md->phys_addr, va); }
Greg Kroah-Hartman
maintainercover 4.4.106-stable review
This is the start of the stable review cycle for the 4.4.106 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Dec 17 09:22:39 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.106-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.4.106-rc1
Vincent Pelletier <[email protected]>
usb: gadget: ffs: Forbid usb_ep_alloc_request from sleeping
Marc Zyngier <[email protected]>
arm: KVM: Fix VTTBR_BADDR_MASK BUG_ON off-by-one
Greg Kroah-Hartman <[email protected]>
Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Greg Kroah-Hartman <[email protected]>
Revert "x86/efi: Hoist page table switching code into efi_call_virt()"
Greg Kroah-Hartman <[email protected]>
Revert "x86/efi: Build our own page table structures"
Eric Dumazet <[email protected]>
net/packet: fix a race in packet_bind() and packet_notifier()
Mike Maloney <[email protected]>
packet: fix crash in fanout_demux_rollover()
Hangbin Liu <[email protected]>
sit: update frag_off info
Håkon Bugge <[email protected]>
rds: Fix NULL pointer dereference in __rds_rdma_map
Jon Maloy <[email protected]>
tipc: fix memory leak in tipc_accept_from_sock()
Al Viro <[email protected]>
more bio_map_user_iov() leak fixes
Heiko Carstens <[email protected]>
s390: always save and restore all registers on context switch
Masamitsu Yamazaki <[email protected]>
ipmi: Stop timers before cleaning up the module
Paul Moore <[email protected]>
audit: ensure that 'audit=1' actually enables audit for PID 1
Keefe Liu <[email protected]>
ipvlan: fix ipv6 outbound device
David Howells <[email protected]>
afs: Connect up the CB.ProbeUuid
Majd Dibbiny <[email protected]>
IB/mlx5: Assign send CQ and recv CQ of UMR QP
Mark Bloch <[email protected]>
IB/mlx4: Increase maximal message size under UD QP
Herbert Xu <[email protected]>
xfrm: Copy policy family in clone_policy
Jason Baron <[email protected]>
jump_label: Invoke jump_label_test() via early_initcall()
Arvind Yadav <[email protected]>
atm: horizon: Fix irq release error
Xin Long <[email protected]>
sctp: use the right sk after waking up from wait_buf sleep
Xin Long <[email protected]>
sctp: do not free asoc when it is already dead in sctp_sendmsg
Pavel Tatashin <[email protected]>
sparc64/mm: set fields in deferred pages
Ming Lei <[email protected]>
block: wake up all tasks blocked in get_request()
Chuck Lever <[email protected]>
sunrpc: Fix rpc_task_begin trace point
Trond Myklebust <[email protected]>
NFS: Fix a typo in nfs_rename()
Randy Dunlap <[email protected]>
dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0
Stephen Bates <[email protected]>
lib/genalloc.c: make the avail variable an atomic_long_t
Xin Long <[email protected]>
route: update fnhe_expires for redirect when the fnhe exists
Xin Long <[email protected]>
route: also update fnhe_genid when updating a route cache
Ben Hutchings <[email protected]>
mac80211_hwsim: Fix memory leak in hwsim_new_radio_nl()
Masahiro Yamada <[email protected]>
kbuild: pkg: use --transform option to prefix paths in tar
Jérémy Lefaure <[email protected]>
EDAC, i5000, i5400: Fix definition of NRECMEMB register
Jérémy Lefaure <[email protected]>
EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro
Alexey Kardashevskiy <[email protected]>
powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requested
Jim Qu <[email protected]>
drm/amd/amdgpu: fix console deadlock if late init failed
Jan Kara <[email protected]>
axonram: Fix gendisk handling
Florian Westphal <[email protected]>
netfilter: don't track fragmented packets
Johannes Thumshirn <[email protected]>
zram: set physical queue limits to avoid array out of bounds accesses
Chris Brandt <[email protected]>
i2c: riic: fix restart condition
Krzysztof Kozlowski <[email protected]>
crypto: s5p-sss - Fix completing crypto request in IRQ handler
WANG Cong <[email protected]>
ipv6: reorder icmpv6_init() and ip6_mr_init()
Michal Schmidt <[email protected]>
bnx2x: do not rollback VF MAC/VLAN filters we did not configure
Michal Schmidt <[email protected]>
bnx2x: fix possible overrun of VFPF multicast addresses array
Michal Schmidt <[email protected]>
bnx2x: prevent crash when accessing PTP with interface down
Blomme, Maarten <[email protected]>
spi_ks8995: fix "BUG: key accdaa28 not in .data!"
Mark Rutland <[email protected]>
arm64: KVM: Survive unknown traps from guests
Mark Rutland <[email protected]>
arm: KVM: Survive unknown traps from guests
Wanpeng Li <[email protected]>
KVM: nVMX: reset nested_run_pending if the vCPU is going to be reset
Franck Demathieu <[email protected]>
irqchip/crossbar: Fix incorrect type of register size
James Smart <[email protected]>
scsi: lpfc: Fix crash during Hardware error recovery on SLI3 adapters
Tejun Heo <[email protected]>
workqueue: trigger WARN if queue_delayed_work() is called with NULL @wq
Tejun Heo <[email protected]>
libata: drop WARN from protocol error in ata_sff_qc_issue()
Jim Mattson <[email protected]>
kvm: nVMX: VMCLEAR should not cause the vCPU to shut down
Christophe JAILLET <[email protected]>
USB: gadgetfs: Fix a potential memory leak in 'dev_config()'
John Keeping <[email protected]>
usb: gadget: configs: plug memory leak
Daniel Drake <[email protected]>
HID: chicony: Add support for another ASUS Zen AiO keyboard
Phil Reid <[email protected]>
gpio: altera: Use handle_level_irq when configured as a level_high
Guenter Roeck <[email protected]>
ARM: OMAP2+: Release device node after it is no longer needed.
Guenter Roeck <[email protected]>
ARM: OMAP2+: Fix device node reference counts
David Daney <[email protected]>
module: set __jump_table alignment to 8
Sachin Sant <[email protected]>
selftest/powerpc: Fix false failures for skipped tests
Thomas Gleixner <[email protected]>
x86/hpet: Prevent might sleep splat on resume
Ladislav Michl <[email protected]>
ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure
Steffen Klassert <[email protected]>
vti6: Don't report path MTU below IPV6_MIN_MTU.
Sasha Levin <[email protected]>
Revert "s390/kbuild: enable modversions for symbols exported from asm"
Sasha Levin <[email protected]>
Revert "spi: SPI_FSL_DSPI should depend on HAS_DMA"
Sasha Levin <[email protected]>
Revert "drm/armada: Fix compile fail"
Kirill A. Shutemov <[email protected]>
mm: drop unused pmdp_huge_get_and_clear_notify()
Kirill A. Shutemov <[email protected]>
thp: fix MADV_DONTNEED vs. numa balancing race
Kirill A. Shutemov <[email protected]>
thp: reduce indentation level in change_huge_pmd()
Stephen Hemminger <[email protected]>
scsi: storvsc: Workaround for virtual DVD SCSI version
Russell King <[email protected]>
ARM: avoid faulting on qemu
Russell King <[email protected]>
ARM: BUG if jumping to usermode address in kernel mode
Dave Martin <[email protected]>
arm64: fpsimd: Prevent registers leaking from dead tasks
Andrew Honig <[email protected]>
KVM: VMX: remove I/O port 0x80 bypass on Intel hosts
Kristina Martsenko <[email protected]>
arm64: KVM: fix VTTBR_BADDR_MASK BUG_ON off-by-one
Laurent Caumont <[email protected]>
media: dvb: i2c transfers over usb cannot be done from stack
Marek Szyprowski <[email protected]>
drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU
Dave Gordon <[email protected]>
drm: extra printk() wrapper macros
Daniel Thompson <[email protected]>
kdb: Fix handling of kallsyms_symbol_next() return value
Heiko Carstens <[email protected]>
s390: fix compat system call table
Robin Murphy <[email protected]>
iommu/vt-d: Fix scatterlist offset handling
Jaejoong Kim <[email protected]>
ALSA: usb-audio: Add check return value for usb_string()
Jaejoong Kim <[email protected]>
ALSA: usb-audio: Fix out-of-bound error
Takashi Iwai <[email protected]>
ALSA: seq: Remove spurious WARN_ON() at timer check
Robb Glasser <[email protected]>
ALSA: pcm: prevent UAF in snd_pcm_info
Rafael J. Wysocki <[email protected]>
x86/PCI: Make broadcom_postcore_init() check acpi_disabled
Eric Biggers <[email protected]>
X.509: reject invalid BIT STRING for subjectPublicKey
Eric Biggers <[email protected]>
ASN.1: check for error from ASN1_OP_END__ACT actions
Eric Biggers <[email protected]>
ASN.1: fix out-of-bounds read when parsing indefinite length item
Greg Kroah-Hartman <[email protected]>
efi: Move some sysfs files to be read-only by root
Huacai Chen <[email protected]>
scsi: libsas: align sata_device's rps_resp on a cacheline
William Breathitt Gray <[email protected]>
isa: Prevent NULL dereference in isa_bus driver callbacks
Paul Meyer <[email protected]>
hv: kvp: Avoid reading past allocated blocks from KVP file
weiping zhang <[email protected]>
virtio: release virtio index when fail to device_register
Martin Kelly <[email protected]>
can: usb_8dev: cancel urb on -EPIPE and -EPROTO
Martin Kelly <[email protected]>
can: esd_usb2: cancel urb on -EPIPE and -EPROTO
Martin Kelly <[email protected]>
can: ems_usb: cancel urb on -EPIPE and -EPROTO
Martin Kelly <[email protected]>
can: kvaser_usb: cancel urb on -EPIPE and -EPROTO
Jimmy Assarsson <[email protected]>
can: kvaser_usb: ratelimit errors if incomplete messages are received
Jimmy Assarsson <[email protected]>
can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback()
Jimmy Assarsson <[email protected]>
can: kvaser_usb: free buf in error paths
Oliver Stäbler <[email protected]>
can: ti_hecc: Fix napi poll return value for repoll
-------------
Diffstat:
Makefile | 4 +- arch/arm/include/asm/assembler.h | 18 +++ arch/arm/include/asm/kvm_arm.h | 4 +- arch/arm/kernel/entry-header.S | 6 + arch/arm/kvm/handle_exit.c | 19 +-- arch/arm/mach-omap2/gpmc-onenand.c | 10 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 25 ++-- arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/kernel/process.c | 9 ++ arch/arm64/kvm/handle_exit.c | 19 +-- arch/powerpc/platforms/powernv/pci-ioda.c | 3 + arch/powerpc/sysdev/axonram.c | 5 +- arch/s390/include/asm/asm-prototypes.h | 8 -- arch/s390/include/asm/switch_to.h | 19 ++- arch/s390/kernel/syscalls.S | 6 +- arch/sparc/mm/init_64.c | 9 +- arch/x86/include/asm/efi.h | 26 ---- arch/x86/kernel/hpet.c | 2 +- arch/x86/kvm/vmx.c | 31 ++--- arch/x86/mm/pageattr.c | 17 ++- arch/x86/pci/broadcom_bus.c | 2 +- arch/x86/platform/efi/efi.c | 39 +++--- arch/x86/platform/efi/efi_32.c | 5 - arch/x86/platform/efi/efi_64.c | 137 ++++++---------------- arch/x86/platform/efi/efi_stub_64.S | 43 +++++++ block/bio.c | 14 ++- block/blk-core.c | 4 +- crypto/asymmetric_keys/x509_cert_parser.c | 2 + drivers/ata/libata-sff.c | 1 - drivers/atm/horizon.c | 2 +- drivers/base/isa.c | 10 +- drivers/block/zram/zram_drv.c | 2 + drivers/char/ipmi/ipmi_si_intf.c | 44 +++---- drivers/crypto/s5p-sss.c | 5 +- drivers/edac/i5000_edac.c | 8 +- drivers/edac/i5400_edac.c | 9 +- drivers/firmware/efi/efi.c | 3 +- drivers/firmware/efi/esrt.c | 15 +-- drivers/firmware/efi/runtime-map.c | 10 +- drivers/gpio/gpio-altera.c | 26 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +- drivers/gpu/drm/armada/Makefile | 2 - drivers/gpu/drm/exynos/exynos_drm_gem.c | 9 ++ drivers/hid/Kconfig | 4 +- drivers/hid/hid-chicony.c | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/i2c/busses/i2c-riic.c | 6 +- drivers/infiniband/hw/mlx4/qp.c | 2 +- drivers/infiniband/hw/mlx5/main.c | 2 + drivers/iommu/intel-iommu.c | 8 +- drivers/irqchip/irq-crossbar.c | 8 +- drivers/media/usb/dvb-usb/dibusb-common.c | 16 ++- drivers/memory/omap-gpmc.c | 4 +- drivers/net/can/ti_hecc.c | 3 + drivers/net/can/usb/ems_usb.c | 2 + drivers/net/can/usb/esd_usb2.c | 2 + drivers/net/can/usb/kvaser_usb.c | 13 +- drivers/net/can/usb/usb_8dev.c | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 20 +++- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 8 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 23 ++-- drivers/net/ipvlan/ipvlan_core.c | 2 +- drivers/net/phy/spi_ks8995.c | 1 + drivers/net/wireless/mac80211_hwsim.c | 5 +- drivers/scsi/lpfc/lpfc_els.c | 14 ++- drivers/scsi/storvsc_drv.c | 27 +++-- drivers/spi/Kconfig | 1 - drivers/usb/gadget/configfs.c | 1 + drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/legacy/inode.c | 4 +- drivers/virtio/virtio.c | 2 + fs/afs/cmservice.c | 3 + fs/nfs/dir.c | 2 +- include/drm/drmP.h | 26 +++- include/linux/genalloc.h | 3 +- include/linux/mmu_notifier.h | 13 -- include/linux/omap-gpmc.h | 5 +- include/linux/sysfs.h | 6 + include/scsi/libsas.h | 2 +- kernel/audit.c | 10 +- kernel/debug/kdb/kdb_io.c | 2 +- kernel/jump_label.c | 2 +- kernel/workqueue.c | 1 + lib/asn1_decoder.c | 49 ++++---- lib/dynamic_debug.c | 4 + lib/genalloc.c | 10 +- mm/huge_memory.c | 82 +++++++++---- net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c | 4 + net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 5 - net/ipv4/route.c | 14 ++- net/ipv6/af_inet6.c | 10 +- net/ipv6/ip6_vti.c | 8 +- net/ipv6/sit.c | 1 + net/packet/af_packet.c | 37 +++--- net/packet/internal.h | 1 - net/rds/rdma.c | 2 +- net/sctp/socket.c | 38 ++++-- net/sunrpc/sched.c | 3 +- net/tipc/server.c | 1 + net/xfrm/xfrm_policy.c | 1 + scripts/module-common.lds | 2 + scripts/package/Makefile | 5 +- sound/core/pcm.c | 2 + sound/core/seq/seq_timer.c | 2 +- sound/usb/mixer.c | 13 +- tools/hv/hv_kvp_daemon.c | 70 +++-------- tools/testing/selftests/powerpc/harness.c | 6 +- 109 files changed, 701 insertions(+), 570 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 104/105 arm: KVM: Fix VTTBR_BADDR_MASK BUG_ON off-by-one
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marc Zyngier <[email protected]>
commit 5553b142be11e794ebc0805950b2e8313f93d718 upstream.
VTTBR_BADDR_MASK is used to sanity check the size and alignment of the VTTBR address. It seems to currently be off by one, thereby only allowing up to 39-bit addresses (instead of 40-bit) and also insufficiently checking the alignment. This patch fixes it.
This patch is the 32bit pendent of Kristina's arm64 fix, and she deserves the actual kudos for pinpointing that one.
--- arch/arm/include/asm/kvm_arm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/include/asm/kvm_arm.h +1 -2
@@ -161,8 +161,7 @@#else #define VTTBR_X (5 - KVM_T0SZ)#endif -#define VTTBR_BADDR_SHIFT (VTTBR_X - 1) -#define VTTBR_BADDR_MASK (((1LLU << (40 - VTTBR_X)) - 1) << VTTBR_BADDR_SHIFT) +#define VTTBR_BADDR_MASK (((1LLU << (40 - VTTBR_X)) - 1) << VTTBR_X)#define VTTBR_VMID_SHIFT (48LLU)#define VTTBR_VMID_MASK (0xffLLU << VTTBR_VMID_SHIFT)
Greg Kroah-Hartman
maintainerPATCH 105/105 usb: gadget: ffs: Forbid usb_ep_alloc_request from sleeping
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vincent Pelletier <[email protected]>
commit 30bf90ccdec1da9c8198b161ecbff39ce4e5a9ba upstream.
Found using DEBUG_ATOMIC_SLEEP while submitting an AIO read operation:
[ 100.853642] BUG: sleeping function called from invalid context at mm/slab.h:421
[ 100.861148] in_atomic(): 1, irqs_disabled(): 1, pid: 1880, name: python
[ 100.867954] 2 locks held by python/1880:
[ 100.867961] #0: (&epfile->mutex){....}, at: [<f8188627>] ffs_mutex_lock+0x27/0x30 [usb_f_fs]
[ 100.868020] #1: (&(&ffs->eps_lock)->rlock){....}, at: [<f818ad4b>] ffs_epfile_io.isra.17+0x24b/0x590 [usb_f_fs]
[ 100.868076] CPU: 1 PID: 1880 Comm: python Not tainted 4.14.0-edison+ #118
[ 100.868085] Hardware name: Intel Corporation Merrifield/BODEGA BAY, BIOS 542 2015.01.21:18.19.48
[ 100.868093] Call Trace:
[ 100.868122] dump_stack+0x47/0x62
[ 100.868156] ___might_sleep+0xfd/0x110
[ 100.868182] __might_sleep+0x68/0x70
[ 100.868217] kmem_cache_alloc_trace+0x4b/0x200
[ 100.868248] ? dwc3_gadget_ep_alloc_request+0x24/0xe0 [dwc3]
[ 100.868302] dwc3_gadget_ep_alloc_request+0x24/0xe0 [dwc3]
[ 100.868343] usb_ep_alloc_request+0x16/0xc0 [udc_core]
[ 100.868386] ffs_epfile_io.isra.17+0x444/0x590 [usb_f_fs]
[ 100.868424] ? _raw_spin_unlock_irqrestore+0x27/0x40
[ 100.868457] ? kiocb_set_cancel_fn+0x57/0x60
[ 100.868477] ? ffs_ep0_poll+0xc0/0xc0 [usb_f_fs]
[ 100.868512] ffs_epfile_read_iter+0xfe/0x157 [usb_f_fs]
[ 100.868551] ? security_file_permission+0x9c/0xd0
[ 100.868587] ? rw_verify_area+0xac/0x120
[ 100.868633] aio_read+0x9d/0x100
[ 100.868692] ? __fget+0xa2/0xd0
[ 100.868727] ? __might_sleep+0x68/0x70
[ 100.868763] SyS_io_submit+0x471/0x680
[ 100.868878] do_int80_syscall_32+0x4e/0xd0
[ 100.868921] entry_INT80_32+0x2a/0x2a
[ 100.868932] EIP: 0xb7fbb676
[ 100.868941] EFLAGS: 00000292 CPU: 1
[ 100.868951] EAX: ffffffda EBX: b7aa2000 ECX: 00000002 EDX: b7af8368
[ 100.868961] ESI: b7fbb660 EDI: b7aab000 EBP: bfb6c658 ESP: bfb6c638
[ 100.868973] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b--- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/function/f_fs.c +1 -1
@@ -791,7 +791,7 @@ static ssize_t ffs_epfile_io(struct file }if (io_data->aio) { - req =usb_ep_alloc_request (ep->ep,GFP_KERNEL ); + req =usb_ep_alloc_request (ep->ep,GFP_ATOMIC );if (unlikely (!req)) goto error_lock;
Greg Kroah-Hartman
maintainerPATCH 10/105 hv: kvp: Avoid reading past allocated blocks from KVP file
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Paul Meyer <[email protected]>
commit 297d6b6e56c2977fc504c61bbeeaa21296923f89 upstream.
While reading in more than one block (50) of KVP records, the allocation goes per block, but the reads used the total number of allocated records (without resetting the pointer/stream). This causes the records buffer to overrun when the refresh reads more than one block over the previous capacity (e.g. reading more than 100 KVP records whereas the in-memory database was empty before).
Fix this by reading the correct number of KVP records from file each time.
--- tools/hv/hv_kvp_daemon.c | 70 +++++++++-------------------------------------- 1 file changed, 14 insertions(+), 56 deletions(-)
tools/hv/hv_kvp_daemon.c +14 -56
@@ -193,11 +193,14 @@ static void kvp_update_mem_state(int poofor (;;) { readp = &record[records_read]; records_read +=fread (readp,sizeof (struct kvp_record ), -ENTRIES_PER_BLOCK * num_blocks, - filep); +ENTRIES_PER_BLOCK * num_blocks - records_read, + filep);if (ferror (filep)) { -syslog (LOG_ERR ,"Failed to read file, pool: %d" , pool); +syslog (LOG_ERR , +"Failed to read file, pool: %d; error: %d %s" , + pool, errno,strerror (errno)); +kvp_release_lock (pool);exit (EXIT_FAILURE ); }
@@ -210,6 +213,7 @@ static void kvp_update_mem_state(int pooif (record ==NULL ) {syslog (LOG_ERR ,"malloc failed" ); +kvp_release_lock (pool);exit (EXIT_FAILURE ); }continue ;
@@ -224,15 +228,11 @@ static void kvp_update_mem_state(int poofclose (filep);kvp_release_lock (pool); } +static int kvp_file_init (void ) {int fd; -FILE *filep; -size_t records_read;char *fname; -struct kvp_record *record; -struct kvp_record *readp; -int num_blocks;int i;int alloc_unit =sizeof (struct kvp_record ) *ENTRIES_PER_BLOCK ;
@@ -246,61 +246,19 @@ static int kvp_file_init(void)for (i =0 ; i <KVP_POOL_COUNT ; i++) { fname = kvp_file_info[i].fname; - records_read =0 ; - num_blocks =1 ;sprintf (fname,"%s/.kvp_pool_%d" ,KVP_CONFIG_LOC , i); fd =open (fname,O_RDWR |O_CREAT |O_CLOEXEC ,0644 /* rw-r--r-- */ );if (fd ==-1 )return 1 ; - - filep =fopen (fname,"re" ); -if (!filep) { -close (fd); -return 1 ; - } - - record =malloc (alloc_unit * num_blocks); -if (record ==NULL ) { -fclose (filep); -close (fd); -return 1 ; - } -for (;;) { - readp = &record[records_read]; - records_read +=fread (readp,sizeof (struct kvp_record ), -ENTRIES_PER_BLOCK , - filep); - -if (ferror (filep)) { -syslog (LOG_ERR ,"Failed to read file, pool: %d" , - i); -exit (EXIT_FAILURE ); - } - -if (!feof (filep)) { -/* -* We have more data to read. -*/ - num_blocks++; - record =realloc (record, alloc_unit * - num_blocks); -if (record ==NULL ) { -fclose (filep); -close (fd); -return 1 ; - } -continue ; - } -break ; - } kvp_file_info[i].fd = fd; - kvp_file_info[i].num_blocks = num_blocks; - kvp_file_info[i].records = record; - kvp_file_info[i].num_records = records_read; -fclose (filep); - + kvp_file_info[i].num_blocks =1 ; + kvp_file_info[i].records =malloc (alloc_unit); +if (kvp_file_info[i].records ==NULL ) +return 1 ; + kvp_file_info[i].num_records =0 ; +kvp_update_mem_state (i); }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 12/105 scsi: libsas: align sata_devices rps_resp on a cacheline
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Huacai Chen <[email protected]>
commit c2e8fbf908afd81ad502b567a6639598f92c9b9d upstream.
The rps_resp buffer in ata_device is a DMA target, but it isn't explicitly cacheline aligned. Due to this, adjacent fields can be overwritten with stale data from memory on non-coherent architectures. As a result, the kernel is sometimes unable to communicate with an SATA device behind a SAS expander.
Fix this by ensuring that the rps_resp buffer is cacheline aligned.
This issue is similar to that fixed by Commit 84bda12af31f93 ("libata:
align ap->sector_buf") and Commit 4ee34ea3a12396f35b26 ("libata: Align ata_device's id on a cacheline").
--- include/scsi/libsas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/scsi/libsas.h +1 -1
@@ -165,11 +165,11 @@ struct expander_device {struct sata_device {unsigned int class; -struct smp_resp rps_resp;/* report_phy_sata_resp */ u8 port_no;/* port number, if this is a PM (Port) */ struct ata_port *ap;struct ata_host ata_host; +struct smp_resp rps_resp____cacheline_aligned ;/* report_phy_sata_resp */ u8 fis[ATA_RESP_FIS_SIZE ]; };
Greg Kroah-Hartman
maintainerPATCH 17/105 x86/PCI: Make broadcom_postcore_init() check acpi_disabled
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rafael J. Wysocki <[email protected]>
commit ddec3bdee05b06f1dda20ded003c3e10e4184cab upstream.
acpi_os_get_root_pointer() may return a valid address even if acpi_disabled is set, but the host bridge information from the ACPI tables is not going to be used in that case and the Broadcom host bridge initialization should not be skipped then, So make broadcom_postcore_init() check acpi_disabled too to avoid this issue.
--- arch/x86/pci/broadcom_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/pci/broadcom_bus.c +1 -1
@@ -97,7 +97,7 @@ static int __init broadcom_postcore_init* We should get host bridge information from ACPI unless the BIOS * doesn't support it. */ -if (acpi_os_get_root_pointer ()) +if (!acpi_disabled &&acpi_os_get_root_pointer ())return 0 ;#endif
Greg Kroah-Hartman
maintainerPATCH 19/105 ALSA: seq: Remove spurious WARN_ON() at timer check
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Takashi Iwai <[email protected]>
commit 43a3542870328601be02fcc9d27b09db467336ef upstream.
The use of snd_BUG_ON() in ALSA sequencer timer may lead to a spurious WARN_ON() when a slave timer is deployed as its backend and a corresponding master timer stops meanwhile. The symptom was triggered by syzkaller spontaneously.
Since the NULL timer is valid there, rip off snd_BUG_ON().
--- sound/core/seq/seq_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/seq/seq_timer.c +1 -1
@@ -355,7 +355,7 @@ static int initialize_timer(struct snd_sunsigned long freq; t = tmr->timeri->timer; -if (snd_BUG_ON (!t)) +if (!t)return -EINVAL ; freq = tmr->preferred_resolution;
Greg Kroah-Hartman
maintainerPATCH 20/105 ALSA: usb-audio: Fix out-of-bound error
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jaejoong Kim <[email protected]>
commit 251552a2b0d454badc8f486e6d79100970c744b0 upstream.
The snd_usb_copy_string_desc() retrieves the usb string corresponding to the index number through the usb_string(). The problem is that the usb_string() returns the length of the string (>= 0) when successful, but it can also return a negative value about the error case or status of usb_control_msg().
If iClockSource is '0' as shown below, usb_string() will returns -EINVAL. This will result in '0' being inserted into buf[-22], and the following KASAN out-of-bound error message will be output.
AudioControl Interface Descriptor:
bLength 8
bDescriptorType 36
bDescriptorSubtype 10 (CLOCK_SOURCE)
bClockID 1
bmAttributes 0x07 Internal programmable Clock (synced to SOF)
bmControls 0x07
Clock Frequency Control (read/write)
Clock Validity Control (read-only)
bAssocTerminal 0
iClockSource 0
To fix it, check usb_string()'return value and bail out.
==================================================================
BUG: KASAN: stack-out-of-bounds in parse_audio_unit+0x1327/0x1960 [snd_usb_audio] Write of size 1 at addr ffff88007e66735a by task systemd-udevd/18376 CPU: 0 PID: 18376 Comm: systemd-udevd Not tainted 4.13.0+ #3 Hardware name: LG Electronics 15N540-RFLGL/White Tip Mountain, BIOS 15N5 Call Trace: dump_stack+0x63/0x8d print_address_description+0x70/0x290 ? parse_audio_unit+0x1327/0x1960 [snd_usb_audio] kasan_report+0x265/0x350 __asan_store1+0x4a/0x50 parse_audio_unit+0x1327/0x1960 [snd_usb_audio] ? save_stack+0xb5/0xd0 ? save_stack_trace+0x1b/0x20 ? save_stack+0x46/0xd0 ? kasan_kmalloc+0xad/0xe0 ? kmem_cache_alloc_trace+0xff/0x230 ? snd_usb_create_mixer+0xb0/0x4b0 [snd_usb_audio] ? usb_audio_probe+0x4de/0xf40 [snd_usb_audio] ? usb_probe_interface+0x1f5/0x440 ? driver_probe_device+0x3ed/0x660 ? build_feature_ctl+0xb10/0xb10 [snd_usb_audio] ? save_stack_trace+0x1b/0x20 ? init_object+0x69/0xa0 ? snd_usb_find_csint_desc+0xa8/0xf0 [snd_usb_audio] snd_usb_mixer_controls+0x1dc/0x370 [snd_usb_audio] ? build_audio_procunit+0x890/0x890 [snd_usb_audio] ? snd_usb_create_mixer+0xb0/0x4b0 [snd_usb_audio] ? kmem_cache_alloc_trace+0xff/0x230 ? usb_ifnum_to_if+0xbd/0xf0 snd_usb_create_mixer+0x25b/0x4b0 [snd_usb_audio] ? snd_usb_create_stream+0x255/0x2c0 [snd_usb_audio] usb_audio_probe+0x4de/0xf40 [snd_usb_audio] ? snd_usb_autosuspend.part.7+0x30/0x30 [snd_usb_audio] ? __pm_runtime_idle+0x90/0x90 ? kernfs_activate+0xa6/0xc0 ? usb_match_one_id_intf+0xdc/0x130 ? __pm_runtime_set_status+0x2d4/0x450 usb_probe_interface+0x1f5/0x440
--- sound/usb/mixer.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/usb/mixer.c +4 -0
@@ -203,6 +203,10 @@ static int snd_usb_copy_string_desc(stru int index, char *buf, int maxlen) { int len = usb_string(state->chip->dev, index, buf, maxlen - 1); + +if (len <0 ) +return 0 ; + buf[len] =0 ;return len; }
Greg Kroah-Hartman
maintainerPATCH 24/105 kdb: Fix handling of kallsyms_symbol_next() return value
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Thompson <[email protected]>
commit c07d35338081d107e57cf37572d8cc931a8e32e2 upstream.
kallsyms_symbol_next() returns a boolean (true on success). Currently kdb_read() tests the return value with an inequality that unconditionally evaluates to true.
This is fixed in the obvious way and, since the conditional branch is supposed to be unreachable, we also add a WARN_ON().
--- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/kdb/kdb_io.c +1 -1
@@ -349,7 +349,7 @@ poll_again: }kdb_printf ("\n" );for (i =0 ; i < count; i++) { -if (kallsyms_symbol_next (p_tmp, i) <0 ) +if (WARN_ON (!kallsyms_symbol_next (p_tmp, i)))break ;kdb_printf ("%s " , p_tmp); *(p_tmp + len) ='\0' ;
Greg Kroah-Hartman
maintainerPATCH 25/105 drm: extra printk() wrapper macros
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Gordon <[email protected]>
commit 30b0da8d556e65ff935a56cd82c05ba0516d3e4a upstream.
We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk() provides several other useful intermediate levels such as NOTICE and WARNING. So this patch fills out the set by providing both regular and once-only macros for each of the levels INFO, NOTICE, and WARNING, using a common underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
--- include/drm/drmP.h | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-)
include/drm/drmP.h +20 -6
@@ -158,6 +158,26 @@ void drm_err(const char *format, ...);/** \name Macros to make printk easier */ /*@{*/ +#define _DRM_PRINTK (once, level, fmt, ...) \ + do { \ + printk##once(KERN_##level "[" DRM_NAME "] " fmt, \ + ##__VA_ARGS__); \ + } while (0) + +#define DRM_INFO (fmt, ...) \ + _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__) +#define DRM_NOTE (fmt, ...) \ + _DRM_PRINTK(, NOTICE, fmt, ##__VA_ARGS__) +#define DRM_WARN (fmt, ...) \ + _DRM_PRINTK(, WARNING, fmt, ##__VA_ARGS__) + +#define DRM_INFO_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, INFO, fmt, ##__VA_ARGS__) +#define DRM_NOTE_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, NOTICE, fmt, ##__VA_ARGS__) +#define DRM_WARN_ONCE (fmt, ...) \ + _DRM_PRINTK(_once, WARNING, fmt, ##__VA_ARGS__) +/** * Error output. *
@@ -183,12 +203,6 @@ void drm_err(const char *format, ...); drm_err(fmt, ##__VA_ARGS__); \ }) -#define DRM_INFO (fmt, ...) \ - printk(KERN_INFO "[" DRM_NAME "] " fmt, ##__VA_ARGS__) - -#define DRM_INFO_ONCE (fmt, ...) \ - printk_once(KERN_INFO "[" DRM_NAME "] " fmt, ##__VA_ARGS__) -/** * Debug output. *
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Greg Kroah-Hartman
maintainerPATCH 26/105 drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marek Szyprowski <[email protected]>
commit 120a264f9c2782682027d931d83dcbd22e01da80 upstream.
When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver are contiguous, because of the underlying dma_alloc_attrs() function provides only such buffers. In such case it makes no sense to keep BO_NONCONTIG flag for the allocated GEM buffers. This allows to avoid failures for buffer contiguity checks in the subsequent operations on GEM objects.
--- drivers/gpu/drm/exynos/exynos_drm_gem.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/gpu/drm/exynos/exynos_drm_gem.c +9 -0
@@ -245,6 +245,15 @@ struct exynos_drm_gem *exynos_drm_gem_crif (IS_ERR (exynos_gem))return exynos_gem; +if (!is_drm_iommu_supported (dev) && (flags &EXYNOS_BO_NONCONTIG )) { +/* +* when no IOMMU is available, all allocated buffers are +* contiguous anyway, so drop EXYNOS_BO_NONCONTIG flag +*/ + flags &= ~EXYNOS_BO_NONCONTIG ; +DRM_WARN ("Non-contiguous allocation is not supported without IOMMU, falling back to contiguous buffer\n" ); + } +/* set memory type and cache attribute from user side. */ exynos_gem->flags = flags;
Greg Kroah-Hartman
maintainerPATCH 27/105 media: dvb: i2c transfers over usb cannot be done from stack
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Laurent Caumont <[email protected]>
commit 6d33377f2abbf9f0e561b116dd468d1c3ff36a6a upstream.
--- drivers/media/usb/dvb-usb/dibusb-common.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/media/usb/dvb-usb/dibusb-common.c +14 -2
@@ -179,8 +179,20 @@ EXPORT_SYMBOL(dibusb_i2c_algo);int dibusb_read_eeprom_byte (struct dvb_usb_device *d,u8 offs,u8 *val) { -u8 wbuf[1 ] = { offs }; -return dibusb_i2c_msg (d,0x50 , wbuf,1 , val,1 ); +u8 *buf; +int rc; + + buf =kmalloc (2 ,GFP_KERNEL ); +if (!buf) +return -ENOMEM ; + + buf[0 ] = offs; + + rc =dibusb_i2c_msg (d,0x50 , &buf[0 ],1 , &buf[1 ],1 ); + *val = buf[1 ]; +kfree (buf); + +return rc; }EXPORT_SYMBOL (dibusb_read_eeprom_byte);
Greg Kroah-Hartman
maintainerPATCH 3/105 can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jimmy Assarsson <[email protected]>
commit e84f44eb5523401faeb9cc1c97895b68e3cfb78d upstream.
The conditon in the while-loop becomes true when actual_length is less than 2 (MSG_HEADER_LEN). In best case we end up with a former, already dispatched msg, that got msg->len greater than actual_length. This will result in a "Format error" error printout.
Problem seen when unplugging a Kvaser USB device connected to a vbox guest.
warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
--- drivers/net/can/usb/kvaser_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/usb/kvaser_usb.c +1 -1
@@ -1330,7 +1330,7 @@ static void kvaser_usb_read_bulk_callbac goto resubmit_urb; } -while (pos <= urb->actual_length -MSG_HEADER_LEN ) { +while (pos <= (int )(urb->actual_length -MSG_HEADER_LEN )) { msg = urb->transfer_buffer + pos;/* The Kvaser firmware can only read and write messages that
Greg Kroah-Hartman
maintainerPATCH 30/105 arm64: fpsimd: Prevent registers leaking from dead tasks
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Martin <[email protected]>
commit 071b6d4a5d343046f253a5a8835d477d93992002 upstream.
Currently, loading of a task's fpsimd state into the CPU registers is skipped if that task's state is already present in the registers of that CPU.
However, the code relies on the struct fpsimd_state * (and by extension struct task_struct *) to unambiguously identify a task.
There is a particular case in which this doesn't work reliably:
when a task exits, its task_struct may be recycled to describe a new task.
Consider the following scenario:
1) Task P loads its fpsimd state onto cpu C.
per_cpu(fpsimd_last_state, C) := P;
P->thread.fpsimd_state.cpu := C;2) Task X is scheduled onto C and loads its fpsimd state on C.
per_cpu(fpsimd_last_state, C) := X;
X->thread.fpsimd_state.cpu := C; 3) X exits, causing X's task_struct to be freed.
4) P forks a new child T, which obtains X's recycled task_struct.
T == X. T->thread.fpsimd_state.cpu == C (inherited from P).
5) T is scheduled on C.
T's fpsimd state is not loaded, because
per_cpu(fpsimd_last_state, C) == T (== X) &&
T->thread.fpsimd_state.cpu == C.
(This is the check performed by fpsimd_thread_switch().)So, T gets X's registers because the last registers loaded onto C were those of X, in (2).
This patch fixes the problem by ensuring that the sched-in check fails in (5): fpsimd_flush_task_state(T) is called when T is forked, so that T->thread.fpsimd_state.cpu == C cannot be true. This relies on the fact that T is not schedulable until after copy_thread() completes.
Once T's fpsimd state has been loaded on some CPU C there may still be other cpus D for which per_cpu(fpsimd_last_state, D) == &X->thread.fpsimd_state. But D is necessarily != C in this case, and the check in (5) must fail.
An alternative fix would be to do refcounting on task_struct. This would result in each CPU holding a reference to the last task whose fpsimd state was loaded there. It's not clear whether this is preferable, and it involves higher overhead than the fix proposed in this patch. It would also move all the task_struct freeing work into the context switch critical section, or otherwise some deferred cleanup mechanism would need to be introduced, neither of which seems obviously justified.
--- arch/arm64/kernel/process.c | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/kernel/process.c +9 -0
@@ -251,6 +251,15 @@ int copy_thread(unsigned long clone_flagmemset (&p->thread.cpu_context,0 ,sizeof (struct cpu_context )); +/* +* In case p was allocated the same task_struct pointer as some +* other recently-exited task, make sure p is disassociated from +* any cpu that may have run that now-exited task recently. +* Otherwise we could erroneously skip reloading the FPSIMD +* registers for p. +*/ +fpsimd_flush_task_state (p); +if (likely (!(p->flags &PF_KTHREAD ))) { *childregs = *current_pt_regs (); childregs->regs[0 ] =0 ;
Greg Kroah-Hartman
maintainerPATCH 31/105 ARM: BUG if jumping to usermode address in kernel mode
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Russell King <[email protected]>
commit 8bafae202c82dc257f649ea3c275a0f35ee15113 upstream.
Detect if we are returning to usermode via the normal kernel exit paths but the saved PSR value indicates that we are in kernel mode. This could occur due to corrupted stack state, which has been observed with "ftracetest".
This ensures that we catch the problem case before we get to user code.
--- arch/arm/include/asm/assembler.h | 18 ++++++++++++++++++ arch/arm/kernel/entry-header.S | 6 ++++++ 2 files changed, 24 insertions(+)
arch/arm/include/asm/assembler.h +18 -0
@@ -512,4 +512,22 @@ THUMB( orr \reg , \reg , #PSR_T_BIT )#endif .endm + .macro bug, msg, line +#ifdef CONFIG_THUMB2_KERNEL +1: .inst 0xde02 +#else +1: .inst 0xe7f001f2 +#endif +#ifdef CONFIG_DEBUG_BUGVERBOSE + .pushsection .rodata.str, "aMS", %progbits, 1 +2: .asciz "\msg" + .popsection + .pushsection __bug_table, "aw" + .align 2 + .word 1b, 2b + .hword \line + .popsection +#endif + .endm +#endif /* __ASM_ASSEMBLER_H__ */
arch/arm/kernel/entry-header.S +6 -0
@@ -295,6 +295,8 @@ mov r2, sp ldr r1, [r2, #\offset + S_PSR] @ get calling cpsr ldr lr, [r2, #\offset + S_PC]! @ get pc + tst r1, #0xcf + bne 1f msr spsr_cxsf, r1 @ save in spsr_svc #if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_32v6K) @ We must avoid clrex due to Cortex-A15 erratum #830321
@@ -309,6 +311,7 @@ @ after ldm {}^ add sp, sp, #\offset + S_FRAME_SIZE movs pc, lr @ return & move spsr_svc into cpsr +1: bug "Returning to usermode but unexpected PSR bits set?", \@ #elif defined(CONFIG_CPU_V7M) @ V7M restore. @ Note that we don't need to do clrex here as clearing the local
@@ -324,6 +327,8 @@ ldr r1, [sp, #\offset + S_PSR] @ get calling cpsr ldr lr, [sp, #\offset + S_PC] @ get pc add sp, sp, #\offset + S_SP + tst r1, #0xcf + bne 1f msr spsr_cxsf, r1 @ save in spsr_svc @ We must avoid clrex due to Cortex-A15 erratum #830321
@@ -336,6 +341,7 @@ .endif add sp, sp, #S_FRAME_SIZE - S_SP movs pc, lr @ return & move spsr_svc into cpsr +1: bug "Returning to usermode but unexpected PSR bits set?", \@ #endif /* !CONFIG_THUMB2_KERNEL */ .endm
Greg Kroah-Hartman
maintainerPATCH 32/105 ARM: avoid faulting on qemu
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Russell King <[email protected]>
commit 3aaf33bebda8d4ffcc0fc8ef39e6c1ac68823b11 upstream.
When qemu starts a kernel in a bare environment, the default SCR has the AW and FW bits clear, which means that the kernel can't modify the PSR A or PSR F bits, and means that FIQs and imprecise aborts are always masked.
When running uboot under qemu, the AW and FW SCR bits are set, and the kernel functions normally - and this is how real hardware behaves.
Fix this for qemu by ignoring the FIQ bit.
--- arch/arm/kernel/entry-header.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/kernel/entry-header.S +2 -2
@@ -295,7 +295,7 @@ mov r2, sp ldr r1, [r2, #\offset + S_PSR] @ get calling cpsr ldr lr, [r2, #\offset + S_PC]! @ get pc - tst r1, #0xcf + tst r1, #PSR_I_BIT | 0x0f bne 1f msr spsr_cxsf, r1 @ save in spsr_svc #if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_32v6K)
@@ -327,7 +327,7 @@ ldr r1, [sp, #\offset + S_PSR] @ get calling cpsr ldr lr, [sp, #\offset + S_PC] @ get pc add sp, sp, #\offset + S_SP - tst r1, #0xcf + tst r1, #PSR_I_BIT | 0x0f bne 1f msr spsr_cxsf, r1 @ save in spsr_svc
Greg Kroah-Hartman
maintainerPATCH 5/105 can: kvaser_usb: cancel urb on -EPIPE and -EPROTO
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Martin Kelly <[email protected]>
commit 6aa8d5945502baf4687d80de59b7ac865e9e666b upstream.
In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO).
This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way.
--- drivers/net/can/usb/kvaser_usb.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/usb/kvaser_usb.c +2 -0
@@ -1322,6 +1322,8 @@ static void kvaser_usb_read_bulk_callbaccase 0 :break ;case -ENOENT : +case -EPIPE : +case -EPROTO :case -ESHUTDOWN :return ;default :
Greg Kroah-Hartman
maintainerPATCH 6/105 can: ems_usb: cancel urb on -EPIPE and -EPROTO
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Martin Kelly <[email protected]>
commit bd352e1adfe0d02d3ea7c8e3fb19183dc317e679 upstream.
In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO).
This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way.
--- drivers/net/can/usb/ems_usb.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/can/usb/ems_usb.c +2 -0
@@ -290,6 +290,8 @@ static void ems_usb_read_interrupt_callbcase -ECONNRESET :/* unlink */ case -ENOENT : +case -EPIPE : +case -EPROTO :case -ESHUTDOWN :return ;
Greg Kroah-Hartman
maintainerPATCH 45/105 ARM: OMAP2+: Fix device node reference counts
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Guenter Roeck <[email protected]>
[ Upstream commit 10e5778f54765c96fe0c8f104b7a030e5b35bc72 ]
After commit 0549bde0fcb1 ("of: fix of_node leak caused in of_find_node_opts_by_path"), the following error may be reported when running omap images.
OF: ERROR: Bad of_node_put() on /ocp@68000000
CPU: 0 PID: 0 Comm: swapper Not tainted 4.10.0-rc7-next-20170210 #1 Hardware name: Generic OMAP3-GP (Flattened Device Tree) [<c0310604>] (unwind_backtrace) from [<c030bbf4>] (show_stack+0x10/0x14) [<c030bbf4>] (show_stack) from [<c05add8c>] (dump_stack+0x98/0xac) [<c05add8c>] (dump_stack) from [<c05af1b0>] (kobject_release+0x48/0x7c) [<c05af1b0>] (kobject_release) from [<c0ad1aa4>] (of_find_node_by_name+0x74/0x94) [<c0ad1aa4>] (of_find_node_by_name) from [<c1215bd4>] (omap3xxx_hwmod_is_hs_ip_block_usable+0x24/0x2c) [<c1215bd4>] (omap3xxx_hwmod_is_hs_ip_block_usable) from [<c1215d5c>] (omap3xxx_hwmod_init+0x180/0x274) [<c1215d5c>] (omap3xxx_hwmod_init) from [<c120faa8>] (omap3_init_early+0xa0/0x11c) [<c120faa8>] (omap3_init_early) from [<c120fb2c>] (omap3430_init_early+0x8/0x30) [<c120fb2c>] (omap3430_init_early) from [<c1204710>] (setup_arch+0xc04/0xc34)
[<c1204710>] (setup_arch) from [<c1200948>] (start_kernel+0x68/0x38c) [<c1200948>] (start_kernel) from [<8020807c>] (0x8020807c)
of_find_node_by_name() drops the reference to the passed device node. The commit referenced above exposes this problem.
To fix the problem, use of_get_child_by_name() instead of of_find_node_by_name(); of_get_child_by_name() does not drop the reference count of passed device nodes. While semantically different, we only look for immediate children of the passed device node, so of_get_child_by_name() is a more appropriate function to use anyway.
Release the reference to the device node obtained with of_get_child_by_name() after it is no longer needed to avoid another device node leak.
While at it, clean up the code and change the return type of omap3xxx_hwmod_is_hs_ip_block_usable() to bool to match its use and the return type of of_device_is_available().
--- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +10 -6
@@ -3885,16 +3885,20 @@ static struct omap_hwmod_ocp_if *omap3xx* Return: 0 if device named @dev_name is not likely to be accessible, * or 1 if it is likely to be accessible. */ -static int __init omap3xxx_hwmod_is_hs_ip_block_usable (struct device_node *bus, -const char *dev_name) +static bool __init omap3xxx_hwmod_is_hs_ip_block_usable (struct device_node *bus, +const char *dev_name) { +struct device_node *node; +bool available; +if (!bus) -return (omap_type () ==OMAP2_DEVICE_TYPE_GP ) ?1 :0 ; +return omap_type () ==OMAP2_DEVICE_TYPE_GP ; -if (of_device_is_available (of_find_node_by_name (bus, dev_name))) -return 1 ; + node =of_get_child_by_name (bus, dev_name); + available =of_device_is_available (node); +of_node_put (node); -return 0 ; +return available; }int __init omap3xxx_hwmod_init (void )
Greg Kroah-Hartman
maintainerPATCH 47/105 gpio: altera: Use handle_level_irq when configured as a level_high
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Phil Reid <[email protected]>
[ Upstream commit f759921cfbf4847319d197a6ed7c9534d593f8bc ]
When a threaded irq handler is chained attached to one of the gpio pins when configure for level irq the altera_gpio_irq_leveL_high_handler does not mask the interrupt while being handled by the chained irq. This resulting in the threaded irq not getting enough cycles to complete quickly enough before the irq was disabled as faulty. handle_level_irq should be used in this situation instead of handle_simple_irq.
In gpiochip_irqchip_add set default handler to handle_bad_irq as per Documentation/gpio/driver.txt. Then set the correct handler in the set_type callback.
--- drivers/gpio/gpio-altera.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-)
drivers/gpio/gpio-altera.c +11 -15
@@ -94,21 +94,18 @@ static int altera_gpio_irq_set_type(stru altera_gc =to_altera (irq_data_get_irq_chip_data (d)); -if (type ==IRQ_TYPE_NONE ) +if (type ==IRQ_TYPE_NONE ) { +irq_set_handler_locked (d, handle_bad_irq);return 0 ; -if (type ==IRQ_TYPE_LEVEL_HIGH && - altera_gc->interrupt_trigger ==IRQ_TYPE_LEVEL_HIGH ) -return 0 ; -if (type ==IRQ_TYPE_EDGE_RISING && - altera_gc->interrupt_trigger ==IRQ_TYPE_EDGE_RISING ) -return 0 ; -if (type ==IRQ_TYPE_EDGE_FALLING && - altera_gc->interrupt_trigger ==IRQ_TYPE_EDGE_FALLING ) -return 0 ; -if (type ==IRQ_TYPE_EDGE_BOTH && - altera_gc->interrupt_trigger ==IRQ_TYPE_EDGE_BOTH ) + } +if (type == altera_gc->interrupt_trigger) { +if (type ==IRQ_TYPE_LEVEL_HIGH ) +irq_set_handler_locked (d, handle_level_irq); +else +irq_set_handler_locked (d, handle_simple_irq);return 0 ; - + } +irq_set_handler_locked (d, handle_bad_irq);return -EINVAL ; }
@@ -234,7 +231,6 @@ static void altera_gpio_irq_edge_handlerchained_irq_exit (chip, desc); } -static void altera_gpio_irq_leveL_high_handler (struct irq_desc *desc) {struct altera_gpio_chip *altera_gc;
@@ -314,7 +310,7 @@ static int altera_gpio_probe(struct plat altera_gc->interrupt_trigger = reg; ret =gpiochip_irqchip_add (&altera_gc->mmchip.gc, &altera_irq_chip,0 , - handle_simple_irq,IRQ_TYPE_NONE ); + handle_bad_irq,IRQ_TYPE_NONE );if (ret) {dev_info (&pdev->dev,"could not add irqchip\n" );
Greg Kroah-Hartman
maintainerPATCH 49/105 usb: gadget: configs: plug memory leak
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: John Keeping <[email protected]>
[ Upstream commit 38355b2a44776c25b0f2ad466e8c51bb805b3032 ]
When binding a gadget to a device, "name" is stored in gi->udc_name, but this does not happen when unregistering and the string is leaked.
--- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/gadget/configfs.c +1 -0
@@ -270,6 +270,7 @@ static ssize_t gadget_dev_desc_UDC_store ret =unregister_gadget (gi);if (ret) goto err; +kfree (name); }else {if (gi->udc_name) { ret = -EBUSY ;
Greg Kroah-Hartman
maintainerPATCH 52/105 libata: drop WARN from protocol error in ata_sff_qc_issue()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tejun Heo <[email protected]>
[ Upstream commit 0580b762a4d6b70817476b90042813f8573283fa ]
ata_sff_qc_issue() expects upper layers to never issue commands on a command protocol that it doesn't implement. While the assumption holds fine with the usual IO path, nothing filters based on the command protocol in the passthrough path (which was added later), allowing the warning to be tripped with a passthrough command with the right (well, wrong) protocol.
Failing with AC_ERR_SYSTEM is the right thing to do anyway. Remove the unnecessary WARN.
--- drivers/ata/libata-sff.c | 1 - 1 file changed, 1 deletion(-)
drivers/ata/libata-sff.c +0 -1
@@ -1480,7 +1480,6 @@ unsigned int ata_sff_qc_issue(struct atabreak ;default : -WARN_ON_ONCE (1 );return AC_ERR_SYSTEM ; }
Greg Kroah-Hartman
maintainerPATCH 37/105 Revert "drm/armada: Fix compile fail"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sasha Levin <[email protected]>
This reverts commit 82f260d472c3b4dbb7324624e395c3e91f73a040.
Not required on < 4.10.
--- drivers/gpu/drm/armada/Makefile | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/armada/Makefile +0 -2
@@ -4,5 +4,3 @@ armada-y += armada_510.o armada-$(CONFIG_DEBUG_FS) += armada_debugfs.o obj-$(CONFIG_DRM_ARMADA) := armada.o - -CFLAGS_armada_trace.o := -I$(src)
Greg Kroah-Hartman
maintainerPATCH 55/105 irqchip/crossbar: Fix incorrect type of register size
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Franck Demathieu <[email protected]>
[ Upstream commit 4b9de5da7e120c7f02395da729f0ec77ce7a6044 ]
The 'size' variable is unsigned according to the dt-bindings. As this variable is used as integer in other places, create a new variable that allows to fix the following sparse issue (-Wtypesign):
drivers/irqchip/irq-crossbar.c:279:52: warning: incorrect type in argument 3 (different signedness)
drivers/irqchip/irq-crossbar.c:279:52: expected unsigned int [usertype] *out_value
drivers/irqchip/irq-crossbar.c:279:52: got int *<noident>
--- drivers/irqchip/irq-crossbar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/irqchip/irq-crossbar.c +4 -4
@@ -199,7 +199,7 @@ static const struct irq_domain_ops crossstatic int __init crossbar_of_init (struct device_node *node) {int i, size, reserved =0 ; -u32 max =0 , entry; +u32 max =0 , entry, reg_size;const __be32 *irqsr;int ret = -ENOMEM ;
@@ -276,9 +276,9 @@ static int __init crossbar_of_init(strucif (!cb->register_offsets) goto err_irq_map; -of_property_read_u32 (node,"ti,reg-size" , &size); +of_property_read_u32 (node,"ti,reg-size" , ®_size); -switch (size) { +switch (reg_size) {case 1 : cb->write = crossbar_writeb;break ;
@@ -304,7 +304,7 @@ static int __init crossbar_of_init(struccontinue ; cb->register_offsets[i] = reserved; - reserved += size; + reserved += reg_size; }of_property_read_u32 (node,"ti,irqs-safe-map" , &cb->safe_map);
Greg Kroah-Hartman
maintainerPATCH 58/105 arm64: KVM: Survive unknown traps from guests
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mark Rutland <[email protected]>
[ Upstream commit ba4dd156eabdca93501d92a980ba27fa5f4bbd27 ]
Currently we BUG() if we see an ESR_EL2.EC value we don't recognise. As configurable disables/enables are added to the architecture (controlled by RES1/RES0 bits respectively), with associated synchronous exceptions, it may be possible for a guest to trigger exceptions with classes that we don't recognise.
While we can't service these exceptions in a manner useful to the guest, we can avoid bringing down the host. Per ARM DDI 0487A.k_iss10775, page D7-1937, EC values within the range 0x00 - 0x2c are reserved for future use with synchronous exceptions, and EC values within the range 0x2d - 0x3f may be used for either synchronous or asynchronous exceptions.
The patch makes KVM handle any unknown EC by injecting an UNDEFINED exception into the guest, with a corresponding (ratelimited) warning in the host dmesg. We could later improve on this with with a new (opt-in) exit to the host userspace.
--- arch/arm64/kvm/handle_exit.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)
arch/arm64/kvm/handle_exit.c +12 -7
@@ -121,7 +121,19 @@ static int kvm_handle_guest_debug(structreturn ret; } +static int kvm_handle_unknown_ec (struct kvm_vcpu *vcpu,struct kvm_run *run) +{ +u32 hsr =kvm_vcpu_get_hsr (vcpu); + +kvm_pr_unimpl ("Unknown exception class: hsr: %#08x -- %s\n" , + hsr,esr_get_class_string (hsr)); + +kvm_inject_undefined (vcpu); +return 1 ; +} +static exit_handle_fn arm_exit_handlers[] = { + [0 ... ESR_ELx_EC_MAX] = kvm_handle_unknown_ec, [ESR_ELx_EC_WFx] = kvm_handle_wfx, [ESR_ELx_EC_CP15_32] = kvm_handle_cp15_32, [ESR_ELx_EC_CP15_64] = kvm_handle_cp15_64,
@@ -147,13 +159,6 @@ static exit_handle_fn kvm_get_exit_handlu32 hsr =kvm_vcpu_get_hsr (vcpu);u8 hsr_ec = hsr >> ESR_ELx_EC_SHIFT; -if (hsr_ec >=ARRAY_SIZE (arm_exit_handlers) || - !arm_exit_handlers[hsr_ec]) { -kvm_err ("Unknown exception class: hsr: %#08x -- %s\n" , - hsr,esr_get_class_string (hsr)); -BUG (); - } -return arm_exit_handlers[hsr_ec]; }
Greg Kroah-Hartman
maintainerPATCH 59/105 spi_ks8995: fix "BUG: key accdaa28 not in .data!"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Blomme, Maarten" <[email protected]>
[ Upstream commit 4342696df764ec65dcdfbd0c10d90ea52505f8ba ]
--- drivers/net/phy/spi_ks8995.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/phy/spi_ks8995.c +1 -0
@@ -310,6 +310,7 @@ static int ks8995_probe(struct spi_devicif (err)return err; +sysfs_attr_init (&ks->regs_attr.attr); err =sysfs_create_bin_file (&spi->dev.kobj, &ks->regs_attr);if (err) { dev_err(&spi->dev, "unable to create sysfs file, err=%d\n",
Greg Kroah-Hartman
maintainerPATCH 60/105 bnx2x: prevent crash when accessing PTP with interface down
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michal Schmidt <[email protected]>
[ Upstream commit 466e8bf10ac104d96e1ea813e8126e11cb72ea20 ]
It is possible to crash the kernel by accessing a PTP device while its associated bnx2x interface is down. Before the interface is brought up, the timecounter is not initialized, so accessing it results in NULL dereference.
Fix it by checking if the interface is up.
Use -ENETDOWN as the error code when the interface is down.
-EFAULT in bnx2x_ptp_adjfreq() did not seem right.
Tested using phc_ctl get/set/adj/freq commands.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +19 -1
@@ -13646,7 +13646,7 @@ static int bnx2x_ptp_adjfreq(struct ptp_if (!netif_running (bp->dev)) {DP (BNX2X_MSG_PTP ,"PTP adjfreq called while the interface is down\n" ); -return -EFAULT ; +return -ENETDOWN ; }if (ppb <0 ) {
@@ -13705,6 +13705,12 @@ static int bnx2x_ptp_adjtime(struct ptp_ { struct bnx2x *bp = container_of(ptp, struct bnx2x, ptp_clock_info); +if (!netif_running (bp->dev)) { +DP (BNX2X_MSG_PTP , +"PTP adjtime called while the interface is down\n" ); +return -ENETDOWN ; + } +DP (BNX2X_MSG_PTP ,"PTP adjtime called, delta = %llx\n" , delta);timecounter_adjtime (&bp->timecounter, delta);
@@ -13717,6 +13723,12 @@ static int bnx2x_ptp_gettime(struct ptp_ struct bnx2x *bp = container_of(ptp, struct bnx2x, ptp_clock_info);u64 ns; +if (!netif_running (bp->dev)) { +DP (BNX2X_MSG_PTP , +"PTP gettime called while the interface is down\n" ); +return -ENETDOWN ; + } + ns =timecounter_read (&bp->timecounter);DP (BNX2X_MSG_PTP ,"PTP gettime called, ns = %llu\n" , ns);
@@ -13732,6 +13744,12 @@ static int bnx2x_ptp_settime(struct ptp_ struct bnx2x *bp = container_of(ptp, struct bnx2x, ptp_clock_info);u64 ns; +if (!netif_running (bp->dev)) { +DP (BNX2X_MSG_PTP , +"PTP settime called while the interface is down\n" ); +return -ENETDOWN ; + } + ns =timespec64_to_ns (ts);DP (BNX2X_MSG_PTP ,"PTP settime called, ns = %llu\n" , ns);
Greg Kroah-Hartman
maintainerPATCH 62/105 bnx2x: do not rollback VF MAC/VLAN filters we did not configure
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Michal Schmidt <[email protected]>
[ Upstream commit 78d5505432436516456c12abbe705ec8dee7ee2b ]
On failure to configure a VF MAC/VLAN filter we should not attempt to rollback filters that we failed to configure with -EEXIST.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 8 +++++++- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +7 -1
@@ -434,7 +434,9 @@ static int bnx2x_vf_mac_vlan_config(stru/* Add/Remove the filter */ rc =bnx2x_config_vlan_mac (bp, &ramrod); -if (rc && rc != -EEXIST ) { +if (rc == -EEXIST ) +return 0 ; +if (rc) { BNX2X_ERR("Failed to %s %s\n", filter->add ? "add" : "delete", (filter->type == BNX2X_VF_FILTER_VLAN_MAC) ?
@@ -444,6 +446,8 @@ static int bnx2x_vf_mac_vlan_config(strureturn rc; } + filter->applied = true; +return 0 ; }
@@ -471,6 +475,8 @@ int bnx2x_vf_mac_vlan_config_list(structBNX2X_ERR ("Managed only %d/%d filters - rolling back\n" , i, filters->count +1 );while (--i >=0 ) { +if (!filters->filters[i].applied) +continue ; filters->filters[i].add = !filters->filters[i].add; bnx2x_vf_mac_vlan_config(bp, vf, qid, &filters->filters[i],
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h +1 -0
@@ -114,6 +114,7 @@ struct bnx2x_vf_mac_vlan_filter { (BNX2X_VF_FILTER_MAC | BNX2X_VF_FILTER_VLAN) /*shortcut*/bool add; +bool applied;u8 *mac;u16 vid; };
Greg Kroah-Hartman
maintainerPATCH 66/105 zram: set physical queue limits to avoid array out of bounds accesses
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Johannes Thumshirn <[email protected]>
[ Upstream commit 0bc315381fe9ed9fb91db8b0e82171b645ac008f ]
zram can handle at most SECTORS_PER_PAGE sectors in a bio's bvec. When using the NVMe over Fabrics loopback target which potentially sends a huge bulk of pages attached to the bio's bvec this results in a kernel panic because of array out of bounds accesses in zram_decompress_page().
--- drivers/block/zram/zram_drv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/block/zram/zram_drv.c +2 -0
@@ -1247,6 +1247,8 @@ static int zram_add(void)blk_queue_io_min (zram->disk->queue,PAGE_SIZE );blk_queue_io_opt (zram->disk->queue,PAGE_SIZE ); zram->disk->queue->limits.discard_granularity =PAGE_SIZE ; + zram->disk->queue->limits.max_sectors =SECTORS_PER_PAGE ; + zram->disk->queue->limits.chunk_sectors =0 ;blk_queue_max_discard_sectors (zram->disk->queue,UINT_MAX );/* * zram_bio_discard() will clear all logical blocks if logical block
Greg Kroah-Hartman
maintainerPATCH 69/105 drm/amd/amdgpu: fix console deadlock if late init failed
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jim Qu <[email protected]>
[ Upstream commit c085bd5119d5d0bdf3ef591a5563566be7dedced ]
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +4 -1
@@ -1760,8 +1760,11 @@ int amdgpu_resume_kms(struct drm_device } r =amdgpu_late_init (adev); -if (r) +if (r) { +if (fbcon) +console_unlock ();return r; + }/* pin cursors */ list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {
Greg Kroah-Hartman
maintainerPATCH 70/105 powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requested
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alexey Kardashevskiy <[email protected]>
[ Upstream commit 7aafac11e308d37ed3c509829bb43d80c1811ac3 ]
The IODA2 specification says that a 64 DMA address cannot use top 4 bits (3 are reserved and one is a "TVE select"); bottom page_shift bits cannot be used for multilevel table addressing either.
The existing IODA2 table allocation code aligns the minimum TCE table size to PAGE_SIZE so in the case of 64K system pages and 4K IOMMU pages, we have 64-4-12=48 bits. Since 64K page stores 8192 TCEs, i.e. needs 13 bits, the maximum number of levels is 48/13 = 3 so we physically cannot address more and EEH happens on DMA accesses.
This adds a check that too many levels were requested.
It is still possible to have 5 levels in the case of 4K system page size.
--- arch/powerpc/platforms/powernv/pci-ioda.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/platforms/powernv/pci-ioda.c +3 -0
@@ -2270,6 +2270,9 @@ static long pnv_pci_ioda2_table_alloc_pa level_shift = entries_shift +3 ; level_shift =max_t (unsigned, level_shift,PAGE_SHIFT ); +if ((level_shift -3 ) * levels + page_shift >=60 ) +return -EINVAL ; +/* Allocate TCE table */ addr =pnv_pci_ioda2_table_do_alloc_pages (nid, level_shift, levels, tce_table_size, &offset, &total_allocated);
Greg Kroah-Hartman
maintainerPATCH 39/105 Revert "s390/kbuild: enable modversions for symbols exported from asm"
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sasha Levin <[email protected]>
This reverts commit cabab3f9f5ca077535080b3252e6168935b914af.
Not needed for < 4.9.
--- arch/s390/include/asm/asm-prototypes.h | 8 -------- 1 file changed, 8 deletions(-) delete mode 100644 arch/s390/include/asm/asm-prototypes.h
arch/s390/include/asm/asm-prototypes.h deleted +0 -8
@@ -1,8 +0,0 @@ -#ifndef _ASM_S390_PROTOTYPES_H - -#include <linux/kvm_host.h> -#include <linux/ftrace.h> -#include <asm/fpu/api.h> -#include <asm-generic/asm-prototypes.h> - -#endif /* _ASM_S390_PROTOTYPES_H */
Greg Kroah-Hartman
maintainerPATCH 40/105 vti6: Dont report path MTU below IPV6_MIN_MTU.
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steffen Klassert <[email protected]>
[ Upstream commit e3dc847a5f85b43ee2bfc8eae407a7e383483228 ]
In vti6_xmit(), the check for IPV6_MIN_MTU before we send a ICMPV6_PKT_TOOBIG message is missing. So we might report a PMTU below 1280. Fix this by adding the required check.
--- net/ipv6/ip6_vti.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
net/ipv6/ip6_vti.c +6 -2
@@ -474,11 +474,15 @@ vti6_xmit(struct sk_buff *skb, struct neif (!skb->ignore_df && skb->len > mtu) {skb_dst (skb)->ops->update_pmtu (dst,NULL , skb, mtu); -if (skb->protocol ==htons (ETH_P_IPV6 )) +if (skb->protocol ==htons (ETH_P_IPV6 )) { +if (mtu <IPV6_MIN_MTU ) + mtu =IPV6_MIN_MTU ; +icmpv6_send (skb,ICMPV6_PKT_TOOBIG ,0 , mtu); -else + }else {icmp_send (skb,ICMP_DEST_UNREACH ,ICMP_FRAG_NEEDED ,htonl (mtu)); + }return -EMSGSIZE ; }
Greg Kroah-Hartman
maintainerPATCH 41/105 ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ladislav Michl <[email protected]>
[ Upstream commit 7807e086a2d1f69cc1a57958cac04fea79fc2112 ]
gpmc_probe_onenand_child returns success even on gpmc_onenand_init failure. Fix that.
--- arch/arm/mach-omap2/gpmc-onenand.c | 10 ++++++---- drivers/memory/omap-gpmc.c | 4 +--- include/linux/omap-gpmc.h | 5 +++-- 3 files changed, 10 insertions(+), 9 deletions(-)
arch/arm/mach-omap2/gpmc-onenand.c +6 -4
@@ -367,7 +367,7 @@ static int gpmc_onenand_setup(void __iomreturn ret; } -void gpmc_onenand_init (struct omap_onenand_platform_data *_onenand_data) +int gpmc_onenand_init (struct omap_onenand_platform_data *_onenand_data) {int err;struct device *dev = &gpmc_onenand_device.dev;
@@ -393,15 +393,17 @@ void gpmc_onenand_init(struct omap_onenaif (err <0 ) {dev_err (dev,"Cannot request GPMC CS %d, error %d\n" , gpmc_onenand_data->cs, err); -return ; +return err; } gpmc_onenand_resource.end = gpmc_onenand_resource.start +ONENAND_IO_SIZE -1 ; -if (platform_device_register (&gpmc_onenand_device) <0 ) { + err =platform_device_register (&gpmc_onenand_device); +if (err) {dev_err (dev,"Unable to register OneNAND device\n" );gpmc_cs_free (gpmc_onenand_data->cs); -return ; } + +return err; }
drivers/memory/omap-gpmc.c +1 -3
@@ -1890,9 +1890,7 @@ static int gpmc_probe_onenand_child(struif (!of_property_read_u32 (child,"dma-channel" , &val)) gpmc_onenand_data->dma_channel = val; -gpmc_onenand_init (gpmc_onenand_data); - -return 0 ; +return gpmc_onenand_init (gpmc_onenand_data); }#else static int gpmc_probe_onenand_child(struct platform_device *pdev,
include/linux/omap-gpmc.h +3 -2
@@ -191,10 +191,11 @@ static inline int gpmc_nand_init(struct#endif #if IS_ENABLED (CONFIG_MTD_ONENAND_OMAP2 ) -extern void gpmc_onenand_init (struct omap_onenand_platform_data *d); +extern int gpmc_onenand_init (struct omap_onenand_platform_data *d);#else #define board_onenand_data NULL -static inline void gpmc_onenand_init (struct omap_onenand_platform_data *d) +static inline int gpmc_onenand_init (struct omap_onenand_platform_data *d) { +return 0 ; }#endif
Greg Kroah-Hartman
maintainerPATCH 43/105 selftest/powerpc: Fix false failures for skipped tests
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sachin Sant <[email protected]>
[ Upstream commit a6d8a21596df041f36f4c2ccc260c459e3e851f1 ]
Tests under alignment subdirectory are skipped when executed on previous generation hardware, but harness still marks them as failed.
test: test_copy_unaligned
tags: git_version:unknown
[SKIP] Test skipped on line 26
skip: test_copy_unaligned
selftests: copy_unaligned [FAIL]
The MAGIC_SKIP_RETURN_VALUE value assigned to rc variable is retained till the program exit which causes the test to be marked as failed.
This patch resets the value before returning to the main() routine. With this patch the test o/p is as follows:
test: test_copy_unaligned
tags: git_version:unknown
[SKIP] Test skipped on line 26
skip: test_copy_unaligned
selftests: copy_unaligned [PASS]
--- tools/testing/selftests/powerpc/harness.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/testing/selftests/powerpc/harness.c +4 -2
@@ -109,9 +109,11 @@ int test_harness(int (test_function)(voi rc =run_test (test_function, name); -if (rc ==MAGIC_SKIP_RETURN_VALUE ) +if (rc ==MAGIC_SKIP_RETURN_VALUE ) {test_skip (name); -else +/* so that skipped test is not marked as failed */ + rc =0 ; + }else test_finish (name, rc);return rc;
Greg Kroah-Hartman
maintainerPATCH 44/105 module: set __jump_table alignment to 8
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Daney <[email protected]>
[ Upstream commit ab42632156becd35d3884ee5c14da2bedbf3149a ]
For powerpc the __jump_table section in modules is not aligned, this causes a WARN_ON() splat when loading a module containing a __jump_table.
Strict alignment became necessary with commit 3821fd35b58d ("jump_label: Reduce the size of struct static_key"), currently in linux-next, which uses the two least significant bits of pointers to __jump_table elements.
Fix by forcing __jump_table to 8, which is the same alignment used for this section in the kernel proper.
--- scripts/module-common.lds | 2 ++ 1 file changed, 2 insertions(+)
scripts/module-common.lds +2 -0
@@ -19,4 +19,6 @@ SECTIONS { . = ALIGN(8); .init_array 0 : { *(SORT(.init_array.*)) *(.init_array) } + + __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) } }
Greg Kroah-Hartman
maintainerPATCH 75/105 route: also update fnhe_genid when updating a route cache
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xin Long <[email protected]>
[ Upstream commit cebe84c6190d741045a322f5343f717139993c08 ]
Now when ip route flush cache and it turn out all fnhe_genid != genid. If a redirect/pmtu icmp packet comes and the old fnhe is found and all it's members but fnhe_genid will be updated.
Then next time when it looks up route and tries to rebind this fnhe to the new dst, the fnhe will be flushed due to fnhe_genid != genid. It causes this redirect/pmtu icmp packet acutally not to be applied.
This patch is to also reset fnhe_genid when updating a route cache.
--- net/ipv4/route.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
net/ipv4/route.c +7 -2
@@ -624,9 +624,12 @@ static void update_or_create_fnhe(structstruct fnhe_hash_bucket *hash;struct fib_nh_exception *fnhe;struct rtable *rt; +u32 genid, hval;unsigned int i;int depth; -u32 hval =fnhe_hashfun (daddr); + + genid =fnhe_genid (dev_net (nh->nh_dev)); + hval =fnhe_hashfun (daddr);spin_lock_bh (&fnhe_lock);
@@ -649,6 +652,8 @@ static void update_or_create_fnhe(struct }if (fnhe) { +if (fnhe->fnhe_genid != genid) + fnhe->fnhe_genid = genid;if (gw) fnhe->fnhe_gw = gw;if (pmtu) {
@@ -673,7 +678,7 @@ static void update_or_create_fnhe(struct fnhe->fnhe_next = hash->chain;rcu_assign_pointer (hash->chain, fnhe); } - fnhe->fnhe_genid =fnhe_genid (dev_net (nh->nh_dev)); + fnhe->fnhe_genid = genid; fnhe->fnhe_daddr = daddr; fnhe->fnhe_gw = gw; fnhe->fnhe_pmtu = pmtu;
Greg Kroah-Hartman
maintainerPATCH 86/105 jump_label: Invoke jump_label_test() via early_initcall()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jason Baron <[email protected]>
[ Upstream commit 92ee46efeb505ead3ab06d3c5ce695637ed5f152 ]
Fengguang Wu reported that running the rcuperf test during boot can cause the jump_label_test() to hit a WARN_ON(). The issue is that the core jump label code relies on kernel_text_address() to detect when it can no longer update branches that may be contained in __init sections. The kernel_text_address() in turn assumes that if the system_state variable is greter than or equal to SYSTEM_RUNNING then __init sections are no longer valid (since the assumption is that they have been freed). However, when rcuperf is setup to run in early boot it can call kernel_power_off() which sets the system_state to SYSTEM_POWER_OFF.
Since rcuperf initialization is invoked via a module_init(), we can make the dependency of jump_label_test() needing to complete before rcuperf explicit by calling it via early_initcall().
--- kernel/jump_label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/jump_label.c +1 -1
@@ -553,7 +553,7 @@ static __init int jump_label_test(void)return 0 ; } -late_initcall (jump_label_test); +early_initcall (jump_label_test);#endif /* STATIC_KEYS_SELFTEST */ #endif /* HAVE_JUMP_LABEL */
Greg Kroah-Hartman
maintainerPATCH 89/105 IB/mlx5: Assign send CQ and recv CQ of UMR QP
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Majd Dibbiny <[email protected]>
[ Upstream commit 31fde034a8bd964a5c7c1a5663fc87a913158db2 ]
The UMR's QP is created by calling mlx5_ib_create_qp directly, and therefore the send CQ and the recv CQ on the ibqp weren't assigned.
Assign them right after calling the mlx5_ib_create_qp to assure that any access to those pointers will work as expected and won't crash the system as might happen as part of reset flow.
--- drivers/infiniband/hw/mlx5/main.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/infiniband/hw/mlx5/main.c +2 -0
@@ -1123,6 +1123,8 @@ static int create_umr_res(struct mlx5_ib qp->real_qp = qp; qp->uobject =NULL ; qp->qp_type =MLX5_IB_QPT_REG_UMR ; + qp->send_cq = init_attr->send_cq; + qp->recv_cq = init_attr->recv_cq; attr->qp_state =IB_QPS_INIT ; attr->port_num =1 ;
Greg Kroah-Hartman
maintainerPATCH 90/105 afs: Connect up the CB.ProbeUuid
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Howells <[email protected]>
[ Upstream commit f4b3526d83c40dd8bf5948b9d7a1b2c340f0dcc8 ]
The handler for the CB.ProbeUuid operation in the cache manager is implemented, but isn't listed in the switch-statement of operation selection, so won't be used. Fix this by adding it.
--- fs/afs/cmservice.c | 3 +++ 1 file changed, 3 insertions(+)
fs/afs/cmservice.c +3 -0
@@ -115,6 +115,9 @@ bool afs_cm_incoming_call(struct afs_calcase CBProbe: call->type = &afs_SRXCBProbe;return true; +case CBProbeUuid: + call->type = &afs_SRXCBProbeUuid; +return true;case CBTellMeAboutYourself: call->type = &afs_SRXCBTellMeAboutYourself;return true;
Greg Kroah-Hartman
maintainerPATCH 76/105 route: update fnhe_expires for redirect when the fnhe exists
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Xin Long <[email protected]>
[ Upstream commit e39d5246111399dbc6e11cd39fd8580191b86c47 ]
Now when creating fnhe for redirect, it sets fnhe_expires for this new route cache. But when updating the exist one, it doesn't do it. It will cause this fnhe never to be expired.
Paolo already noticed it before, in Jianlin's test case, it became even worse:
When ip route flush cache, the old fnhe is not to be removed, but only clean it's members. When redirect comes again, this fnhe will be found and updated, but never be expired due to fnhe_expires not being set.
So fix it by simply updating fnhe_expires even it's for redirect.
--- net/ipv4/route.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
net/ipv4/route.c +2 -3
@@ -656,10 +656,9 @@ static void update_or_create_fnhe(struct fnhe->fnhe_genid = genid;if (gw) fnhe->fnhe_gw = gw; -if (pmtu) { +if (pmtu) fnhe->fnhe_pmtu = pmtu; - fnhe->fnhe_expires =max (1UL , expires); - } + fnhe->fnhe_expires =max (1UL , expires);/* Update all cached dsts too */ rt =rcu_dereference (fnhe->fnhe_rth_input);if (rt)
Greg Kroah-Hartman
maintainerPATCH 94/105 s390: always save and restore all registers on context switch
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Heiko Carstens <[email protected]>
commit fbbd7f1a51965b50dd12924841da0d478f3da71b upstream.
The switch_to() macro has an optimization to avoid saving and restoring register contents that aren't needed for kernel threads.
There is however the possibility that a kernel thread execve's a user space program. In such a case the execve'd process can partially see the contents of the previous process, which shouldn't be allowed.
To avoid this, simply always save and restore register contents on context switch.
--- arch/s390/include/asm/switch_to.h | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
arch/s390/include/asm/switch_to.h +9 -10
@@ -29,17 +29,16 @@ static inline void restore_access_regs(u }#define switch_to (prev,next,last) do { \ - if (prev->mm) { \ - save_fpu_regs(); \ - save_access_regs(&prev->thread.acrs[0]); \ - save_ri_cb(prev->thread.ri_cb); \ - } \ +/* save_fpu_regs() sets the CIF_FPU flag, which enforces \ +* a restore of the floating point / vector registers as \ +* soon as the next task returns to user space \ +*/ \ +save_fpu_regs (); \ +save_access_regs (&prev->thread.acrs[0 ]); \ +save_ri_cb (prev->thread.ri_cb); \update_cr_regs (next); \ - if (next->mm) { \ - set_cpu_flag(CIF_FPU); \ - restore_access_regs(&next->thread.acrs[0]); \ - restore_ri_cb(next->thread.ri_cb, prev->thread.ri_cb); \ - } \ +restore_access_regs (&next->thread.acrs[0 ]); \ +restore_ri_cb (next->thread.ri_cb, prev->thread.ri_cb); \ prev =__switch_to (prev,next); \ }while (0 )
Greg Kroah-Hartman
maintainerPATCH 100/105 net/packet: fix a race in packet_bind() and packet_notifier()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eric Dumazet <[email protected]>
[ Upstream commit 15fe076edea787807a7cdc168df832544b58eba6 ]
syzbot reported crashes [1] and provided a C repro easing bug hunting.
When/if packet_do_bind() calls __unregister_prot_hook() and releases po->bind_lock, another thread can run packet_notifier() and process an NETDEV_UP event.
This calls register_prot_hook() and hooks again the socket right before first thread is able to grab again po->bind_lock.
Fixes this issue by temporarily setting po->num to 0, as suggested by David Miller.
[1]dev_remove_pack: ffff8801bf16fa80 not found
------------[ cut here ]------------ kernel BUG at net/core/dev.c:7945! ( BUG_ON(!list_empty(&dev->ptype_all)); ) invalid opcode: 0000 [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: device syz0 entered promiscuous mode CPU: 0 PID: 3161 Comm: syzkaller404108 Not tainted 4.14.0+ #190 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 task: ffff8801cc57a500 task.stack: ffff8801cc588000 RIP: 0010:netdev_run_todo+0x772/0xae0 net/core/dev.c:7945 RSP: 0018:ffff8801cc58f598 EFLAGS: 00010293 RAX: ffff8801cc57a500 RBX: dffffc0000000000 RCX: ffffffff841f75b2 RDX: 0000000000000000 RSI: 1ffff100398b1ede RDI: ffff8801bf1f8810 device syz0 entered promiscuous mode RBP: ffff8801cc58f898 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8801bf1f8cd8 R13: ffff8801cc58f870 R14: ffff8801bf1f8780 R15: ffff8801cc58f7f0 FS: 0000000001716880(0000) GS:ffff8801db400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020b13000 CR3: 0000000005e25000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: rtnl_unlock+0xe/0x10 net/core/rtnetlink.c:106 tun_detach drivers/net/tun.c:670 [inline] tun_chr_close+0x49/0x60 drivers/net/tun.c:2845 __fput+0x333/0x7f0 fs/file_table.c:210 ____fput+0x15/0x20 fs/file_table.c:244 task_work_run+0x199/0x270 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x9bb/0x1ae0 kernel/exit.c:865 do_group_exit+0x149/0x400 kernel/exit.c:968 SYSC_exit_group kernel/exit.c:979 [inline] SyS_exit_group+0x1d/0x20 kernel/exit.c:977 entry_SYSCALL_64_fastpath+0x1f/0x96 RIP: 0033:0x44ad19
--- net/packet/af_packet.c | 5 +++++ 1 file changed, 5 insertions(+)
net/packet/af_packet.c +5 -0
@@ -2976,6 +2976,10 @@ static int packet_do_bind(struct sock *sif (need_rehook) {if (po->running) {rcu_read_unlock (); +/* prevents packet_notifier() from calling +* register_prot_hook() +*/ + po->num =0 ;__unregister_prot_hook (sk, true);rcu_read_lock (); dev_curr = po->prot_hook.dev;
@@ -2984,6 +2988,7 @@ static int packet_do_bind(struct sock *s dev->ifindex); } +BUG_ON (po->running); po->num = proto; po->prot_hook.type = proto;
Greg Kroah-Hartman
maintainerPATCH 77/105 lib/genalloc.c: make the avail variable an atomic_long_t
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stephen Bates <[email protected]>
[ Upstream commit 36a3d1dd4e16bcd0d2ddfb4a2ec7092f0ae0d931 ]
If the amount of resources allocated to a gen_pool exceeds 2^32 then the avail atomic overflows and this causes problems when clients try and borrow resources from the pool. This is only expected to be an issue on 64 bit systems.
Add the <linux/atomic.h> header to pull in atomic_long* operations. So that 32 bit systems continue to use atomic32_t but 64 bit systems can use atomic64_t.
--- include/linux/genalloc.h | 3 ++- lib/genalloc.c | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-)
include/linux/genalloc.h +2 -1
@@ -31,6 +31,7 @@#define __GENALLOC_H__#include <linux/spinlock_types.h> +#include <linux/atomic.h> struct device ;struct device_node ;
@@ -68,7 +69,7 @@ struct gen_pool {*/ struct gen_pool_chunk {struct list_head next_chunk;/* next chunk in pool */ -atomic_t avail; +atomic_long_t avail;phys_addr_t phys_addr;/* physical starting address of memory chunk */ unsigned long start_addr;/* start address of memory chunk */ unsigned long end_addr;/* end address of memory chunk (inclusive) */
lib/genalloc.c +5 -5
@@ -194,7 +194,7 @@ int gen_pool_add_virt(struct gen_pool *p chunk->phys_addr = phys; chunk->start_addr = virt; chunk->end_addr = virt + size -1 ; -atomic_set (&chunk->avail, size); +atomic_long_set (&chunk->avail, size);spin_lock (&pool->lock);list_add_rcu (&chunk->next_chunk, &pool->chunks);
@@ -285,7 +285,7 @@ unsigned long gen_pool_alloc(struct gen_ nbits = (size + (1UL << order) -1 ) >> order;rcu_read_lock ();list_for_each_entry_rcu (chunk, &pool->chunks, next_chunk) { -if (size >atomic_read (&chunk->avail)) +if (size >atomic_long_read (&chunk->avail))continue ; start_bit =0 ;
@@ -305,7 +305,7 @@ retry: addr = chunk->start_addr + ((unsigned long )start_bit << order); size = nbits << order; -atomic_sub (size, &chunk->avail); +atomic_long_sub (size, &chunk->avail);break ; }rcu_read_unlock ();
@@ -371,7 +371,7 @@ void gen_pool_free(struct gen_pool *pool remain =bitmap_clear_ll (chunk->bits, start_bit, nbits);BUG_ON (remain); size = nbits << order; -atomic_add (size, &chunk->avail); +atomic_long_add (size, &chunk->avail);rcu_read_unlock ();return ; }
@@ -445,7 +445,7 @@ size_t gen_pool_avail(struct gen_pool *prcu_read_lock ();list_for_each_entry_rcu (chunk, &pool->chunks, next_chunk) - avail +=atomic_read (&chunk->avail); + avail +=atomic_long_read (&chunk->avail);rcu_read_unlock ();return avail; }
Greg Kroah-Hartman
maintainerPATCH 78/105 dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Randy Dunlap <[email protected]>
[ Upstream commit 1f3c790bd5989fcfec9e53ad8fa09f5b740c958f ]
line-range is supposed to treat "1-" as "1-endoffile", so handle the special case by setting last_lineno to UINT_MAX.
Fixes this error:
dynamic_debug:ddebug_parse_query: last-line:0 < 1st-line:1 dynamic_debug:ddebug_exec_query: query parse failed
--- lib/dynamic_debug.c | 4 ++++ 1 file changed, 4 insertions(+)
lib/dynamic_debug.c +4 -0
@@ -353,6 +353,10 @@ static int ddebug_parse_query(char *wordif (parse_lineno (last, &query->last_lineno) <0 )return -EINVAL ; +/* special case for last lineno not specified */ +if (query->last_lineno ==0 ) + query->last_lineno =UINT_MAX ; +if (query->last_lineno < query->first_lineno) { pr_err("last-line:%d < 1st-line:%d\n", query->last_lineno,
Greg Kroah-Hartman
maintainerPATCH 79/105 NFS: Fix a typo in nfs_rename()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Trond Myklebust <[email protected]>
[ Upstream commit d803224c84be067754db7fa58a93f36f61566493 ]
On successful rename, the "old_dentry" is retained and is attached to the "new_dir", so we need to call nfs_set_verifier() accordingly.
--- fs/nfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/dir.c +1 -1
@@ -2051,7 +2051,7 @@ out:if (new_inode !=NULL )nfs_drop_nlink (new_inode);d_move (old_dentry, new_dentry); -nfs_set_verifier (new_dentry, +nfs_set_verifier (old_dentry,nfs_save_change_attribute (new_dir)); }else if (error == -ENOENT )nfs_dentry_handle_enoent (old_dentry);
Greg Kroah-Hartman
maintainerPATCH 81/105 block: wake up all tasks blocked in get_request()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ming Lei <[email protected]>
[ Upstream commit 34d9715ac1edd50285168dd8d80c972739a4f6a4 ]
Once blk_set_queue_dying() is done in blk_cleanup_queue(), we call blk_freeze_queue() and wait for q->q_usage_counter becoming zero. But if there are tasks blocked in get_request(), q->q_usage_counter can never become zero. So we have to wake up all these tasks in blk_set_queue_dying() first.
--- block/blk-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
block/blk-core.c +2 -2
@@ -526,8 +526,8 @@ void blk_set_queue_dying(struct request_blk_queue_for_each_rl (rl, q) {if (rl->rq_pool) { -wake_up (&rl->wait[BLK_RW_SYNC ]); -wake_up (&rl->wait[BLK_RW_ASYNC ]); +wake_up_all (&rl->wait[BLK_RW_SYNC ]); +wake_up_all (&rl->wait[BLK_RW_ASYNC ]); } } }
Greg Kroah-Hartman
maintainerPATCH 82/105 sparc64/mm: set fields in deferred pages
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Pavel Tatashin <[email protected]>
[ Upstream commit 2a20aa171071a334d80c4e5d5af719d8374702fc ]
Without deferred struct page feature (CONFIG_DEFERRED_STRUCT_PAGE_INIT), flags and other fields in "struct page"es are never changed prior to first initializing struct pages by going through __init_single_page().
With deferred struct page feature enabled there is a case where we set some fields prior to initializing:
mem_init() {
register_page_bootmem_info();
free_all_bootmem();
...
}When register_page_bootmem_info() is called only non-deferred struct pages are initialized. But, this function goes through some reserved pages which might be part of the deferred, and thus are not yet initialized.
mem_initregister_page_bootmem_inforegister_page_bootmem_info_node
get_page_bootmem
.. setting fields here ..
such as: page->freelist = (void *)type;
free_all_bootmem()free_low_memory_core_early()
for_each_reserved_mem_region()
reserve_bootmem_region()
init_reserved_page() <- Only if this is deferred reserved page
__init_single_pfn()
__init_single_page()
memset(0) <-- Loose the set fields hereWe end up with similar issue as in the previous patch, where currently we do not observe problem as memory is zeroed. But, if flag asserts are changed we can start hitting issues.
Also, because in this patch series we will stop zeroing struct page memory during allocation, we must make sure that struct pages are properly initialized prior to using them.
The deferred-reserved pages are initialized in free_all_bootmem(). Therefore, the fix is to switch the above calls.
--- arch/sparc/mm/init_64.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
arch/sparc/mm/init_64.c +8 -1
@@ -2402,10 +2402,17 @@ void __init mem_init(void) { high_memory =__va (last_valid_pfn <<PAGE_SHIFT ); -register_page_bootmem_info ();free_all_bootmem ();/* +* Must be done after boot memory is put on freelist, because here we +* might set fields in deferred struct pages that have not yet been +* initialized, and free_all_bootmem() initializes all the reserved +* deferred pages for us. +*/ +register_page_bootmem_info (); + +/* * Set up the zero page, mark it reserved, so that page count * is not manipulated when freeing the page from user ptes. */
Greg Kroah-Hartman
maintainerPATCH 74/105 mac80211_hwsim: Fix memory leak in hwsim_new_radio_nl()
In reply to Greg Kroah-Hartman4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <[email protected]>
[ Upstream commit 67bd52386125ce1159c0581cbcd2740addf33cd4 ]
hwsim_new_radio_nl() now copies the name attribute in order to add a null-terminator. mac80211_hwsim_new_radio() (indirectly) copies it again into the net_device structure, so the first copy is not used or freed later. Free the first copy before returning.
--- drivers/net/wireless/mac80211_hwsim.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/mac80211_hwsim.c +4 -1
@@ -2885,6 +2885,7 @@ static int hwsim_new_radio_nl(struct sk_ {struct hwsim_new_radio_params param = {0 };const char *hwname =NULL ; +int ret; param.reg_strict = info->attrs[HWSIM_ATTR_REG_STRICT_REG ]; param.p2p_device = info->attrs[HWSIM_ATTR_SUPPORT_P2P_DEVICE ];
@@ -2924,7 +2925,9 @@ static int hwsim_new_radio_nl(struct sk_ param.regd = hwsim_world_regdom_custom[idx]; } -return mac80211_hwsim_new_radio (info, ¶m); + ret =mac80211_hwsim_new_radio (info, ¶m); +kfree (hwname); +return ret; }static int hwsim_del_radio_nl (struct sk_buff *msg,struct genl_info *info)
Quoted 446 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.106 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Dec 17 09:22:39 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.106-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:Greg Kroah-Hartman <[email protected]>
Linux 4.4.106-rc1Vincent Pelletier <[email protected]>
usb: gadget: ffs: Forbidusb_ep_alloc_requestfrom sleepingMarc Zyngier <[email protected]>
arm: KVM: FixVTTBR_BADDR_MASKBUG_ONoff-by-oneGreg Kroah-Hartman <[email protected]>
Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"Greg Kroah-Hartman <[email protected]>
Revert "x86/efi: Hoist page table switching code intoefi_call_virt()"Greg Kroah-Hartman <[email protected]>
Revert "x86/efi: Build our own page table structures"Eric Dumazet <[email protected]>
net/packet: fix a race inpacket_bind()andpacket_notifier()Mike Maloney <[email protected]>
packet: fix crash infanout_demux_rollover()Hangbin Liu <[email protected]>
sit: updatefrag_offinfoH�kon Bugge <[email protected]>
rds: Fix NULL pointer dereference in__rds_rdma_mapJon Maloy <[email protected]>
tipc: fix memory leak intipc_accept_from_sock()Al Viro <[email protected]>
morebio_map_user_iov()leak fixesHeiko Carstens <[email protected]>
s390: always save and restore all registers on context switchMasamitsu Yamazaki <[email protected]>
ipmi: Stop timers before cleaning up the modulePaul Moore <[email protected]>
audit: ensure that 'audit=1' actually enables audit for PID 1Keefe Liu <[email protected]>
ipvlan: fix ipv6 outbound deviceDavid Howells <[email protected]>
afs: Connect up the CB.ProbeUuidMajd Dibbiny <[email protected]>
IB/mlx5: Assign send CQ and recv CQ of UMR QPMark Bloch <[email protected]>
IB/mlx4: Increase maximal message size under UD QPHerbert Xu <[email protected]>
xfrm: Copy policy family inclone_policyJason Baron <[email protected]>
jump_label: Invokejump_label_test()viaearly_initcall()Arvind Yadav <[email protected]>
atm: horizon: Fix irq release errorXin Long <[email protected]>
sctp: use the right sk after waking up fromwait_bufsleepXin Long <[email protected]>
sctp: do not free asoc when it is already dead insctp_sendmsgPavel Tatashin <[email protected]>
sparc64/mm: set fields in deferred pagesMing Lei <[email protected]>
block: wake up all tasks blocked inget_request()Chuck Lever <[email protected]>
sunrpc: Fixrpc_task_begintrace pointTrond Myklebust <[email protected]>
NFS: Fix a typo innfs_rename()Randy Dunlap <[email protected]>
dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0Stephen Bates <[email protected]>
lib/genalloc.c: make the avail variable anatomic_long_tXin Long <[email protected]>
route: updatefnhe_expiresfor redirect when the fnhe existsXin Long <[email protected]>
route: also updatefnhe_genidwhen updating a route cacheBen Hutchings <[email protected]>
mac80211_hwsim: Fix memory leak inhwsim_new_radio_nl()Masahiro Yamada <[email protected]>
kbuild: pkg: use --transform option to prefix paths in tarJ�r�my Lefaure <[email protected]>
EDAC, i5000, i5400: Fix definition of NRECMEMB registerJ�r�my Lefaure <[email protected]>
EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macroAlexey Kardashevskiy <[email protected]>
powerpc/powernv/ioda2: Gracefully fail if too many TCE levels requestedJim Qu <[email protected]>
drm/amd/amdgpu: fix console deadlock if late init failedJan Kara <[email protected]>
axonram: Fix gendisk handlingFlorian Westphal <[email protected]>
netfilter: don't track fragmented packetsJohannes Thumshirn <[email protected]>
zram: set physical queue limits to avoid array out of bounds accessesChris Brandt <[email protected]>
i2c: riic: fix restart conditionKrzysztof Kozlowski <[email protected]>
crypto: s5p-sss - Fix completing crypto request in IRQ handlerWANG Cong <[email protected]>
ipv6: reordericmpv6_init()andip6_mr_init()Michal Schmidt <[email protected]>
bnx2x: do not rollback VF MAC/VLAN filters we did not configureMichal Schmidt <[email protected]>
bnx2x: fix possible overrun of VFPF multicast addresses arrayMichal Schmidt <[email protected]>
bnx2x: prevent crash when accessing PTP with interface downBlomme, Maarten <[email protected]>
spi_ks8995: fix "BUG: key accdaa28 not in .data!"Mark Rutland <[email protected]>
arm64: KVM: Survive unknown traps from guestsMark Rutland <[email protected]>
arm: KVM: Survive unknown traps from guestsWanpeng Li <[email protected]>
KVM: nVMX: resetnested_run_pendingif the vCPU is going to be resetFranck Demathieu <[email protected]>
irqchip/crossbar: Fix incorrect type of register sizeJames Smart <[email protected]>
scsi: lpfc: Fix crash during Hardware error recovery on SLI3 adaptersTejun Heo <[email protected]>
workqueue: trigger WARN ifqueue_delayed_work()is called with NULL @wqTejun Heo <[email protected]>
libata: drop WARN from protocol error inata_sff_qc_issue()Jim Mattson <[email protected]>
kvm: nVMX: VMCLEAR should not cause the vCPU to shut downChristophe JAILLET <[email protected]>
USB: gadgetfs: Fix a potential memory leak in 'dev_config()'John Keeping <[email protected]>
usb: gadget: configs: plug memory leakDaniel Drake <[email protected]>
HID: chicony: Add support for another ASUS Zen AiO keyboardPhil Reid <[email protected]>
gpio: altera: Usehandle_level_irqwhen configured as alevel_highGuenter Roeck <[email protected]>
ARM: OMAP2+: Release device node after it is no longer needed.Guenter Roeck <[email protected]>
ARM: OMAP2+: Fix device node reference countsDavid Daney <[email protected]>
module: set__jump_tablealignment to 8Sachin Sant <[email protected]>
selftest/powerpc: Fix false failures for skipped testsThomas Gleixner <[email protected]>
x86/hpet: Prevent might sleep splat on resumeLadislav Michl <[email protected]>
ARM: OMAP2+: gpmc-onenand: propagate error on initialization failureSteffen Klassert <[email protected]>
vti6: Don't report path MTU belowIPV6_MIN_MTU.Sasha Levin <[email protected]>
Revert "s390/kbuild: enable modversions for symbols exported from asm"Sasha Levin <[email protected]>
Revert "spi:SPI_FSL_DSPIshould depend onHAS_DMA"Sasha Levin <[email protected]>
Revert "drm/armada: Fix compile fail"Kirill A. Shutemov <[email protected]>
mm: drop unusedpmdp_huge_get_and_clear_notify()Kirill A. Shutemov <[email protected]>
thp: fixMADV_DONTNEEDvs. numa balancing raceKirill A. Shutemov <[email protected]>
thp: reduce indentation level inchange_huge_pmd()Stephen Hemminger <[email protected]>
scsi: storvsc: Workaround for virtual DVD SCSI versionRussell King <[email protected]>
ARM: avoid faulting on qemuRussell King <[email protected]>
ARM: BUG if jumping to usermode address in kernel modeDave Martin <[email protected]>
arm64: fpsimd: Prevent registers leaking from dead tasksAndrew Honig <[email protected]>
KVM: VMX: remove I/O port 0x80 bypass on Intel hostsKristina Martsenko <[email protected]>
arm64: KVM: fixVTTBR_BADDR_MASKBUG_ONoff-by-oneLaurent Caumont <[email protected]>
media: dvb: i2c transfers over usb cannot be done from stackMarek Szyprowski <[email protected]>
drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMUDave Gordon <[email protected]>
drm: extraprintk()wrapper macrosDaniel Thompson <[email protected]>
kdb: Fix handling ofkallsyms_symbol_next()return valueHeiko Carstens <[email protected]>
s390: fix compat system call tableRobin Murphy <[email protected]>
iommu/vt-d: Fix scatterlist offset handlingJaejoong Kim <[email protected]>
ALSA: usb-audio: Add check return value forusb_string()Jaejoong Kim <[email protected]>
ALSA: usb-audio: Fix out-of-bound errorTakashi Iwai <[email protected]>
ALSA: seq: Remove spuriousWARN_ON()at timer checkRobb Glasser <[email protected]>
ALSA: pcm: prevent UAF insnd_pcm_infoRafael J. Wysocki <[email protected]>
x86/PCI: Makebroadcom_postcore_init()checkacpi_disabledEric Biggers <[email protected]>
X.509: reject invalid BIT STRING for subjectPublicKeyEric Biggers <[email protected]>
ASN.1: check for error fromASN1_OP_END__ACTactionsEric Biggers <[email protected]>
ASN.1: fix out-of-bounds read when parsing indefinite length itemGreg Kroah-Hartman <[email protected]>
efi: Move some sysfs files to be read-only by rootHuacai Chen <[email protected]>
scsi: libsas: align sata_device'srps_respon a cachelineWilliam Breathitt Gray <[email protected]>
isa: Prevent NULL dereference inisa_busdriver callbacksPaul Meyer <[email protected]>
hv: kvp: Avoid reading past allocated blocks from KVP fileweiping zhang <[email protected]>
virtio: release virtio index when fail todevice_registerMartin Kelly <[email protected]>
can:usb_8dev: cancel urb on-EPIPEand-EPROTOMartin Kelly <[email protected]>
can:esd_usb2: cancel urb on-EPIPEand-EPROTOMartin Kelly <[email protected]>
can:ems_usb: cancel urb on-EPIPEand-EPROTOMartin Kelly <[email protected]>
can:kvaser_usb: cancel urb on-EPIPEand-EPROTOJimmy Assarsson <[email protected]>
can:kvaser_usb: ratelimit errors if incomplete messages are receivedJimmy Assarsson <[email protected]>
can:kvaser_usb: Fix comparison bug inkvaser_usb_read_bulk_callback()Jimmy Assarsson <[email protected]>
can:kvaser_usb: free buf in error pathsOliver St�bler <[email protected]>
can:ti_hecc: Fix napi poll return value for repoll-------------
Diffstat:
Makefile | 4 +- arch/arm/include/asm/assembler.h | 18 +++ arch/arm/include/asm/kvm_arm.h | 4 +- arch/arm/kernel/entry-header.S | 6 + arch/arm/kvm/handle_exit.c | 19 +-- arch/arm/mach-omap2/gpmc-onenand.c | 10 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 25 ++-- arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/kernel/process.c | 9 ++ arch/arm64/kvm/handle_exit.c | 19 +-- arch/powerpc/platforms/powernv/pci-ioda.c | 3 + arch/powerpc/sysdev/axonram.c | 5 +- arch/s390/include/asm/asm-prototypes.h | 8 -- arch/s390/include/asm/switch_to.h | 19 ++- arch/s390/kernel/syscalls.S | 6 +- arch/sparc/mm/init_64.c | 9 +- arch/x86/include/asm/efi.h | 26 ---- arch/x86/kernel/hpet.c | 2 +- arch/x86/kvm/vmx.c | 31 ++--- arch/x86/mm/pageattr.c | 17 ++- arch/x86/pci/broadcom_bus.c | 2 +- arch/x86/platform/efi/efi.c | 39 +++--- arch/x86/platform/efi/efi_32.c | 5 - arch/x86/platform/efi/efi_64.c | 137 ++++++---------------- arch/x86/platform/efi/efi_stub_64.S | 43 +++++++ block/bio.c | 14 ++- block/blk-core.c | 4 +- crypto/asymmetric_keys/x509_cert_parser.c | 2 + drivers/ata/libata-sff.c | 1 - drivers/atm/horizon.c | 2 +- drivers/base/isa.c | 10 +- drivers/block/zram/zram_drv.c | 2 + drivers/char/ipmi/ipmi_si_intf.c | 44 +++---- drivers/crypto/s5p-sss.c | 5 +- drivers/edac/i5000_edac.c | 8 +- drivers/edac/i5400_edac.c | 9 +- drivers/firmware/efi/efi.c | 3 +- drivers/firmware/efi/esrt.c | 15 +-- drivers/firmware/efi/runtime-map.c | 10 +- drivers/gpio/gpio-altera.c | 26 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +- drivers/gpu/drm/armada/Makefile | 2 - drivers/gpu/drm/exynos/exynos_drm_gem.c | 9 ++ drivers/hid/Kconfig | 4 +- drivers/hid/hid-chicony.c | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/i2c/busses/i2c-riic.c | 6 +- drivers/infiniband/hw/mlx4/qp.c | 2 +- drivers/infiniband/hw/mlx5/main.c | 2 + drivers/iommu/intel-iommu.c | 8 +- drivers/irqchip/irq-crossbar.c | 8 +- drivers/media/usb/dvb-usb/dibusb-common.c | 16 ++- drivers/memory/omap-gpmc.c | 4 +- drivers/net/can/ti_hecc.c | 3 + drivers/net/can/usb/ems_usb.c | 2 + drivers/net/can/usb/esd_usb2.c | 2 + drivers/net/can/usb/kvaser_usb.c | 13 +- drivers/net/can/usb/usb_8dev.c | 2 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 20 +++- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 8 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 23 ++-- drivers/net/ipvlan/ipvlan_core.c | 2 +- drivers/net/phy/spi_ks8995.c | 1 + drivers/net/wireless/mac80211_hwsim.c | 5 +- drivers/scsi/lpfc/lpfc_els.c | 14 ++- drivers/scsi/storvsc_drv.c | 27 +++-- drivers/spi/Kconfig | 1 - drivers/usb/gadget/configfs.c | 1 + drivers/usb/gadget/function/f_fs.c | 2 +- drivers/usb/gadget/legacy/inode.c | 4 +- drivers/virtio/virtio.c | 2 + fs/afs/cmservice.c | 3 + fs/nfs/dir.c | 2 +- include/drm/drmP.h | 26 +++- include/linux/genalloc.h | 3 +- include/linux/mmu_notifier.h | 13 -- include/linux/omap-gpmc.h | 5 +- include/linux/sysfs.h | 6 + include/scsi/libsas.h | 2 +- kernel/audit.c | 10 +- kernel/debug/kdb/kdb_io.c | 2 +- kernel/jump_label.c | 2 +- kernel/workqueue.c | 1 + lib/asn1_decoder.c | 49 ++++---- lib/dynamic_debug.c | 4 + lib/genalloc.c | 10 +- mm/huge_memory.c | 82 +++++++++---- net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c | 4 + net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 5 - net/ipv4/route.c | 14 ++- net/ipv6/af_inet6.c | 10 +- net/ipv6/ip6_vti.c | 8 +- net/ipv6/sit.c | 1 + net/packet/af_packet.c | 37 +++--- net/packet/internal.h | 1 - net/rds/rdma.c | 2 +- net/sctp/socket.c | 38 ++++-- net/sunrpc/sched.c | 3 +- net/tipc/server.c | 1 + net/xfrm/xfrm_policy.c | 1 +
Quoted 10 lines
scripts/module-common.lds | 2 + scripts/package/Makefile | 5 +- sound/core/pcm.c | 2 + sound/core/seq/seq_timer.c | 2 +- sound/usb/mixer.c | 13 +- tools/hv/hv_kvp_daemon.c | 70 +++-------- tools/testing/selftests/powerpc/harness.c | 6 +- 109 files changed, 701 insertions(+), 570 deletions(-)
Merged, compiled, and flashed onto my Pixel 2 XL and OnePlus 5.
No initial issues noticed in general usage or dmesg.
Cheers!
Nathan
Greg Kroah-Hartman
maintainerQuoted 4 lines · Nathan Chancellor
Merged, compiled, and flashed onto my Pixel 2 XL and OnePlus 5.
No initial issues noticed in general usage or dmesg.
Wonderful, thanks for testing and letting me know.
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.106 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Dec 17 09:22:39 UTC 2017. Anything received after that time might be too late.
Build results:
total: 145 pass: 145 fail: 0 Qemu test results: total: 116 pass: 116 fail: 0
Details are available at http://kerneltests.org/builders.
Guenter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.106 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Dec 17 09:22:39 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.106-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.106 release. There are 105 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun Dec 17 09:22:39 UTC 2017. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.106-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.4.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm and x86_64.
NOTE:
We do not have arm64 hikey board results due to the changes required from the firmware update. Hikey board is under maintenance.
readahead02 failed once in 3 iterations of full syscall run which is intermittently failure on ARM64 juno running 4.4.106-rc1. Resubmitted test looped for 20 Iterations out of which 7 times TCONF and 13 times PASS.
Test log failed instance:
readahead02 0 TINFO : read_testfile(0) used cache: 65468 kB readahead02 0 TINFO : read_testfile(1) used cache: 32592 kB readahead02 0 TWARN : readahead02.c:351: using less cache than expected
Test pass log:
readahead02 0 TINFO : read_testfile(0) used cache: 65568 kB readahead02 0 TINFO : read_testfile(1) used cache: 65268 kB readahead02 3 TPASS : using cache as expected
Test CONF log:
readahead02 0 TINFO : read_testfile(0) used cache: 65376 kB readahead02 0 TINFO : read_testfile(1) used cache: 65564 kB readahead02 3 TCONF : readahead02.c:354: Page cache on your
system is too small to hold whole testfile.
Bug reported for the investigation.
https://bugs.linaro.org/show_bug.cgi?id=3539
Summary
------------------------------------------------------------------------
kernel: 4.4.106-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.4.y
git commit: 67065bd41780929c2b8406ac3dd5356e83cd2d19
git describe: v4.4.105-106-g67065bd41780
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.4-oe/build/v4.4.105-106-g67065bd41780
No regressions (compared to build v4.4.105-108-g894d367e5d93)
------------------------------------------------------------------------
Boards, architectures and test suites:
-------------------------------------
juno-r2 - arm64
* boot - pass: 20,
* kselftest - pass: 32, skip: 29
* libhugetlbfs - pass: 90, skip: 1
* ltp-cap_bounds-tests - pass: 2,
* ltp-containers-tests - pass: 28, skip: 36
* ltp-fcntl-locktests-tests - pass: 2,
* ltp-filecaps-tests - pass: 2,
* ltp-fs-tests - pass: 60,
* ltp-fs_bind-tests - pass: 2,
* ltp-fs_perms_simple-tests - pass: 19,
* ltp-fsx-tests - pass: 2,
* ltp-hugetlb-tests - pass: 22,
* ltp-io-tests - pass: 3,
* ltp-ipc-tests - pass: 9,
* ltp-math-tests - pass: 11,
* ltp-nptl-tests - pass: 2,
* ltp-pty-tests - pass: 4,
* ltp-sched-tests - pass: 14,
* ltp-securebits-tests - pass: 4,
* ltp-syscalls-tests - fail: 2, pass: 980, skip: 124
* ltp-timers-tests - pass: 12,
x15 - arm
* boot - pass: 20,
* kselftest - pass: 31, skip: 29
* libhugetlbfs - pass: 87, skip: 1
* ltp-cap_bounds-tests - pass: 2,
* ltp-containers-tests - pass: 64,
* ltp-fcntl-locktests-tests - pass: 2,
* ltp-filecaps-tests - pass: 2,
* ltp-fs-tests - pass: 60,
* ltp-fs_bind-tests - pass: 2,
* ltp-fs_perms_simple-tests - pass: 19,
* ltp-fsx-tests - pass: 2,
* ltp-hugetlb-tests - pass: 20, skip: 2
* ltp-io-tests - pass: 3,
* ltp-ipc-tests - pass: 9,
* ltp-math-tests - pass: 11,
* ltp-nptl-tests - pass: 2,
* ltp-pty-tests - pass: 4,
* ltp-sched-tests - pass: 13, skip: 1
* ltp-securebits-tests - pass: 4,
* ltp-syscalls-tests - pass: 1035, skip: 67
* ltp-timers-tests - pass: 12,
x86_64
* boot - pass: 20,
* kselftest - pass: 44, skip: 32
* libhugetlbfs - pass: 90, skip: 1
* ltp-cap_bounds-tests - pass: 2,
* ltp-containers-tests - pass: 64,
* ltp-fcntl-locktests-tests - pass: 2,
* ltp-filecaps-tests - pass: 2,
* ltp-fs-tests - pass: 61, skip: 1
* ltp-fs_bind-tests - pass: 2,
* ltp-fs_perms_simple-tests - pass: 19,
* ltp-fsx-tests - pass: 2,
* ltp-hugetlb-tests - pass: 22,
* ltp-io-tests - pass: 3,
* ltp-ipc-tests - pass: 9,
* ltp-math-tests - pass: 11,
* ltp-nptl-tests - pass: 2,
* ltp-pty-tests - pass: 4,
* ltp-sched-tests - pass: 9, skip: 1
* ltp-securebits-tests - pass: 4,
* ltp-syscalls-tests - pass: 956, skip: 164
* ltp-timers-tests - pass: 12,
Documentation - https://collaborate.linaro.org/display/LKFT/Email+Reports
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Greg Kroah-HartmanQuoted 5 lines · Greg Kroah-Hartman
This reverts commit
87e2bd898d3a79a8c609f183180adac47879a2a4which is commitedc3b9129cecd0f0857112136f5b8b1bc1d45918upstream.Turns there was too many other issues with this patch to make it viable for the stable tree.
This was sort of a long time ago, but does anyone remember why this needed to be reverted from 4.4?
The reason I ask is that without this, commit 02ff2769edbc / "x86/mm/pat: Make set_memory_np() L1TF safe" in 4.4.148 is broken. That patch has
- set_pud(pud, __pud(cpa->pfn | _PAGE_PSE |
- massage_pgprot(pud_pgprot)));
+ set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn,
+ canon_pgprot(pud_pgprot))));
(and similarly for pmds) but pfn_pud() is operating on page frame numbers and __pud(cpa->pfn... in the old code is operating on physical addresses.
This is bad enough that 4.4.148 and all newer 4.4.y crash early in boot on some EFI systems that I have.
For now I am re-applying the "ensure cpa->pfn only contains page frame numbers" patch, ported on top of 4.4.151.
- R.
Greg Kroah-Hartman
maintainerRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 10 lines · Roland Dreier
Quoted 5 lines · Greg Kroah-Hartman
This reverts commit
87e2bd898d3a79a8c609f183180adac47879a2a4which is commitedc3b9129cecd0f0857112136f5b8b1bc1d45918upstream.Turns there was too many other issues with this patch to make it viable for the stable tree.
This was sort of a long time ago, but does anyone remember why this needed to be reverted from 4.4?
I tried to dig through my old emails, but could not find anything, sorry.
Quoted 9 lines
The reason I ask is that without this, commit
02ff2769edbc/ "x86/mm/pat: Makeset_memory_np()L1TF safe" in 4.4.148 is broken. That patch has(quoted diff) +2
-2- set_pud(pud, __pud(cpa->pfn | _PAGE_PSE | - massage_pgprot(pud_pgprot))); + set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, + canon_pgprot(pud_pgprot))));
Quoted 6 lines
(and similarly for pmds) but
pfn_pud()is operating on page frame numbers and __pud(cpa->pfn... in the old code is operating on physical addresses.This is bad enough that 4.4.148 and all newer 4.4.y crash early in boot on some EFI systems that I have.
Ugh, not good.
Quoted 2 lines
For now I am re-applying the "ensure
cpa->pfnonly contains page frame numbers" patch, ported on top of 4.4.151.
I can try to add it back and see what blows up, want me to attempt that? :)
thanks,
greg k-h
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 9 lines
Quoted 2 lines
This is bad enough that 4.4.148 and all newer 4.4.y crash early in boot on some EFI systems that I have.
Ugh, not good.
Quoted 2 lines
For now I am re-applying the "ensure
cpa->pfnonly contains page frame numbers" patch, ported on top of 4.4.151.I can try to add it back and see what blows up, want me to attempt that?
Not sure what to say... the current state is obviously broken. If you look at what 02ff2769edbc is doing, it's clear that we're now shifting cpa->pfn by PAGE_SHIFT where we weren't before, so we're putting bogus values in the page table. And this is enough that my server system booting with EFI crashes early in boot efi_enter_virtual_mode() with the symptom that NX is improperly set on some pages (booting with "noexec=off" fixes things, although obviously I don't want to run that way). FWIW I can confirm that reverting the single patch 02ff2769edbc fixes things, as does the cpa->pfn fix I mentioned above.
It's hard for me to make a call on applying "ensure cpa->pfn only contains page frame numbers" without knowing the problems it caused before. The patch looks fine to me and I definitely need it, but maybe it exposes some other bug elsewhere? Maybe Ben or Matt remember more above why this was reverted in 4.4.106? Otherwise I'd say yeah, we should re-apply it, since I don't think we want to revert 02ff2769edbc.
- R.
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 20 lines · Roland Dreier
Quoted 9 lines
Quoted 2 lines
This is bad enough that 4.4.148 and all newer 4.4.y crash early in boot on some EFI systems that I have.
Ugh, not good.
Quoted 2 lines
For now I am re-applying the "ensure
cpa->pfnonly contains page frame numbers" patch, ported on top of 4.4.151.I can try to add it back and see what blows up, want me to attempt that?
Not sure what to say... the current state is obviously broken. If you look at what
02ff2769edbcis doing, it's clear that we're now shiftingcpa->pfnbyPAGE_SHIFTwhere we weren't before, so we're putting bogus values in the page table. And this is enough that my server system booting with EFI crashes early in bootefi_enter_virtual_mode()with the symptom that NX is improperly set on some pages (booting with "noexec=off" fixes things, although obviously I don't want to run that way). FWIW I can confirm that reverting the single patch02ff2769edbcfixes things, as does thecpa->pfnfix I mentioned above.
Quoted 7 lines
It's hard for me to make a call on applying "ensure
cpa->pfnonly contains page frame numbers" without knowing the problems it caused before. The patch looks fine to me and I definitely need it, but maybe it exposes some other bug elsewhere? Maybe Ben or Matt remember more above why this was reverted in 4.4.106? Otherwise I'd say yeah, we should re-apply it, since I don't think we want to revert02ff2769edbc.
For the record, I wasn't even aware it had been reverted.
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Roland DreierQuoted 10 lines · Roland Dreier
On Fri, Dec 15, 2017 at 2:20 AM Greg Kroah-Hartman
Quoted 6 lines
<[email protected]> wrote:
This reverts commit87e2bd898d3a79a8c609f183180adac47879a2a4which is commitedc3b9129cecd0f0857112136f5b8b1bc1d45918upstream.Turns there was too many other issues with this patch to make it viable for the stable tree.
This was sort of a long time ago, but does anyone remember why this needed to be reverted from 4.4?
See
<https://lore.kernel.org/lkml/[email protected]/T/#u>.
Ben.
Quoted 21 lines
The reason I ask is that without this, commit
02ff2769edbc/ "x86/mm/pat: Makeset_memory_np()L1TF safe" in 4.4.148 is broken. That patch has- set_pud(pud, __pud(cpa->pfn |
_PAGE_PSE| - massage_pgprot(pud_pgprot))); + set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, + canon_pgprot(pud_pgprot))));(and similarly for pmds) but
pfn_pud()is operating on page frame numbers and __pud(cpa->pfn... in the old code is operating on physical addresses.This is bad enough that 4.4.148 and all newer 4.4.y crash early in boot on some EFI systems that I have.
For now I am re-applying the "ensure
cpa->pfnonly contains page frame numbers" patch, ported on top of 4.4.151.- R.
Signature · 3 lines
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United KingdomRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 2 lines
Thanks! I'm not using SGI UV and I'm not using kexec, so I guess I sidestepped most of those issues. Greg, I think we need to unrevert the cpa->pfn change (otherwise the L1TF fix probably gets pretty messy) and I guess pull in the other patches that Ben mentions.
- R.
Greg Kroah-Hartman
maintainerRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 7 lines · Roland Dreier
Quoted 2 lines
Thanks! I'm not using SGI UV and I'm not using kexec, so I guess I sidestepped most of those issues. Greg, I think we need to unrevert the
cpa->pfnchange (otherwise the L1TF fix probably gets pretty messy) and I guess pull in the other patches that Ben mentions.
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Guenter, any ideas?
thanks,
greg k-h
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in edc3b9129cec and at least the first three patches that Ben listed:
21cdb6b56843 x86/mm: Page align the '_end' symbol to avoid pfn conversion bugs b61a76f8850d x86/efi: Map RAM into the identity page table for mixed mode 753b11ef8e92 x86/efi: Setup separate EFI page tables in kexec paths
the first patch takes a bit of massaging (mostly because some of it is already touched by 02ff2769edbc, which keeps the changes from edc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.
I'm currently testing that and can send you the state of my tree in a bit.
- R.
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Greg Kroah-HartmanQuoted 9 lines · Greg Kroah-Hartman
Quoted 7 lines · Roland Dreier
Quoted 2 lines
Thanks! I'm not using SGI UV and I'm not using kexec, so I guess I sidestepped most of those issues. Greg, I think we need to unrevert the
cpa->pfnchange (otherwise the L1TF fix probably gets pretty messy) and I guess pull in the other patches that Ben mentions.
Quoted 6 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Guenter, any ideas?
I think we'll need to reapply 87e2bd898d3a ("x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"), and possibly apply d367cef0a7f0 ("x86/mm/pat:
Fix boot crash when 1GB pages are not supported by the CPU"). Both require conflict resolutions, but they are quite straightforward. I am not sure about the other EFI patches.
I am going to send the backports as RFT in a minute. Problem is that I don't have an EFI system at hand and can not test if this fixes the problem (or maybe introduces a new one), so someone will need to step in and do those tests.
Guenter
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Roland DreierQuoted 14 lines · Roland Dreier
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in
edc3b9129cecand at least the first three patches that Ben listed:
21cdb6b56843x86/mm: Page align the '_end' symbol to avoid pfn conversion bugsb61a76f8850dx86/efi: Map RAM into the identity page table for mixed mode753b11ef8e92x86/efi: Setup separate EFI page tables in kexec paths
Quoted 7 lines
the first patch takes a bit of massaging (mostly because some of it is already touched by
02ff2769edbc, which keeps the changes fromedc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.I'm currently testing that and can send you the state of my tree in a bit.
Sounds great. I'll hold off with sending my RFT series and wait for your test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix boot crash when 1GB pages are not supported by the CPU").
Thanks,
Guenter
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 3 lines
Sounds great. I'll hold off with sending my RFT series and wait for your test results. I think we'll also need
d367cef0a7f0c6("x86/mm/pat: Fix boot crash when 1GB pages are not supported by the CPU").
Sure, makes sense - I don't have any EFI systems with CPUs old enough not to support 1G pages but that looks reasonable. I'll pull that into my tree as well.
- R.
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 8 lines · Roland Dreier
Quoted 3 lines
Sounds great. I'll hold off with sending my RFT series and wait for your test results. I think we'll also need
d367cef0a7f0c6("x86/mm/pat: Fix boot crash when 1GB pages are not supported by the CPU").Sure, makes sense - I don't have any EFI systems with CPUs old enough not to support 1G pages but that looks reasonable. I'll pull that into my tree as well.
kernelci reported a crash on a CPU which doesn't support 1G pages. See https://kernelci.org/boot/id/5b7d39ea59b514c03796ba9c/
Guenter
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Roland Dreier+Andi Kleen <[email protected]>
Quoted 22 lines · Roland Dreier
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in
edc3b9129cecand at least the first three patches that Ben listed:
21cdb6b56843x86/mm: Page align the '_end' symbol to avoid pfn conversion bugsb61a76f8850dx86/efi: Map RAM into the identity page table for mixed mode753b11ef8e92x86/efi: Setup separate EFI page tables in kexec pathsthe first patch takes a bit of massaging (mostly because some of it is already touched by
02ff2769edbc, which keeps the changes fromedc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.I'm currently testing that and can send you the state of my tree in a bit.
- R.
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Roland DreierHi Roland,
Quoted 14 lines · Roland Dreier
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in
edc3b9129cecand at least the first three patches that Ben listed:
21cdb6b56843x86/mm: Page align the '_end' symbol to avoid pfn conversion bugsb61a76f8850dx86/efi: Map RAM into the identity page table for mixed mode753b11ef8e92x86/efi: Setup separate EFI page tables in kexec paths
Quoted 7 lines
the first patch takes a bit of massaging (mostly because some of it is already touched by
02ff2769edbc, which keeps the changes fromedc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.I'm currently testing that and can send you the state of my tree in a bit.
Have you made any progress ? On my side I am still out of luck since I can not reproduce the problem.
Thanks,
Guenter
Greg Kroah-Hartman
maintainerRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 22 lines · Guenter Roeck
Hi Roland,
Quoted 19 lines · Roland Dreier
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in
edc3b9129cecand at least the first three patches that Ben listed:
21cdb6b56843x86/mm: Page align the '_end' symbol to avoid pfn conversion bugsb61a76f8850dx86/efi: Map RAM into the identity page table for mixed mode753b11ef8e92x86/efi: Setup separate EFI page tables in kexec pathsthe first patch takes a bit of massaging (mostly because some of it is already touched by
02ff2769edbc, which keeps the changes fromedc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.
Quoted 5 lines
Quoted 2 lines
I'm currently testing that and can send you the state of my tree in a bit.
Have you made any progress ? On my side I am still out of luck since I can not reproduce the problem.
Perhaps just the patch that Andi posted to the stable list helps out here?
Roland, can you try just that?
thanks,
greg k-h
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 23 lines · Greg Kroah-Hartman
Quoted 22 lines · Guenter Roeck
Hi Roland,
Quoted 19 lines · Roland Dreier
Quoted 3 lines
Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do.
Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up.
I don't think we want to revert anything. I think you should pull in
edc3b9129cecand at least the first three patches that Ben listed:
21cdb6b56843x86/mm: Page align the '_end' symbol to avoid pfn conversion bugsb61a76f8850dx86/efi: Map RAM into the identity page table for mixed mode753b11ef8e92x86/efi: Setup separate EFI page tables in kexec pathsthe first patch takes a bit of massaging (mostly because some of it is already touched by
02ff2769edbc, which keeps the changes fromedc3b9129cec, and so we can drop a good bit when applying). The other three apply cleanly.
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
I'm currently testing that and can send you the state of my tree in a bit.
Have you made any progress ? On my side I am still out of luck since I can not reproduce the problem.
Perhaps just the patch that Andi posted to the stable list helps out here?
For reference:
https://www.spinics.net/lists/stable/msg253357.html
That would be the most straightforward and simple fix, so I would prefer to go with it if it works.
Guenter
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 10 lines
Quoted 3 lines
Perhaps just the patch that Andi posted to the stable list helps out here?
For reference:
https://www.spinics.net/lists/stable/msg253357.html
That would be the most straightforward and simple fix, so I would prefer to go with it if it works.
Sorry for being slow, it turned out to take a slightly bigger stack of patches to get everything working.
I agree, Andi's simple fix is better anyway.
- R.
Greg Kroah-Hartman
maintainerRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 8 lines · Roland Dreier
Quoted 8 lines
Quoted 3 lines
Perhaps just the patch that Andi posted to the stable list helps out here?
For reference:
Quoted 7 lines
Quoted 2 lines
That would be the most straightforward and simple fix, so I would prefer to go with it if it works.
Sorry for being slow, it turned out to take a slightly bigger stack of patches to get everything working.
I agree, Andi's simple fix is better anyway.
So 4.4.153 works fine for you now?
thanks,
greg k-h
Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
In reply to Guenter RoeckQuoted 11 lines · Guenter Roeck
Quoted 8 lines · Roland Dreier
Quoted 3 lines
Sounds great. I'll hold off with sending my RFT series and wait for your test results. I think we'll also need
d367cef0a7f0c6("x86/mm/pat: Fix boot crash when 1GB pages are not supported by the CPU").Sure, makes sense - I don't have any EFI systems with CPUs old enough not to support 1G pages but that looks reasonable. I'll pull that into my tree as well.
kernelci reported a crash on a CPU which doesn't support 1G pages. See https://kernelci.org/boot/id/5b7d39ea59b514c03796ba9c/
Looks like this has now been fixed with Andi's patch in 4.4.153:
"x86/mm/pat: Fix L1TF stable backport for CPA"
I can confirm this platform is now booting fine in kernelci:
http://lava.streamtester.net/scheduler/job/146195
Thanks,
Guillaume
Greg Kroah-Hartman
maintainerRe: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"
Quoted 13 lines · Guillaume Tucker
Quoted 11 lines · Guenter Roeck
Quoted 8 lines · Roland Dreier
Quoted 3 lines
Sounds great. I'll hold off with sending my RFT series and wait for your test results. I think we'll also need
d367cef0a7f0c6("x86/mm/pat: Fix boot crash when 1GB pages are not supported by the CPU").Sure, makes sense - I don't have any EFI systems with CPUs old enough not to support 1G pages but that looks reasonable. I'll pull that into my tree as well.
kernelci reported a crash on a CPU which doesn't support 1G pages. See https://kernelci.org/boot/id/5b7d39ea59b514c03796ba9c/
Quoted 7 lines
Looks like this has now been fixed with Andi's patch in 4.4.153:
"x86/mm/pat: Fix L1TF stable backport for CPA"
I can confirm this platform is now booting fine in kernelci:
Wonderful, thanks for letting us know.
greg k-h