i40e: simplify pointer dereferences
Subsystems (2)
PATCH 8/9 i40e: simplify pointer dereferences
From: Mitch Williams <[email protected]>
Now that i40e_vsi_config_tc() has the pf and hw variable defined, use them, instead of dereferencing vsi->back. Much easier to read.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +8 -10
@@ -5250,7 +5250,7 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)if (ret) {struct i40e_aqc_query_vsi_bw_config_resp bw_config = {0 }; -dev_info (&vsi->back->pdev->dev, +dev_info (&pf->pdev->dev,"Failed configuring TC map %d for VSI %d\n" , enabled_tc, vsi->seid); ret = i40e_aq_query_vsi_bw_config(hw, vsi->seid,
@@ -5321,13 +5321,12 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)/* Update the VSI after updating the VSI queue-mapping * information */ - ret =i40e_aq_update_vsi_params (&vsi->back->hw, &ctxt,NULL ); + ret =i40e_aq_update_vsi_params (hw, &ctxt,NULL );if (ret) { -dev_info (&vsi->back->pdev->dev, +dev_info (&pf->pdev->dev,"Update vsi tc config failed, err %s aq_err %s\n" , -i40e_stat_str (&vsi->back->hw, ret), -i40e_aq_str (&vsi->back->hw, - vsi->back->hw.aq.asq_last_status)); +i40e_stat_str (hw, ret), +i40e_aq_str (hw, hw->aq.asq_last_status)); goto out; }/* update the local VSI info with updated queue map */
@@ -5337,11 +5336,10 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)/* Update current VSI BW information */ ret =i40e_vsi_get_bw_info (vsi);if (ret) { -dev_info (&vsi->back->pdev->dev, +dev_info (&pf->pdev->dev,"Failed updating vsi bw info, err %s aq_err %s\n" , -i40e_stat_str (&vsi->back->hw, ret), -i40e_aq_str (&vsi->back->hw, - vsi->back->hw.aq.asq_last_status)); +i40e_stat_str (hw, ret), +i40e_aq_str (hw, hw->aq.asq_last_status)); goto out; }
Signature · 1 line
2.9.5
Bowers
PATCH 8/9 i40e: simplify pointer dereferences
Quoted 11 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Monday, December 18, 2017 2:18 AM
To: Michael, Alice <[email protected]>; intel-wired- lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S83-V5 8/9] i40e: simplify pointer dereferencesFrom: Mitch Williams <[email protected]>
Quoted 7 lines
Now that
i40e_vsi_config_tc()has the pf and hw variable defined, use them, instead of dereferencingvsi->back. Much easier to read.Signed-off-by Mitch Williams <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)