Skip to contentSkip to conversation

x86/pti: hide unused pti_user_pagetable_walk_pte() function

PATCH New Arnd Bergmann 1 participant 1 message Dec 18, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pti: hide unused pti_user_pagetable_walk_pte() function

The new pti_user_pagetable_walk_pte() function is not referenced when CONFIG_X86_VSYSCALL_EMULATION is disabled, so we need to either hide it or make the caller visible to gcc:

arch/x86/mm/pti.c:204:15: error: 'pti_user_pagetable_walk_pte' defined but not used [-Werror=unused-function]

Fixes 9d2fdd3ff05d ("x86/pti: Map the vsyscall page if needed")
---
 arch/x86/mm/pti.c | 2 ++
 1 file changed, 2 insertions(+)
arch/x86/mm/pti.c +2 -0
index fa22fdc73172..f7c8913d4daa 100644
@@ -192,6 +192,7 @@ static pmd_t *pti_user_pagetable_walk_pmd(unsigned long address)
 	return pmd_offset(pud, address);
 }
 
+#ifdef CONFIG_X86_VSYSCALL_EMULATION
 /*
  * Walk the shadow copy of the page tables (optionally) trying to allocate
  * page table pages on the way down.  Does not support large pages.
@@ -233,6 +234,7 @@ static pte_t *pti_user_pagetable_walk_pte(unsigned long address)
 	}
 	return pte;
 }
+#endif
 
 static void __init
 pti_clone_pmds(unsigned long start, unsigned long end, pmdval_t clear)
Signature · 1 line
2.9.0