Skip to contentSkip to conversation

tools/power: Don't make man pages executable

PATCH Superseded Laura Abbott 2 participants 4 messages Dec 19, 2017 – Dec 20, 2017 Turbostat utility

lore
Share & tools
lore

Laura Abbott

author
#0 lore raw

PATCH 1/1 tools/power: Don't make man pages executable

rpm-lint flagged these as being executable:

kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz

Fix this

Signed-off-by Laura Abbott <[email protected]>
---
 tools/power/x86/turbostat/Makefile              | 2 +-
 tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/power/x86/turbostat/Makefile +1 -1
index a9bc914a8fe8..2ab25aa38263 100644
@@ -25,4 +25,4 @@ install : turbostat
 	install -d  $(DESTDIR)$(PREFIX)/bin
 	install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
 	install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-	install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+	install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
tools/power/x86/x86_energy_perf_policy/Makefile +1 -1
index 2447b1bbaacf..f4534fb8b951 100644
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
 	install -d  $(DESTDIR)$(PREFIX)/bin
 	install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
 	install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-	install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+	install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
Signature · 1 line
2.14.3
#1 lore raw
Quoted 8 lines · Laura Abbott

rpm-lint flagged these as being executable:

kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz

Fix this

Signed-off-by Laura Abbott <[email protected]>

Please CC PM stuff to linux-pm (which makes it easier to handle).

Quoted 20 lines
---
  tools/power/x86/turbostat/Makefile              | 2 +-
  tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
tools/power/x86/turbostat/Makefile +1 -1
index a9bc914a8fe8..2ab25aa38263 100644
@@ -25,4 +25,4 @@ install : turbostat
  	install -d  $(DESTDIR)$(PREFIX)/bin
  	install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
  	install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-	install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+	install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
tools/power/x86/x86_energy_perf_policy/Makefile +0 -0
index 2447b1bbaacf..f4534fb8b951 100644

tools/power/x86/x86_energy_perf_policy/Makefile install : x86_energy_perf_policy · line 28

Quoted 6 lines
tools/power/x86/x86_energy_perf_policy/Makefile +1 -1
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
  	install -d  $(DESTDIR)$(PREFIX)/bin
  	install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
  	install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-	install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+	install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8

Thanks,

Rafael

author
#2 lore raw
Quoted 12 lines · Rafael J. Wysocki
Quoted 8 lines · Laura Abbott

rpm-lint flagged these as being executable:

kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz

Fix this

Signed-off-by Laura Abbott <[email protected]>

Please CC PM stuff to linux-pm (which makes it easier to handle).

Neither of these are listed in MAINTAINERS so I missed sending to linux-pm. I'll remember for next time, do you want me to resend for tracking?

Thanks,
Laura

Quoted 32 lines
Quoted 20 lines

---
  tools/power/x86/turbostat/Makefile              | 2 +- tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-

  2 files changed, 2 insertions(+), 2 deletions(-)
tools/power/x86/turbostat/Makefile +0 -0
index a9bc914a8fe8..2ab25aa38263 100644
@@ -25,4 +25,4 @@ install : turbostat

      install -d  $(DESTDIR)$(PREFIX)/bin
      install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8

tools/power/x86/x86_energy_perf_policy/Makefile +0 -0
index 2447b1bbaacf..f4534fb8b951 100644
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
Quoted 5 lines

      install -d  $(DESTDIR)$(PREFIX)/bin
      install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8

Thanks,

Rafael

#3 lore raw
Quoted 9 lines · Laura Abbott
Quoted 8 lines · Rafael J. Wysocki
Quoted 7 lines · Laura Abbott

rpm-lint flagged these as being executable:

kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz

Fix this

Quoted 9 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Laura Abbott <[email protected]>

Please CC PM stuff to linux-pm (which makes it easier to handle).

Neither of these are listed in MAINTAINERS so I missed sending to linux-pm. I'll remember for next time, do you want me to resend for tracking?

Yes, please.

Thanks,
Rafael

Quoted 36 lines
Quoted 35 lines
Quoted 21 lines

---
  tools/power/x86/turbostat/Makefile              | 2 +- tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-

  2 files changed, 2 insertions(+), 2 deletions(-)
tools/power/x86/turbostat/Makefile +0 -0
index a9bc914a8fe8..2ab25aa38263 100644
@@ -25,4 +25,4 @@ install : turbostat

      install -d  $(DESTDIR)$(PREFIX)/bin
      install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8

tools/power/x86/x86_energy_perf_policy/Makefile +0 -0
index 2447b1bbaacf..f4534fb8b951 100644
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
Quoted 7 lines

      install -d  $(DESTDIR)$(PREFIX)/bin
      install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy install -d  $(DESTDIR)$(PREFIX)/share/man/man8
-    install x86_energy_perf_policy.8
$(DESTDIR)$(PREFIX)/share/man/man8
+    install -m 644 x86_energy_perf_policy.8
$(DESTDIR)$(PREFIX)/share/man/man8

Thanks,

Rafael