Skip to contentSkip to conversation

platform/x86: silead_dmi: Add entries for 2 Chuwi tablets

PATCH In review Hans de Goede 3 participants 5 messages Dec 20, 2017 – Dec 21, 2017 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

cover platform/x86: silead_dmi: Add entries for 2 Chuwi tablets

Hi Andy, et al,

Here are 2 patches to add entries for 2 more Chuwi tablet models to silead_dmi.c. Note that these are for 2 different tablets, even though the entries look similar.

I've based this series on top of the review-andy branch for easy merging, the first patch is not mine, but I've picked it up and used it as a base for this series to avoid conflicts.

Regards,

Hans

#1 lore raw

PATCH 1/2 platform/x86: silead_dmi: add entry for Chuwi Hi8 tablet

From: Maruyama Shohei <[email protected]>

This commit add entry for Chuwi Hi8 tablet.

---
 drivers/platform/x86/silead_dmi.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
drivers/platform/x86/silead_dmi.c +22 -0
index 89bd924fb8dc..21fdce159877 100644
@@ -203,6 +203,20 @@ static const struct silead_ts_dmi_data onda_obook_20_plus_data = {
 	.properties	= onda_obook_20_plus_props,
 };
 
+static const struct property_entry chuwi_hi8_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1665),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi8.fw"),
+	{ }
+};
+
+static const struct silead_ts_dmi_data chuwi_hi8_data = {
+	.acpi_name      = "MSSL0001:00",
+	.properties     = chuwi_hi8_props,
+};
+
 static const struct dmi_system_id silead_ts_dmi_table[] = {
 	{
 		/* CUBE iwork8 Air */
@@ -319,6 +333,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"),
 		},
 	},
+	{
+		/* Chuwi Hi8 */
+		.driver_data = (void *)&chuwi_hi8_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ilife"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S806"),
+		},
+	},
 	{ },
 };
 
Signature · 1 line
2.14.3
#2 lore raw

PATCH 2/2 platform/x86: silead_dmi: Add entry for the Chuwi Vi8 tablet

In reply to Hans de Goede

Add touchscreen platform data for the Chuwi Vi8 tablet.

---
 drivers/platform/x86/silead_dmi.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
drivers/platform/x86/silead_dmi.c +24 -0
index 21fdce159877..09b589fb79d4 100644
@@ -217,6 +217,21 @@ static const struct silead_ts_dmi_data chuwi_hi8_data = {
 	.properties     = chuwi_hi8_props,
 };
 
+static const struct property_entry chuwi_vi8_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1724),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-chuwi-vi8.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct silead_ts_dmi_data chuwi_vi8_data = {
+	.acpi_name      = "MSSL1680:00",
+	.properties     = chuwi_vi8_props,
+};
+
 static const struct dmi_system_id silead_ts_dmi_table[] = {
 	{
 		/* CUBE iwork8 Air */
@@ -341,6 +356,15 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "S806"),
 		},
 	},
+	{
+		/* Chuwi Vi8 (CWI506) */
+		.driver_data = (void *)&chuwi_vi8_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "i86"),
+			DMI_MATCH(DMI_BIOS_VERSION, "CHUWI.D86JLBNR"),
+		},
+	},
 	{ },
 };
 
Signature · 1 line
2.14.3
#3 lore raw
In reply to Hans de Goede
Quoted 7 lines · Hans de Goede

Hi Andy, et al,

Here are 2 patches to add entries for 2 more Chuwi tablet models to silead_dmi.c. Note that these are for 2 different tablets, even though the entries look similar.

I've based this series on top of the review-andy branch for easy merging,

OK, will leave this to andy to pull in then.

Signature · 2 lines
Darren Hart
VMware Open Source Technology Center
#4 lore raw
Quoted 10 lines · Darren Hart
Quoted 7 lines · Hans de Goede

Hi Andy, et al,

Here are 2 patches to add entries for 2 more Chuwi tablet models to silead_dmi.c. Note that these are for 2 different tablets, even though the entries look similar.

I've based this series on top of the review-andy branch for easy merging,

OK, will leave this to andy to pull in then.

Both applied to my review and testing queue, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko