Skip to contentSkip to conversation

Revert change to fsl,mpc8641 example

PATCH In review Grant Likely 2 participants 3 messages Dec 20, 2017 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert change to fsl,mpc8641 example

Commit 7d888a01, "Aesthetic/grammar fixes to first part of devicetree-basics.rst" changed one of the Freescale compatible examples from "fsl,mpc8641-uart" to "fsl,ns16550". However, there is value in using examples from real hardware when possible, and to also show that different strings (mpc8641-uart vs. ns16550) for a device is normal, so revert that hunk.

Cc Robert P. J. Day <rpjday-L09J2beyid0N/[email protected]>
---
 source/devicetree-basics.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
source/devicetree-basics.rst +2 -2
index f007a4b..1900cc8 100644
@@ -469,10 +469,10 @@ Description:
 
 Example:
 
-   ``compatible = "fsl,ns16550", "ns16550";``
+   ``compatible = "fsl,mpc8641", "ns16550";``
 
    In this example, an operating system would first try to locate a device
-   driver that supported fsl,ns16550. If a driver was not found, it
+   driver that supported fsl,mpc8641. If a driver was not found, it
    would then try to locate a driver that supported the more general
    ns16550 device type.
 
Signature · 1 line
2.11.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 18 lines · Grant Likely

Commit 7d888a01, "Aesthetic/grammar fixes to first part of devicetree-basics.rst" changed one of the Freescale compatible examples from "fsl,mpc8641-uart" to "fsl,ns16550". However, there is value in using examples from real hardware when possible, and to also show that different strings (mpc8641-uart vs. ns16550) for a device is normal, so revert that hunk.

Cc Robert P. J. Day <rpjday-L09J2beyid0N/[email protected]>
---
 source/devicetree-basics.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
source/devicetree-basics.rst +0 -0
index f007a4b..1900cc8 100644

source/devicetree-basics.rst Description: · line 472

Quoted 5 lines
source/devicetree-basics.rst +1 -1
@@ -469,10 +469,10 @@ Description:
 
 Example:
 
-   ``compatible = "fsl,ns16550", "ns16550";``
+   ``compatible = "fsl,mpc8641", "ns16550";``

Missing the "-uart" part.

Quoted 14 lines
source/devicetree-basics.rst +1 -2
    In this example, an operating system would first try to locate a device
-   driver that supported fsl,ns16550. If a driver was not found, it
+   driver that supported fsl,mpc8641. If a driver was not found, it
    would then try to locate a driver that supported the more general
    ns16550 device type.
 
--

2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree-spec" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAL_Jsq+dMY7kvoB6JbG0iKG1RmsSP-zPArL5oJuXO00MeXL=Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 20 lines · Rob Herring
Quoted 19 lines · Grant Likely

Commit 7d888a01, "Aesthetic/grammar fixes to first part of devicetree-basics.rst" changed one of the Freescale compatible examples from "fsl,mpc8641-uart" to "fsl,ns16550". However, there is value in using examples from real hardware when possible, and to also show that different strings (mpc8641-uart vs. ns16550) for a device is normal, so revert that hunk.

Cc Robert P. J. Day <rpjday-L09J2beyid0N/[email protected]>
---
 source/devicetree-basics.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
source/devicetree-basics.rst +0 -0
index f007a4b..1900cc8 100644
@@ -469,10 +469,10 @@ Description:
 
Quoted 6 lines

source/devicetree-basics.rst Description: · line 472

Quoted 4 lines
source/devicetree-basics.rst +1 -1
 Example:
 
-   ``compatible = "fsl,ns16550", "ns16550";``
+   ``compatible = "fsl,mpc8641", "ns16550";``

Missing the "-uart" part.

Well, that's embarrassing, and I've already cut the v0.2 release. :-( That's what I get for trying to do last minute changes.

Oh well. I've posted a fixup and it will show up in v0.3

Cheers,
g.

Quoted 15 lines
Quoted 15 lines
source/devicetree-basics.rst +1 -2
    In this example, an operating system would first try to locate a device
-   driver that supported fsl,ns16550. If a driver was not found, it
+   driver that supported fsl,mpc8641. If a driver was not found, it
    would then try to locate a driver that supported the more general
    ns16550 device type.
 
--

2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree-spec" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html