Skip to contentSkip to conversation

iw_cxgb4: Only validate the MSN for successful completions

PATCH Applied Steve Wise 2 participants 4 messages Dec 18, 2017 – Dec 22, 2017 2 messages not in the archive

Subsystems (2)
InfiniBand CXGB4 iWARP RNIC driver (IW_CXGB4)
lore
Share & tools
lore

Steve Wise

author
#0 lore raw

PATCH 1/3 iw_cxgb4: Only validate the MSN for successful completions

If the RECV CQE is in error, ignore the MSN check. This was causing recvs that were flushed into the sw cq to be completed with the wrong status (BAD_MSN instead of FLUSHED).

Cc [email protected]
Signed-off-by Steve Wise <[email protected]>
---
 drivers/infiniband/hw/cxgb4/cq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/hw/cxgb4/cq.c +3 -3
index b7bfc53..7ed8762 100644
@@ -571,10 +571,10 @@ static int poll_cq(struct t4_wq *wq, struct t4_cq *cq, struct t4_cqe *cqe,
 			ret = -EAGAIN;
 			goto skip_cqe;
 		}
-		if (unlikely((CQE_WRID_MSN(hw_cqe) != (wq->rq.msn)))) {
+		if (unlikely(!CQE_STATUS(hw_cqe) &&
+			     CQE_WRID_MSN(hw_cqe) != wq->rq.msn)) {
 			t4_set_wq_in_error(wq);
-			hw_cqe->header |= htonl(CQE_STATUS_V(T4_ERR_MSN));
-			goto proc_cqe;
+			hw_cqe->header |= cpu_to_be32(CQE_STATUS_V(T4_ERR_MSN));
 		}
 		goto proc_cqe;
 	}
Signature · 6 lines
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171220191644.CB3F62BC88-ff04S8wfc4plDsoTORJclLwze2ij/[email protected]

Applied
#2 lore raw
Quoted 8 lines · Steve Wise

If the RECV CQE is in error, ignore the MSN check. This was causing recvs that were flushed into the sw cq to be completed with the wrong status (BAD_MSN instead of FLUSHED).

Cc [email protected]
Signed-off-by Steve Wise <[email protected]>
 drivers/infiniband/hw/cxgb4/cq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied the series to for-next, thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20171222002341.GA20855-uk2M96/[email protected]

author
#4 lore raw
Quoted 6 lines · Steve Wise
Quoted 4 lines

If the RECV CQE is in error, ignore the MSN check. This was causing recvs that were flushed into the sw cq to be completed with the wrong status (BAD_MSN instead of FLUSHED).

Quoted 6 lines
Quoted 4 lines
Cc [email protected]
Signed-off-by Steve Wise <[email protected]>
 drivers/infiniband/hw/cxgb4/cq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied the series to for-next, thanks

Thanks Jason. I requested -rc though. Did you not want it in -rc?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw
Quoted 6 lines · Steve Wise
Quoted 6 lines · Steve Wise
Quoted 4 lines

If the RECV CQE is in error, ignore the MSN check. This was causing recvs that were flushed into the sw cq to be completed with the wrong status (BAD_MSN instead of FLUSHED).

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Cc [email protected]
Signed-off-by Steve Wise <[email protected]>
 drivers/infiniband/hw/cxgb4/cq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied the series to for-next, thanks

Thanks Jason. I requested -rc though. Did you not want it in -rc?

Ah, I did put it in -rc, sorry, toddler-came-home distraction when I was finishing.. Same for all the last couple patches.

The -rc branch tip is here right now while 0-day runs on it.

https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=wip/jgg-zero-day

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html