Skip to contentSkip to conversation

tests: Add tests for new sequence API and leases

PATCH In review Keith Packard 3 participants 6 messages Dec 21, 2017 – Jan 9, 2018

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH 1/2 tests/kms_sequence: Add tests for new CRTC get/queue sequence ioctls [v2]

These ioctls replace drmWaitVBlank and add ns time resolution and 64-bit sequence numbers to comply with the Vulkan API specifications.

The tests were derived from the existing kms_vblank tests with the 'wait' variant elided as the new API doesn't provide a mechanism for blocking in the kernel.

v2: from Dave Airlie <[email protected]>

* Add local definitions of new ioctls to avoid requiring latest libdrm.

* Remove FIRST_PIXEL_OUT as that has been removed from the proposed kernel patches.

---
 lib/igt_kms.c          |   2 +-
 lib/igt_kms.h          |   1 +
 tests/Makefile.sources |   1 +
 tests/kms_sequence.c   | 317 +++++++++++++++++++++++++++++++++++++++++++++++++
 tests/meson.build      |   1 +
 5 files changed, 321 insertions(+), 1 deletion(-)
 create mode 100644 tests/kms_sequence.c
lib/igt_kms.c +1 -1
index 1242324e..f6ad3565 100644
@@ -2079,7 +2079,7 @@ report_dup:
 	}
 }
 
-static igt_pipe_t *igt_output_get_driving_pipe(igt_output_t *output)
+igt_pipe_t *igt_output_get_driving_pipe(igt_output_t *output)
 {
 	igt_display_t *display = output->display;
 	enum pipe pipe;
lib/igt_kms.h +1 -0
index cfe646ae..8f270bfd 100644
@@ -377,6 +377,7 @@ igt_plane_t *igt_output_get_plane(igt_output_t *output, int plane_idx);
 igt_plane_t *igt_output_get_plane_type(igt_output_t *output, int plane_type);
 igt_output_t *igt_output_from_connector(igt_display_t *display,
     drmModeConnector *connector);
+igt_pipe_t *igt_output_get_driving_pipe(igt_output_t *output);
 igt_plane_t *igt_pipe_get_plane_type(igt_pipe_t *pipe, int plane_type);
 
 void igt_pipe_request_out_fence(igt_pipe_t *pipe);
tests/Makefile.sources +1 -0
index e4e06d01..485ed429 100644
@@ -211,6 +211,7 @@ TESTS_progs = \
 	kms_tv_load_detect \
 	kms_universal_plane \
 	kms_vblank \
+	kms_sequence \
 	meta_test \
 	perf \
 	perf_pmu \
tests/kms_sequence.c new file +317 -0

317 lines not on this page · raw message

tests/meson.build +1 -0
index 191ac4ce..b16fe9a5 100644
@@ -189,6 +189,7 @@ test_progs = [
 	'kms_tv_load_detect',
 	'kms_universal_plane',
 	'kms_vblank',
+	'kms_sequence',
 	'meta_test',
 	'perf',
 	'pm_backlight',
Signature · 6 lines
2.15.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

PATCH 2/2 tests/kms_lease: add tests for lease ioctls [v3]

In reply to Keith Packard

Validate that the leasing API creates leases that allow access to a subset of the available resources and that lease revocation works.

v2: from Dave Airlie <[email protected]>

* Update ioctl numbers to latest proposed values.
* Fix commit message
* Add tests for get_lease and list_lessees

v3: adapt to final kernel API

* Disable CAP_UNIVERSAL_PLANES before leasing so that we don't need to also include a plane.

* Zero out all of the ioctl structures so that any padding fields are set correctly.

* When listing a lease, expect 3 resources -- crtc, connector and plane.

---
 tests/Makefile.sources |   1 +
 tests/kms_lease.c      | 606 +++++++++++++++++++++++++++++++++++++++++++++++++
 tests/meson.build      |   1 +
 3 files changed, 608 insertions(+)
 create mode 100644 tests/kms_lease.c
tests/Makefile.sources +1 -0
index 485ed429..2bef7d68 100644
@@ -189,6 +189,7 @@ TESTS_progs = \
 	kms_frontbuffer_tracking \
 	kms_hdmi_inject \
 	kms_invalid_dotclock \
+	kms_lease \
 	kms_legacy_colorkey \
 	kms_mmap_write_crc \
 	kms_mmio_vs_cs_flip \
tests/kms_lease.c new file +606 -0

606 lines not on this page · raw message

tests/meson.build +1 -0
index b16fe9a5..4a9b5946 100644
@@ -167,6 +167,7 @@ test_progs = [
 	'kms_frontbuffer_tracking',
 	'kms_hdmi_inject',
 	'kms_invalid_dotclock',
+	'kms_lease',
 	'kms_legacy_colorkey',
 	'kms_mmap_write_crc',
 	'kms_mmio_vs_cs_flip',
Signature · 6 lines
2.15.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✓ Fi.CI.BAT: success for tests: Add tests for new sequence API and leases

In reply to Keith Packard
== Series Details ==

== Series Details ==

Series: tests: Add tests for new sequence API and leases
URL : https://patchwork.freedesktop.org/series/35657/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 382865bf1204241cdb609fbf8953a1de781368f7 lib/i915_pciids.h: synchronize with kernel header

with latest DRM-Tip kernel build CI_DRM_3561
e17acd399942 drm-tip: 2017y-12m-21d-00h-38m-27s UTC integration manifest

Testlist changes:
+igt@kms_lease@lease_again
+igt@kms_lease@lease_get
+igt@kms_lease@lease_invalid_connector
+igt@kms_lease@lease_invalid_crtc
+igt@kms_lease@lease_revoke
+igt@kms_lease@lease_unleased_connector
+igt@kms_lease@lease_unleased_crtc
+igt@kms_lease@lessee_list
+igt@kms_lease@simple_lease
+igt@kms_sequence@get-busy
+igt@kms_sequence@get-forked
+igt@kms_sequence@get-forked-busy
+igt@kms_sequence@get-idle
+igt@kms_sequence@queue-busy
+igt@kms_sequence@queue-idle

Test debugfs_test:

        Subgroup read_all_entries:
                fail       -> DMESG-WARN (fi-elk-e7500) fdo#103989 +1
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:387s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:507s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:279s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:496s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:499s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:480s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:468s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:260s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:532s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:406s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:415s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:479s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:432s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:479s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:520s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:472s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:528s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:579s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:457s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:534s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:558s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:508s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:488s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:420s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:584s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:611s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_716/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.IGT: failure for tests: Add tests for new sequence API and leases

In reply to Keith Packard
== Series Details ==

== Series Details ==

Series: tests: Add tests for new sequence API and leases
URL : https://patchwork.freedesktop.org/series/35657/
State : failure

== Summary ==

Test kms_frontbuffer_tracking:

        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                pass       -> FAIL       (shard-snb) fdo#101623
Test kms_cursor_crc:
        Subgroup cursor-64x64-suspend:
                skip       -> PASS       (shard-snb) fdo#102365
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw) fdo#104218
Test kms_flip:
        Subgroup wf_vblank:
                pass       -> INCOMPLETE (shard-snb)

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218

shard-hsw        total:2727 pass:1551 dwarn:1   dfail:0   fail:11  skip:1164 time:9463s
shard-snb        total:2716 pass:1314 dwarn:1   dfail:0   fail:12  skip:1388 time:7800s
Blacklisted hosts:
shard-apl        total:2727 pass:1702 dwarn:1   dfail:0   fail:23  skip:1001 time:13875s
shard-kbl        total:2703 pass:1799 dwarn:2   dfail:0   fail:26  skip:875 time:10774s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_716/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: ✗ Fi.CI.IGT: failure for tests: Add tests for new sequence API and leases

Quoted 31 lines · Patchwork

== Series Details ==

Series: tests: Add tests for new sequence API and leases
URL : https://patchwork.freedesktop.org/series/35657/
State : failure

== Summary ==

Test kms_frontbuffer_tracking:

        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                pass       -> FAIL       (shard-snb) fdo#101623
Test kms_cursor_crc:
        Subgroup cursor-64x64-suspend:
                skip       -> PASS       (shard-snb) fdo#102365
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-hsw) fdo#104218
Test kms_flip:
        Subgroup wf_vblank:
                pass       -> INCOMPLETE (shard-snb)

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218

shard-hsw        total:2727 pass:1551 dwarn:1   dfail:0   fail:11  skip:1164 time:9463s
shard-snb        total:2716 pass:1314 dwarn:1   dfail:0   fail:12  skip:1388 time:7800s
Blacklisted hosts:
shard-apl        total:2727 pass:1702 dwarn:1   dfail:0   fail:23  skip:1001 time:13875s
shard-kbl        total:2703 pass:1799 dwarn:2   dfail:0   fail:26  skip:875 time:10774s
Quoted 3 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_716/shards.html

Results for new tests are hard to find, but in a nutshell:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_716/shards-all.html
shows all of them passing except for kms_lease@simple_get which failed on all platforms:

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_716/shard-hsw5/igt@kms_lease@lease_get.html

Signature · 5 lines
Petri Latvala
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx