spi: pxa2xx: Use gpiod_put() not gpiod_free()
Subsystems (3)
PATCH 1/1 spi: pxa2xx: Use gpiod_put() not gpiod_free()
gpiod_free() is an internal function for gpiolib, gpiod_put() is the correct external function.
--- drivers/spi/spi-pxa2xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-pxa2xx.c +2 -2
@@ -1237,7 +1237,7 @@ static int setup_cs(struct spi_device *spi, struct chip_data *chip,* different chip_info, release previously requested GPIO */ if (chip->gpiod_cs) { -gpiod_free (chip->gpiod_cs); +gpiod_put (chip->gpiod_cs); chip->gpiod_cs =NULL ; }
@@ -1417,7 +1417,7 @@ static void cleanup(struct spi_device *spi)if (drv_data->ssp_type !=CE4100_SSP && !drv_data->cs_gpiods && chip->gpiod_cs) -gpiod_free (chip->gpiod_cs); +gpiod_put (chip->gpiod_cs);kfree (chip); }
Signature · 6 lines
2.15.0 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20171222161755.2742-1-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Hi Mark,
Quoted 6 lines · Mark Brown
gpiod_free()is an internal function for gpiolib,gpiod_put()is the correct external function.Reported-by Stephen Rothwell <[email protected]>Signed-off-by Mark Brown <[email protected]>
Given you usually don't rebase spi/for-next:
gpio_to_desc(desc_to_gpio()) round-trip")
Else we may have to repeat the exercise for stable later ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied "spi: pxa2xx: Use gpiod_put() not gpiod_free()" to the spi tree
In reply to a message not in the archiveThe patch
spi: pxa2xx: Use gpiod_put() not gpiod_free()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
a885eebc1b062c6a6a925db85828108779fb0e62Mon Sep 17 00:00:00 2001
From: Mark Brown <[email protected]>
Date: Fri, 22 Dec 2017 16:15:36 +0000
Subject: [PATCH] spi: pxa2xx: Use gpiod_put() not gpiod_free()
gpiod_free() is an internal function for gpiolib, gpiod_put() is the correct external function.
--- drivers/spi/spi-pxa2xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-pxa2xx.c +2 -2
@@ -1237,7 +1237,7 @@ static int setup_cs(struct spi_device *spi, struct chip_data *chip,* different chip_info, release previously requested GPIO */ if (chip->gpiod_cs) { -gpiod_free (chip->gpiod_cs); +gpiod_put (chip->gpiod_cs); chip->gpiod_cs =NULL ; }
@@ -1417,7 +1417,7 @@ static void cleanup(struct spi_device *spi)if (drv_data->ssp_type !=CE4100_SSP && !drv_data->cs_gpiods && chip->gpiod_cs) -gpiod_free (chip->gpiod_cs); +gpiod_put (chip->gpiod_cs);kfree (chip); }
Signature · 6 lines
2.15.0 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html