Skip to contentSkip to conversation

powerpc/xmon: Do not compute/store the major opcode

PATCH Applied Mathieu Malaterre 2 participants 2 messages Dec 26, 2017 – Jan 22, 2018 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/xmon: Do not compute/store the major opcode

In commit 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation changes)") usage of variable op has been removed. Completely remove opcode computation since not used anymore.

Fix fatal warning:

arch/powerpc/xmon/ppc-dis.c: In function ‘lookup_powerpc’:
arch/powerpc/xmon/ppc-dis.c:96:17: error: variable ‘op’ set but not used [-Werror=unused-but-set-variable]

   unsigned long op;
                 ^~
---
 arch/powerpc/xmon/ppc-dis.c | 4 ----
 1 file changed, 4 deletions(-)
arch/powerpc/xmon/ppc-dis.c +0 -4
index 31db8c072acd..9deea5ee13f6 100644
@@ -93,10 +93,6 @@ lookup_powerpc (unsigned long insn, ppc_cpu_t dialect)
 {
   const struct powerpc_opcode *opcode;
   const struct powerpc_opcode *opcode_end;
-  unsigned long op;
-
-  /* Get the major opcode of the instruction.  */
-  op = PPC_OP (insn);
 
   opcode_end = powerpc_opcodes + powerpc_num_opcodes;
   /* Find the first match in the opcode table for this major opcode.  */
Signature · 1 line
2.11.0
#1 lore raw
Quoted 4 lines · Mathieu Malaterre

In commit 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation changes)") usage of variable op has been removed. Completely remove opcode computation since not used anymore.

Quoted 8 lines

Fix fatal warning:

arch/powerpc/xmon/ppc-dis.c: In function ‘lookup_powerpc’:
arch/powerpc/xmon/ppc-dis.c:96:17: error: variable ‘op’ set but not used [-Werror=unused-but-set-variable]

   unsigned long op;
                 ^~

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/104d55ae4df928c205268c1eb83b80

cheers