i40e: Add returning AQ critical error to SW
Subsystems (2)
PATCH 1/13 i40e: Add returning AQ critical error to SW
From: Michal Kosiarz <[email protected]>
The FW has the ability to return a critical error on every AQ command. When this critical error occurs then we need to send the correct response to the caller.
--- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 13 +++++++++---- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 ++ drivers/net/ethernet/intel/i40e/i40e_status.h | 1 + drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 13 +++++++++---- drivers/net/ethernet/intel/i40evf/i40e_common.c | 2 ++ drivers/net/ethernet/intel/i40evf/i40e_status.h | 1 + 6 files changed, 24 insertions(+), 8 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_adminq.c +9 -4
@@ -907,10 +907,15 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw,/* update the error if time out occurred */ if ((!cmd_completed) && (!details->async && !details->postpone)) { -i40e_debug (hw, -I40E_DEBUG_AQ_MESSAGE , -"AQTX: Writeback timeout.\n" ); - status =I40E_ERR_ADMIN_QUEUE_TIMEOUT ; +if (rd32 (hw, hw->aq.asq.len) &I40E_GL_ATQLEN_ATQCRIT_MASK ) { +i40e_debug (hw,I40E_DEBUG_AQ_MESSAGE , +"AQTX: AQ Critical error.\n" ); + status =I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR ; + }else { +i40e_debug (hw,I40E_DEBUG_AQ_MESSAGE , +"AQTX: Writeback timeout.\n" ); + status =I40E_ERR_ADMIN_QUEUE_TIMEOUT ; + } } asq_send_command_error:
drivers/net/ethernet/intel/i40e/i40e_common.c +2 -0
@@ -278,6 +278,8 @@ const char *i40e_stat_str(struct i40e_hw *hw, i40e_status stat_err)return "I40E_NOT_SUPPORTED" ;case I40E_ERR_FIRMWARE_API_VERSION :return "I40E_ERR_FIRMWARE_API_VERSION" ; +case I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR : +return "I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR" ; }snprintf (hw->err_str,sizeof (hw->err_str),"%d" , stat_err);
drivers/net/ethernet/intel/i40e/i40e_status.h +1 -0
@@ -95,6 +95,7 @@ enum i40e_status_code {I40E_ERR_NOT_READY =-63 ,I40E_NOT_SUPPORTED =-64 ,I40E_ERR_FIRMWARE_API_VERSION =-65 , + I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR = -66, };#endif /* _I40E_STATUS_H_ */
drivers/net/ethernet/intel/i40evf/i40e_adminq.c +9 -4
@@ -837,10 +837,15 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw,/* update the error if time out occurred */ if ((!cmd_completed) && (!details->async && !details->postpone)) { -i40e_debug (hw, -I40E_DEBUG_AQ_MESSAGE , -"AQTX: Writeback timeout.\n" ); - status =I40E_ERR_ADMIN_QUEUE_TIMEOUT ; +if (rd32 (hw, hw->aq.asq.len) &I40E_VF_ATQLEN1_ATQCRIT_MASK ) { +i40e_debug (hw,I40E_DEBUG_AQ_MESSAGE , +"AQTX: AQ Critical error.\n" ); + status =I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR ; + }else { +i40e_debug (hw,I40E_DEBUG_AQ_MESSAGE , +"AQTX: Writeback timeout.\n" ); + status =I40E_ERR_ADMIN_QUEUE_TIMEOUT ; + } } asq_send_command_error:
drivers/net/ethernet/intel/i40evf/i40e_common.c +2 -0
@@ -284,6 +284,8 @@ const char *i40evf_stat_str(struct i40e_hw *hw, i40e_status stat_err)return "I40E_NOT_SUPPORTED" ;case I40E_ERR_FIRMWARE_API_VERSION :return "I40E_ERR_FIRMWARE_API_VERSION" ; +case I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR : +return "I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR" ; }snprintf (hw->err_str,sizeof (hw->err_str),"%d" , stat_err);
drivers/net/ethernet/intel/i40evf/i40e_status.h +1 -0
@@ -95,6 +95,7 @@ enum i40e_status_code {I40E_ERR_NOT_READY =-63 ,I40E_NOT_SUPPORTED =-64 ,I40E_ERR_FIRMWARE_API_VERSION =-65 , + I40E_ERR_ADMIN_QUEUE_CRITICAL_ERROR = -66, };#endif /* _I40E_STATUS_H_ */
Signature · 1 line
2.9.5
Bowers
PATCH 1/13 i40e: Add returning AQ critical error to SW
Quoted 17 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Wednesday, December 27, 2017 5:15 AM
To: Michael, Alice <[email protected]>; intel-wired-
lan at lists.osuosl.org
Cc: Kosiarz, Michal <[email protected]>
Subject: [Intel-wired-lan] [next PATCH S84-V2 01/13] i40e: Add returning AQ critical error to SWFrom: Michal Kosiarz <[email protected]>
The FW has the ability to return a critical error on every AQ command. When this critical error occurs then we need to send the correct response to the caller.
Signed-off-by Michal Kosiarz <[email protected]>
Quoted 8 lines
--- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 13 +++++++++---- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 ++ drivers/net/ethernet/intel/i40e/i40e_status.h | 1 + drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 13 +++++++++---- drivers/net/ethernet/intel/i40evf/i40e_common.c | 2 ++ drivers/net/ethernet/intel/i40evf/i40e_status.h | 1 + 6 files changed, 24 insertions(+), 8 deletions(-)