Skip to contentSkip to conversation

staging: iio: add spaces around '-' operator

PATCH In review Ji-Hun Kim 3 participants 3 messages Dec 28, 2017 – Dec 29, 2017

Subsystems (5)
Staging Kernel janitors IIO Analog Devices IIO drivers +1 more subsystems
lore
Share & tools
lore

Ji-Hun Kim

author
#0 lore raw

PATCH 2/2 staging: iio: add spaces around '-' operator

Clean up checkpatch warning:
CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by Ji-Hun Kim <[email protected]>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +1 -1
index f015955..c4eff71 100644
@@ -340,7 +340,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,
 			     0444, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
Signature · 1 line
2.10.1 (Apple Git-78)
#1 lore raw
Quoted 13 lines · Ji-Hun Kim

Clean up checkpatch warning:
CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by Ji-Hun Kim <[email protected]>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +0 -0
index f015955..c4eff71 100644

drivers/staging/iio/adc/ad7192.c ad7192_show_scale_available(struct device *dev, · line 343

Quoted 5 lines
drivers/staging/iio/adc/ad7192.c +1 -1
@@ -340,7 +340,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,

I think this has been discussed at length before, and it is a hyphen not a subtraction. IIO_DEVICE_ATTR_NAMED is a macro, as indicated by the capital letters, and you have to look and see what the code expands into.

julia

Quoted 11 lines
drivers/staging/iio/adc/ad7192.c +0 -1
 			     0444, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
--

2.10.1 (Apple Git-78)

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
Quoted 17 lines · On Thu, 28 Dec 2017 07:07:17 +0100 (CET) Julia Lawall <[email protected]>…
Quoted 15 lines · Ji-Hun Kim

Clean up checkpatch warning:
CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by Ji-Hun Kim <[email protected]>
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +0 -0
index f015955..c4eff71 100644
@@ -340,7 +340,7 @@ ad7192_show_scale_available(struct device *dev,
 }
Quoted 7 lines

drivers/staging/iio/adc/ad7192.c ad7192_show_scale_available(struct device *dev, · line 343

Quoted 3 lines
drivers/staging/iio/adc/ad7192.c +1 -1
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-			     in_voltage-voltage_scale_available,
+			     in_voltage - voltage_scale_available,

I think this has been discussed at length before, and it is a hyphen not a subtraction. IIO_DEVICE_ATTR_NAMED is a macro, as indicated by the capital letters, and you have to look and see what the code expands into.

Technically it is a subtraction, but the symbol rather than the c operator ;) It's indicating that this sysfs attribute is referring to any voltage channels minus other voltage channels (differential channels).

Sometimes I wonder if we should leave this there for ever as a way of getting people to understand that they need to look really closely at what checkpatch is suggesting and not assume it is right.

Jonathan

Quoted 18 lines

julia

Quoted 11 lines
drivers/staging/iio/adc/ad7192.c +0 -1
 			     0444, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
--

2.10.1 (Apple Git-78)

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html