drm/ttm: check the return value of kzalloc
Subsystems (3)
PATCH v3 1/1 drm/ttm: check the return value of kzalloc
In the function ttm_page_alloc_init, kzalloc call is made for variable _manager, we need to check its return value, it may return NULL.
---v2->v3: delete goto expressionv1->v2: delete kfree _manager
--- drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/ttm/ttm_page_alloc.c +2 -0
@@ -1007,6 +1007,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)pr_info ("Initializing pool allocator\n" ); _manager =kzalloc (sizeof (*_manager),GFP_KERNEL ); +if (!_manager) +return -ENOMEM ;ttm_page_pool_init_locked (&_manager->wc_pool,GFP_HIGHUSER ,"wc" ,0 );
Signature · 1 line
2.15.1
Am 02.01.2018 um 14:24 schrieb Xiongwei Song:
Quoted 4 lines
In the function
ttm_page_alloc_init, kzalloc call is made for variable_manager, we need to check its return value, it may return NULL.Signed-off-by Xiongwei Song <[email protected]>
Going to pick that up for the next release.
Thanks,
Christian.
Quoted 12 lines
---
v2->v3: delete goto expressionv1->v2: delete kfree_manager--- drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/ttm/ttm_page_alloc.c +0
-0
drivers/gpu/drm/ttm/ttm_page_alloc.c int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) · line 1014
Quoted 8 lines
drivers/gpu/drm/ttm/ttm_page_alloc.c +2
-0@@ -1007,6 +1007,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)pr_info ("Initializing pool allocator\n" ); _manager =kzalloc (sizeof (*_manager),GFP_KERNEL ); +if (!_manager) +return -ENOMEM ;ttm_page_pool_init_locked (&_manager->wc_pool,GFP_HIGHUSER ,"wc" ,0 );
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel