platform/x86: dell-laptop: Filter out spurious keyboard backlight change events
PATCH 1/1 platform/x86: dell-laptop: Filter out spurious keyboard backlight change events
On some Dell XPS models WMI events of type 0x0000 reporting a keycode of 0xe00c get reported when the brightness of the LCD panel changes.
This leads to us reporting false-positive kbd_led change events to userspace which in turn leads to the kbd backlight OSD showing when it should not.
We already read the current keyboard backlight brightness value when reporting events because the led_classdev_notify_brightness_hw_changed API requires this. Compare this value to the last known value and filter out duplicate events, fixing this.
Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)
drivers/platform/x86/dell-laptop.c +22 -2
@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;/* * NOTE: there are three ways to set the keyboard backlight level.
@@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct led_classdev *led_cdev)static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;
@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev *led_cdev, } out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);return ret; }
@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL ); + ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;
@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; }
Signature · 1 line
2.14.3
Quoted 7 lines · Hans de Goede
On some Dell XPS models WMI events of type
0x0000reporting a keycode of0xe00cget reported when the brightness of the LCD panel changes.This leads to us reporting false-positive
kbd_ledchange events to userspace which in turn leads to the kbd backlight OSD showing when it should not.
Quoted 9 lines
We already read the current keyboard backlight brightness value when reporting events because the
led_classdev_notify_brightness_hw_changedAPI requires this. Compare this value to the last known value and filter out duplicate events, fixing this.Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
Should it have Fixes tag?
Pali, any comment on this?
Quoted 77 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)drivers/platform/x86/dell-laptop.c +22
-3@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;/* * NOTE: there are three ways to set the keyboard backlight level. @@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct led_classdev *led_cdev)static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev *led_cdev, } out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);return ret; }@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL ); + ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; } --2.14.3
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Hans de Goede
On some Dell XPS models WMI events of type
0x0000reporting a keycode of0xe00cget reported when the brightness of the LCD panel changes.This leads to us reporting false-positive
kbd_ledchange events to userspace which in turn leads to the kbd backlight OSD showing when it should not.We already read the current keyboard backlight brightness value when reporting events because the
led_classdev_notify_brightness_hw_changedAPI requires this. Compare this value to the last known value and filter out duplicate events, fixing this.
Quoted 6 lines
Quoted 4 lines
Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
Should it have Fixes tag?
Good point, yes it should probably have a:
Regards,
Hans
Quoted 83 lines
Pali, any comment on this?
Quoted 77 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)drivers/platform/x86/dell-laptop.c +22
-3@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;/* * NOTE: there are three ways to set the keyboard backlight level. @@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct led_classdev *led_cdev)static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev *led_cdev, } out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);return ret; }@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL ); + ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; } --2.14.3
Pali Rohár
Acked-byQuoted 13 lines · On Friday 05 January 2018 12:40:04 Andy Shevchenko wrote:
Quoted 12 lines · Hans de Goede
On some Dell XPS models WMI events of type
0x0000reporting a keycode of0xe00cget reported when the brightness of the LCD panel changes.This leads to us reporting false-positive
kbd_ledchange events to userspace which in turn leads to the kbd backlight OSD showing when it should not.We already read the current keyboard backlight brightness value when reporting events because the
led_classdev_notify_brightness_hw_changedAPI requires this. Compare this value to the last known value and filter out duplicate events, fixing this.
Quoted 8 lines
Quoted 4 lines
Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
Should it have Fixes tag?
Pali, any comment on this?
See comments below. If there are not any problems, add my:
Quoted 12 lines
Quoted 12 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)drivers/platform/x86/dell-laptop.c +0
-0@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;
Quoted 3 lines
drivers/platform/x86/dell-laptop.c static u8 kbd_previous_mode_bit; · line 1136
Quoted 3 lines
drivers/platform/x86/dell-laptop.c +1
-0static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;
Introduction of cached state of brightness level in kernel driver can lead to problem as userspace is able to change brightness (via direct DELL SMM API) without notice of kernel.
But now patches for new interaction with DELL SMM via WMI are in kernel and there is explicit filter which blocks request for keyboard backlight. So hopefully this would not be a problem anymore... (or correct me if there still can be).
Quoted 13 lines
Quoted 13 lines
drivers/platform/x86/dell-laptop.c +1
-0/* * NOTE: there are three ways to set the keyboard backlight level. @@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct led_classdev *led_cdev)static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev *led_cdev, }
Quoted 13 lines
drivers/platform/x86/dell-laptop.c static int __init kbd_led_init(struct device *dev) · line 2012
Quoted 13 lines
drivers/platform/x86/dell-laptop.c +5
-0out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);return ret; }@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL );
Technically, kbd_led_level_get() is API function for struct led_cdev and therefore should take valid kbd_led, NULL there looks suspicious. But in reality this function itself ignores it first parameter. Probably the clean solution would be to have one private function for struct led_cdev usage and one which get current level for all other cases. This looks ugly too, so if somebody else would not come with better idea, let this code as is.
Quoted 38 lines
Quoted 35 lines
drivers/platform/x86/dell-laptop.c +15
-3+ ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; } --2.14.3
Signature · 2 lines
Pali Rohár [email protected]
Hi,
Quoted 46 lines · Pali Rohár
Quoted 13 lines · On Friday 05 January 2018 12:40:04 Andy Shevchenko wrote:
Quoted 12 lines · Hans de Goede
On some Dell XPS models WMI events of type
0x0000reporting a keycode of0xe00cget reported when the brightness of the LCD panel changes.This leads to us reporting false-positive
kbd_ledchange events to userspace which in turn leads to the kbd backlight OSD showing when it should not.We already read the current keyboard backlight brightness value when reporting events because the
led_classdev_notify_brightness_hw_changedAPI requires this. Compare this value to the last known value and filter out duplicate events, fixing this.Quoted 8 lines
Quoted 4 lines
Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
Should it have Fixes tag?
Pali, any comment on this?
See comments below. If there are not any problems, add my:
Acked-by Pali Rohár <[email protected]>Quoted 12 lines
Quoted 12 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)drivers/platform/x86/dell-laptop.c +0
-0@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;Quoted 3 lines
drivers/platform/x86/dell-laptop.c static u8 kbd_previous_mode_bit; · line 1136
Quoted 3 lines
drivers/platform/x86/dell-laptop.c +1
-0static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;Introduction of cached state of brightness level in kernel driver can lead to problem as userspace is able to change brightness (via direct DELL SMM API) without notice of kernel.
Quoted 4 lines
But now patches for new interaction with DELL SMM via WMI are in kernel and there is explicit filter which blocks request for keyboard backlight. So hopefully this would not be a problem anymore... (or correct me if there still can be).
Right, as discussed previously now that we've kernel support for this userspace really should not be directly touching this.
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
drivers/platform/x86/dell-laptop.c +1
-0/* * NOTE: there are three ways to set the keyboard backlight level. @@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct led_classdev *led_cdev)static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev *led_cdev, }
Quoted 16 lines
Quoted 5 lines
Quoted 5 lines
drivers/platform/x86/dell-laptop.c +3
-0out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);Quoted 8 lines
drivers/platform/x86/dell-laptop.c static int __init kbd_led_init(struct device *dev) · line 2012
Quoted 8 lines
drivers/platform/x86/dell-laptop.c +2
-0return ret; }@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL );Technically,
kbd_led_level_get()is API function for structled_cdevand therefore should take validkbd_led, NULL there looks suspicious.
Right, but I did not want to pass in a non-registered led_cdev and since kbd_led_level_get() does not dereference the passed in led_cdev passing NULL seems the cleanest solution.
Quoted 6 lines
But in
reality this function itself ignores it first parameter. Probably the clean solution would be to have one private function for structled_cdevusage and one which get current level for all other cases. This looks ugly too, so if somebody else would not come with better idea, let this code as is.
Ack, lets keep this as in, as said it is not perfect but passing NULL is the cleanest solution.
Regards,
Hans
Quoted 40 lines
Quoted 39 lines
Quoted 36 lines
drivers/platform/x86/dell-laptop.c +15
-3+ ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; } --2.14.3
Quoted 62 lines
-----Original Message-----
From: [email protected] [mailto:platform-driver-x86- [email protected]] On Behalf Of Pali Rohár
Sent: Friday, January 5, 2018 5:07 AM
To: Andy Shevchenko <[email protected]>
Cc: Hans de Goede <[email protected]>; Darren Hart <[email protected]>; Andy Shevchenko <[email protected]>; Platform Driver <[email protected]>; Linux Kernel Mailing List <linux- [email protected]>
Subject: Re: [PATCH] platform/x86: dell-laptop: Filter out spurious keyboard backlight change eventsQuoted 1 line · On Friday 05 January 2018 12:40:04 Andy Shevchenko wrote:
On Thu, Jan 4, 2018 at 10:52 AM, Hans de Goede <[email protected]>
Quoted 12 lines · wrote:
Quoted 12 lines
On some Dell XPS models WMI events of type
0x0000reporting a keycode of0xe00cget reported when the brightness of the LCD panel changes.This leads to us reporting false-positive
kbd_ledchange events to userspace which in turn leads to the kbd backlight OSD showing when it should not.We already read the current keyboard backlight brightness value when reporting events because the
led_classdev_notify_brightness_hw_changedAPI requires this. Compare this value to the last known value and filter out duplicate events, fixing this.Quoted 8 lines
Quoted 4 lines
Note the fixed issue is esp. a problem on XPS models with an ambient light sensor and automatic brightness adjustments turned on, this causes the kbd backlight OSD to show all the time there.
Should it have Fixes tag?
Pali, any comment on this?
See comments below. If there are not any problems, add my:
Acked-by Pali Rohár <[email protected]>Quoted 7 lines
drivers/platform/x86/dell-
Quoted 7 lines
Signed-off-by Hans de Goede <[email protected]>--- drivers/platform/x86/dell-laptop.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)drivers/platform/x86/dell- renamed from drivers/platform/x86/dell-laptop.c +0
-0
laptop.cQuoted 8 lines
drivers/platform/x86/dell-laptop.c static u8 kbd_previous_mode_bit; · line 1136
Quoted 8 lines
index
cd4725e7e0b5..2ef3297a9efc100644drivers/platform/x86/dell-laptop.c +1
-0@@ -1133,6 +1133,7 @@ static u8 kbd_previous_mode_bit;static bool kbd_led_present;static DEFINE_MUTEX (kbd_led_mutex); +static enum led_brightness kbd_led_level;Introduction of cached state of brightness level in kernel driver can lead to problem as userspace is able to change brightness (via direct DELL SMM API) without notice of kernel.
Quoted 5 lines
But now patches for new interaction with DELL SMM via WMI are in kernel and there is explicit filter which blocks request for keyboard backlight. So hopefully this would not be a problem anymore... (or correct me if there still can be).
It's still technically possible to do it directly from dcdbas.
Once new userspace libsmbios release is out with the WMI support it will be prioritized however over direct dcdbas access.
If you want to entirely block all requests from userspace via filter it would have to be done directly at dcdbas level. I don't think this is a common enough problem to warrant that however.
Quoted 79 lines
Quoted 3 lines
drivers/platform/x86/dell-laptop.c static enum led_brightness kbd_led_level_get(struct
Quoted 3 lines
drivers/platform/x86/dell-laptop.c +0
-0/* * NOTE: there are three ways to set the keyboard backlight level. @@ -1947,6 +1948,7 @@ static enum led_brightness kbd_led_level_get(struct
led_classdev*led_cdev)Quoted 8 lines
drivers/platform/x86/dell-laptop.c static int kbd_led_level_set(struct led_classdev
Quoted 8 lines
drivers/platform/x86/dell-laptop.c +1
-0static int kbd_led_level_set (struct led_classdev *led_cdev,enum led_brightness value) { +enum led_brightness new_value = value;struct kbd_state state;struct kbd_state new_state;u16 num;@@ -1976,6 +1978,9 @@ static int kbd_led_level_set(struct led_classdev
*led_cdev,Quoted 15 lines
Quoted 10 lines
drivers/platform/x86/dell-laptop.c +3
-0} out: +if (ret ==0 ) + kbd_led_level = new_value; +mutex_unlock (&kbd_led_mutex);return ret; }drivers/platform/x86/dell-laptop.c static int __init kbd_led_init(struct device *dev) · line 2012
Quoted 5 lines
drivers/platform/x86/dell-laptop.c +2
-0@@ -2003,6 +2008,9 @@ static int __init kbd_led_init(struct device *dev)if (kbd_led.max_brightness) kbd_led.max_brightness--; } + + kbd_led_level =kbd_led_level_get (NULL );Technically,
kbd_led_level_get()is API function for structled_cdevand therefore should take validkbd_led, NULL there looks suspicious. But in reality this function itself ignores it first parameter. Probably the clean solution would be to have one private function for structled_cdevusage and one which get current level for all other cases. This looks ugly too, so if somebody else would not come with better idea, let this code as is.Quoted 32 lines
Quoted 32 lines
drivers/platform/x86/dell-laptop.c +15
-2+ ret =led_classdev_register (dev, &kbd_led);if (ret) kbd_led_present = false;@@ -2027,13 +2035,25 @@ static void kbd_led_exit(void)static int dell_laptop_notifier_call (struct notifier_block *nb,unsigned long action,void *data) { +bool changed = false; +enum led_brightness new_kbd_led_level; +switch (action) {case DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED :if (!kbd_led_present)break ; -led_classdev_notify_brightness_hw_changed (&kbd_led, -kbd_led_level_get (&kbd_led)); +mutex_lock (&kbd_led_mutex); + new_kbd_led_level =kbd_led_level_get (&kbd_led); +if (kbd_led_level != new_kbd_led_level) { + kbd_led_level = new_kbd_led_level; + changed = true; + } +mutex_unlock (&kbd_led_mutex); + +if (changed) +led_classdev_notify_brightness_hw_changed (&kbd_led, + kbd_led_level);break ; }Quoted 6 lines
Quoted 3 lines
--
2.14.3--
Pali Rohár
[email protected]