Skip to contentSkip to conversation

test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

PATCH In review Marta Lofstedt 2 participants 3 messages Jan 4, 2018 – Jan 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

---
 tests/kms_psr_sink_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_psr_sink_crc.c +2 -0
index 83a69f0b..26cf434a 100644
@@ -532,11 +532,13 @@ int main(int argc, char *argv[])
 	igt_subtest("psr_basic") {
 		setup_test_plane(&data);
 		igt_assert(wait_psr_entry(&data));
+		test_cleanup(&data);
 	}
 
 	igt_subtest("psr_drrs") {
 		setup_test_plane(&data);
 		igt_assert(drrs_disabled(&data));
+		test_cleanup(&data);
 	}
 
 	for (op = PAGE_FLIP; op <= RENDER; op++) {
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/2
#1 lore raw

Including a line about the atomic update failure in the commit message would be nice.

Quoted 15 lines · Marta Lofstedt

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

---
 tests/kms_psr_sink_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_psr_sink_crc.c +0 -0
index 83a69f0b..26cf434a 100644
@@ -532,11 +532,13 @@ int main(int argc, char *argv[])
 	igt_subtest("psr_basic") {
 		setup_test_plane(&data);
 		igt_assert(wait_psr_entry(&data));

tests/kms_psr_sink_crc.c int main(int argc, char *argv[]) · line 544

Quoted 10 lines
tests/kms_psr_sink_crc.c +2 -0
+		test_cleanup(&data);
 	}
 
 	igt_subtest("psr_drrs") {
 		setup_test_plane(&data);
 		igt_assert(drrs_disabled(&data));
+		test_cleanup(&data);
 	}
 
 	for (op = PAGE_FLIP; op <= RENDER; op++) {

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Marta Lofstedt

Arek,
I didn't get any PW for this maybe because I sent it together with a HACK patch to get a test run on BAT.

Should I rename both patches and re-send to the list?

/Marta

Quoted 35 lines

-----Original Message-----
From: Lofstedt, Marta
Sent: Thursday, January 4, 2018 4:07 PM
To: [email protected]
Cc: Latvala, Petri <[email protected]>; Lofstedt, Marta <[email protected]>
Subject: [PATCH i-g-t 1/2] test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

---
 tests/kms_psr_sink_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_psr_sink_crc.c index renamed from tests/kms_psr_sink_crc.c +0 -0

83a69f0b..26cf434a 100644

tests/kms_psr_sink_crc.c +2 -1
@@ -532,11 +532,13 @@ int main(int argc, char *argv[])
 	igt_subtest("psr_basic") {
 		setup_test_plane(&data);
 		igt_assert(wait_psr_entry(&data));
+		test_cleanup(&data);
 	}
 
 	igt_subtest("psr_drrs") {
 		setup_test_plane(&data);
 		igt_assert(drrs_disabled(&data));
+		test_cleanup(&data);
 	}
 
 	for (op = PAGE_FLIP; op <= RENDER; op++) {
--
Quoted 1 line

2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx