Skip to contentSkip to conversation

meson: use message() rather than warning()

PATCH In review Lucas De Marchi 4 participants 5 messages Jan 4, 2018 – Jan 8, 2018 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meson: use message() rather than warning()

warning() was only added to the meson interpreter in 0.44 which is currently the last version. Let's use message() as we are currently requiring meson > 0.40. Otherwise we get the following error:

Meson encountered an error in file overlay/meson.build, line 62, column 1:
Unknown function "warning".

Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location")
Cc Rhys Kidd <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Petri Latvala <[email protected]>
---
 overlay/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
overlay/meson.build +1 -1
index 8b5c52b4..546c8377 100644
@@ -59,7 +59,7 @@ if leg.found()
 		command: [leg, '-P', '-o', '@OUTPUT@', '@INPUT@'])
 	gpu_overlay_src += leg_file
 else
-	warning('leg command not found, disabling overlay; try : apt-get install peg')
+	message('WARNING: leg command not found, disabling overlay; try : apt-get install peg')
 endif
 
 if leg.found() and xrandr.found() and cairo.found()
Signature · 6 lines
2.14.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for meson: use message() rather than warning()

== Series Details ==

== Series Details ==

Series: meson: use message() rather than warning()
URL : https://patchwork.freedesktop.org/series/36040/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 6db24416fdcdf5571125f9005089241cc6ba2652 lib/gem: Reset the global seqno at the start of each test

with latest DRM-Tip kernel build CI_DRM_3602
8ed3b7257f4b drm-tip: 2018y-01m-04d-20h-11m-09s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:

        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_busy:
        Subgroup basic-flip-a:
                dmesg-warn -> PASS       (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-bdw-5557u) fdo#104162

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104162 https://bugs.freedesktop.org/show_bug.cgi?id=104162

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:421s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:370s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:486s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:481s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:472s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:455s
fi-elk-e7500     total:224  pass:169  dwarn:9   dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:267s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:509s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:392s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:401s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:412s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:415s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:468s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:499s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:453s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:500s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:582s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:434s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:510s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:527s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:497s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:487s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:433s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:526s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:405s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:572s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:467s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_747/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Lucas De Marchi
Quoted 4 lines · Lucas De Marchi

warning() was only added to the meson interpreter in 0.44 which is currently the last version. Let's use message() as we are currently requiring meson > 0.40. Otherwise we get the following error:

Quoted 8 lines

Meson encountered an error in file overlay/meson.build, line 62,
column 1:
Unknown function "warning".

Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out

fields' location")

Quoted 21 lines
Cc Rhys Kidd <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Petri Latvala <[email protected]>
---
 overlay/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
overlay/meson.build +1 -1
index 8b5c52b4..546c8377 100644
@@ -59,7 +59,7 @@ if leg.found()
                command: [leg, '-P', '-o', '@OUTPUT@', '@INPUT@'])
        gpu_overlay_src += leg_file
 else
-       warning('leg command not found, disabling overlay; try : apt-get
 install peg')
+       message('WARNING: leg command not found, disabling overlay; try :
 apt-get install peg')
 endif
Quoted 5 lines

if leg.found() and xrandr.found() and cairo.found()
--
2.14.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 11 lines · Rhys Kidd
Quoted 8 lines · Lucas De Marchi

warning() was only added to the meson interpreter in 0.44 which is currently the last version. Let's use message() as we are currently requiring meson > 0.40. Otherwise we get the following error:

Meson encountered an error in file overlay/meson.build, line 62,
column 1:
Unknown function "warning".

Quoted 6 lines
Quoted 4 lines
Fixes 865a47ca ("overlay: parse tracepoints from sysfs to figure out

fields' location")

And merged, thanks.

Signature · 5 lines
Petri Latvala
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

✗ Fi.CI.IGT: failure for meson: use message() rather than warning()

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: meson: use message() rather than warning()
URL : https://patchwork.freedesktop.org/series/36040/
State : failure

== Summary ==

Test kms_frontbuffer_tracking:

        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623 +3
        Subgroup fbc-1p-primscrn-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#103167
Test perf:
        Subgroup blocking:
                fail       -> PASS       (shard-hsw) fdo#102252
Test kms_plane:
        Subgroup plane-panning-bottom-right-suspend-pipe-b-planes:
                pass       -> INCOMPLETE (shard-hsw)
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test kms_flip:
        Subgroup modeset-vs-vblank-race:
                dmesg-warn -> PASS       (shard-hsw) fdo#103060
        Subgroup rcs-wf_vblank-vs-dpms:
                pass       -> DMESG-WARN (shard-hsw) fdo#102614
Test gem_exec_whisper:
        Subgroup normal:
                pass       -> FAIL       (shard-hsw)

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614

shard-hsw        total:2617 pass:1477 dwarn:2   dfail:0   fail:10  skip:1127 time:8291s
shard-snb        total:2713 pass:1311 dwarn:1   dfail:0   fail:10  skip:1391 time:7877s
Blacklisted hosts:
shard-apl        total:2713 pass:1685 dwarn:1   dfail:0   fail:26  skip:1001 time:13456s
shard-kbl        total:2637 pass:1725 dwarn:26  dfail:2   fail:28  skip:856 time:10197s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_747/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx