sunrpc: remove dead code in svc_sock_setbufsize
Subsystems (3)
PATCH 1/1 sunrpc: remove dead code in svc_sock_setbufsize
Setting values in struct sock directly is the usual method. Remove the long dead code using set_fs() and the related comment.
Signed-off-by Christoph Hellwig <[email protected]>
--- net/sunrpc/svcsock.c | 14 -------------- 1 file changed, 14 deletions(-)
net/sunrpc/svcsock.c +0 -14
@@ -384,25 +384,11 @@ static int svc_partial_recvfrom(struct svc_rqst *rqstp,static void svc_sock_setbufsize (struct socket *sock,unsigned int snd,unsigned int rcv) { -#if 0 -mm_segment_t oldfs; - oldfs =get_fs ();set_fs (KERNEL_DS ); -sock_setsockopt (sock,SOL_SOCKET ,SO_SNDBUF , - (char *)&snd,sizeof (snd)); -sock_setsockopt (sock,SOL_SOCKET ,SO_RCVBUF , - (char *)&rcv,sizeof (rcv)); -#else -/* sock_setsockopt limits use to sysctl_?mem_max, -* which isn't acceptable. Until that is made conditional -* on not having CAP_SYS_RESOURCE or similar, we go direct... -* DaveM said I could! -*/ lock_sock (sock->sk); sock->sk->sk_sndbuf = snd *2 ; sock->sk->sk_rcvbuf = rcv *2 ; sock->sk->sk_write_space (sock->sk);release_sock (sock->sk); -#endif }static int svc_sock_secure_port (struct svc_rqst *rqstp)
Signature · 1 line
2.14.2
Thanks, applying for 4.16.--b.
Quoted 45 lines · Christoph Hellwig
Setting values in struct sock directly is the usual method. Remove the long dead code using
set_fs()and the related comment.Signed-off-by Christoph Hellwig <[email protected]>--- net/sunrpc/svcsock.c | 14 -------------- 1 file changed, 14 deletions(-)net/sunrpc/svcsock.c +0
-14@@ -384,25 +384,11 @@ static int svc_partial_recvfrom(struct svc_rqst *rqstp,static void svc_sock_setbufsize (struct socket *sock,unsigned int snd,unsigned int rcv) { -#if 0 -mm_segment_t oldfs; - oldfs =get_fs ();set_fs (KERNEL_DS ); -sock_setsockopt (sock,SOL_SOCKET ,SO_SNDBUF , - (char *)&snd,sizeof (snd)); -sock_setsockopt (sock,SOL_SOCKET ,SO_RCVBUF , - (char *)&rcv,sizeof (rcv)); -#else -/* sock_setsockopt limits use to sysctl_?mem_max, -* which isn't acceptable. Until that is made conditional -* on not having CAP_SYS_RESOURCE or similar, we go direct... -* DaveM said I could! -*/ lock_sock (sock->sk); sock->sk->sk_sndbuf = snd *2 ; sock->sk->sk_rcvbuf = rcv *2 ; sock->sk->sk_write_space (sock->sk);release_sock (sock->sk); -#endif }static int svc_sock_secure_port (struct svc_rqst *rqstp)Signature · 6 lines
2.14.2 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html