staging: rtl8723bs: Fix trailing semicolon

PATCH Superseded Luis de Bethencourt 3 participants 6 messages Jan 9, 2018 Staging

lore

Share & tools

lore

Luis de Bethencourt

author

2018-01-09 15:09 UTC #0 lore raw

PATCH 1/1 staging: rtl8723bs: Fix trailing semicolon

Signed-off-by Luis de Bethencourt <[email protected]>

---

Hi all,

Testing the waters with this cleanup patch. If it is OK to send these there are two very similar ones, plus more in general. Happy to send them.

I have a C.H.I.P. board, which is why this driver is interesting for me to play with.

Thanks,
Luis

 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +1 -1

index 3fca0c2d4c8d..da59496f6e04 100644
@@ -967,7 +967,7 @@ static int rtw_wx_set_mode(struct net_device *dev, struct iw_request_info *a,
 			break;
 
 		default :
-			ret = -EINVAL;;
+			ret = -EINVAL;
 			RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_err_, ("\n Mode: %s is not supported \n", iw_operation_mode[wrqu->mode]));
 			goto exit;
 	}

Signature · 1 line

2.15.1

Greg Kroah-Hartman

maintainer

2018-01-09 15:20 UTC #1 lore raw

Quoted 2 lines · Luis de Bethencourt

Signed-off-by Luis de Bethencourt <[email protected]>
---

I can't take patches without any changelog text, sorry :(

Luis de Bethencourt

author

2018-01-09 16:02 UTC #2 lore raw

Quoted 6 lines · Greg Kroah-Hartman

Quoted 2 lines · Luis de Bethencourt
Signed-off-by Luis de Bethencourt <[email protected]>
---
I can't take patches without any changelog text, sorry :(

Hi Greg,

I have done some research around previous patches to this driver and I am not entirely sure what you mean.

Sorry, but I need to ask before sending a v2.

Do you mind I'm missing a small summary in the commit message? Fix is so small I thought just the commit subject would be enough.

It is something different let me know and I will correct it.

Thanks,
Luis

Hans de Goede

2018-01-09 16:11 UTC #3 lore raw

Hi,

Quoted 13 lines · Luis de Bethencourt

Quoted 6 lines · Greg Kroah-Hartman
Quoted 2 lines · Luis de Bethencourt
Signed-off-by Luis de Bethencourt <[email protected]>
---
I can't take patches without any changelog text, sorry :(
Hi Greg,
I have done some research around previous patches to this driver and I am not entirely sure what you mean.

Quoted 6 lines

Sorry, but I need to ask before sending a v2.
Do you mind I'm missing a small summary in the commit message? Fix is so small I thought just the commit subject would be enough.
It is something different let me know and I will correct it.

I'm not entirely sure, but I believe Greg may have a script for this, given the amount of mail he receives and commits without a changelog in general not being a good idea.

What I usually do with trivial patches like this, is simply take the part after the last : in the subject, append a "." and voila you've a changelog txt. So in this case that would simply be:

Fix trailing semicolon.

Regards,

Hans

Luis de Bethencourt

author

2018-01-09 16:13 UTC #4 lore raw

Quoted 31 lines · Hans de Goede

Hi,
Quoted 13 lines · Luis de Bethencourt
Quoted 6 lines · Greg Kroah-Hartman
Quoted 2 lines · Luis de Bethencourt
Signed-off-by Luis de Bethencourt <[email protected]>
---
I can't take patches without any changelog text, sorry :(
Hi Greg,
I have done some research around previous patches to this driver and I am not entirely sure what you mean.
Quoted 6 lines
Sorry, but I need to ask before sending a v2.
Do you mind I'm missing a small summary in the commit message? Fix is so small I thought just the commit subject would be enough.
It is something different let me know and I will correct it.
I'm not entirely sure, but I believe Greg may have a script for this, given the amount of mail he receives and commits without a changelog in general not being a good idea.
What I usually do with trivial patches like this, is simply take the part after the last : in the subject, append a "." and voila you've a changelog txt. So in this case that would simply be:

Quoted 8 lines

Fix trailing semicolon.
Regards,
Hans

Hi Hans,

That was my plan! Resending.

I like your detailed step-by-step guide :)

Thanks,
Luis

Greg Kroah-Hartman

maintainer

2018-01-09 16:46 UTC #5 lore raw

In reply to Hans de Goede

Quoted 18 lines · Hans de Goede

Hi,
Quoted 15 lines · Luis de Bethencourt
Quoted 6 lines · Greg Kroah-Hartman
Quoted 2 lines · Luis de Bethencourt
Signed-off-by Luis de Bethencourt <[email protected]>
---
I can't take patches without any changelog text, sorry :(
Hi Greg,
I have done some research around previous patches to this driver and I am not entirely sure what you mean.
Sorry, but I need to ask before sending a v2.

Quoted 8 lines

Quoted 4 lines
Do you mind I'm missing a small summary in the commit message? Fix is so small I thought just the commit subject would be enough.
It is something different let me know and I will correct it.
I'm not entirely sure, but I believe Greg may have a script for this, given the amount of mail he receives and commits without a changelog in general not being a good idea.

No script for this, yet :)

Quoted 5 lines

What I usually do with trivial patches like this, is simply take the part after the last : in the subject, append a "." and voila you've a changelog txt. So in this case that would simply be:
Fix trailing semicolon.

Ick, no, come on, you can do it correctly...

greg k-h