Skip to contentSkip to conversation

crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

bug report Dan Carpenter 1 participant 1 message Jan 16, 2018 Crypto API

lore
Share & tools
lore
#0 lore raw

Hello Brijesh Singh,

The patch 200664d5237f: "crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support" from Dec 4, 2017, leads to the following static checker warning:

	drivers/crypto/ccp/psp-dev.c:779 psp_pci_init()
	error: uninitialized symbol 'error'.

drivers/crypto/ccp/psp-dev.c
764 void psp_pci_init(void)
765 {

   766          struct sev_user_data_status *status;
   767          struct sp_device *sp;
   768          int error, rc;
   769  
   770          sp = sp_get_psp_master_device();
   771          if (!sp)
   772                  return;
   773  
   774          psp_master = sp->psp_data;
   775  
   776          /* Initialize the platform */
   777          rc = sev_platform_init(&error);
   778          if (rc) {
   779                  dev_err(sp->dev, "SEV: failed to INIT error %#x\n", error);
                                                                            ^^^^^

Generally not set on the error paths.

780 goto err;
781 }
782
783 /* Display SEV firmware version */

regards,
dan carpenter