Skip to contentSkip to conversation

tcmu: Fix trailing semicolon

PATCH Applied Luis de Bethencourt 3 participants 3 messages Jan 16, 2018 – Jan 18, 2018

Subsystems (3)
SCSI SCSI target SCSI target core user driver
lore
Share & tools
lore

Luis de Bethencourt

author
#0 lore raw

PATCH 1/1 tcmu: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <[email protected]>

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/target/target_core_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_user.c +1 -1
index 60c8a87b7a88..f6164d294fb3 100644
@@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev)
 
 	wake_up_all(&udev->nl_cmd_wq);
 
-	return ret;;
+	return ret;
 }
 
 static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,
Signature · 1 line
2.15.1
Acked-by on v1 1/1
#1 lore raw
Quoted 28 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <[email protected]>

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/target/target_core_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/target/target_core_user.c +0 -0
index 60c8a87b7a88..f6164d294fb3 100644

drivers/target/target_core_user.c static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) · line 1570

Quoted 8 lines
drivers/target/target_core_user.c +1 -1
@@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev)
 
 	wake_up_all(&udev->nl_cmd_wq);
 
-	return ret;;
+	return ret;
 }
 
 static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,
Acked-by Mike Christie <[email protected]>
Applied
#2 lore raw
Quoted 17 lines · Michael Christie
Quoted 16 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <[email protected]>

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

Quoted 6 lines
Quoted 6 lines

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/target/target_core_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks Luis + MNC.