kconfig: Clarify menu and 'if' dependency propagation
PATCH 1/1 kconfig: Clarify menu and 'if' dependency propagation
It is not obvious that the last two cases refer to menus and ifs, respectively, in the conditional that sets 'parentdep'.
Automatic submenu creation is done later, so the parent can't be a symbol here.
No functional changes. Only comments added.
Signed-off-by Ulf Magnusson <[email protected]>
--- scripts/kconfig/menu.c | 2 ++ 1 file changed, 2 insertions(+)
scripts/kconfig/menu.c +2 -0
@@ -325,8 +325,10 @@ void menu_finalize(struct menu *parent) } parentdep =expr_alloc_symbol (sym); }else if (parent->prompt) +/* Menu node for 'menu' */ parentdep = parent->prompt->visible.expr;else +/* Menu node for 'if' */ parentdep = parent->dep;/* For each child menu node... */
Signature · 1 line
2.14.1
2018-01-17 5:39 GMT+09:00 Ulf Magnusson <[email protected]>:
Quoted 11 lines
It is not obvious that the last two cases refer to menus and ifs, respectively, in the conditional that sets 'parentdep'.
Automatic submenu creation is done later, so the parent can't be a symbol here.
No functional changes. Only comments added.
Signed-off-by Ulf Magnusson <[email protected]>--- scripts/kconfig/menu.c | 2 ++
Applied to linux-kbuild/kconfig. Thanks!
Signature · 2 lines
Best Regards Masahiro Yamada