Skip to contentSkip to conversation

usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

PATCH Superseded Ladislav Michl 3 participants 3 messages Jan 17, 2018 – Jan 18, 2018 1 message not in the archive

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later.

---
Changes:
- v2: None, just added Tony's ack

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-omap.c +3 -2
index 854b146a457d..fd6170962a1a 100644
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}
 
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Ladislav Michl

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later.

Quoted 24 lines

---
Changes:
- v2: None, just added Tony's ack

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-omap.c +3 -2
index 854b146a457d..fd6170962a1a 100644
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}
 
Signature · 8 lines
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 0eb30b03-e748-5727-a8bd-71483e951ee8-l0cyMroinI0@public.gmane.org

#3 lore raw

In you commit message, there is a typo "when when"

2018-01-17 22:41 GMT+09:00 Roger Quadros <[email protected]>:

Quoted 2 lines · Ladislav Michl
Quoted 1 line

Don't complain on -EPROBE_DEFER when when no PHY found, the driver

                                                                  ^^^^^^^^^^^^

thanks,
jaejoong

Quoted 36 lines
Quoted 4 lines

probe will be retried later.

Quoted 14 lines

---
Changes:
- v2: None, just added Tony's ack

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-omap.c +0 -0
index 854b146a457d..fd6170962a1a 100644
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
                              continue;

drivers/usb/host/ehci-omap.c static int ehci_hcd_omap_probe(struct platform_device *pdev) · line 175

Quoted 10 lines
drivers/usb/host/ehci-omap.c +3 -2
 
                      ret = PTR_ERR(phy);
-                     dev_err(dev, "Can't get PHY device for port %d: %d\n",
-                                     i, ret);
+                     if (ret != -EPROBE_DEFER)
+                             dev_err(dev, "Can't get PHY device for port "
+                                     "%d: %d\n", i, ret);
                      goto err_phy;
              }
 

--
cheers,
-roger

Quoted 5 lines

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html