Skip to contentSkip to conversation

Remove unneeded reference to nfsidmap_internal.h

PATCH In review Chuck Lever 3 participants 5 messages Jan 17, 2018 – Feb 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unneeded reference to nfsidmap_internal.h

This file is not part of "git clone" and is not #included from any C file.

---
 support/nfsidmap/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hey Steve-

I don't see nfsidmap_internal.h anywhere. Wondering if I missed something?

support/nfsidmap/Makefile.am +1 -1
index 9466f92..8b5dfe4 100644
@@ -25,7 +25,7 @@ pkgplugin_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_L
 #  <age> 	The number of previous additional interfaces supported
 #  		by this library.
 
-libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_internal.h nfsidmap_common.c
+libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_common.c
 libnfsidmap_la_LDFLAGS = -version-info 1:0:0
 libnfsidmap_la_LIBADD = -ldl ../../support/nfs/libnfsconf.la
 
#1 lore raw
Quoted 4 lines · Chuck Lever

This file is not part of "git clone" and is not #included from any C file.

Quoted 8 lines
---
 support/nfsidmap/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hey Steve-

I don't see nfsidmap_internal.h anywhere. Wondering if I missed something?

It was removed as part of my ABI cleanup (commit f080188e) to stop libnfsidmap from leaking all sorts of private symbols.

Some of it went to libnfsidmap_plugin.h and some to libnfsidmap_private.h

Some external packages which offered libnfsidmap plugins were using these undocumented symbols by copying libnfsidmap_internal.h, so i reworked the neccessary parts into an API as libnfsidmap_plugin.h and hid the rest.

I clearly missed this reference to the file as it didn't generate any warnings for me, sorry about that.

#2 lore raw
Quoted 24 lines · Justin Mitchell
Quoted 4 lines · Chuck Lever

This file is not part of "git clone" and is not #included from any C file.

Quoted 8 lines

---
support/nfsidmap/Makefile.am | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Hey Steve-

I don't see nfsidmap_internal.h anywhere. Wondering if I missed something?

It was removed as part of my ABI cleanup (commit f080188e) to stop libnfsidmap from leaking all sorts of private symbols.

Some of it went to libnfsidmap_plugin.h and some to libnfsidmap_private.h

Quoted 7 lines

Some external packages which offered libnfsidmap plugins were using these undocumented symbols by copying libnfsidmap_internal.h, so i reworked the neccessary parts into an API as libnfsidmap_plugin.h and hid the rest.

I clearly missed this reference to the file as it didn't generate any warnings for me, sorry about that.

No apologies needed. Are you confirming that this clean up is OK? Can I get an amen? (I mean, can I get a Reviewed-by?)

--
Chuck Lever

Reviewed-by
#3 lore raw
Quoted 31 lines · Chuck Lever
Quoted 23 lines · Justin Mitchell
Quoted 4 lines · Chuck Lever

This file is not part of "git clone" and is not #included from any C file.

Quoted 8 lines

---
support/nfsidmap/Makefile.am | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Hey Steve-

I don't see nfsidmap_internal.h anywhere. Wondering if I missed something?

It was removed as part of my ABI cleanup (commit f080188e) to stop libnfsidmap from leaking all sorts of private symbols.

Some of it went to libnfsidmap_plugin.h and some to libnfsidmap_private.h

Quoted 7 lines

Some external packages which offered libnfsidmap plugins were using these undocumented symbols by copying libnfsidmap_internal.h, so i reworked the neccessary parts into an API as libnfsidmap_plugin.h and hid the rest.

I clearly missed this reference to the file as it didn't generate any warnings for me, sorry about that.

Quoted 7 lines

No apologies needed. Are you confirming that this clean up is OK? Can I get an amen? (I mean, can I get a Reviewed-by?)

--
Chuck Lever

Yes, all looks good. thanks

#4 lore raw
In reply to Chuck Lever
Quoted 4 lines · Chuck Lever

This file is not part of "git clone" and is not #included from any C file.

Committed...

steved.

Quoted 23 lines
---
 support/nfsidmap/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hey Steve-

I don't see nfsidmap_internal.h anywhere. Wondering if I missed something?

support/nfsidmap/Makefile.am +1 -1
index 9466f92..8b5dfe4 100644
@@ -25,7 +25,7 @@ pkgplugin_LTLIBRARIES = nsswitch.la static.la $(UMICH_LDAP_LIB) $(GUMS_MAPPING_L
 #  <age> 	The number of previous additional interfaces supported
 #  		by this library.
 
-libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_internal.h nfsidmap_common.c
+libnfsidmap_la_SOURCES = libnfsidmap.c nfsidmap_common.c
 libnfsidmap_la_LDFLAGS = -version-info 1:0:0
 libnfsidmap_la_LIBADD = -ldl ../../support/nfs/libnfsconf.la