RDMA/mlx5: Remove redundant allocation warning print
Subsystems (2)
PATCH 1/1 RDMA/mlx5: Remove redundant allocation warning print
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The kmalloc() failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.
---
Changelog:
v0 -> v1:
* Fixed type in subject
* Removed "return" from end of void function
--- drivers/infiniband/hw/mlx5/main.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-)
drivers/infiniband/hw/mlx5/main.c +8 -11
@@ -3345,19 +3345,16 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,struct mlx5_ib_event_work *work; work =kmalloc (sizeof (*work),GFP_ATOMIC ); -if (work) { -INIT_WORK (&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - -queue_work (mlx5_ib_event_wq, &work->work); +if (!work)return ; - } -dev_warn (&dev->pdev->dev,"%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n" , - __func__, event, param); +INIT_WORK (&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + +queue_work (mlx5_ib_event_wq, &work->work); }static int set_has_smi_cap (struct mlx5_ib_dev *dev)
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180119110711.8758-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Yuval Shaia
Reviewed-byQuoted 7 lines · Leon Romanovsky
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The
kmalloc()failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")
Quoted 42 lines
---
Changelog:
v0 -> v1:
* Fixed type in subject
* Removed "return" from end of void function--- drivers/infiniband/hw/mlx5/main.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-)drivers/infiniband/hw/mlx5/main.c +8
-12@@ -3345,19 +3345,16 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,struct mlx5_ib_event_work *work; work =kmalloc (sizeof (*work),GFP_ATOMIC ); -if (work) { -INIT_WORK (&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - -queue_work (mlx5_ib_event_wq, &work->work); +if (!work)return ; - } -dev_warn (&dev->pdev->dev,"%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n" , - __func__, event, param); +INIT_WORK (&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + +queue_work (mlx5_ib_event_wq, &work->work); }static int set_has_smi_cap (struct mlx5_ib_dev *dev) --
Quoted 2 lines
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe
AppliedQuoted 8 lines · Leon Romanovsky
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The
kmalloc()failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")Reviewed-by Yuval Shaia <[email protected]>
Quoted 6 lines
Changelog:
v0 -> v1:
* Fixed type in subject
* Removed "return" from end of void functiondrivers/infiniband/hw/mlx5/main.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-)
Applied to for-next thanks
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html