netfilter: remove messages print and boot/module load time
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: remove messages print and boot/module load time
Several reasons for this:
* Several modules maintain internal version numbers, that they print at boot/module load time, that are not exposed to userspace, as a primitive mechanism to make revision number control from the earlier days of Netfilter.
* IPset shows the protocol version at boot/module load time, instead display this via module description, as Jozsef suggested.
* Remove copyright notice at boot/module load time in two spots, the Netfilter codebase is a collective development effort, if we would have to display copyrights for each contributor at boot/module load time for each extensions we have, we would probably fill up logs with lots of useless information - from a technical standpoint.
So let's be consistent and remove them all.
--- net/netfilter/ipset/ip_set_core.c | 3 ++- net/netfilter/nf_conntrack_netlink.c | 5 ----- net/netfilter/nf_tables_api.c | 1 - net/netfilter/nfnetlink.c | 4 ---- net/netfilter/nfnetlink_acct.c | 2 -- net/netfilter/nft_compat.c | 2 -- 6 files changed, 2 insertions(+), 15 deletions(-)
net/netfilter/ipset/ip_set_core.c +2 -1
@@ -2122,7 +2122,6 @@ ip_set_init(void)return ret; } -pr_info ("ip_set: protocol %u\n" ,IPSET_PROTOCOL );return 0 ; }
@@ -2138,3 +2137,5 @@ ip_set_fini(void)module_init (ip_set_init);module_exit (ip_set_fini); + +MODULE_DESCRIPTION ("ip_set: protocol " __stringify(IPSET_PROTOCOL ));
net/netfilter/nf_conntrack_netlink.c +0 -5
@@ -57,8 +57,6 @@MODULE_LICENSE ("GPL" ); -static char __initdata version[] ="0.93" ; -static int ctnetlink_dump_tuples_proto (struct sk_buff *skb,const struct nf_conntrack_tuple *tuple,const struct nf_conntrack_l4proto *l4proto)
@@ -3425,7 +3423,6 @@ static int __init ctnetlink_init(void) {int ret; -pr_info ("ctnetlink v%s: registering with nfnetlink.\n" , version); ret =nfnetlink_subsys_register (&ctnl_subsys);if (ret <0 ) {pr_err ("ctnetlink_init: cannot register with nfnetlink.\n" );
@@ -3459,8 +3456,6 @@ static int __init ctnetlink_init(void) static void __exit ctnetlink_exit(void) { -pr_info ("ctnetlink: unregistering from nfnetlink.\n" ); -unregister_pernet_subsys (&ctnetlink_net_ops);nfnetlink_subsys_unregister (&ctnl_exp_subsys);nfnetlink_subsys_unregister (&ctnl_subsys);
net/netfilter/nf_tables_api.c +0 -1
@@ -6603,7 +6603,6 @@ static int __init nf_tables_module_init(void)register_netdevice_notifier (&nf_tables_flowtable_notifier); -pr_info ("nf_tables: (c) 2007-2009 Patrick McHardy <[email protected]>\n" );return register_pernet_subsys (&nf_tables_net_ops); err3:nf_tables_core_module_exit ();
net/netfilter/nfnetlink.c +0 -4
@@ -37,8 +37,6 @@ MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_NETFILTER);rcu_dereference_protected (table[(id)].subsys, \ lockdep_nfnl_is_held((id))) -static char __initdata nfversion[] ="0.30" ; - static struct { struct mutex mutex; const struct nfnetlink_subsystem __rcu *subsys;
@@ -580,13 +578,11 @@ static int __init nfnetlink_init(void)for (i=0 ; i<NFNL_SUBSYS_COUNT ; i++)mutex_init (&table[i].mutex); -pr_info ("Netfilter messages via NETLINK v%s.\n" , nfversion);return register_pernet_subsys (&nfnetlink_net_ops); } static void __exit nfnetlink_exit(void) { -pr_info ("Removing netfilter NETLINK layer.\n" );unregister_pernet_subsys (&nfnetlink_net_ops); }module_init (nfnetlink_init);
net/netfilter/nfnetlink_acct.c +0 -2
@@ -527,7 +527,6 @@ static int __init nfnl_acct_init(void) goto err_out; } -pr_info ("nfnl_acct: registering with nfnetlink.\n" ); ret =nfnetlink_subsys_register (&nfnl_acct_subsys);if (ret <0 ) {pr_err ("nfnl_acct_init: cannot register with nfnetlink.\n" );
@@ -543,7 +542,6 @@ static int __init nfnl_acct_init(void) static void __exit nfnl_acct_exit(void) { -pr_info ("nfnl_acct: unregistering from nfnetlink.\n" );nfnetlink_subsys_unregister (&nfnl_acct_subsys);unregister_pernet_subsys (&nfnl_acct_ops); }
net/netfilter/nft_compat.c +0 -2
@@ -812,8 +812,6 @@ static int __init nft_compat_module_init(void) goto err_target; } -pr_info ("nf_tables_compat: (c) 2012 Pablo Neira Ayuso <[email protected]>\n" ); -return ret; err_target:
Signature · 1 line
2.11.0
Quoted 10 lines · Pablo Neira Ayuso
Several reasons for this:
* Several modules maintain internal version numbers, that they print at boot/module load time, that are not exposed to userspace, as a primitive mechanism to make revision number control from the earlier days of Netfilter.
* IPset shows the protocol version at boot/module load time, instead display this via module description, as Jozsef suggested.
Quoted 7 lines
* Remove copyright notice at boot/module load time in two spots, the Netfilter codebase is a collective development effort, if we would have to display copyrights for each contributor at boot/module load time for each extensions we have, we would probably fill up logs with lots of useless information - from a technical standpoint.
So let's be consistent and remove them all.
Quoted 19 lines · Pablo Neira Ayuso
Several reasons for this:
* Several modules maintain internal version numbers, that they print at boot/module load time, that are not exposed to userspace, as a primitive mechanism to make revision number control from the earlier days of Netfilter.
* IPset shows the protocol version at boot/module load time, instead display this via module description, as Jozsef suggested.
* Remove copyright notice at boot/module load time in two spots, the Netfilter codebase is a collective development effort, if we would have to display copyrights for each contributor at boot/module load time for each extensions we have, we would probably fill up logs with lots of useless information - from a technical standpoint.
So let's be consistent and remove them all.
Signed-off-by Pablo Neira Ayuso <[email protected]>
Quoted 8 lines
--- net/netfilter/ipset/ip_set_core.c | 3 ++- net/netfilter/nf_conntrack_netlink.c | 5 ----- net/netfilter/nf_tables_api.c | 1 - net/netfilter/nfnetlink.c | 4 ---- net/netfilter/nfnetlink_acct.c | 2 -- net/netfilter/nft_compat.c | 2 -- 6 files changed, 2 insertions(+), 15 deletions(-)
Best regards,
Jozsef
-
E-mail : [email protected], [email protected] PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary
Quoted 16 lines · Pablo Neira Ayuso
Several reasons for this:
* Several modules maintain internal version numbers, that they print at boot/module load time, that are not exposed to userspace, as a primitive mechanism to make revision number control from the earlier days of Netfilter.
* IPset shows the protocol version at boot/module load time, instead display this via module description, as Jozsef suggested.
* Remove copyright notice at boot/module load time in two spots, the Netfilter codebase is a collective development effort, if we would have to display copyrights for each contributor at boot/module load time for each extensions we have, we would probably fill up logs with lots of useless information - from a technical standpoint.
Quoted 3 lines
So let's be consistent and remove them all.
Signed-off-by Pablo Neira Ayuso <[email protected]>